Hello David
thx to have looked at this. I'll check the code and eventually fix it,
unless you already have a patch to propose.
Kind Regards
Peppe
On 7/13/2015 11:48 AM, David Binderman wrote:
Hello there,
[linux-4.2-rc2/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1993]: (style)
Checking if unsigned variable 'entry' is less than zero.
Source code is
entry = priv->hw->mode->jumbo_frm(priv, skb, csum_insertion);
if (unlikely(entry < 0))
goto dma_map_err;
but
unsigned int entry;
So the error checking from the function call looks broken to me.
If the return value from the function call to jumbo_frm is a plain signed
integer, suggest
sanity check that *before* assigning into an unsigned integer.
Regards
David Binderman
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
