The e1000 driver stores the content of the PCI resources into
unsigned long's before ioremapping. This breaks on 32 bits
platforms that support 64 bits MMIO resources such as ppc 44x.
This fixes it by removing those temporary variables and passing
directly the result of pci_resource_start/len to i
Sam Ravnborg wrote:
> On Thu, Nov 15, 2007 at 11:19:26AM -0700, Eric W. Biederman wrote:
>> Sam Ravnborg <[EMAIL PROTECTED]> writes:
>>
>>> On Thu, Nov 15, 2007 at 05:42:04PM +0300, Denis V. Lunev wrote:
nothing is discarded after module load. Though, I can be wrong. Could
you point me to
On Thu, 15 Nov 2007 20:42:55 -0600
"Jon Nelson" <[EMAIL PROTECTED]> wrote:
> On 11/15/07, Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> ..
>
> > Sure! I was only worried velocity_open() treats dev->mtu
> > a bit different than velocity_change_mtu(), so eg. after:
> >
> > velocity_change_mtu() // d
Herbert Xu said the following on 2007-11-16 12:11:
> Wang Chen <[EMAIL PROTECTED]> wrote:
>> So, I think the checksum in udp_queue_rcv_skb() actually does
>> the work, not that in udp_recvmsg() and udp_poll().
>>
>> If I am wrong, please point out.
>
> We may have a bug in the accounting area. Ch
David Miller said the following on 2007-11-16 12:04:
> From: Wang Chen <[EMAIL PROTECTED]>
> Date: Fri, 16 Nov 2007 11:18:16 +0800
>
> That's right, InDataGrams will increase even if we haven't
> verified the checksum yet.
>
> When the user does a recvmsg() or a poll() on the socket,
> we will no
Wang Chen <[EMAIL PROTECTED]> wrote:
>
> So, I think the checksum in udp_queue_rcv_skb() actually does
> the work, not that in udp_recvmsg() and udp_poll().
>
> If I am wrong, please point out.
We may have a bug in the accounting area. Check the recent
patch made to UDP/IPv6 which is probably ne
On Thu, 15 Nov 2007 20:42:55 -0600
"Jon Nelson" <[EMAIL PROTECTED]> wrote:
> On 11/15/07, Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> ..
>
> > Sure! I was only worried velocity_open() treats dev->mtu
> > a bit different than velocity_change_mtu(), so eg. after:
> >
> > velocity_change_mtu() // d
From: Arjan van de Ven <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 19:38:02 -0800
> On Thu, 15 Nov 2007 04:01:48 GMT
> Linux Kernel Mailing List <[EMAIL PROTECTED]> wrote:
>
> > Using a "if (need_resched())" test before calling
> > "cond_resched();" is necessary to avoid spending too much time
From: Wang Chen <[EMAIL PROTECTED]>
Date: Fri, 16 Nov 2007 11:18:16 +0800
> Actually, I tested and found this issue.
> I sent 50 udp packets, which have wrong checksum, to my
> machine.
> Before the patch being applied, /proc/net/snmp's udp
> InDatagrams increased, and InErrors didn't increase.
>
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 15:37:33 +0200
> Key points of this patch are:
>
> - In case new SACK information is advance only type, no skb
> processing below previously discovered highest point is done
> - Optimize cases below highest point too since t
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 15:37:32 +0200
> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
This is fine, and I can see how it sets things up for the
new "fastpath" code. Applied to net-2.6.25, thanks!
-
To unsubscribe from this list: send the line "unsubsc
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 15:37:31 +0200
> Worker function that implements the main logic of
> the inner-most loop of tcp_sacktag_write_queue().
>
> Idea was originally presented by David S. Miller.
>
> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
How
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 15:37:30 +0200
> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
Every simplification like this is like one less potential
bug to fix :-)
Patch applied to net-2.6.25, thanks!
-
To unsubscribe from this list: send the line "unsubsc
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 15:37:27 +0200
> Many assumptions that are true when no reordering or other
> strange events happen are not a part of the RFC3517. FACK
> implementation is based on such assumptions. Previously (before
> the rewrite) the non-FACK SAC
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 15:37:28 +0200
> It is going to replace the sack fastpath hint quite soon... :-)
>
> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
I always liked this patch, how can I not apply it? :-)
Added to net-2.6.25, thanks Ilpo!
-
To un
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 15:37:29 +0200
> Highest_sack_end_seq is no longer calculated in the loop,
> thus it can be pushed to the worker function altogether
> making that function independent of the sacktag.
>
> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECT
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 15:37:26 +0200
> This implements more accurately what is stated in sacktag's
> overall comment:
>
> "Both of these heuristics are not used in Loss state, when
>we cannot account for retransmits accurately."
>
> When CA_Loss s
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 15:37:25 +0200
> All intermediate conditions include it already, make them
> simpler as well.
>
> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
Applied to net-2.6.25
-
To unsubscribe from this list: send the line "unsubscribe ne
David Miller said the following on 2007-11-16 10:54:
> From: Wang Chen <[EMAIL PROTECTED]>
> Date: Fri, 16 Nov 2007 10:46:26 +0800
>
>> The current kernel doesn't verify the udp checksum if user doesn't set a
>> socket filter.It's fine for LAN. But for WAN, it's not a good option.
>> Shall we fix
From: "John W. Linville" <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 20:49:17 -0500
> Dave,
>
> Here is one more fix for 2.6.24. This is additive to the pull request
> from yesterday (2007-11-15), so if you haven't already pulled then
> you can just pull this one to get all the fix patches.
Pull
Corey Hickey wrote:
> Patchset try 2 addresses the review by Michael Buesch.
> Patchset try 3 addresses the review by Patrick McHardy.
> Patchset try 4 has a few cosmetic improvements.
> Patchset try 5 addresses further review by Patrick McHardy.
>
> This set of patches is substantially the same a
Dave,
The current kernel doesn't verify the udp checksum if user doesn't set a
socket filter.It's fine for LAN. But for WAN, it's not a good option.
Shall we fix it? Below is the patch to make udp checksum be always
available.
[IPV4] UDP: Always checksum even if without socket filter
Make udp c
On Thu, 15 Nov 2007 18:04:19 -0800 (PST) [EMAIL PROTECTED] wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=9391
>
>Summary: Netgear GA320T(tg3) strange errors and non-workingness
>Product: Drivers
>Version: 2.5
> KernelVersion: 2.6.22.12 (openSUSE 10.3
From: Wang Chen <[EMAIL PROTECTED]>
Date: Fri, 16 Nov 2007 10:46:26 +0800
> The current kernel doesn't verify the udp checksum if user doesn't set a
> socket filter.It's fine for LAN. But for WAN, it's not a good option.
> Shall we fix it? Below is the patch to make udp checksum be always
> avail
On November 15, 2007 06:02:09 am Andy Whitcroft wrote:
> When testing some of the later 2.6.24-rc2-mm1+hotfix combinations on three
> of our test systems one job from each batch (1/4) failed. In each case the
> machine appears to have booted normally all the way to a login: prompt.
> However in th
On 11/15/07, Jarek Poplawski <[EMAIL PROTECTED]> wrote:
..
> Sure! I was only worried velocity_open() treats dev->mtu
> a bit different than velocity_change_mtu(), so eg. after:
>
> velocity_change_mtu() // dev is down
> velocity_open()
> velocity_change_mtu() // dev is up
>
> with the same mtu, v
On Thu, Nov 15, 2007 at 03:23:53PM -0800, David Miller wrote:
>
> We don't have tests all over the place to see if a socket is TCP or
> DCCP or SCTP in order to implement memory accounting there, because we
> did it for connection oriented protocols cleanly, seperating things
> via callbacks etc.
>
I have created bug 9391 on bugzilla.kernel.org containing pretty much
everything.
--
Jon
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Dave,
Here is one more fix for 2.6.24. This is additive to the pull request
from yesterday (2007-11-15), so if you haven't already pulled then
you can just pull this one to get all the fix patches.
Thanks!
John
---
Individual patch available here:
http://www.kernel.org/pub/linux/kern
On Thu, 2007-11-15 at 16:32 -0800, Rick Jones wrote:
> I'm going to get very rapidly out of my PCI depth, but on one or the
> other (e vs X) isn't is possible from the standpoint of PCI for a device
> to have multiple transactions outstanding at a time?
Yes, see my other response. Multiple out
On Thu, 15 Nov 2007 20:28:29 -0400
Kevin Winchester <[EMAIL PROTECTED]> wrote:
> On November 15, 2007 06:02:09 am Andy Whitcroft wrote:
> > When testing some of the later 2.6.24-rc2-mm1+hotfix combinations on three
> > of our test systems one job from each batch (1/4) failed. In each case the
> >
I sense that the PCI spec wants devices to use an MRRS value of 512 in
order to get better fairness on a PCI-E segment amongst multiple
devices.
Unless there are PCIe switches, there is only ever one device on the
PCIe segment yes? Even on the biggest PCI-X or PCIe systems with which
I am fam
On Thu, Nov 15, 2007 at 01:50:43PM +1100, Neil Brown wrote:
> Virtual Folders.
>
> I use VM mode in EMACS, but I believe some other mail readers have the
> same functionality.
> I have a virtual folder called "nfs" which shows me all mail in my
> inbox which has the string 'nfs' or 'lockd' in a To
David Miller wrote:
From: Evgeniy Polyakov <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 15:06:59 +0300
Please test attached patch.
This routing is called each time hash should be replaced, nf_conn has
extension list which contains pointers to connection tracking users
(like nat, which is right n
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Fri, 16 Nov 2007 01:00:22 +0100
> David Miller wrote:
> > From: Evgeniy Polyakov <[EMAIL PROTECTED]>
> > Date: Thu, 15 Nov 2007 15:06:59 +0300
> >
> >> Please test attached patch.
> >>
> >> This routing is called each time hash should be replaced, nf
From: Evgeniy Polyakov <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 15:06:59 +0300
> Please test attached patch.
>
> This routing is called each time hash should be replaced, nf_conn has
> extension list which contains pointers to connection tracking users
> (like nat, which is right now the only s
From: Andrew Morton <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 02:12:19 -0800
> > Most recent kernel where this bug did not occur: 2.6.10. Maybe 2.6.15? It
> > was
> > in 2.6.18 along with bug 7421 which caused me to disable netatalk until now.
> > Distribution: Debian etch (4.0)
> > Hardware Env
From: "Jonas Danielsson" <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 22:40:13 +0100
> Is there a reason that the target hardware address isn't the target
> hardware address?
Linux subscribes to the host based addressing model rather
than an interface based addressing model. Both approaches
are va
David Miller <[EMAIL PROTECTED]> :
[...]
> I wonder if somehow sis190_phy_task() is creating some kind
> of deadlock when handling the link down and up events.
I should be able to test it during the week end if nobody beats me
The sis190 stands headless in the kitchen. Given the current situation
From: Hideo AOKI <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 16:50:14 -0500
> +static inline int __ip_check_max_skb_pages(struct sock *sk, int size)
> +{
> + switch(sk->sk_protocol) {
> + case IPPROTO_UDP:
> + if (atomic_read(sk->sk_prot->memory_allocated) + size
> +
On Mon, 2007-11-12 at 21:21 -0800, David Miller wrote:
> From: "Matt Carlson" <[EMAIL PROTECTED]>
> Date: Fri, 09 Nov 2007 16:39:01 -0800
>
> > Previous devices hardcoded the PCI Maximum Read Request Size to 4K. To
> > better comply with the PCI spec, the hardware now defaults the MRRS to
> > 512
From: "Eliezer Tamir" <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 21:19:46 +0200
> ftp://[EMAIL PROTECTED]/0001-add-bnx2x-driver-for-BCM57710.patch
I've added this to the netdev-2.6 tree, thanks a lot for
all of your hard work getting this driver into shape!
-
To unsubscribe from this list: send t
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 15:03:49 -0800
> 1. Please use dev_err() to help user figure out which board has problem:
> Not:
> printk(KERN_ERR PFX "Cannot register net device\n");
> Instead:
> dev_err(&pdev->dev, "cannot register n
Stephen Hemminger wrote, On 11/15/2007 07:20 PM:
> On Thu, 15 Nov 2007 09:26:00 +0100
> Jarek Poplawski <[EMAIL PROTECTED]> wrote:
>
>> On 15-11-2007 04:38, Stephen Hemminger wrote:
>>> Simple mtu change when device is down.
>>> Fix http://bugzilla.kernel.org/show_bug.cgi?id=9382.
>>>
>>> Signed-
From: "Michael Chan" <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 15:51:31 -0800
> I don't know what's the exact rationale for defaulting to 512, but I
> will try to find out.
Thank you.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED
On Thu, 2007-11-15 at 14:41 -0800, David Miller wrote:
> From: "Matt Carlson" <[EMAIL PROTECTED]>
> Date: Thu, 15 Nov 2007 14:20:10 -0800
> >
> > Keeping the MRRS at 512 introduces DMA latencies that effectively
> > prevent us from achieving linerate. With a packet size of ~1.5K and the
> > MRRS a
From: Divy Le Ray <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 03:38:57 -0800
> From: Divy Le Ray <[EMAIL PROTECTED]>
>
> eth_type_trans() now sets skb->dev.
> Access skb->def after it gets set.
>
> Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
Patch applied, thanks.
-
To unsubscribe from this
1. Please use dev_err() to help user figure out which board has problem:
Not:
printk(KERN_ERR PFX "Cannot register net device\n");
Instead:
dev_err(&pdev->dev, "cannot register net device\n");
2. Use new MAC_ADDR() rather than
printk("node addr ");
From: Andrew Morton <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 11:58:41 -0800
> On Thu, 15 Nov 2007 07:30:53 -0800 (PST) [EMAIL PROTECTED] wrote:
>
> > http://bugzilla.kernel.org/show_bug.cgi?id=9386
...
> > I have a problem where I can lock up a number of machines by
> > changing the link stat
Hello,
On Wed, 14 Nov 2007, Simon Horman wrote:
> > So, as long as these entries are not
> > accessible from sysctl it is safe to run without strategy handler but if
> > values can be changed then we will need strategy handler to
> > properly call update_defense_level() as done in proc_d
From: "Matt Carlson" <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 14:20:10 -0800
> On Mon, 2007-11-12 at 21:21 -0800, David Miller wrote:
> > From: "Matt Carlson" <[EMAIL PROTECTED]>
> > Date: Fri, 09 Nov 2007 16:39:01 -0800
> >
> > > Previous devices hardcoded the PCI Maximum Read Request Size to
Jon Nelson wrote, On 11/15/2007 09:21 PM:
...
> NOTE: to avoid list noise, I can make a bug out of this on
> bugzilla.kernel.org and we can proceed from there if that is
> preferred.
Why avoid list noise? These lists are made just for this. But, since
this case needs a lot of space for your confi
Yoshifuji,
> -Original Message-
> From: YOSHIFUJI Hideaki / 吉藤英明 [mailto:[EMAIL PROTECTED]
> Sent: Thursday, November 15, 2007 10:44 AM
> To: Templin, Fred L
> Cc: netdev@vger.kernel.org; [EMAIL PROTECTED];
> [EMAIL PROTECTED]
> Subject: Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.2)
>
This patch introduces sndbuf size check before memory allocation for
send buffer.
signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]>
signed-off-by: Hideo Aoki <[EMAIL PROTECTED]>
---
ip_output.c |5 +
1 file changed, 5 insertions(+)
diff -pruN net-2.6/net/ipv4/ip_output.c net-2.6-udp-p1/
This patch added /proc/sys/net/ipv4/udp_rmem_min and
/proc/sys/net/ipv4/udp_rmem_min. Each UDP packet is drooped when the
number of pages for socket buffer is beyond the limit and the socket
already consumes minimum buffer.
Cc: Satoshi Oshima <[EMAIL PROTECTED]>
signed-off-by: Hideo Aoki <[EMAIL P
This patch introduces global variable for UDP memory accounting.
The unit is page.
signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]>
signed-off-by: Hideo Aoki <[EMAIL PROTECTED]>
---
include/net/sock.h |8
include/net/udp.h |2 ++
net/ipv4/proc.c|3 ++-
net/ipv4/udp.c
This patch adds UDP memory usage accounting in IPv4.
signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]>
signed-off-by: Hideo Aoki <[EMAIL PROTECTED]>
---
af_inet.c | 30 +-
ip_output.c | 25 ++---
udp.c | 10 ++
3 files changed
This patch introduces memory limitation for UDP.
signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]>
signed-off-by: Hideo Aoki <[EMAIL PROTECTED]>
---
Documentation/networking/ip-sysctl.txt |6
include/net/udp.h |3 ++
net/ipv4/af_inet.c |3
Hello,
This is the latest patch set of UDP memory accounting and limitation.
I modified sk_datagram_pages() to avoid using divide instruction.
In addition, I also fixed memory accounting code in udp_recvmsg(),
since, in previous takes, the accounting code referred released
sk_buff's truesize. Th
Herbert Xu wrote:
> On Wed, Nov 14, 2007 at 06:30:51PM -0500, Hideo AOKI wrote:
>> +#define SK_DATAGRAM_MEM_QUANTUM ((unsigned int)PAGE_SIZE)
>> +
>> +static inline int sk_datagram_pages(int amt)
>> +{
>> +/* Cast to unsigned as an optimization, since amt is always
>> positive. */
>> +retu
Hi,
I started to look at this code when I was working on a project of
rewriting a dhcp-client.
I wanted to make the client use arp to determine if the offered
address was free or in use.
Thats when I noticed that linux machines responded in this, for me, odd way.
The problem is not really the ta
> You could optimize this by getting HARD_TX_LOCK after the
> check. I assume that netif_stop_subqueue (from another CPU)
> would always be called by the driver xmit, and that is not
> possible since we hold the __LINK_STATE_QDISC_RUNNING bit.
> Does that sound correct?
Sorry for not respondin
On Tue, Nov 13, 2007 at 10:34:37PM +, Russell King wrote:
> On Tue, Nov 13, 2007 at 06:25:16PM +, Alan Cox wrote:
> > > Given the wide range of ARM platforms today, it is utterly idiotic to
> > > expect a single person to be able to provide responses for all ARM bugs.
> > > I for one wish I
On 11/15/07, Michael Chan <[EMAIL PROTECTED]> wrote:
> On Thu, 2007-11-15 at 13:17 -0600, Jon Nelson wrote:
>
> > Is this what you mean? I pulled this from the quoted text:
> >
> > Nov 10 22:45:52 frank kernel: NETDEV WATCHDOG: eth0: transmit timed out
> >
>
> Right. This explains the reset at 22:
On Thu, 15 Nov 2007 07:30:53 -0800 (PST) [EMAIL PROTECTED] wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=9386
>
>Summary: sis190 network driver crash
>Product: Drivers
>Version: 2.5
> KernelVersion: 2.6.23.1
> Platform: All
> OS/Ver
posting individual files for comments.
---
/* bnx2x.h: Broadcom Everest network driver.
*
* Copyright (c) 2007 Broadcom Corporation
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Softw
On Thu, 15 Nov 2007 09:26:00 +0100
Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> On 15-11-2007 04:38, Stephen Hemminger wrote:
> > Simple mtu change when device is down.
> > Fix http://bugzilla.kernel.org/show_bug.cgi?id=9382.
> >
> > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
> >
> >
Sam Ravnborg <[EMAIL PROTECTED]> writes:
> On Thu, Nov 15, 2007 at 05:42:04PM +0300, Denis V. Lunev wrote:
>>
>> nothing is discarded after module load. Though, I can be wrong. Could
>> you point me to the exact place?
> If __initdata is not discarded after module load then we should do it.
> The
posting individual files for comments.
---
/* bnx2x_init.h: Broadcom Everest network driver.
*
* Copyright (c) 2007 Broadcom Corporation
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free
On Thu, 2007-11-15 at 13:17 -0600, Jon Nelson wrote:
> Is this what you mean? I pulled this from the quoted text:
>
> Nov 10 22:45:52 frank kernel: NETDEV WATCHDOG: eth0: transmit timed out
>
Right. This explains the reset at 22:45:52, but not the earlier reset
at 22:24:40. Link never came up
On Thu, Nov 15, 2007 at 10:17:14PM +0300, Denis V. Lunev wrote:
>
> will you mind against this?
> diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h
> index 5dd6d90..d136707 100644
> --- a/include/net/net_namespace.h
> +++ b/include/net/net_namespace.h
> @@ -119,10 +119,14 @@
Dave,
Here is the latest version for bnx2x.
Please consider applying to 2.6.25.
This patch also applies cleanly to net-2.6 for anyone that would like to
test it.
Major changes from last post.
* parts of the slowpath have been re-factored.
* slowpath task now runs in work queue context,
which
On 11/15/07, Michael Chan <[EMAIL PROTECTED]> wrote:
> On Thu, 2007-11-15 at 10:47 +0100, Jarek Poplawski wrote:
> > On 13-11-2007 19:57, Jon Nelson wrote:
> > > The best info I've got is this:
>
> It looks like the card is being reset periodically. Every time the card
> gets reset, you'll see tho
Hello Stephen,
Le jeudi 15 novembre 2007, Stephen Hemminger a écrit :
> Looks good, thanks:
>
> There is a function to make this easier:
> > @@ -756,10 +803,8 @@ r6040_open(struct net_device *dev)
> > if (lp->switch_sig != ICPLUS_PHY_ID) {
> > /* set and active a timer process */
>
On Thu, 15 Nov 2007 19:37:43 +0100
Florian Fainelli <[EMAIL PROTECTED]> wrote:
> This patch fixes various bugfixes spotted by Stephen, thanks !
>
> - add functions to allocate/free TX and RX buffers
> - recover from transmit timeout and use the 4 helpers defined below
> - use netdev_alloc_skb ins
In article <[EMAIL PROTECTED]> (at Thu, 15 Nov 2007 10:11:16 -0800), "Templin,
Fred L" <[EMAIL PROTECTED]> says:
> Yoshifuji,
>
> > -Original Message-
> > From: YOSHIFUJI Hideaki / 吉藤英明 [mailto:[EMAIL PROTECTED]
> > Sent: Thursday, November 15, 2007 3:48 AM
> > To: Templin, Fred L
> >
On Thu, Nov 15, 2007 at 11:19:26AM -0700, Eric W. Biederman wrote:
> Sam Ravnborg <[EMAIL PROTECTED]> writes:
>
> > On Thu, Nov 15, 2007 at 05:42:04PM +0300, Denis V. Lunev wrote:
> >>
> >> nothing is discarded after module load. Though, I can be wrong. Could
> >> you point me to the exact place?
This patch fixes various bugfixes spotted by Stephen, thanks !
- add functions to allocate/free TX and RX buffers
- recover from transmit timeout and use the 4 helpers defined below
- use netdev_alloc_skb instead of dev_alloc_skb
- do not use a private stats structure to store statistics
- break e
On Thu, 2007-11-15 at 10:47 +0100, Jarek Poplawski wrote:
> On 13-11-2007 19:57, Jon Nelson wrote:
> > The best info I've got is this:
It looks like the card is being reset periodically. Every time the card
gets reset, you'll see those PM messages in the version of the driver
you're using. Do yo
posting individual files for comments.
---
/* bnx2x_fw_defs.h: Broadcom Everest network driver.
*
* Copyright (c) 2007 Broadcom Corporation
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Fr
Yoshifuji,
> -Original Message-
> From: YOSHIFUJI Hideaki / 吉藤英明 [mailto:[EMAIL PROTECTED]
> Sent: Thursday, November 15, 2007 3:48 AM
> To: Templin, Fred L
> Cc: netdev@vger.kernel.org; [EMAIL PROTECTED];
> [EMAIL PROTECTED]
> Subject: Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.2)
>
Yoshifuji,
See below for follow-up:
> -Original Message-
> From: YOSHIFUJI Hideaki / 吉藤英明 [mailto:[EMAIL PROTECTED]
> Sent: Thursday, November 15, 2007 3:22 AM
> To: Templin, Fred L
> Cc: netdev@vger.kernel.org; [EMAIL PROTECTED];
> [EMAIL PROTECTED]
> Subject: Re: [PATCH 01/01] ipv6: R
[MACVLAN]: Allow setting mac address while device is up
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 3c50588260810d735231220f9a8ebaa6a6e8fb1e
tree 48ee2625502caf2454263a05b5a9869648de3aed
parent e2d06a34b52a999e8c539d1cdef51ff523e2f2c2
author Patrick McHardy <[EMAIL PROTECTED]> T
On Wed, Nov 14, 2007 at 06:23:34PM -0500, Daniel Barkalow wrote:
> I don't see any reason that we couldn't have a tool accessible to Ubuntu
> users that does a real "git bisect". Git is really good at being scripted
> by fancy GUIs. It should be easy enough to have a drop down with all of
> the
On Thu, Nov 15, 2007 at 04:57:17PM +, Nj A ([EMAIL PROTECTED]) wrote:
> > Well, your code will oops just like before - you provide empty skb to
> > the inet_iif(), which is wrong. Actually you will not even reach that
> > point, since your code will exit after skb->dev check.
> >
> > Try simpl
Hello all,
No bugs are due to the inet_lookup call now using the following:
if ((s_skb = alloc_skb (MAX_TCP_HEADER + 15, GFP_ATOMIC)) == NULL)
{
printk ("%s: Unable to allocate memory \n", __FUNCTION__);
err = -ENOMEM;
}
dev = s_skb->dev;
if (!dev)
On Thu, 15 Nov 2007, Theodore Tso wrote:
> On Wed, Nov 14, 2007 at 06:23:34PM -0500, Daniel Barkalow wrote:
> > I don't see any reason that we couldn't have a tool accessible to Ubuntu
> > users that does a real "git bisect". Git is really good at being scripted
> > by fancy GUIs. It should be e
> Well, your code will oops just like before - you provide empty skb to
> the inet_iif(), which is wrong. Actually you will not even reach that
> point, since your code will exit after skb->dev check.
>
> Try simple inet_lookup(&tcp_hashinfo, src, p_src, dst, p_dst, 0).
But trying inet_lookup(&t
On Thu, Nov 15, 2007 at 05:29:52PM +0100, Nj A ([EMAIL PROTECTED]) wrote:
> Hello all,
> No bugs are due to the inet_lookup call now using the following:
> if ((s_skb = alloc_skb (MAX_TCP_HEADER + 15, GFP_ATOMIC)) == NULL)
> {
> printk ("%s: Unable to allocate memory \n", __FUN
Eric Dumazet wrote:
On Thu, 15 Nov 2007 13:41:54 +0100
Patrick McHardy <[EMAIL PROTECTED]> wrote:
+#define XT_TABLE_INFO_SZ (offsetof(struct xt_table_info, entries) \
+ + nr_cpu_ids * sizeof(char *))
/* overflow check */
- if (tmp.size >= (INT_MAX - size
[MACVLAN]: Remove unnecessary IFF_UP check
Only devices that are UP are in the hash, so macvlan_broadcast() doesn't
need to check for IFF_UP.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit e2d06a34b52a999e8c539d1cdef51ff523e2f2c2
tree f95a5eef37c421950ddc7318797909c0031ee948
paren
These two patches remove an unnecessary check in macvlan_broadcast() and
add the ability to change the mac address while the device is up.
Please apply, thanks.
drivers/net/macvlan.c | 26 --
1 files changed, 24 insertions(+), 2 deletions(-)
Patrick McHardy (2):
After this patch none of the netlink callback support anything
except the initial network namespace but the rtnetlink infrastructure
now handles multiple network namespaces.
Changes from v2:
- IPv6 addrlabel processing
Changes from v1:
- no need for special rtnl_unlock handling
- fixed IPv6 ndisc
From: Eric W. Biederman <[EMAIL PROTECTED]>
After the previous prep work this just consists of removing checks
limiting the code to work in the initial network namespace, and
updating rtmsg_ifinfo so we can generate events for devices in
something other then the initial network namespace.
Referri
Before I can enable rtnetlink to work in all network namespaces
I need to be certain that something won't break. So this
patch deliberately disables all of the rtnletlink methods in everything
except the initial network namespace. After the methods have been
audited this extra check can be disabl
On Thu, 15 Nov 2007 13:41:54 +0100
Patrick McHardy <[EMAIL PROTECTED]> wrote:
> Eric Dumazet wrote:
> > [PATCH] netfilter : struct xt_table_info diet
> >
> > Instead of using a big array of NR_CPUS entries, we can compute the size
> > needed at runtime, using nr_cpu_ids
> >
> > This should save
Hello!
> Send a correct arp reply instead of one with sender ip and sender
> hardware adress in target fields.
I do not see anything more legal in setting target address to 0.
Actually, semantics of target address in ARP reply is ambiguous.
If it is a reply to some real request, it is set to ad
net: consolidate net namespace related proc files creation
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
---
fs/proc/proc_net.c | 38 ++
include/linux/seq_file.h | 13 +
net/core/dev.c
This is done by making packet_sklist_lock and packet_sklist per
network namespace and adding an additional filter condition on
received packets to ensure they came from the proper network
namespace.
Changes from v1:
- prohibit to call inet_dgram_ops.ioctl in other than init_net
Signed-off-by: Den
>From 337f0867c81ab93a1bc645e62896a798d0c864ac Mon Sep 17 00:00:00 2001
From: Denis V. Lunev <[EMAIL PROTECTED]>
Date: Thu, 15 Nov 2007 15:04:12 +0300
Subject: [PATCH] net: Make AF_UNIX per network namespace safe [v2]
Because of the global nature of garbage collection, and because of the
cost of p
1 - 100 of 154 matches
Mail list logo
