On Thu, 15 Nov 2007 19:37:43 +0100
Florian Fainelli <[EMAIL PROTECTED]> wrote:
> This patch fixes various bugfixes spotted by Stephen, thanks !
>
> - add functions to allocate/free TX and RX buffers
> - recover from transmit timeout and use the 4 helpers defined below
> - use netdev_alloc_skb instead of dev_alloc_skb
> - do not use a private stats structure to store statistics
> - break each TX/RX error to a separate line for better reading
> - suppress volatiles and make checkpatch happy
> - better control of the timer
> - fix spin_unlock_irq typo in netdev_get_settings
> - fix various typos and spelling in the driver
>
> Signed-off-by: Florian Fainelli <[EMAIL PROTECTED]>
Looks good, thanks:
There is a function to make this easier:
> @@ -756,10 +803,8 @@ r6040_open(struct net_device *dev)
> if (lp->switch_sig != ICPLUS_PHY_ID) {
> /* set and active a timer process */
> init_timer(&lp->timer);
> - lp->timer.expires = TIMER_WUT;
> lp->timer.data = (unsigned long)dev;
> lp->timer.function = &r6040_timer;
> - add_timer(&lp->timer);
Could be:
setup_timer(&lp->timer, r6040_timer, dev);
if (lp->switch_sig != ICPLUS_PHY_ID)
mod_timer(&lp->timer, jiffies + HZ);
--
Stephen Hemminger <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
