Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-09 Thread Nick Piggin
On Saturday 10 November 2007 12:29, Nick Piggin wrote: > cc'ed linux-netdev Err, make that 'netdev' :P > On Saturday 10 November 2007 10:46, Christoph Lameter wrote: > > commit deea84b0ae3d26b41502ae0a39fe7fe134e703d0 seems to cause a drop > > in SLUB tbench performance: > > > > 8p x86_64 system:

Re: [PATCH 00/05] pull request for 'upstream-jeff' branch

2007-11-09 Thread Jeff Garzik
Francois Romieu wrote: Please pull from branch 'upstream-jeff' in repository git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git upstream-jeff to get the changes below. They should make things better for people who have experienced the 8168b regression since 2.6.24-rc1. Dista

Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)

2007-11-09 Thread Jeff Garzik
Ben Dooks wrote: in submission process, or awaiting for an resolution. In the case of simtec-ide, I would like to replace it with platform-ata, but the libata maintainers seem wholy un-interested in PLAT_HAS_PLATFORM_ATA or similar. I've either missed or forgotten your patch/proposal, want to

Re: [PATCH 05/05] ipv6: RFC4214 Support (3)

2007-11-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 09 Nov 2007 16:35:59 -0800), osprey67 <[EMAIL PROTECTED]> says: > --- linux-2.6.24-rc2/include/linux/if_tunnel.h.orig 2007-11-09 > 09:06:16.0 -0800 > +++ linux-2.6.24-rc2/include/linux/if_tunnel.h2007-11-09 > 15:49:54.0 -0800 > @

Re: [PATCH 01/01] iproute2-2.6.23: RFC4214 Support (3)

2007-11-09 Thread Patrick McHardy
osprey67 wrote: --- iproute2-2.6.23/ip/iptunnel.c.orig 2007-11-08 16:27:24.0 -0800 +++ iproute2-2.6.23/ip/iptunnel.c 2007-11-09 15:47:06.0 -0800 @@ -1,3 +1,5 @@ +#define ISATAP + /* * iptunnel.c "ip tunnel" * @@ -39,7 +41,12 @@ static void usage(void) __att

[PATCH 01/01] iproute2-2.6.23: RFC4214 Support (3)

2007-11-09 Thread osprey67
From: Fred L. Templin <[EMAIL PROTECTED]> This is experimental support for the Intra-Site Automatic Tunnel Addressing Protocol (ISATAP) per RFC4214. It uses the SIT module, and is configured using the unmodified "ip" utility with device names beginning with: "isatap". The following diffs are spe

[PATCH 05/05] ipv6: RFC4214 Support (3)

2007-11-09 Thread osprey67
From: Fred L. Templin <[EMAIL PROTECTED]> This message attaches the combined diffs from messages 01/05 through 04/05. This file should be suitable for use with the patch utility. Signed-off-by: Fred L. Templin <[EMAIL PROTECTED]> --- linux-2.6.24-rc2/include/linux/if.h.orig2007-11-08 12:05:

[PATCH 04/05] ipv6: RFC4214 Support (3)

2007-11-09 Thread osprey67
From: Fred L. Templin <[EMAIL PROTECTED]> This is experimental support for the Intra-Site Automatic Tunnel Addressing Protocol (ISATAP) per RFC4214. It uses the SIT module, and is configured using the unmodified "ip" utility with device names beginning with: "isatap". The following diffs are spe

[PATCH 03/05] ipv6: RFC4214 Support (3)

2007-11-09 Thread osprey67
From: Fred L. Templin <[EMAIL PROTECTED]> This is experimental support for the Intra-Site Automatic Tunnel Addressing Protocol (ISATAP) per RFC4214. It uses the SIT module, and is configured using the unmodified "ip" utility with device names beginning with: "isatap". The following diffs are spe

[PATCH 02/05] ipv6: RFC4214 Support (3)

2007-11-09 Thread osprey67
From: Fred L. Templin <[EMAIL PROTECTED]> This is experimental support for the Intra-Site Automatic Tunnel Addressing Protocol (ISATAP) per RFC4214. It uses the SIT module, and is configured using the unmodified "ip" utility with device names beginning with: "isatap". The following diffs are spe

[PATCH 01/05] ipv6: RFC4214 Support (3)

2007-11-09 Thread osprey67
From: Fred L. Templin <[EMAIL PROTECTED]> This is experimental support for the Intra-Site Automatic Tunnel Addressing Protocol (ISATAP) per RFC4214. It uses the SIT module, and is configured using the unmodified "ip" utility with device names beginning with: "isatap". The following diffs are spe

[PATCH 0/13] tg3: 5761, 5784, and 5764 support fixes

2007-11-09 Thread Matt Carlson
The following patches round out support for 5784, 5764, and 5761 devices, fixing bugs in the process. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 5/13] tg3: Fix nvram selftest failures

2007-11-09 Thread Matt Carlson
Newer devices contain bootcode in the chip's private ROM area. This bootcode is called selfboot. Selfboot can be patched in the device's NVRAM and the patches can have several formats. In one particular format, the checksum calculation needs to be slightly modified. This patch adjusts the NVRAM

[PATCH 9/13] tg3: Prescaler fix

2007-11-09 Thread Matt Carlson
Internal hardware timers become inaccurate after link events. Clock frequency switches performed by the CPMU fail to adjust timer prescalers. The fix is to detect core clock frequency changes during link events and adjust the timer prescalers accordingly. Signed-off-by: Matt Carlson <[EMAIL PROT

[PATCH 6/13] tg3: CPMU adjustments for loopback tests

2007-11-09 Thread Matt Carlson
This patch adds the LINK_SPEED mode to the list of CPMU modes that can cause the loopback tests to fail. These bugs are planned to be fixed in future revisions of the chip, so the patch qualifies the fixes as such. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAI

[PATCH 2/13] tg3: 5784 / 5764 GPHY power down fix

2007-11-09 Thread Matt Carlson
5784 and 5764 devices fail to link / pass traffic after one load / unload cycle. This happens because of a hardware bug in the new CPMU. During normal operation, the MAC depends on the PHY clock being available. When the PHY is powered down, the clock the MAC depends on is disabled. The fix is t

[PATCH 4/13] tg3: 5784 / 5764 DMA engine lockup fix

2007-11-09 Thread Matt Carlson
5784 and 5764 devices lock up when the link speed is 10Mbps, the CPMU link speed mode is enabled, and the MAC clock is running at 1.5Mhz. The fix is to run the MAC clock at faster speeds. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a

[PATCH 1/13] tg3: Fix 5761 PXEboot crash

2007-11-09 Thread Matt Carlson
When 5761 devices boot the machine using PXEboot, PXE leaves the device active when it terminates. The tg3 driver has code to detect this condition and resets the device during initialization. On 5761 devices, device resets involve sending a driver state update message to the APE on the 5761. Ho

[PATCH 10/13] tg3: Increase the PCI MRRS

2007-11-09 Thread Matt Carlson
Previous devices hardcoded the PCI Maximum Read Request Size to 4K. To better comply with the PCI spec, the hardware now defaults the MRRS to 512 bytes. This will yield poor driver performance if left untouched. This patch increases the MRRS to 4K on driver initialization. Signed-off-by: Matt Ca

[PATCH 7/13] tg3: Disable GPHY autopowerdown

2007-11-09 Thread Matt Carlson
New CPMU devices contend with the GPHY for power management. The GPHY autopowerdown feature is enabled by default in the PHY and thus needs to be disabled after every PHY reset. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/n

[PATCH 12/13] tg3: MII => TP

2007-11-09 Thread Matt Carlson
This patch changes the PHY type reported through ethtool for copper devices from MII to TP. The latter is more accurate. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 8e76092..8d518cc 10064

[PATCH 13/13] tg3: Update version to 3.86

2007-11-09 Thread Matt Carlson
This patch updates the version number to 3.86 Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 8d518cc..4942f7d 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -64,8 +64,8 @@ #defi

[PATCH 3/13] tg3: APE flag fix

2007-11-09 Thread Matt Carlson
This patch corrects a bug where the ENABLE_APE flag was tested against the wrong flag variable. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 82b1cf0..833cb9b 100644 --- a/drivers/net/tg3.c

[PATCH 11/13] tg3: Add A1 revs

2007-11-09 Thread Matt Carlson
This patch adds the A1 revision of 5784, 5764, and 5761, and applies all previous bugfixes. In places where the list of devices gets too long, the patch uses a new TG3_FLG3_5761_5784_AX_FIXES flag instead. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECT

[PATCH 8/13] tg3: Limit 5784 / 5764 to MAC LED mode

2007-11-09 Thread Matt Carlson
Most 5784 / 5764 LED modes do not work as expected because of a hardware bug. This patch forces the LED mode to be in MAC LED mode. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index b5c4799..bb

Re: [PATCH] ehea: Add kdump support

2007-11-09 Thread Michael Neuling
> To support ehea driver reloading in a kdump kernel the driver has to > perform firmware handle deregistrations when the original kernel > crashes. As there's currently no notifier chain for machine crashes > this patch enables kdump support in the ehea driver by bending the > ppc_md.machine_crash

Re: [PATCH] Fix infinite loop on dev_mc_unsync()

2007-11-09 Thread Patrick McHardy
Joe Perches wrote: On Sat, 2007-11-10 at 00:12 +0100, Patrick McHardy wrote: This may cause a use-after-free since __dev_addr_delete frees the address when all references are gone. How about a comment then? Perhaps: diff --git a/net/core/dev_mcast.c b/net/core/dev_mcast.c index ae354

Re: [PATCH] Fix infinite loop on dev_mc_unsync()

2007-11-09 Thread Joe Perches
On Sat, 2007-11-10 at 00:12 +0100, Patrick McHardy wrote: > This may cause a use-after-free since __dev_addr_delete frees the address > when all references are gone. How about a comment then? Perhaps: diff --git a/net/core/dev_mcast.c b/net/core/dev_mcast.c index ae35405..63576aa 100644 --- a/ne

Re: SIS190.c

2007-11-09 Thread Francois Romieu
j gleacher <[EMAIL PROTECTED]> : [sorry for the delay, I was busy] > I'm not sure how to properly send you this information about subject, > but with a new Acer Desktop I needed to add 0x0968 to the below to > get the eth0 recognized. Ok. Can you check the patch below against 2.6.24-rc2 ? diff --

[PATCH 5/5] Net: sunrpc, remove SPIN_LOCK_UNLOCKED

2007-11-09 Thread Jiri Slaby
sunrpc, remove SPIN_LOCK_UNLOCKED SPIN_LOCK_UNLOCKED is deprecated, use DEFINE_SPINLOCK instead Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit d5e782e62a4fe2663a012571c345d9887b02 tree b993038b020d8c619f6ffdad412fbb992c073513 parent 828042d12cc0aa515e049889aa76d4066df100c0 author J

[PATCH 1/5] Net: ibm_newemac, remove SPIN_LOCK_UNLOCKED

2007-11-09 Thread Jiri Slaby
ibm_newemac, remove SPIN_LOCK_UNLOCKED SPIN_LOCK_UNLOCKED is deprecated, use DEFINE_SPINLOCK instead Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> --- commit aefcf0f6b6ab925184e7cebff8b609e4da1f5c0d tree 9e1e6240f26c759826959e8812885726c520019d parent f87566db

Re: [PATCH] Fix infinite loop on dev_mc_unsync()

2007-11-09 Thread Patrick McHardy
Luis R. Rodriguez wrote: diff --git a/net/core/dev_mcast.c b/net/core/dev_mcast.c index 15241cf..2aea8e1 100644 --- a/net/core/dev_mcast.c +++ b/net/core/dev_mcast.c @@ -160,14 +160,12 @@ EXPORT_SYMBOL(dev_mc_sync); */ void dev_mc_unsync(struct net_device *to, struct net_device *from) { -

Re: [PATCH 2/2]: e1000: avoid lockup durig error recovery

2007-11-09 Thread Linas Vepstas
On Fri, Nov 09, 2007 at 06:02:34PM +0100, Ingo Oeser wrote: > Linas Vepstas schrieb: > > + * napi_enabled_p - return non-zero if napi enabled > > + * > > + * Mnemonic: _p stands for "predicate", returning a yes/no > > + * answer to the question. > > Call it "is_napi_enabled()" an nobody will ask

Re: [PATCH 2.6.24] RDMA/cxgb3: Set the max_qp_init_rd_atom attribute.

2007-11-09 Thread Roland Dreier
thanks, applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: stateless 1:1 NAT

2007-11-09 Thread Florin Andrei
Herbert Xu wrote: Florin Andrei <[EMAIL PROTECTED]> wrote: OK, if I download 2.6.24-rc1, will it have this feature already? Yes. OK, I want to test this feature with 2.6.24-rc2. I compiled iproute2-2.6.23 with your patch applied. The problem is, I have no experience with tc (and very little

Re: [PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

2007-11-09 Thread Kim Phillips
On Fri, 9 Nov 2007 16:25:07 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote: > On Thu, Nov 08, 2007 at 01:11:35PM -0600, Kim Phillips wrote: > [...] > > right, but whether it does or not doesn't affect your failure outcome > > either I'm assuming. > > > > > > If it's something like 0x03, the u-bo

Re: [PATCH] Fix infinite loop on dev_mc_unsync()

2007-11-09 Thread Luis R. Rodriguez
On Fri, Nov 09, 2007 at 11:07:16AM -0800, Joe Perches wrote: > On Fri, 2007-11-09 at 13:51 -0500, Luis R. Rodriguez wrote: > > While reviewing net/core/dev_mcast.c I found what I think is an > > infinite loop on dev_mc_unsync(). This fixes it. We make use of > > this guy on mac80211 in ieee80211_s

Re: [PATCH] Fix infinite loop on dev_mc_unsync()

2007-11-09 Thread Joe Perches
On Fri, 2007-11-09 at 13:51 -0500, Luis R. Rodriguez wrote: > While reviewing net/core/dev_mcast.c I found what I think is an > infinite loop on dev_mc_unsync(). This fixes it. We make use of > this guy on mac80211 in ieee80211_stop(). This is untested. > > Signed-off-by: Luis R. Rodriguez <[EMAI

Re: [PATCH] Fix infinite loop on dev_mc_unsync()

2007-11-09 Thread Luis R. Rodriguez
Sorry, forgot to CC David. On Fri, Nov 09, 2007 at 10:11:35AM -0500, Luis R. Rodriguez wrote: While reviewing net/core/dev_mcast.c I found what I think is an infinite loop on dev_mc_unsync(). This fixes it. We make use of this guy on mac80211 in ieee80211_stop(). This is untested. Signed-off-by

Re: [PATCH 02/05] ipv6: RFC4214 Support

2007-11-09 Thread Ingo Oeser
YOSHIFUJI Hideaki / 吉藤英明 schrieb: > In article <[EMAIL PROTECTED]> (at Wed, 7 Nov 2007 10:52:47 -0800), "Templin, > Fred L" <[EMAIL PROTECTED]> says: > > > > > > > > + if (((ipv4 >= 0x0100) && (ipv4 < 0x0a00)) || > > > > > > > + ((ipv4 >= 0x0b00) && (ipv4 < 0x7f00)) || > > > >

Re: [PATCH 2/2]: e1000: avoid lockup durig error recovery

2007-11-09 Thread Ingo Oeser
Hi Linas, Linas Vepstas schrieb: > Index: linux-2.6.23-rc8-mm1/include/linux/netdevice.h > === > --- linux-2.6.23-rc8-mm1.orig/include/linux/netdevice.h 2007-09-26 > 15:07:05.0 -0500 > +++ linux-2.6.23-rc8-mm1/include/l

Re: [PATCH 08/13] SCTP: Use hashed lookup when looking for an association.

2007-11-09 Thread Vlad Yasevich
Vlad Yasevich wrote: > A SCTP endpoint may have a lot of associations on them and walking > the list is fairly inefficient. Instead, use a hashed lookup, > and filter out the hash list based on the endopoint we already have. This one is missing an unlock. Will send an update shortly. -vlad >

Re: [PATCH] PCI: export pci_restore_msi_state()

2007-11-09 Thread Linas Vepstas
On Thu, Nov 08, 2007 at 07:21:01PM -0600, Wen Xiong wrote: > Hi Linas, > > I saw you have submitted several patches to support pci-express network > adapters EEH. But looks only this patch fixed something in linux kernel > code. And its an old patch, submitted long ago ... I've resubmitted, bec

Re: [PATCH 02/05] ipv6: RFC4214 Support (2)

2007-11-09 Thread osprey67
YOSHIFUJI Hideaki / 吉藤英明 wrote: In article <[EMAIL PROTECTED]> (at Thu, 08 Nov 2007 12:41:39 -0800), osprey67 <[EMAIL PROTECTED]> says: From: Fred L. Templin <[EMAIL PROTECTED]> This is experimental support for the Intra-Site Automatic Tunnel Addressing Protocol (ISATAP) per RFC4214. It uses

Re: [PATCH] using mii-bitbang on different processor ports - update the booting-without-of.txt-file

2007-11-09 Thread Scott Wood
Sergej Stepanov wrote: We also need to change the reference to port C in fsl,mdio-pin and fsl,mdc-pin. Do you mean this: Currently defined compatibles: fsl,pq1-fec-mdio (reg is same as first resource of FEC device) -> fsl,cpm2-mdio-bitbang (reg is port C registers) Properties for fsl,c

[PATCH 2.6.24] RDMA/cxgb3: Set the max_qp_init_rd_atom attribute.

2007-11-09 Thread Steve Wise
RDMA/cxgb3: Set the max_qp_init_rd_atom attribute. Attribute max_qp_init_rd_atom is not getting set. Version 1.0.4 of librdmacm now validates the user's requested initiator and responder resources vs the max supported by the device. Since iw_cxgb3 wasn't setting this attribute (and it defaulted

[PATCH] Fix infinite loop on dev_mc_unsync()

2007-11-09 Thread Luis R. Rodriguez
While reviewing net/core/dev_mcast.c I found what I think is an infinite loop on dev_mc_unsync(). This fixes it. We make use of this guy on mac80211 in ieee80211_stop(). This is untested. Signed-off-by: Luis R. Rodriguez <[EMAIL PROTECTED]> diff --git a/net/core/dev_mcast.c b/net/core/dev_mcast.

[RFC][PATCH][LLC] Use existing sock refcnt debugging

2007-11-09 Thread Pavel Emelyanov
Hi, Arnaldo. I've grep-ed through the code and found one more place, where the sk refcnt debugging is required, but is still performed in an old fashion - this is the LLC2. The problem in using the sk_refcnt_debug_xxx here is that these socks do not provide the sk_destruct callback to catch the

Re: [PATCH][IPX] Use existing sock refcnt debugging infrastructure

2007-11-09 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 09, 2007 at 04:42:05PM +0300, Pavel Emelyanov escreveu: > Just like in the af_packet.c, the ipx_sock_nr variable is used > for debugging purposes. > > Switch to using existing infrastructure. Thanks to Arnaldo for > pointing this out. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECT

Re: [PATCH][PACKET] Use existing sock refcnt debugging infrastructure

2007-11-09 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 09, 2007 at 04:39:41PM +0300, Pavel Emelyanov escreveu: > The packet_socks_nr variable is used purely for debugging > the number of sockets. > > As Arnaldo pointed out, there's already an infrastructure > for this purposes, so switch to using it. > > Signed-off-by: Pavel Emelyanov <[E

Re: [PATCH] Fix buglets in mpc5200 FEC code that are corrupting memory.

2007-11-09 Thread Grant Likely
On 11/9/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > On 09/11/07 00:31 -0500, Jon Smirl wrote: > > This is the reason I couldn't get user space started or connect to my > > nfs server. Patch is against current linus git. > > > > mpc5200 fec driver is corrupting memory. This patch fixes two bugs >

[PATCH][IPX] Use existing sock refcnt debugging infrastructure

2007-11-09 Thread Pavel Emelyanov
Just like in the af_packet.c, the ipx_sock_nr variable is used for debugging purposes. Switch to using existing infrastructure. Thanks to Arnaldo for pointing this out. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/ipx/af_ipx.c b/net/ipx/af_ipx.c index a195a66..c76a952

[PATCH][PACKET] Use existing sock refcnt debugging infrastructure

2007-11-09 Thread Pavel Emelyanov
The packet_socks_nr variable is used purely for debugging the number of sockets. As Arnaldo pointed out, there's already an infrastructure for this purposes, so switch to using it. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/packet/af_packet.c b/net/packet/af_packet.

Re: [PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

2007-11-09 Thread Anton Vorontsov
On Mon, Nov 05, 2007 at 12:15:30PM -0600, Kim Phillips wrote: > Hello all, > > the following patches fix RGMII timing for rev. 2.1 of the mpc8360, > according to erratum #2 (erratum text included below). Basically the > most intrusive part is the addition of two new RGMII Internal Delay > modes;

[PATCH] ehea: Add kdump support

2007-11-09 Thread Thomas Klein
To support ehea driver reloading in a kdump kernel the driver has to perform firmware handle deregistrations when the original kernel crashes. As there's currently no notifier chain for machine crashes this patch enables kdump support in the ehea driver by bending the ppc_md.machine_crash_shutdown

Re: [PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

2007-11-09 Thread Anton Vorontsov
On Thu, Nov 08, 2007 at 01:11:35PM -0600, Kim Phillips wrote: [...] > right, but whether it does or not doesn't affect your failure outcome > either I'm assuming. > > > > If it's something like 0x03, the u-boot patch will probably look like: > > > > > > if ((bcsr[12] == 0x10) && > > > (immr->

[PATCH 4/4] Consolidate equal handlers in tunnel4.c

2007-11-09 Thread Pavel Emelyanov
Two sets - tunnel[6]4_rcv() and tunnel[6]4_err - do the same thing, but scan for different lists of tunnels, so this code is easily consolidated. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/ipv4/tunnel4.c b/net/ipv4/tunnel4.c index b662a9e..c85547d 100644 --- a/net/ip

[PATCH 3/4] Cleanup the xfrm4_tunnel_(un)register

2007-11-09 Thread Pavel Emelyanov
Both check for the family to select an appropriate tunnel list. Consolidate this check and make the for() loop more readable. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/ipv4/tunnel4.c b/net/ipv4/tunnel4.c index 7938430..b662a9e 100644 --- a/net/ipv4/tunnel4.c +++ b/n

[PATCH 2/4] Add missed tunnel64_err handler

2007-11-09 Thread Pavel Emelyanov
The tunnel64_protocol uses the tunnel4_protocol's err_handler and thus calls the tunnel4_protocol's handlers. This is not very good, as in case of (icmp) error the wrong error handlers will be called (e.g. ipip ones instead of sit) and this won't be noticed at all, because the error is not reporte

[PATCH 1/4] Un-define the IPTUNNEL_XMIT() macro

2007-11-09 Thread Pavel Emelyanov
This one is used in all the smth-to-ip tunnels we have and looks ... not very good. Make this a regular function in the tunnel4.ko module. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/include/net/ipip.h b/include/net/ipip.h index 7cdc914..bc8f4a1 100644 --- a/include/net/i

Re: [PATCH 3/5] memory accounting

2007-11-09 Thread Herbert Xu
On Mon, Oct 29, 2007 at 05:23:21PM -0400, Hideo AOKI wrote: > This patch adds UDP memory usage accounting in IPv4. > > -- > Hideo Aoki > Hitachi Computer Products (America) Inc. > > Signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]> > Signed-off-by: Hideo Aoki <[EMAIL PROTECTED]> This looks fine

Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)

2007-11-09 Thread Ben Dooks
On Thu, Nov 08, 2007 at 08:18:54AM +, Al Viro wrote: > On Thu, Nov 08, 2007 at 04:31:05PM +0900, Magnus Damm wrote: > > config AX88796 > > tristate "ASIX AX88796 NE2000 clone support" > > - depends on ARM || MIPS > > + depends on ARM || MIPS || SUPERH > > You know, that really sucks m

Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)

2007-11-09 Thread Ben Dooks
On Fri, Nov 09, 2007 at 06:40:23PM +0900, Paul Mundt wrote: > On Fri, Nov 09, 2007 at 09:26:52AM +, Ralf Baechle wrote: > > If writesb() is not an official API then maybe the answer should have been > > to either add that API to other architectures or fix the driver. > > > > I guess this incid

Re: [PATCH 2/5] accounting unit and variable

2007-11-09 Thread Herbert Xu
On Mon, Oct 29, 2007 at 05:23:10PM -0400, Hideo AOKI wrote: > > +#define SK_DATAGRAM_MEM_QUANTUM ((int)PAGE_SIZE) > + > +static inline int sk_datagram_pages(int amt) > +{ > + return DIV_ROUND_UP(amt, SK_DATAGRAM_MEM_QUANTUM); > +} Does this really have to be int? Unsigned would let the compi

Re: [PATCH 1/5] fix send buffer check

2007-11-09 Thread Herbert Xu
On Mon, Oct 29, 2007 at 05:22:53PM -0400, Hideo AOKI wrote: > This patch introduces sndbuf size check before memory allocation for > send buffer. Looks good, what about IPv6? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://

Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)

2007-11-09 Thread Russell King
On Fri, Nov 09, 2007 at 06:40:23PM +0900, Paul Mundt wrote: > On Fri, Nov 09, 2007 at 09:26:52AM +, Ralf Baechle wrote: > > If writesb() is not an official API then maybe the answer should have been > > to either add that API to other architectures or fix the driver. > > > > I guess this incid

Re: [PATCH] using mii-bitbang on different processor ports - update the booting-without-of.txt-file

2007-11-09 Thread Sergej Stepanov
Am Donnerstag, den 08.11.2007, 14:20 -0600 schrieb Scott Wood: > Sergej Stepanov wrote: > > If both mdio and mdc controlling pins are on the same processor port, > > one resource should be used. > > Otherwise, two resources are used: the 1-st - mdio, the 2-nd - mdc. > > How about: > The first reg

Re: [PATCH 1/1]: Using ICMP type and code in xfrm selector

2007-11-09 Thread Herbert Xu
On Fri, Nov 02, 2007 at 06:17:40PM -0500, Joy Latten wrote: > > While fixing this I wondered why we put icmp message > type in sport and code in dport? Where we put the info in the kernel is not specified by the RFC. It has to document where you put it in IKE because IKE is used by two systems wh

Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)

2007-11-09 Thread Paul Mundt
On Fri, Nov 09, 2007 at 09:26:52AM +, Ralf Baechle wrote: > If writesb() is not an official API then maybe the answer should have been > to either add that API to other architectures or fix the driver. > > I guess this incident means I need to go through all Kconfig* files to > see what bogus

Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)

2007-11-09 Thread Ralf Baechle
On Thu, Nov 08, 2007 at 08:18:54AM +, Al Viro wrote: > On Thu, Nov 08, 2007 at 04:31:05PM +0900, Magnus Damm wrote: > > config AX88796 > > tristate "ASIX AX88796 NE2000 clone support" > > - depends on ARM || MIPS > > + depends on ARM || MIPS || SUPERH > > You know, that really sucks

Re: [PATCH] Fix buglets in mpc5200 FEC code that are corrupting memory.

2007-11-09 Thread Domen Puncer
On 09/11/07 00:31 -0500, Jon Smirl wrote: > This is the reason I couldn't get user space started or connect to my > nfs server. Patch is against current linus git. > > mpc5200 fec driver is corrupting memory. This patch fixes two bugs > where the wrong skb buffer was being referenced. > > Signed-