On Fri, Nov 02, 2007 at 06:17:40PM -0500, Joy Latten wrote: > > While fixing this I wondered why we put icmp message > type in sport and code in dport?
Where we put the info in the kernel is not specified by the RFC. It has to document where you put it in IKE because IKE is used by two systems which must agree on one format. Your patch looks OK to me but in general we want to encourage applications to use the xfrm_user interface as pf_key is not portable anyway because of the lack of a standard specification that covers the SPD. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
