Re: RFC: Established connections hash function

2007-03-22 Thread Evgeniy Polyakov
On Thu, Mar 22, 2007 at 01:53:03PM -0700, Nikolaos D. Bougalis ([EMAIL PROTECTED]) wrote: > >Grrr, I think I pointed several times already, that properly distributed > >values do not change distribution after folding. And it can be seen in > >all tests (and in that you pointed too). > >Yes, I

Re: L2TP support?

2007-03-22 Thread Jorge Boncompte [DTI2]
- Original Message - From: "James Chapman" <[EMAIL PROTECTED]> To: "Ingo Oeser" <[EMAIL PROTECTED]> Cc: Sent: Thursday, March 22, 2007 9:13 PM Subject: Re: L2TP support? Yes there is. There's a pppd plugin which comes with the openl2tp project, http://sf.net/projects/openl2tp. OpenL2T

Re: RFC: Established connections hash function

2007-03-22 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 23:03:04 +0100 > David Miller a écrit : > > From: "Nikolaos D. Bougalis" <[EMAIL PROTECTED]> > > Date: Thu, 22 Mar 2007 12:44:09 -0700 > > > >> People _have_ had problems. _I_ have had problems. And when > >> someone with a few tho

[git patches] net driver fixes

2007-03-22 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/Kconfig | 25 ++-- drivers/net/cxgb3/common.h | 15 ++ drivers/net/cxgb3/cx

[PATCH 13/13] mac68k: SONIC interrupt handling, version 3

2007-03-22 Thread Finn Thain
Install the built-in macsonic interrupt handler on both IRQs when using via_alt_mapping. Otherwise the rare interrupt that still comes from the nubus slot will wedge the nubus. $ cat /proc/interrupts auto 2: 89176 via2 auto 3: 744367 sonic auto 4: 0 scc auto

Re: [PATCH 0/8] [RESEND] netlink error magngement + others

2007-03-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 23:18:04 +0100 > I've rediffed all patches and combined the two patchsets into > one. Patrick has already queued the NLM_F_REQUEST change for > nfnetlink. > > [PATCH 0/5] [PATCHSET] Netlink Patches > Converts westwood and vegas netlink

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-22 Thread David Miller
From: Eric Paris <[EMAIL PROTECTED]> Date: Fri, 23 Mar 2007 01:39:47 -0400 > It seems reasonable to me that the check for every policy (which is > between current->security->sid and xp->security->ctx_sid) makes sense. > There doesn't appear to me right offhand to be anything intrinsic in the > cod

Re: [PATCH] Netpoll support for Sibyte MAC

2007-03-22 Thread Jeff Garzik
Deepak Saxena wrote: NETPOLL support for Sibyte MAC Signed-off-by: Manish Lachwani <[EMAIL PROTECTED]> Signed-off-by: Deepak Saxena <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo inf

Re: [PATCH 1/2] ehea: fix for dynamic lpar support

2007-03-22 Thread Jeff Garzik
Jan-Bernd Themann wrote: The patch fixes bugs related to the probe / remove adapter functionality (handling of OFDT nodes) Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> applied 1-2 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL P

Re: [PATCH 1/2] S2io: Remove unused variables

2007-03-22 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Remove unused variables from s2io_nic structure - Changed the memory failure printk messages to print only in debug mode - Updated the copyright messages (Resending; due to patch being corrupted) Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]> applied - To un

Re: [PATCH 4/7] skge: ignore unused error interrupts

2007-03-22 Thread Jeff Garzik
Stephen Hemminger wrote: The following hardware error bits only show up on Genesis chipset and are handled elsewhere, so they can be masked off. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/skge.h |1 - 1 file changed, 1 deletion(-) applied 4-7 - To unsubscribe

Re: [PATCH 1/4] myri10ge: Serverworks HT2100 provides aligned PCIe completion

2007-03-22 Thread Jeff Garzik
Brice Goglin wrote: [PATCH 1/4] myri10ge: Serverworks HT2100 provides aligned PCIe completion Use the regular firmware on Serverworks HT2100 PCIe ports since this chipset provides aligned PCIe completion. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c |

Re: [PATCH] mv643xx_eth: add mv643xx_eth_shutdown function

2007-03-22 Thread Jeff Garzik
Dale Farnsworth wrote: From: Dale Farnsworth <[EMAIL PROTECTED]> mv643xx_eth_shutdown is needed for kexec. Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> --- drivers/net/mv643xx_eth.c | 14 ++ 1 file changed, 14 insertions(+) applied - To unsubscribe from this list: send

Re: [PATCH 2.6.21 5/4] cxgb3 - fix white spaces in drivers/net/Kconfig

2007-03-22 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Use tabs instead of white spaces for CHELSIO_T3 entry. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] Revert "ucc_geth: returns NETDEV_TX_BUSY when BD ring is full"

2007-03-22 Thread Jeff Garzik
Li Yang wrote: This reverts commit 18babd38547a042a4bfd4154a014d1ad33373eb0. Michael Barkowski points out that it's wrong, and I agree. The patch causes a problem rather than fixes one after another patch "ucc_geth: Fix BD processing" was applied. Before that patch, current packet should be bl

Re: [NET] SAA9730: Fix large pile of warnings

2007-03-22 Thread Jeff Garzik
Ralf Baechle wrote: The SAA9730 driver doesn't quite grok what the difference between an ioport and memory mapped I/O is. It just happened to work on the one Linux system the SAA9730 happens to spend it's misserable existence on. applied - To unsubscribe from this list: send the line "unsubs

Re: [PATCH 3/7] skge: use per-port phy locking

2007-03-22 Thread Jeff Garzik
Stephen Hemminger wrote: Rather than a workqueue and a per-board mutex to control PHY, use a tasklet and spinlock. Tasklet is lower overhead and works just as well for this. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Like we give a crap about overhead of PHY code. This seems like th

Re: Fix return code in pci-skeleton.c

2007-03-22 Thread Jeff Garzik
Anton Blanchard wrote: We assign the return value of register_netdev to i, but return rc later on. Fix it. Signed-off-by: Anton Blanchard <[EMAIL PROTECTED]> --- diff --git a/drivers/net/pci-skeleton.c b/drivers/net/pci-skeleton.c index 00ca0fd..6ca4e4f 100644 --- a/drivers/net/pci-skeleton.c +

Re: [PATCH 2.6.21 1/4] cxgb3 - fix ethtool cmd on multiple queues port

2007-03-22 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Limit ethtool -g/-G to the given port's queues. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> applied 1-4 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More ma

Re: [PATCH 1/7] skge: deadlock on tx timeout

2007-03-22 Thread Jeff Garzik
Stephen Hemminger wrote: The skge driver will deadlock if gets a transmit timeout because the netif_tx_lock() is already held. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied 1-3 to #upstream-fixes - To unsubscribe from this list: send the line "unsubscribe netdev" in the body o

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-22 Thread Eric Paris
On Thu, 2007-03-22 at 19:49 -0400, James Morris wrote: > On Thu, 22 Mar 2007, Joy Latten wrote: > > > > I would look at this patch differently if there were some > > > security level key being checked for a match here, which is > > > an input key to the flush, but that is not what is happening > >

Re: Recent net-2.6.22 patches break bootup!

2007-03-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Fri, 23 Mar 2007 00:47:04 +0100 > * Stephen Hemminger <[EMAIL PROTECTED]> 2007-03-22 14:27 > > Something is broken now. If I boot the system (Fedora) it gets to: > > > > Bringing up loopback interface: RTNETLINK answers: Invalid argument > > Dump term

[PATCH 13/13] mac68k: SONIC interrupt handling, version 2

2007-03-22 Thread Finn Thain
The previous version of this patch had a bug where a nubus sonic card would register two interrupt handlers. Only a built-in sonic needs both. Install the built-in macsonic interrupt handler on both IRQs when using via_alt_mapping. Otherwise the rare interrupt that still comes from the nubus s

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-22 Thread James Morris
On Thu, 22 Mar 2007, Joy Latten wrote: > > Perhaps a better semantic would be to fail the entire flush operation if > > one of the security checks failed. e.g. loop through for permissions > > first, then if all ok, loop through for deletion. > > > Ok, will code this up and test it if there ar

[PATCH 2.6] WE-22 : prevent information leak on 64 bit

2007-03-22 Thread Jean Tourrilhes
Hi, Johannes Berg discovered that kernel space was leaking to userspace on 64 bit platform. He made a first patch to fix that. This is an improved version of his patch. This was tested on 2.6.21-rc4. Would you mind pushing that upstream ? Thanks... Jean Si

[PATCH 2.6] Add missing ioctls to 64<->32 conversion

2007-03-22 Thread Jean Tourrilhes
Hi John, Johannes Berg and Michael Buesch noticed that the WPA ioctls were missing from the 64<->32 bit conversion. This means that when using a 32 bits userspace on a 64 bit kernel, those ioctls fail. This patch was tested on 2.6.21-rc4. Would you mind pushing it upstream

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-22 Thread Joy Latten
On Thu, 2007-03-22 at 19:49 -0400, James Morris wrote: > On Thu, 22 Mar 2007, Joy Latten wrote: > > > > I would look at this patch differently if there were some > > > security level key being checked for a match here, which is > > > an input key to the flush, but that is not what is happening > >

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-22 Thread James Morris
On Thu, 22 Mar 2007, Joy Latten wrote: > > I would look at this patch differently if there were some > > security level key being checked for a match here, which is > > an input key to the flush, but that is not what is happening > > here as the object is being looked at by itself. > > Yes, I und

Re: Recent net-2.6.22 patches break bootup!

2007-03-22 Thread Thomas Graf
* Stephen Hemminger <[EMAIL PROTECTED]> 2007-03-22 14:27 > Something is broken now. If I boot the system (Fedora) it gets to: > > Bringing up loopback interface: RTNETLINK answers: Invalid argument > Dump terminated > RTNETLINK answers: Invalid argument > > > tg3 device eth0 does not seem

Re: [PATCH] Fix crash in tg3 when using irqpoll

2007-03-22 Thread Bernhard Walle
Hello Michael, * Michael Chan <[EMAIL PROTECTED]> [2007-03-22 23:04]: > On Thu, 2007-03-22 at 21:46 +0100, Bernhard Walle wrote: > > > This patch makes sure that even the tr32() instruction in the interrupt > > handler > > is not executed which accesses PCI memory. Accessing PCI memory when > >

Re: VIA Velocity VLAN vexation

2007-03-22 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : [...] > Is this likely to be a problem with the via-velocity driver? Yes. > Is anyone working on it ? Not as much as I'd like to. > Or should I just get a different gigabit card ? This one probably got answered the 2005/11/29. :o) I'll got to bed in a f

Recent net-2.6.22 patches break bootup!

2007-03-22 Thread Stephen Hemminger
On Thu, 22 Mar 2007 12:06:19 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Thomas Graf <[EMAIL PROTECTED]> > Date: Thu, 22 Mar 2007 13:59:55 +0100 > > > The existing function names seem to have sentimental value to some > > people. Same patches but without changes to the functio nam

[PATCH 8/8] [NETLINK]: Directly return -EINTR from netlink_dump_start()

2007-03-22 Thread Thomas Graf
Now that all users of netlink_dump_start() use netlink_run_queue() to process the receive queue, it is possible to return -EINTR from netlink_dump_start() directly, therefore simplying the callers. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.22/net/core/rtnetlink.c =

[PATCH 6/8] [NETLINK]: Remove error pointer from netlink message handler

2007-03-22 Thread Thomas Graf
The error pointer argument in netlink message handlers is used to signal the special case where processing has to be interrupted because a dump was started but no error happened. Instead it is simpler and more clear to return -EINTR and have netlink_run_queue() deal with getting the queue right. n

[PATCH 7/8] [IPv4] diag: Use netlink_run_queue() to process the receive queue

2007-03-22 Thread Thomas Graf
Makes use of netlink_run_queue() to process the receive queue and converts inet_diag_rcv_msg() to use the type safe netlink interface. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.22/net/ipv4/inet_diag.c === --- net-

[PATCH 3/8] [NETLINK]: Remove unused groups variable

2007-03-22 Thread Thomas Graf
Leftover from dynamic multicast groups allocation work. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.22/net/netlink/af_netlink.c === --- net-2.6.22.orig/net/netlink/af_netlink.c2007-03-22 23:08:48.0 +010

[PATCH 4/8] [NETLINK]: Ignore !NLM_F_REQUEST messages directly in netlink_run_queue()

2007-03-22 Thread Thomas Graf
netlink_rcv_skb() is changed to skip messages which don't have the NLM_F_REQUEST bit to avoid every netlink family having to perform this check on their own. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.22/net/netlink/af_netlink.c =

[PATCH 5/8] [NETLINK]: Ignore control messages directly in netlink_run_queue()

2007-03-22 Thread Thomas Graf
Changes netlink_rcv_skb() to skip netlink controll messages and don't pass them on to the message handler. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.22/net/netlink/af_netlink.c === --- net-2.6.22.orig/net/netlink/

[PATCH 0/8] [RESEND] netlink error magngement + others

2007-03-22 Thread Thomas Graf
Dave, I've rediffed all patches and combined the two patchsets into one. Patrick has already queued the NLM_F_REQUEST change for nfnetlink. [PATCH 0/5] [PATCHSET] Netlink Patches Converts westwood and vegas netlink code to use the typesafe interface, removes an unused varaible, and move some netl

[PATCH 1/8] [TCP] vegas: Use type safe netlink interface

2007-03-22 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.22/net/ipv4/tcp_vegas.c === --- net-2.6.22.orig/net/ipv4/tcp_vegas.c2007-03-22 23:08:48.0 +0100 +++ net-2.6.22/net/ipv4/tcp_vegas.c 2007-03-22 23:09:21

[PATCH 2/8] [TCP] westwood: Use type safe netlink interface

2007-03-22 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.22/net/ipv4/tcp_westwood.c === --- net-2.6.22.orig/net/ipv4/tcp_westwood.c 2007-03-22 23:08:48.0 +0100 +++ net-2.6.22/net/ipv4/tcp_westwood.c 2007-03-22 23:09

Re: RFC: Established connections hash function

2007-03-22 Thread Eric Dumazet
David Miller a écrit : From: "Nikolaos D. Bougalis" <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 12:44:09 -0700 People _have_ had problems. _I_ have had problems. And when someone with a few thousand drones under his control hoses your servers because he can do math and he leaves you with 200

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-22 Thread Joy Latten
On Thu, 2007-03-22 at 12:01 -0700, David Miller wrote: > From: Joy Latten <[EMAIL PROTECTED]> > Date: Thu, 22 Mar 2007 12:35:39 -0600 > > > Within selinux we check for authorization before deleting entries from > > SAD and SPD. > > > > We are not checking for authorization when flushing the SPD

[PATCH 2.6.21] iw_cxgb3: Fix a resource leak in cxio_hal_init_ctrl_qp().

2007-03-22 Thread Steve Wise
Fix a resource leak in cxio_hal_init_ctrl_qp(). Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/cxio_hal.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw/cxgb3/cxio_

Re: [PATCH] Fix crash in tg3 when using irqpoll

2007-03-22 Thread Michael Chan
On Thu, 2007-03-22 at 21:46 +0100, Bernhard Walle wrote: > > This patch makes sure that even the tr32() instruction in the interrupt > handler > is not executed which accesses PCI memory. Accessing PCI memory when > pci_restore_state() is called is a bad idea because that function modifies > the

Re: [PATCH 4/5] netem: avoid excessive requeues

2007-03-22 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 21:40:43 +0100 > > --- net-2.6.22.orig/net/sched/sch_netem.c > > +++ net-2.6.22/net/sched/sch_netem.c > > @@ -272,6 +272,10 @@ static struct sk_buff *netem_dequeue(str > > struct netem_sched_data *q = qdisc_priv(sch); > > str

Re: [PATCH 0/3] [PATCHSET] netlink error management

2007-03-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 20:57:54 +0100 > * David Miller <[EMAIL PROTECTED]> 2007-03-22 12:23 > > From: Thomas Graf <[EMAIL PROTECTED]> > > Date: Thu, 22 Mar 2007 00:18:01 +0100 > > > > > This series of patches simplifies the error management and > > > signaliz

Re: RFC: Established connections hash function

2007-03-22 Thread David Miller
From: "Nikolaos D. Bougalis" <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 12:44:09 -0700 > People _have_ had problems. _I_ have had problems. And when > someone with a few thousand drones under his control hoses your > servers because he can do math and he leaves you with 2-item > long chain

Re: RFC: Established connections hash function

2007-03-22 Thread Nikolaos D. Bougalis
We started our discussion a bit wrong - let's start it again, ok? :) Fair enough. You do not want to read what was written - _if_ we use artificial data, then attacker can use it too, so if it is possible to break the system with artificial data, then it is possible it will be broken in

[PATCH] Fix crash in tg3 when using irqpoll

2007-03-22 Thread Bernhard Walle
When using irqpoll I had a crash when I loaded the tg3 network driver (on IA64). The stack trace was: ia64_leave_kernel [tg3]tg3_interrupt_tagged note_interrupt __do_IRQ ia64_handle_irq ia64_leave_kernel _spin_unlock_irqrestore pci_bu

Re: [PATCH 4/5] netem: avoid excessive requeues

2007-03-22 Thread Patrick McHardy
Stephen Hemminger wrote: > @@ -315,6 +316,7 @@ void qdisc_watchdog_schedule(struct qdis > ktime_t time; > > wd->qdisc->flags |= TCQ_F_THROTTLED; > + smp_wmb(); > time = ktime_set(0, 0); > time = ktime_add_ns(time, PSCHED_US2NS(expires)); > hrtimer_start(&wd->time

Re: L2TP support?

2007-03-22 Thread James Chapman
Hi Ingo, Ingo Oeser wrote: Hi James, James Chapman schrieb: Is there interest in adding L2TP support? Yes, if there is also a user space part somewhere. Yes there is. There's a pppd plugin which comes with the openl2tp project, http://sf.net/projects/openl2tp. OpenL2TP supports both LAC a

Re: RFC: Established connections hash function

2007-03-22 Thread Evgeniy Polyakov
On Thu, Mar 22, 2007 at 12:44:09PM -0700, Nikolaos D. Bougalis ([EMAIL PROTECTED]) wrote: > On Thu, Mar 22, 2007 11:21 AM, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > >> Utterly broken? Nonsense. I have tested the actual function I proposed > >>(sans the __force and __u32 stuff, which weren

Re: [PATCH 0/3] [PATCHSET] netlink error management

2007-03-22 Thread Thomas Graf
* David Miller <[EMAIL PROTECTED]> 2007-03-22 12:23 > From: Thomas Graf <[EMAIL PROTECTED]> > Date: Thu, 22 Mar 2007 00:18:01 +0100 > > > This series of patches simplifies the error management and > > signalization of dump starts of netlink_run_queue() message > > handlers. It touches a fair bit o

Re: RFC: Established connections hash function

2007-03-22 Thread Nikolaos D. Bougalis
On Thu, Mar 22, 2007 11:21 AM, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: Utterly broken? Nonsense. I have tested the actual function I proposed (sans the __force and __u32 stuff, which weren't necessary in my test program), against real data, collected from various servers in real-time. It

Re: [ANN] Unified dynamic storage for different socket types instead of separate hash tables.

2007-03-22 Thread Evgeniy Polyakov
On Thu, Mar 22, 2007 at 12:36:04PM -0700, David Miller ([EMAIL PROTECTED]) wrote: > > > 2) An extra list insert/delete to give list of all sockets > > > > That is too small price. > > In your imagination. Our connection rates went up significantly > when I got rid of the linked list we had many

Re: [ANN] Unified dynamic storage for different socket types instead of separate hash tables.

2007-03-22 Thread David Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 22:30:52 +0300 > > 2) An extra list insert/delete to give list of all sockets > > That is too small price. In your imagination. Our connection rates went up significantly when I got rid of the linked list we had many years ago.

Re: [ANN] Unified dynamic storage for different socket types instead of separate hash tables.

2007-03-22 Thread Evgeniy Polyakov
On Thu, Mar 22, 2007 at 12:21:20PM -0700, David Miller ([EMAIL PROTECTED]) wrote: > From: Evgeniy Polyakov <[EMAIL PROTECTED]> > Date: Thu, 22 Mar 2007 22:14:49 +0300 > > > And to be absolutely clear - existing interface does not support it too > > - we iterate over every single hash entry, and t

Re: fix up misplaced inlines.

2007-03-22 Thread David Miller
From: Dave Jones <[EMAIL PROTECTED]> Date: Wed, 21 Mar 2007 20:18:28 -0400 > Turning up the warnings on gcc makes it emit warnings > about the placement of 'inline' in function declarations. > Here's everything that was under net/ > > Signed-off-by: Dave Jones <[EMAIL PROTECTED]> Applied, thanks

Re: [PATCH] [SCTP] Correctly reset ssthresh when restarting association

2007-03-22 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 14:56:19 -0400 > Reset ssthresh to the correct value (peer's a_rwnd) when restarting > association. > > Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]> Applied, thanks Vlad. - To unsubscribe from this list: send the line "unsubscrib

Re: [NET]: Fix fib_rules dump race

2007-03-22 Thread David Miller
Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [BRIDGE]: Fix fdb RCU race

2007-03-22 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 19:29:09 +0100 > Fix what looks like a RCU race. Untested since this is only > used by ATM, which I don't have. Also applied, thanks Patrick. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mess

Re: [PATCH 0/3] [PATCHSET] netlink error management

2007-03-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 00:18:01 +0100 > This series of patches simplifies the error management and > signalization of dump starts of netlink_run_queue() message > handlers. It touches a fair bit of nfnetlink code as the > error pointer has been passed on to su

Re: [ANN] Unified dynamic storage for different socket types instead of separate hash tables.

2007-03-22 Thread David Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 22:14:49 +0300 > And to be absolutely clear - existing interface does not support it too > - we iterate over every single hash entry, and then over every single > item in the chain (if it exists). I can create the same for the tree

Re: [ANN] Unified dynamic storage for different socket types instead of separate hash tables.

2007-03-22 Thread Evgeniy Polyakov
On Thu, Mar 22, 2007 at 12:14:41PM -0700, David Miller ([EMAIL PROTECTED]) wrote: > From: Evgeniy Polyakov <[EMAIL PROTECTED]> > Date: Thu, 22 Mar 2007 22:09:40 +0300 > > > I specially have only one hash structure in the socket - skc_bind_node - > > to be used for statistics and remove hash and s

Re: [PATCH 0/5] netem performance improvements

2007-03-22 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 21 Mar 2007 10:42:31 -0700 > The following patches for the 2.6.22 net tree, increase the > performance of netem by about 2x. With 2.6.20 getting about > 100K (out of possible 300K) packets per second, after these > patches now at over 200K pp

Re: [NET]: Fix fib_rules dump race

2007-03-22 Thread Thomas Graf
* Patrick McHardy <[EMAIL PROTECTED]> 2007-03-22 15:38 > [NET]: Fix fib_rules dump race > > fib_rules_dump needs to use list_for_each_entry_rcu to protect against > concurrent changes to the rules list. Good catch, it's not serialized with add/del by rtnl mutex if the dump gets interrupted. - To

Re: [ANN] Unified dynamic storage for different socket types instead of separate hash tables.

2007-03-22 Thread David Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 22:09:40 +0300 > I specially have only one hash structure in the socket - skc_bind_node - > to be used for statistics and remove hash and skc_node (and for netlink > broadcasting too), so this code reduces socket structure by 12 byt

Re: [ANN] Unified dynamic storage for different socket types instead of separate hash tables.

2007-03-22 Thread Evgeniy Polyakov
On Thu, Mar 22, 2007 at 12:03:46PM -0700, David Miller ([EMAIL PROTECTED]) wrote: > From: Evgeniy Polyakov <[EMAIL PROTECTED]> > Date: Thu, 22 Mar 2007 21:59:44 +0300 > > > Yes, current code does not support statistics. > > Existing stats run over whole hash table, I do not like such approach, >

Re: [PATCH 2/2] tcp: cubic optimization

2007-03-22 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 21 Mar 2007 13:17:21 -0700 > Use willy's work in optimizing cube root by having table for small values. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Also applied to net-2.6.22, thanks Stephen. - To unsubscribe from this list: sen

Re: [PATCH 1/2] div64_64 optimization

2007-03-22 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 21 Mar 2007 13:15:32 -0700 > Minor optimization of div64_64. do_div() already does optimization > for the case of 32 by 32 divide, so no need to do it here. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied to net-2.6.22 - To

Re: [ANN] Unified dynamic storage for different socket types instead of separate hash tables.

2007-03-22 Thread Evgeniy Polyakov
On Thu, Mar 22, 2007 at 12:03:46PM -0700, David Miller ([EMAIL PROTECTED]) wrote: > From: Evgeniy Polyakov <[EMAIL PROTECTED]> > Date: Thu, 22 Mar 2007 21:59:44 +0300 > > > Yes, current code does not support statistics. > > Existing stats run over whole hash table, I do not like such approach, >

Re: [RESEND] [NET] rules: Unified rules dumping

2007-03-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 14:03:02 +0100 > Rediffed based on new rtnl registration patches. > > Implements a unified, protocol independant rules dumping function > which is capable of both, dumping a specific protocol family or > all of them. This speeds up dump

Re: [PATCH 00/12] [RESEND] rtnetlink message handler registration interface

2007-03-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 13:59:55 +0100 > The existing function names seem to have sentimental value to some > people. Same patches but without changes to the functio names. > > Introduces an interface to register rtnetlink message handlers > and converts all u

Re: [PATCH 09/12] [DECNet]: Use rtnl registration interface

2007-03-22 Thread David Miller
From: Steven Whitehouse <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 13:07:54 + > Hi, > > On Thu, Mar 22, 2007 at 02:00:04PM +0100, Thomas Graf wrote: > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> > > > Acked-by: Steven Whitehouse <[EMAIL PROTECTED]> > > for all the DECnet bits & also the

Re: [ANN] Unified dynamic storage for different socket types instead of separate hash tables.

2007-03-22 Thread David Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 21:59:44 +0300 > Yes, current code does not support statistics. > Existing stats run over whole hash table, I do not like such approach, > so I will introduce a per-protocol lists of all sockets, which can be > accessed from statist

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-22 Thread David Miller
From: Joy Latten <[EMAIL PROTECTED]> Date: Thu, 22 Mar 2007 12:35:39 -0600 > Within selinux we check for authorization before deleting entries from > SAD and SPD. > > We are not checking for authorization when flushing the SPD and > the SAD. It was perhaps missed in original patch. > > This pat

Re: [ANN] Unified dynamic storage for different socket types instead of separate hash tables.

2007-03-22 Thread Evgeniy Polyakov
On Thu, Mar 22, 2007 at 11:43:04AM -0700, Stephen Hemminger ([EMAIL PROTECTED]) wrote: > > > > > diff --git a/include/linux/netlink.h b/include/linux/netlink.h > > index 2a20f48..f11b4e7 100644 > > --- a/include/linux/netlink.h > > +++ b/include/linux/netlink.h > > @@ -151,7 +151,6 @@ struct net

[PATCH] [SCTP] Correctly reset ssthresh when restarting association

2007-03-22 Thread Vlad Yasevich
Reset ssthresh to the correct value (peer's a_rwnd) when restarting association. Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]> --- net/sctp/transport.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/sctp/transport.c b/net/sctp/transport.c index c4699f5..4d8c2ab 1

[PATCH]: Add security check before flushing SAD/SPD

2007-03-22 Thread Joy Latten
Within selinux we check for authorization before deleting entries from SAD and SPD. We are not checking for authorization when flushing the SPD and the SAD. It was perhaps missed in original patch. This patch adds security check when flushing entries from SAD and SPD. Please let me know if this

Re: [ANN] Unified dynamic storage for different socket types instead of separate hash tables.

2007-03-22 Thread Stephen Hemminger
> > diff --git a/include/linux/netlink.h b/include/linux/netlink.h > index 2a20f48..f11b4e7 100644 > --- a/include/linux/netlink.h > +++ b/include/linux/netlink.h > @@ -151,7 +151,6 @@ struct netlink_skb_parms > #define NETLINK_CB(skb) (*(struct > netlink_skb_parms*)&((skb)->cb)) >

Re: [BRIDGE]: Fix fdb RCU race

2007-03-22 Thread Stephen Hemminger
On Thu, 22 Mar 2007 19:29:09 +0100 Patrick McHardy <[EMAIL PROTECTED]> wrote: > Fix what looks like a RCU race. Untested since this is only > used by ATM, which I don't have. > That looks right, I wonder if the ATM hooks ever get used? -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe

[BRIDGE]: Fix fdb RCU race

2007-03-22 Thread Patrick McHardy
Fix what looks like a RCU race. Untested since this is only used by ATM, which I don't have. [BRIDGE]: Fix fdb RCU race br_fdb_get use atomic_inc to increase the refcount of an element found on a RCU protected list, which can lead to the following race: CPU0CP

Re: RFC: Established connections hash function

2007-03-22 Thread Evgeniy Polyakov
On Thu, Mar 22, 2007 at 10:32:44AM -0700, Nikolaos D. Bougalis ([EMAIL PROTECTED]) wrote: >Utterly broken? Nonsense. I have tested the actual function I proposed > (sans the __force and __u32 stuff, which weren't necessary in my test > program), against real data, collected from various serv

Re: [PATCH 2.6.21] iw_cxgb3: Handle build_phys_page_list() failure in iwch_reregister_phys_mem().

2007-03-22 Thread Roland Dreier
thanks, applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: L2TP support?

2007-03-22 Thread Ingo Oeser
Hi James, James Chapman schrieb: > Is there interest in adding L2TP support? Yes, if there is also a user space part somewhere. > I have a patch which could be submitted for review. The PPPoL2TP driver > presents a PPPoX socket to userspace pppd in the same way as the PPPoE > and PPPoATM driver

Re: RFC: Established connections hash function

2007-03-22 Thread Nikolaos D. Bougalis
On Thu, March 22, 2007 at 8:52 AM, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: It seems you do not know a history... I know a lot about history. I may not know the specific history you had in mind though. I do see now that this has been brought up before. Before posting, I did searc

Re: iproute2-2.6.20-070313 bug ?

2007-03-22 Thread Patrick McHardy
Stephen Hemminger wrote: > tc should check for overflows and doesn't. Do you want to make a patch > for the obvious cases? I agree. I'll take care of it once I'm done with my patches for 2.6.22. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

Re: iproute2-2.6.20-070313 bug ?

2007-03-22 Thread Stephen Hemminger
On Thu, 22 Mar 2007 14:09:06 +0100 Patrick McHardy <[EMAIL PROTECTED]> wrote: > Denys wrote: > > /sbin/tc2 qdisc del dev ppp0 root > > /sbin/tc2 qdisc add dev ppp0 root handle 1: prio > > /sbin/tc2 qdisc add dev ppp0 parent 1:1 handle 2: tbf buffer 1024kb latency > > 500ms rate 128kbit peakrate

L2TP support?

2007-03-22 Thread James Chapman
Is there interest in adding L2TP support? I have a patch which could be submitted for review. The PPPoL2TP driver presents a PPPoX socket to userspace pppd in the same way as the PPPoE and PPPoATM drivers. The kernel handles all data traffic, while userspace daemons do L2TP and PPP control messag

[PATCH 2/2] ehea: code cleanup

2007-03-22 Thread Jan-Bernd Themann
This patch includes: - code cleanup related to resource management - extended error data gathering for resource management - removing trailing whitespaces Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- This patch applies on top of the netdev upstream branch for 2.6.22 drivers/net/e

[PATCH 1/2] ehea: fix for dynamic lpar support

2007-03-22 Thread Jan-Bernd Themann
The patch fixes bugs related to the probe / remove adapter functionality (handling of OFDT nodes) Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- This patch applies on top of the netdev upstream branch for 2.6.22 diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h index d59

Re: RFC: Established connections hash function

2007-03-22 Thread Evgeniy Polyakov
On Thu, Mar 22, 2007 at 08:39:04AM -0700, Nikolaos D. Bougalis ([EMAIL PROTECTED]) wrote: >This particular hash seems to be the odd-man out, since most other > network related hashes in the kernel seem to be Jenkins-based, and some use > tagged hashing to defeat algorithmic complexity attacks.

RFC: Established connections hash function

2007-03-22 Thread Nikolaos D. Bougalis
Hello, I have noticed that the hash function that the kernel uses for established TCP/IP connections is rather simplistic, specifically: h = (local address ^ local_port) ^ (remote_address ^ remote_port); h ^= h >> 16; h ^= h >> 8; Now, simple is great, but this has a number of

[PATCH 2.6.21] iw_cxgb3: Handle build_phys_page_list() failure in iwch_reregister_phys_mem().

2007-03-22 Thread Steve Wise
Handle build_phys_page_list() failure in iwch_reregister_phys_mem(). Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_provider.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c b/drivers/

Re: [PATCH] netxen: enum and #define cleanups

2007-03-22 Thread Andy Gospodarek
On Thu, Mar 22, 2007 at 07:59:05PM +0530, Amit Kale wrote: > On Thursday 22 March 2007 00:46, Andy Gospodarek wrote: > > This patch cleans up some rather generically named items in the netxen > > driver. It seems bad to use names like USER_START and FLASH_TOTAL_SIZE, > > so I added a NETXEN_ to th

[NET]: Fix fib_rules dump race

2007-03-22 Thread Patrick McHardy
[NET]: Fix fib_rules dump race fib_rules_dump needs to use list_for_each_entry_rcu to protect against concurrent changes to the rules list. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c index 215f1bf..3aea4e8 100644 --- a/net/core/fib_

Re: [PATCH] netxen: enum and #define cleanups

2007-03-22 Thread Amit Kale
On Thursday 22 March 2007 00:46, Andy Gospodarek wrote: > This patch cleans up some rather generically named items in the netxen > driver. It seems bad to use names like USER_START and FLASH_TOTAL_SIZE, > so I added a NETXEN_ to the front of them. > > This has been compile tested. > > Signed-off-b

Re: iproute2-2.6.20-070313 bug ?

2007-03-22 Thread Denys
Hi again On Thu, 22 Mar 2007 14:43:43 +0100, Patrick McHardy wrote > Denys wrote: > >>>Another thing, it is working well > >>>with old tc. Just really if i have plenty of RAM's and i want 32second > >>>buffer, why i cannot have that, and if i see it is really possible before? > >> > >>I know it

Re: [PATCH 09/12] [DECNet]: Use rtnl registration interface

2007-03-22 Thread Steven Whitehouse
Hi, On Thu, Mar 22, 2007 at 02:00:04PM +0100, Thomas Graf wrote: > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> > Acked-by: Steven Whitehouse <[EMAIL PROTECTED]> for all the DECnet bits & also the DECnet changes in the other patch I saw from you relating to the routing rules, Steve. - To unsub

  1   2   >