Re: [patch sungem] improved locking

2006-11-13 Thread David Miller
From: "Eric Lemoine" <[EMAIL PROTECTED]> Date: Tue, 14 Nov 2006 08:28:42 +0100 > because it makes it explicit that only bits 0 through 6 are taken into > account when writing the IACK register. The phrase "bits 0 through 6" doesn't make any sense when bit 3 DOES NOT EXIST in the hardware, it's re

Re: [patch sungem] improved locking

2006-11-13 Thread Eric Lemoine
On 11/14/06, David Miller <[EMAIL PROTECTED]> wrote: From: "Eric Lemoine" <[EMAIL PROTECTED]> Date: Mon, 13 Nov 2006 00:11:49 +0100 > +#if GEM_INTERRUPT_LOCKLESS > + > +/* Bitmask representing the interrupt conditions that we clear using GREG_IACK. > + * We clear all the top-level interrupt con

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-13 Thread Jarek Poplawski
On Mon, Nov 13, 2006 at 02:58:17PM -0500, Paul Moore wrote: > Jarek Poplawski wrote: > > @@ -586,7 +586,7 @@ > >goto failure; > >} > >/* add a DOC_EXMPL_A_MSG attribute */ > > - rc = nla_put_string(skb, DOC_EXMPL_A_MSG, "Generic Netlink Rocks"); > > + rc = nla_put_string(skb, DOC_

RE: Realtek 8139 driver (8139too.c) TX Timeout doesn't allow interrupt handler to disable receive interrupts at high bi-directional traffic

2006-11-13 Thread Basheer, Mansoor Ahamed
Francois Romieu [mailto:[EMAIL PROTECTED] wrote: > Afaics your change may disable the Rx irq right after the poll > routine enabled it again. It will not always work either. > > The (slow) timeout watchdog could grab the poll handler and hack > the irq mask depending on whether poll was schedul

Re: [patch 1/2]d80211: hardware TKIP support for ipw3945

2006-11-13 Thread Hong Liu
Resend the patch according to Johannes's comments. Still put he tkip_key in tx_control structure. Signed-off-by: Hong Liu <[EMAIL PROTECTED]> diff --git a/include/net/d80211.h b/include/net/d80211.h index 812f2d1..cf87adc 100644 --- a/include/net/d80211.h +++ b/include/net/d80211.h @@ -159,6 +15

Re: [Bugme-new] [Bug 7502] New: sunhme not working with 2.6.18 on x86

2006-11-13 Thread Andrew Morton
On Tue, 14 Nov 2006 02:50:22 +0100 "Michal Pokrywka" <[EMAIL PROTECTED]> wrote: > > I'd have expected that this would have been caused by i386 platform > > borkage. But in the debian bug report, Michal has fingered davem's > > http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.18.y. >

Re: [PATCH] IPv6: only modify checksum for UDP

2006-11-13 Thread Al Viro
On Mon, Nov 13, 2006 at 05:44:12PM -0800, David Stevens wrote: > That's actually what I was suggesting. In 1's-complement, > ~0 == -0 which is still 0, so barring any special case (like UDP's > "0 means no checksum" rule), it should be equally valid for a > packet to have 0 or ~0 as the che

Re: [Bugme-new] [Bug 7502] New: sunhme not working with 2.6.18 on x86

2006-11-13 Thread Michal Pokrywka
> I'd have expected that this would have been caused by i386 platform > borkage. But in the debian bug report, Michal has fingered davem's > http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.18.y. > git;a=commit;h=050bbb196392b9c178f82b1205a23dd2f915ee93 > as the cause. > > Michal, w

Re: [PATCH] IPv6: only modify checksum for UDP

2006-11-13 Thread David Stevens
David Miller <[EMAIL PROTECTED]> wrote on 11/13/2006 04:50:58 PM: > Puzzling :-) Then why is the transformation only performed for > UDP in the ipv4 stack? It seems by your logic TCP would need > to either do the "if (sum==0) sum=~0;" thing or it would need > to accept both "0" and "~0" in the

Re: [PATCH] IPv6: only modify checksum for UDP

2006-11-13 Thread Al Viro
On Mon, Nov 13, 2006 at 04:50:58PM -0800, David Miller wrote: > From: David Stevens <[EMAIL PROTECTED]> > Date: Fri, 10 Nov 2006 09:54:58 -0800 > > > The Internet checksum is defined as a 1's-complement sum, so if the > > alternate 0 does not have a special meaning in a protocol, then by > > 1's-

Re: [PATCH 1/8] netpoll: skb private pool management

2006-11-13 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 26 Oct 2006 19:29:34 -0700 > It was a dark and stormy night when Steve first saw the > netpoll beast. The beast was odd, and misshapen but not > extremely ugly. > > "Let me take off one of your warts" he said. This wart > is where you tried t

Re: [PATCH 6/6] IPv6: Fix infinite loop if no matching IPv6 tunnel found

2006-11-13 Thread David Miller
From: Ville Nuorvala <[EMAIL PROTECTED]> Date: Thu, 02 Nov 2006 16:22:07 +0200 > Ok, I'll resubmit a patch doesn't send an ICMPv6 error message. Is this coming soon? I'd like to integrate this patch set into net-2.6.20 if I can. - To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [PATCH] IPv6: only modify checksum for UDP

2006-11-13 Thread David Miller
From: David Stevens <[EMAIL PROTECTED]> Date: Fri, 10 Nov 2006 09:54:58 -0800 > The Internet checksum is defined as a 1's-complement sum, so if the > alternate 0 does not have a special meaning in a protocol, then by > 1's-complement arithmetic, 0 == ~0. > So, it looks to me without the r

Re: [PATCH] dccp: remove module exit functions

2006-11-13 Thread David Miller
From: "Arnaldo Carvalho de Melo" <[EMAIL PROTECTED]> Date: Fri, 10 Nov 2006 16:32:16 -0200 > On 11/10/06, James Morris <[EMAIL PROTECTED]> wrote: > > On Fri, 10 Nov 2006, James Morris wrote: > > > > > I wonder if this facility can be integrated more generally into the kernel > > > protocol which p

Re: [patch sungem] improved locking

2006-11-13 Thread David Miller
From: "Eric Lemoine" <[EMAIL PROTECTED]> Date: Mon, 13 Nov 2006 00:11:49 +0100 > +#if GEM_INTERRUPT_LOCKLESS > + > +/* Bitmask representing the interrupt conditions that we clear using > GREG_IACK. > + * We clear all the top-level interrupt conditions (bits 0 through 6) that we > + * handle. > +

Re: [PATCH] cleanup of the sctp state table code

2006-11-13 Thread Sridhar Samudrala
On Mon, 2006-11-13 at 16:18 -0800, David Miller wrote: > From: Peter Zijlstra <[EMAIL PROTECTED]> > Date: Mon, 13 Nov 2006 14:38:05 +0100 > > > I noticed an insane high density of repeated characters fixable by a > > simple regular expression: > > > > % s/{.fn = \([^,]*\),[[:space:]]\+\(\\\n[[:

Re: [PATCH] cleanup of the sctp state table code

2006-11-13 Thread David Miller
From: Peter Zijlstra <[EMAIL PROTECTED]> Date: Mon, 13 Nov 2006 14:38:05 +0100 > I noticed an insane high density of repeated characters fixable by a > simple regular expression: > > % s/{.fn = \([^,]*\),[[:space:]]\+\(\\\n[[:space:]]\+\)\?.name = > "\1"}/TYPE_SCTP_FUNC(\1)/g > > (NOTE: the .

Re: [patch] fix up generic csum_ipv6_magic function prototype

2006-11-13 Thread David Miller
From: Al Viro <[EMAIL PROTECTED]> Date: Mon, 13 Nov 2006 08:52:23 + > The first question is in the types we are using for length. OK, > csum_tcpudp_...() is a special case; there we want u16 and unless > there's a reason _not_ to do so on sparc, I'd rather convert it > to the same thing. Tha

Re: [PATCH] ambassador,firestream: "-1 >>" is implementation defined

2006-11-13 Thread David Miller
From: Al Viro <[EMAIL PROTECTED]> Date: Mon, 13 Nov 2006 20:26:56 + > On Mon, Nov 13, 2006 at 11:22:00PM +0300, Alexey Dobriyan wrote: > > 6.5.7(5): The result of E1 >> E2 is E1 right-shifted E2 bit positions. > > ... > > If E1 has a signed type and a negative value, the result

Re: [PATCH] SELinux: Add support for DCCP

2006-11-13 Thread David Miller
From: James Morris <[EMAIL PROTECTED]> Date: Mon, 13 Nov 2006 16:15:06 -0500 (EST) > This patch implements SELinux kernel support for DCCP > (http://linux-net.osdl.org/index.php/DCCP), which is similar in operation > to TCP in terms of connected state between peers. > > The SELinux support for DC

Re: [2.6 patch] the scheduled removal of the frame diverter

2006-11-13 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Mon, 13 Nov 2006 22:04:25 +0100 > This patch contains the scheduled removal of the frame diverter. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Applied to net-2.6.20, thanks Adrian. - To unsubscribe from this list: send the line "unsubscribe netd

Re: [2.6 patch] the scheduled removal of the frame diverter

2006-11-13 Thread Kyle Moffett
On Nov 13, 2006, at 16:04:25, Adrian Bunk wrote: This patch contains the scheduled removal of the frame diverter. [snip] -config NET_DIVERT - bool "Frame Diverter (EXPERIMENTAL)" - depends on EXPERIMENTAL && BROKEN - ---help--- - The Frame Diverter allows you to divert

Re: [PATCH 2.6.20] [TCP] MD5 Signature Option (RFC2385) support.

2006-11-13 Thread David Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Fri, 10 Nov 2006 17:15:21 -0800 (PST) > Based on implementation by Rick Payne. > > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> In the tcp_get_md5sig_pool sequences, if NULL is returned the get_cpu() will leak. +static inline +struct tcp

[PATCH] SELinux: Add support for DCCP

2006-11-13 Thread James Morris
This patch implements SELinux kernel support for DCCP (http://linux-net.osdl.org/index.php/DCCP), which is similar in operation to TCP in terms of connected state between peers. The SELinux support for DCCP is thus modeled on existing handling of TCP. A new DCCP socket class is introduced, to all

[2.6 patch] the scheduled removal of the frame diverter

2006-11-13 Thread Adrian Bunk
This patch contains the scheduled removal of the frame diverter. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- Documentation/feature-removal-schedule.txt | 15 drivers/net/Space.c|1 include/linux/Kbuild |1 include/linux/divert.h

Re: [PATCH] ambassador,firestream: "-1 >>" is implementation defined

2006-11-13 Thread Al Viro
On Mon, Nov 13, 2006 at 11:22:00PM +0300, Alexey Dobriyan wrote: > 6.5.7(5): The result of E1 >> E2 is E1 right-shifted E2 bit positions. > ... > If E1 has a signed type and a negative value, the resulting value > is implementation defined. > > So, cast -1 to unsigned typ

[PATCH] ambassador,firestream: "-1 >>" is implementation defined

2006-11-13 Thread Alexey Dobriyan
6.5.7(5): The result of E1 >> E2 is E1 right-shifted E2 bit positions. ... If E1 has a signed type and a negative value, the resulting value is implementation defined. So, cast -1 to unsigned type to make result well-defined. Signed-off-by: Alexey Dobriyan <[EMAIL

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-13 Thread Paul Moore
jamal wrote: > On Mon, 2006-13-11 at 09:08 -0500, Paul Moore wrote: > >>I want to give Jamal a little bit longer to reply. > > Sorry, family emergency - still ongoing today, so havent looked at > anything (including presentation that was supposed to be done) ;-< > > Give me a day or two (I know

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-13 Thread Paul Moore
Jarek Poplawski wrote: > @@ -586,7 +586,7 @@ >goto failure; >} >/* add a DOC_EXMPL_A_MSG attribute */ > - rc = nla_put_string(skb, DOC_EXMPL_A_MSG, "Generic Netlink Rocks"); > + rc = nla_put_string(skb, DOC_EXMPL_A_MSG, "Justin Timberlake rocks"); >if (rc != 0) >goto f

Re: [PATCH] WAN: DSCC4 driver requires generic HDLC

2006-11-13 Thread Francois Romieu
Krzysztof Halasa <[EMAIL PROTECTED]> : [...] > Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> Acked-by: Francois Romieu <[EMAIL PROTECTED]> Let's improve the user-friendliness of hdlc... -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

[PATCH] WAN: DSCC4 driver requires generic HDLC

2006-11-13 Thread Krzysztof Halasa
Another thing, reported recently to me by several people - DSCC4 WAN driver now (and perhaps for the last couple of years+) requires the generic HDLC. I've fixed the Kconfig and moved the DSCC4 option under CONFIG_HDLC so it's consistent visually. Jeff, Francois, I think it's safe to apply. Thanks

RE: [PATCH 0/3] labeled-ipsec: Repost patchset with updates [Originally: mlsxfrm: Various Fixes]

2006-11-13 Thread Joshua Brindle
> From: Venkat Yekkirala [mailto:[EMAIL PROTECTED] > > > I pulled in the lspp respin kernels and am checking the labeling > > behavior now so I should have a full response later, however I ran > > into one unexpected thing immediately on bootup with the new kernel: > > Just FYI- The labeled-ip

RE: [PATCH 0/3] labeled-ipsec: Repost patchset with updates [Originally: mlsxfrm: Various Fixes]

2006-11-13 Thread Venkat Yekkirala
> I pulled in the lspp respin kernels and am checking the labeling > behavior now so I should have a full response later, however > I ran into > one unexpected thing immediately on bootup with the new kernel: Just FYI- The labeled-ipsec patch doesn't affect or influence the packet class handlin

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-13 Thread jamal
On Mon, 2006-13-11 at 09:08 -0500, Paul Moore wrote: > I want to give Jamal a little bit longer > to reply. Sorry, family emergency - still ongoing today, so havent looked at anything (including presentation that was supposed to be done) ;-< Give me a day or two (I know i at least have to do th

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-13 Thread Paul Moore
On Monday 13 November 2006 2:23 am, Jarek Poplawski wrote: > Sorry! Typo in @@ -436,20 part. Forget the earlier message. No problem, my first draft was full of typos too ;) > So there is more... > > Jarek P. > > PS: It is added to my first patch because I don't know > what is the current version.

Re: [PATCH] dccp: remove module exit functions

2006-11-13 Thread Gerrit Renker
Quoting Arnaldo Carvalho de Melo: | On 11/10/06, James Morris <[EMAIL PROTECTED]> wrote: | > I wonder if this facility can be integrated more generally into the kernel | > as a kernel hacking option, as this is not the only protocol which people | > are developing. | > | | See: | http://

[PATCH] cleanup of the sctp state table code

2006-11-13 Thread Peter Zijlstra
I noticed an insane high density of repeated characters fixable by a simple regular expression: % s/{.fn = \([^,]*\),[[:space:]]\+\(\\\n[[:space:]]\+\)\?.name = "\1"}/TYPE_SCTP_FUNC(\1)/g (NOTE: the .name for .fn = sctp_sf_do_9_2_start_shutdown didn't match) Signed-off-by: Peter Zijlstra <[EM

Re: [take24 0/6] kevent: Generic event handling mechanism.

2006-11-13 Thread Evgeniy Polyakov
On Mon, Nov 13, 2006 at 01:54:58PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > > === > > > > - there is really no reason to invent yet another timer implementation. > > We have the POSIX timers which are feature rich and nicely > > implemented. All that is needed is

Re: [take24 0/6] kevent: Generic event handling mechanism.

2006-11-13 Thread Evgeniy Polyakov
On Sat, Nov 11, 2006 at 02:28:53PM -0800, Ulrich Drepper ([EMAIL PROTECTED]) wrote: > Evgeniy Polyakov wrote: > >Generic event handling mechanism. > >[...] > > Sorry for the delay again. Kernel work is simply not my highest priority. > > I've collected my comments on some parts of the patch. I

Re: bcm43xx-d80211 broadcast reception with WPA

2006-11-13 Thread Jiri Benc
On Sun, 12 Nov 2006 09:34:27 +0100, Michael Buesch wrote: > TKIP hw encryption needs some modifications to the d80211 stack. > There are patches available, but I think they are not merged, yet. > John, do you know the state on these patches? Waiting for Hong Liu to respond to Johannes' comments.

Re: [patch] fix up generic csum_ipv6_magic function prototype

2006-11-13 Thread Andi Kleen
Al Viro <[EMAIL PROTECTED]> writes: > > Incidentally, WTF is > define SK_CS_CALCULATE_CHECKSUM > #ifndef CONFIG_X86_64 > #define SkCsCalculateChecksum(p,l) ((~ip_compute_csum(p, l)) & 0x) > #else > #define SkCsCalculateChecksum(p,l) ((~ip_fast_csum(p, l)) & 0x) > #endif > in .

Re: [PATCH 1/3] [NET]: Supporting UDP-Lite (RFC 3828) in Linux

2006-11-13 Thread David Miller
From: Gerrit Renker <[EMAIL PROTECTED]> Date: Mon, 13 Nov 2006 08:32:44 + > If you give me time until tomorrow morning, I will re-submit the > split version - I would like to take some time to go over it. I will > use the filename as suggested for the header file, unless there is > another sug

Re: [patch] fix up generic csum_ipv6_magic function prototype

2006-11-13 Thread Al Viro
On Mon, Nov 13, 2006 at 09:12:22AM +, Russell King wrote: > On Mon, Nov 13, 2006 at 08:52:23AM +, Al Viro wrote: > > After doing the above we have the following: > > > > Platform-dependent: > > __wsum csum_tcpudp_nofold(__be32, __be32, T1, T2, __wsum); > > On arm/arm26: T1 = unsigned short

Re: [patch] fix up generic csum_ipv6_magic function prototype

2006-11-13 Thread Russell King
On Mon, Nov 13, 2006 at 08:52:23AM +, Al Viro wrote: > After doing the above we have the following: > > Platform-dependent: > __wsum csum_tcpudp_nofold(__be32, __be32, T1, T2, __wsum); > On arm/arm26: T1 = unsigned short, T2 = unsigned int. > __sum16 csum_tcpudp_magic(__be32, __be32, unsigned

Re: Questions regarding network drivers

2006-11-13 Thread Evgeniy Polyakov
On Sat, Nov 11, 2006 at 03:21:17PM -0800, Jonathan Day ([EMAIL PROTECTED]) wrote: > > --- Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > You can use netchannels, which were designed for > > exactly that kind of > > load. > > Actually, netchannels are a mechanism I've been > looking at intensely

Re: [patch] fix up generic csum_ipv6_magic function prototype

2006-11-13 Thread Al Viro
On Wed, Nov 08, 2006 at 11:55:48PM -0800, David Miller wrote: > From: Al Viro <[EMAIL PROTECTED]> > Date: Thu, 9 Nov 2006 07:22:16 + > > > I haven't touch that argument yet; if there's an agreement as to what should > > we switch to, I'll do that. So... does everyone agree that u32 is the way

Re: [PATCH 1/3] [NET]: Supporting UDP-Lite (RFC 3828) in Linux

2006-11-13 Thread Gerrit Renker
| > It is not a huge problem to change this, but it will also mean a non-trivial redesign. | > With regards to Stephen's email, can you/Stephen please indicate whether | > | >(a) configurable or not (CONFIG_IP_UDPLITE)? | >(b) re-design as separate object file or not? | >(c) ...

Re: bcm43xx-d80211 broadcast reception with WPA

2006-11-13 Thread Ismail Donmez
13 Kas 2006 Pts 00:54 tarihinde şunları yazmıştınız: > On Mon, 2006-11-13 at 00:41 +0200, Ismail Donmez wrote: > > > Thanks for information, this firmware would also solve the recent > > > roothole. > > > > s/roothole/security vulnerability would be better =) > > Ummm, the problem was in the driver