Hi,
s2io_card_down() will do few BAR0 read/write. As per
pci-error-recovery.txt Documentation we are not supposed to do any new
IO in error_detected().
Can you try using
atomic_set(&sp->card_state, CARD_DOWN);
instead of s2io_card_down().
Also we have to add following if statement in begin
Randy Dunlap wrote:
From: Randy Dunlap <[EMAIL PROTECTED]>
Correct message typo/spello.
Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
---
net/bridge/br_sysfs_br.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2619-rc3-pv.orig/net/bridge/br_sysfs_br.c
+++ linux-2619-rc3
Jeff Garzik wrote:
On Tue, Oct 24, 2006 at 09:52:15PM -0700, Randy.Dunlap wrote:
Thanks. It's not the only one like that. Also these 3 uses are incorrect
AFAICT:
./drivers/firmware/dell_rbu.c:721: rc =
sysfs_create_bin_file(&rbu_device->dev.kobj, &rbu_data_attr);
this is ok
ack, thanks
On Tue, 2006-10-24 at 15:56 -0700, Simon Barber wrote:
> Hi Luis,
>
> The CVS version of wpa_supplicant implements a user space Client MLME.
>
> Are there any FullMAC clients that do not also do regulatory in the
> hardware? (Intel 2100/2200?)
Atmel (atmel.c) has in-driver regulatory domain logi
On Tue, Oct 24, 2006 at 09:52:15PM -0700, Randy.Dunlap wrote:
> Thanks. It's not the only one like that. Also these 3 uses are incorrect
> AFAICT:
>
> ./drivers/firmware/dell_rbu.c:721:rc =
> sysfs_create_bin_file(&rbu_device->dev.kobj, &rbu_data_attr);
this is ok
> ./drivers/firmware/d
Jeff Garzik wrote:
On Tue, Oct 24, 2006 at 09:35:49PM -0700, Randy Dunlap wrote:
Please grep for sysfs_create_bin_file, you will find plenty of examples.
Hm, I thought that sysfs binary files were supposed to be
for "transparent" blobs of data, not for structured data.
E.g., a "firmware" blob w
On Tue, Oct 24, 2006 at 09:35:49PM -0700, Randy Dunlap wrote:
> >
> > Please grep for sysfs_create_bin_file, you will find plenty of examples.
>
> Hm, I thought that sysfs binary files were supposed to be
> for "transparent" blobs of data, not for structured data.
> E.g., a "firmware" blob would
From: "Michael Chan" <[EMAIL PROTECTED]>
Date: Tue, 24 Oct 2006 21:31:56 -0700
> Can you cat /proc/interrupts a few times to see if the interrupt
> counts on eth1 and eth2 are increasing?
>
> You can also run ethtool -t [eth1 | eth2] to run a basic selftest
> on the 2 devices. Be sure to ifconfi
On Tue, 24 Oct 2006 22:47:18 -0400 Jeff Garzik wrote:
> On Tue, Oct 24, 2006 at 07:25:48PM -0700, Ben Greear wrote:
> > From reading the Documentation/filesystems/sysfs.txt, it seems like
> > it is not recommended that one use sysfs for anything other than
> > very simple (and single) attributes.
Richard Bollinger wrote:
> GigaByte GA-7VCSV-RH motherboard w/two dual core Xeon's, 4gb RAM,
> Intel 5000v Chipset, dual Broadcom 5789 Gigabit Ethernet Controllers,
> connected to Dell GigE switch.
>
> Both interfaces work fine with vendor's drivers on Windows 2003, but
> using Linux 2.6.18.1 tg3
From: Randy Dunlap <[EMAIL PROTECTED]>
Correct message typo/spello.
Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
---
net/bridge/br_sysfs_br.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2619-rc3-pv.orig/net/bridge/br_sysfs_br.c
+++ linux-2619-rc3-pv/net/bridge/br_sysf
Description: Check the return value of kmalloc() in function
mgsl_alloc_intermediate_txbuffer_memory(), in file drivers/char/synclink.c.
Signed-off-by: Amit Choudhary <[EMAIL PROTECTED]>
diff --git a/drivers/char/synclink.c b/drivers/char/synclink.c
index 06784ad..24f99bc 100644
--- a/drivers/ch
On Tue, Oct 24, 2006 at 07:25:48PM -0700, Ben Greear wrote:
> From reading the Documentation/filesystems/sysfs.txt, it seems like
> it is not recommended that one use sysfs for anything other than
> very simple (and single) attributes.
>
> If you know of a piece of code that actually passes back a
hostap_plx: fix two related off-by-one errors in CIS parser
From: Pavel Roskin <[EMAIL PROTECTED]>
The length of the manfid CIS should be at least 4, and it's normally 4.
It's incorrect to require it to be at least 5. This breaks support for
most (if not all) cards.
The right place to ensure th
On Tue, Oct 24, 2006 at 10:12:24PM -0400, Pavel Roskin wrote:
> Coverity has no means to interpret CIS. However, it may understand
> kmalloc, which allocates CIS_MAX_LEN for the CIS copy.
>
> The value of cis[pos + 1] has no bearing on the validity of the access
> to cis[pos + 5] from the point
Jeff Garzik wrote:
On Mon, Oct 23, 2006 at 09:54:48PM -0700, Randy Dunlap wrote:
Similarly, sysfs is desirable in some circumstances, but
not for blocks of binary data.
sysfs specifically has APIs for binary data...
From reading the Documentation/filesystems/sysfs.txt, it seems lik
Hello, Jouni!
On Fri, 2006-10-20 at 18:19 -0700, Jouni Malinen wrote:
> On Fri, Oct 20, 2006 at 06:20:15PM -0400, Pavel Roskin wrote:
>
> > The record length for numerical manufacturer ID should be at least 4
> > bytes (two 16-bit words). The code required 5 bytes, which would break
> > for mos
On Mon, 23 Oct 2006 18:47:25 -0400, Luis R. Rodriguez wrote:
> ieee80211_regdomains
>
> Breaks down regulatory domains into data structures which allow
> drivers to share channel and power contraints based on stack
> regulatory domain. This driver adds in-kernel support for common
> regulatory do
On Mon, 23 Oct 2006 18:45:23 -0400, Luis R. Rodriguez wrote:
> iso3166-1
>
> ISO 3166-1, as part of the ISO 3166 standard, provides codes for the names
> of countries and dependent areas. It was first published in 1974 by
> the International Organization for Standardization (ISO) and defines thre
On Tue, Oct 24, 2006 at 08:48:09PM -0400, Pavel Roskin wrote:
> I don't have Coverity to check, and I think the results of Coverity were
> misinterpreted. It doesn't know anything about CIS structure. Anyway,
> let me just check Jouni's suggestion on a real PLX card.
It doesn't need to know any
On Tue, 2006-10-24 at 20:37 -0400, John W. Linville wrote:
> Will you be refactoring this patch? Or do you disagree with Jouni's
> assessment?
OK, give me an hour to produce a better patch. My patch has an
advantage of being simple and of fixing exactly one thing, but if Jouni
feels more comfort
Michael,
It looks like you have a patch that I don't have, one that moves the
netif_tx_disable and spin_lock_irqsave outside of the "if (badness >
BADNESS_LIMIT)" conditional.
Could you pass that one along as well, or correct this patch to match
what is in Linus' tree?
Thanks,
John
On Tue, Oct
On Fri, Oct 20, 2006 at 06:19:43PM -0700, Jouni Malinen wrote:
> On Fri, Oct 20, 2006 at 06:20:15PM -0400, Pavel Roskin wrote:
>
> > The record length for numerical manufacturer ID should be at least 4
> > bytes (two 16-bit words). The code required 5 bytes, which would break
> > for most (if not
On Tue, 2006-10-24 at 18:19 +0200, Patrick McHardy wrote:
> No, my patch works for qdiscs with and without RTABs, this
> is where they overlap.
Could you explain how this works? I didn't see how
qdiscs that used RTAB to measure rates of transmission
could use your STAB to do the same thing. At
From: "Randy.Dunlap" <[EMAIL PROTECTED]>
Date: Mon, 23 Oct 2006 09:31:50 -0700
> FYI: read_bia() also needs to be changed from __init to __devinit
> since it's called from hrz_init().
Thanks Randy, I've fixed this up in my tree too.
-
To unsubscribe from this list: send the line "unsubscribe net
Hi Luis,
The CVS version of wpa_supplicant implements a user space Client MLME.
Are there any FullMAC clients that do not also do regulatory in the
hardware? (Intel 2100/2200?)
Simon
-Original Message-
From: Luis R. Rodriguez [mailto:[EMAIL PROTECTED]
Sent: Tuesday, October 24, 2006
On Tuesday 24 October 2006 18:03, Luis R. Rodriguez wrote:
> 1. Anyone working on completing FullMAC support on d80211?
That doesn't really make sense. Fullmac devices should just use WE or cfg80211
because they, for the most part, do what d80211 does in firmware. There are
also strange hybrid de
resulted in this:
[10261.556773] BUG: sleeping function called from invalid context at
kernel/mutex.c:86
[10261.556777] in_atomic():1, irqs_disabled():0
[10261.556780] Call Trace:
[10261.556783] [C13CDC80] [C0008ED4] show_stack+0x3c/0x194 (unreliable)
[10261.556799] [C13CDCB0] [C0025AE4] __might_
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed, 25 Oct 2006 00:00:58 +0200
> [XFRM]: Fix xfrm_state accounting
>
> xfrm_state_num needs to be increased for XFRM_STATE_ACQ states created
> by xfrm_state_find() to prevent the counter from going negative when
> the state is destroyed.
>
> Sign
Your patch doesn't apply, your email client turned the tab
characters in the patch into spaces.
Please fix and resubmit, thank you.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majo
From: Ben Greear <[EMAIL PROTECTED]>
Date: Tue, 24 Oct 2006 09:34:38 -0700
> It could be a compile-time option, and even if compiled in, it should
> only be an if branch on
> a pointer. Is there any noticeable performance hit for an if check if
> you wrap it with unlikely?
It's "just an if te
Removed debug print statement
Signed-off-by: Fabric7 Driver-Support <[EMAIL PROTECTED]>
---
vioc.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/vioc.c b/vioc.c
index 51004c6..c771737 100644
--- a/vioc.c
+++ b/vioc.c
@@ -17,8 +17,6 @@ int vioc_dump_regs(struct ethtool_
On 10/24/06, Simon Barber <[EMAIL PROTECTED]> wrote:
The Client MLME code in the kernel was only ever written to be used for
quick testing. It does not have good roaming performance, and was never
intended to be a complete client. The right place for the Client MLME is
in userspace, where it can
[XFRM]: Fix xfrm_state accounting
xfrm_state_num needs to be increased for XFRM_STATE_ACQ states created
by xfrm_state_find() to prevent the counter from going negative when
the state is destroyed.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit d514f03d17b5f7615a549fbe2eb7b57a15af
Koushik, Raju,
Please review, comment, and if you find this acceptable,
please forward upstream.
--linas
This patch adds PCI error recovery support to the
s2io 10-Gigabit ethernet device driver.
Tested, seems to work well.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
Cc: Raghavendra Kous
Auke Kok wrote:
Jeff Garzik wrote:
Kok, Auke wrote:
Hi,
The following fixes targeted to netdev-2.6#upstream-fixes are available
through git:
git pull git://lost.foo-projects.org/~ahkok/git/netdev-2.6
upstream-fixes
hrm. since another e100 fixes got applied, can you either (a) update
the
On Tue, 24 Oct 2006 14:30:41 -0700
Sriram Chidambaram <[EMAIL PROTECTED]> wrote:
> Ethtool patch for Fabric7 VIOC Device Driver.
>
> Signed-off-by: Fabric7 Driver-Support <[EMAIL PROTECTED]>
> ---
> Makefile.am|2 +-
> ethtool-util.h |2 ++
> ethtool.c |1 +
> vioc.c
GigaByte GA-7VCSV-RH motherboard w/two dual core Xeon's, 4gb RAM,
Intel 5000v Chipset, dual Broadcom 5789 Gigabit Ethernet Controllers,
connected to Dell GigE switch.
Both interfaces work fine with vendor's drivers on Windows 2003, but
using Linux 2.6.18.1 tg3 or vendor's Linux driver, the first
Ethtool patch for Fabric7 VIOC Device Driver.
Signed-off-by: Fabric7 Driver-Support <[EMAIL PROTECTED]>
---
Makefile.am|2 +-
ethtool-util.h |2 ++
ethtool.c |1 +
vioc.c | 35 +++
4 files changed, 39 insertions(+), 1 deletions(-)
di
The Client MLME code in the kernel was only ever written to be used for
quick testing. It does not have good roaming performance, and was never
intended to be a complete client. The right place for the Client MLME is
in userspace, where it can be closely coupled with the supplicant, and
better scan
On Tue, 24 Oct 2006, Patrick McHardy wrote:
Russell Stuart wrote:
On Mon, 2006-10-23 at 14:39 +0200, Patrick McHardy wrote:
The implementation may be different, but the intention and the
result is the same. I probably would mind less if it wouldn't
affect userspace compatibility, but we nee
On 10/24/06, David Kimdon <[EMAIL PROTECTED]> wrote:
Hi,
> The following patches extend 802.11 regulatory domain support of the
> d80211 wireless stack through two modules:
>
> 1. ieee80211_regdomains
> 2. iso3166-1
I am glad to see this work, this is something that we need a solution
for. I d
On 10/24/06, John W. Linville <[EMAIL PROTECTED]> wrote:
On Tue, Oct 24, 2006 at 01:33:32AM -0400, Luis R. Rodriguez wrote:
> On 10/23/06, Johannes Berg <[EMAIL PROTECTED]> wrote:
> >On Mon, 2006-10-23 at 18:41 -0400, Luis R. Rodriguez wrote:
> >
> >> The current setup on d80211.h makes regulator
On 10/24/06, Johannes Berg <[EMAIL PROTECTED]> wrote:
Alright, here's more now that I can think clearly again :)
> ISO 3166-1, as part of the ISO 3166 standard, provides codes for the names
> of countries and dependent areas. It was first published in 1974 by
> the International Organization for
On 10/24/06, Johannes Berg <[EMAIL PROTECTED]> wrote:
> and adds support for PtMP (Point
> to MultiPoint) and PtP (Point to Point) type restrictions.
What are those restrictions?
I'm glad you asked. Here's a quote from:
http://university.cyberarmy.net/kb/tiki-index.php?page=The+Power+of+802.
David Miller wrote:
From: Robert Olsson <[EMAIL PROTECTED]>
Date: Tue, 24 Oct 2006 11:16:05 +0200
My first instinct is to avoid the hook in general code and pktgen let spin
to only affect testing.
Mine too.
Why make everyone in the world make that check in netif_wake_queue(),
or wh
Robert Olsson wrote:
Ben Greear writes:
> I'm planning to re-merge my long-lost pktgen branch with the kernel
> tree's pktgen.
>
> I believe the main difference is that my out-of-tree pktgen does not do the
> busy-spin, but waits on a queue for the net-device to wake it's tx-queue
> when
Russell Stuart wrote:
> On Mon, 2006-10-23 at 14:39 +0200, Patrick McHardy wrote:
>
>>The implementation may be different, but the intention and the
>>result is the same. I probably would mind less if it wouldn't
>>affect userspace compatibility, but we need to carry this stuff
>>for ever even if
Kenzo Iwami wrote:
Hi,
Thank you for your comment.
This panic report falls in the category "how hard can I break my system as root".
Explicitly abusing the system performing restricted calls depletes resources and
harasses the sw lock (in this case). The reason that the driver attempts to wai
On Tue, 2006-10-24 at 11:59 -0400, Luis R. Rodriguez wrote:
> also if we index based on alpha3 we get O(1)
> access to the elements. Will make these changes.
I wouldn't do that, it's bound to make the array size explode because
there'll be one country starting with A and one starting with Z.
Prob
On 10/24/06, Johannes Berg <[EMAIL PROTECTED]> wrote:
> +static int load_iso3166_1(void) {
> + int r = 0;
> + r |= iso3166_1_add(4, "AF", "AFG",
> + "Afghanistan");
[...]
Why don't you make the table a static array, then you can use ARRAY_SIZE
and get rid of the whole
Holden Karau wrote:
I've changed the patch based on your suggestions :-)
Thanks, looks fine. Let's just wait for an OK from Ulrich, then you can
send it to John, without broken tabs/lines, with signoff and description.
Daniel
-
To unsubscribe from this list: send the line "unsubscribe netd
On Mon, 23 Oct 2006 23:03:50 -0700 (PDT)
David Miller <[EMAIL PROTECTED]> wrote:
> From: Stephen Hemminger <[EMAIL PROTECTED]>
> Date: Mon, 23 Oct 2006 12:02:53 -0700
>
> > + spin_lock_irqsave(&netpoll_txq.lock, flags);
> > + for (skb = (struct sk_buff *)netpoll_txq.next;
> > +skb !=
Oh, damn crap. Please remove the words "fwd" and "hopefully"
from the subject.
Sorry for the inconvenience.
--
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majord
This fixes a netdev watchdog timeout problem.
The problem is caused by a needed netif_tx_disable
in the hardware calibration code and can be shown by the
following timegraph.
|---5secs - ~10 jiffies time---|---|OOPS
^ ^
last real TX periodic work stop
When using H-TCP with a single flow on a 500Mbit connection (or less
actually), alpha can exceed 65000, so alpha needs to be a u32.
Signed-off-by: Gavin McCullagh <[EMAIL PROTECTED]>
Signed-off-by: Doug Leith <[EMAIL PROTECTED]>
diff --git a/net/ipv4/tcp_htcp.c b/net/ipv4/tcp_htcp.c
index 6edfe
I've changed the patch based on your suggestions :-)
Hopefully my mailer doesn't eat the tabs this time, if it does I've
put the patch up at
http://www.holdenkarau.com/~holden/projects/zd1211rw/zd1211rw-use-geo-for-channels-r2.patch
On 10/23/06, Daniel Drake <[EMAIL PROTECTED]> wrote:
Holden Kar
Hi,
> The following patches extend 802.11 regulatory domain support of the
> d80211 wireless stack through two modules:
>
> 1. ieee80211_regdomains
> 2. iso3166-1
I am glad to see this work, this is something that we need a solution
for. I do wonder if we can push most of this out of the kernel
On Tue, Oct 24, 2006 at 01:33:32AM -0400, Luis R. Rodriguez wrote:
> On 10/23/06, Johannes Berg <[EMAIL PROTECTED]> wrote:
> >On Mon, 2006-10-23 at 18:41 -0400, Luis R. Rodriguez wrote:
> >
> >> The current setup on d80211.h makes regulatory domains device
> >> specific. I believe this should be ch
The PDQ DMA engine requires a different byte-swapping mode for big-endian
hosts; also the MAC address which is read from a register through PIO has
to be byte-swapped. These changes have been verified with DEFPA-DC (PCI)
boards and a Broadcom BCM91250A (MIPS CPU based) host.
Signed-off-by: Macie
From: Robert Olsson <[EMAIL PROTECTED]>
Date: Tue, 24 Oct 2006 11:16:05 +0200
> My first instinct is to avoid the hook in general code and pktgen let spin
> to only affect testing.
Mine too.
Why make everyone in the world make that check in netif_wake_queue(),
or wherever, when %99.99
Hi Stephen,
Stephen Hemminger schrieb:
> Add ability to take old raw dumps from a file and decode them.
> It is kind of limited because you still need to have same device
> as the raw file, but useful for maintainers to decode raw dumps.
What about putting the (Permanent) MAC into the first 4-6 o
Ben Greear writes:
> I'm planning to re-merge my long-lost pktgen branch with the kernel
> tree's pktgen.
>
> I believe the main difference is that my out-of-tree pktgen does not do the
> busy-spin, but waits on a queue for the net-device to wake it's tx-queue
> when over-driving a NIC.
>
On Tue, 2006-10-24 at 16:38 +0800, Hong Liu wrote:
> The first time when we set the TKIP key, we can set the phase1 key if
> the driver requires.
Right.
> The problem is when IV16 wraps, who will generate the new phase1 key?
Ok, I was confused for a moment, but yes, when the 16-bit part of the
On Tue, 2006-10-24 at 11:10 +0200, Johannes Berg wrote:
> How about having the stack maintain
> the IV *only*,
The idea here is that even if not required by hw that does both, it's
cheap to maintain this counter. Though for all I care the driver could
do it too.
johannes
-
To unsubscribe from t
Hi,
Thank you for your comment.
> This panic report falls in the category "how hard can I break my system as
> root".
> Explicitly abusing the system performing restricted calls depletes resources
> and
> harasses the sw lock (in this case). The reason that the driver attempts to
> wait that
On Tue, 2006-10-24 at 16:35, Johannes Berg wrote:
> On Tue, 2006-10-24 at 16:20 +0800, Hong Liu wrote:
>
> > It's really strange bcm43xx only does phase2 mixing in hw. With all the
> > code that does phase2 mixing, doing phase1 mixing is very cheap.
>
> Yeah, well, they have the tkip sbox in hw.
On Tue, 2006-10-24 at 16:20 +0800, Hong Liu wrote:
> It's really strange bcm43xx only does phase2 mixing in hw. With all the
> code that does phase2 mixing, doing phase1 mixing is very cheap.
Yeah, well, they have the tkip sbox in hw.
> With Jiri's ieee80211_tx_ctrl_common patch, I think we can
> and adds support for PtMP (Point
> to MultiPoint) and PtP (Point to Point) type restrictions.
What are those restrictions?
Similar comments here, why do you build the list at module init time
instead of having it static?
Also, do we really need all this data in the kernel?
johannes
-
To unsu
> +static int load_iso3166_1(void) {
> + int r = 0;
> + r |= iso3166_1_add(4, "AF", "AFG",
> + "Afghanistan");
[...]
Why don't you make the table a static array, then you can use ARRAY_SIZE
and get rid of the whole list_head, not have it eat up code size and
mark it as
From: "ArcosCom Linux User" <[EMAIL PROTECTED]>
Date: Tue, 24 Oct 2006 09:39:08 +0200 (CEST)
> Is this patch submitted into kernel tree? What version of kernel will have
> this patch applied (thinking on 2.6.x and 2.4.x branchs)?
2.6.19 and later will have the patch.
-
To unsubscribe from this li
On Mon, 2006-10-23 at 20:56, Jiri Benc wrote:
> On Mon, 23 Oct 2006 14:48:00 +0200, Johannes Berg wrote:
> > On Mon, 2006-10-23 at 14:40 +0200, Jiri Benc wrote:
> > > I don't like extending ieee80211_tx_control by 16 more bytes. The
> > > driver is required to store a copy of each ieee80211_tx_cont
Alright, here's more now that I can think clearly again :)
> ISO 3166-1, as part of the ISO 3166 standard, provides codes for the names
> of countries and dependent areas. It was first published in 1974 by
> the International Organization for Standardization (ISO) and defines three
> different cod
Is this patch submitted into kernel tree? What version of kernel will have
this patch applied (thinking on 2.6.x and 2.4.x branchs)?
Thanks
El Jue, 12 de Octubre de 2006, 20:24, Stephen Hemminger escribió:
> Flush the forwarding table when carrier is lost. This helps for
> availability because we
74 matches
Mail list logo
