David Miller wrote:
From: Robert Olsson <[EMAIL PROTECTED]>
Date: Tue, 24 Oct 2006 11:16:05 +0200

My first instinct is to avoid the hook in general code and pktgen let spin to only affect testing.

Mine too.

Why make everyone in the world make that check in netif_wake_queue(),
or wherever, when %99.99999999999 of the time it'll never be used?
It could be a compile-time option, and even if compiled in, it should only be an if branch on a pointer. Is there any noticeable performance hit for an if check if you wrap it with unlikely?

Thanks,
Ben

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
Ben Greear <[EMAIL PROTECTED]> Candela Technologies Inc http://www.candelatech.com


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to