Re: [take2 1/4] kevent: core files.

On Tue, Aug 01, 2006 at 05:01:38PM -0700, David Miller ([EMAIL PROTECTED]) wrote: > From: Zach Brown <[EMAIL PROTECTED]> > Date: Tue, 01 Aug 2006 16:56:59 -0700 > > > Even if we only have one syscall with a cmd multiplexer (which I'm not > > thrilled with), we should at least make these arguments

Re: [take2 1/4] kevent: core files.

On Tue, Aug 01, 2006 at 04:56:59PM -0700, Zach Brown ([EMAIL PROTECTED]) wrote: > > OK, here's some of my reactions to the core part. Thanks. > > +#define KEVENT_SOCKET 0 > > +#define KEVENT_INODE 1 > > +#define KEVENT_TIMER 2 > > +#define KEVENT_POLL

[Patch] kernel memory leak fix for af_unix datagram getpeersec patch

Hi, all, Enclosed please find the updated patch incorporating comments from Stephen and Dave. Again thanks for your help! Catherine -- From: [EMAIL PROTECTED] This patch implements a cleaner fix for the memory leak problem of the original unix datagram getpeersec patch. Instead of creating

Re: [RFC] gre: transparent ethernet bridging

> Stephen Hemminger wrote: >> I am not against making the bridge code smarter to handle other >> encapsulation. Here's an updated patch that fixes all issues I am aware of. It generates a random mac address for gre ports, and also stores a copy of the mac address for ethernet ports, rather than c

Re: (usagi-core 30280) Re: [PATCH 10/23] [PATCH] [XFRM]: Trace which secpath state is reject factor.

David Miller wrote: > From: Masahide NAKAMURA <[EMAIL PROTECTED]> > Date: Sat, 29 Jul 2006 18:30:29 +0900 > >> @@ -272,6 +272,9 @@ #define XFRM_TYPE_NON_FRAGMENT 1 >> void(*destructor)(struct xfrm_state *); >> int (*input)(struct xfrm_state *, st

Re: [PATCH 1/23] [PATCH] [XFRM]: Add XFRM_MODE_xxx for future use.

Masahide NAKAMURA <[EMAIL PROTECTED]> wrote: > > diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h > index 6b42cc4..7dff1c8 100644 > --- a/include/linux/xfrm.h > +++ b/include/linux/xfrm.h > @@ -178,6 +178,13 @@ struct xfrm_user_sec_ctx { >__u16 ctx_len; > }; > >

Re: [RFC 1/3] secid reconciliation on inbound

On Tue, 1 Aug 2006, James Morris wrote: > On Tue, 1 Aug 2006, Venkat Yekkirala wrote: > > > +#define PACKET__COME_THRU 0x0008UL > > +#define PACKET__GO_THRU 0x0010UL > > These names seem awkward, and do we really need a separate perm for

Re: [PATCH 7/23] [PATCH] [XFRM] STATE: Add a hook to find where to be inserted header in outbound.

From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Wed, 02 Aug 2006 11:20:30 +0900 > David Miller wrote: > > I see a dangerous pattern of adding many, many, many methods > > to the xfrm_type structure which are only used by ipv6. > > But I cannot suggest another method. > > Sometimes this is a dif

Re: [2.6.18-rc2][e1000][swsusp] - Regression - Suspend to disk and resume breaks e1000 - RESOLVED Bug #6867

On Sunday 16 July 2006 12:33 pm, Auke Kok wrote: > [adding netdev to the cc] > > unfortunately I didn't. > > e1000 has a special e1000_pci_save_state/e1000_pci_restore_state set of > routines that save and restore the configuration space. the fact that it > works for suspend to memory to me suggest

Re: [RFC] Mobile IPv6 introduction

Hi Hugo, Please fine my comment inline: Hugo Santos wrote: [snip] >- In general, lot's of places in the IPv6 stack don't take the source > address into consideration and generically only use destination as > key, i think this is a major setback that should be approached > indiv

Re: [PATCH] Fix more per-cpu typos

> --- a/arch/x86_64/kernel/smp.c > +++ b/arch/x86_64/kernel/smp.c > @@ -203,7 +203,7 @@ int __cpuinit init_smp_flush(void) > { > int i; > for_each_cpu_mask(i, cpu_possible_map) { > - spin_lock_init(&per_cpu(flush_state.tlbstate_lock, i)); > + spin_lock_init(&pe

Re: neigh_lookup lockdep bug.

On Tue, 2006-08-01 at 23:19 +1000, Herbert Xu wrote: > Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > > > we fixed lockdep to have this lock key to be per skb queue ... didn't > > you put that patch in rawhide Dave (J) ? > > I've only briefly looked at the lockdep_set_class code so I might be >

Re: [PATCH 7/23] [PATCH] [XFRM] STATE: Add a hook to find where to be inserted header in outbound.

David Miller wrote: > From: Masahide NAKAMURA <[EMAIL PROTECTED]> > Date: Sat, 29 Jul 2006 18:30:23 +0900 > >> @@ -270,6 +270,7 @@ struct xfrm_type >> void(*destructor)(struct xfrm_state *); >> int (*input)(struct xfrm_state *, struct sk_buff >> *

Re: neigh_lookup lockdep bug.

On Tue, 2006-08-01 at 23:19 +1000, Herbert Xu wrote: > > I've only briefly looked at the lockdep_set_class code so I might be > way off here. your reading of the code is right, and in fact this is what the code in -mm does, and is waiting for the networking guys or Andrew to send it to Linus (hin

Re: [PATCH 0/5] d80211: pull request

On Tue, Aug 01, 2006 at 09:16:54PM +0200, Jiri Benc wrote: > Please pull from > git://git.kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git up > to obtain following patches: > > Jiri Benc: > d80211: make sleeping in hw->config possible > d80211: return correct error codes for scan r

Re: [PATCH 6/23] [PATCH] [XFRM] STATE: Search by address using source address list.

David Miller wrote: > From: Masahide NAKAMURA <[EMAIL PROTECTED]> > Date: Sat, 29 Jul 2006 18:30:18 +0900 > >> +#ifdef CONFIG_XFRM_ADVANCED >> +struct xfrm_state *(*state_lookup_byaddr)(xfrm_address_t *daddr, >> xfrm_address_t *saddr, u8 proto); >> +#endif > > I think we should delete

Re: [PATCH 5/23] [PATCH] [XFRM] STATE: Add source address list.

From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Wed, 02 Aug 2006 10:42:51 +0900 > David Miller wrote: > > If you need to provide the source address, you need to pass it in via > > a new xfrm netlink attribute or use an existing data structure member > > which records the source address (if any s

Re: [RFC] Mobile IPv6 introduction

In article <[EMAIL PROTECTED]> (at Wed, 2 Aug 2006 01:58:49 +0100), Hugo Santos <[EMAIL PROTECTED]> says: >Still regarding Subtrees, is there any interest in revitalizing that > code? I have a couple patches that i could submit. I also have several patches which are being sent. --yoshfuji

Re: [PATCH 22/23] [PATCH] [XFRM] POLICY: Support netlink socket interface for sub policy.

David Miller wrote: > From: Masahide NAKAMURA <[EMAIL PROTECTED]> > Date: Sat, 29 Jul 2006 18:30:55 +0900 > >> diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h >> index 901bb65..68d3443 100644 >> --- a/include/linux/xfrm.h >> +++ b/include/linux/xfrm.h >> @@ -303,12 +303,14 @@ #define XFRM

Re: [PATCH 5/23] [PATCH] [XFRM] STATE: Add source address list.

David Miller wrote: > This is a userspace exported structure, therefore you cannot > make changes to it like this, it will break the userland API. OK. > If you need to provide the source address, you need to pass it in via > a new xfrm netlink attribute or use an existing data structure member >

Re: [PATCH 1/23] [PATCH] [XFRM]: Add XFRM_MODE_xxx for future use.

David Miller wrote: > From: Masahide NAKAMURA <[EMAIL PROTECTED]> > Date: Sat, 29 Jul 2006 18:29:45 +0900 > >> Transformation mode is used as either IPsec transport or tunnel. >> It is required to add two more items, route-optimization and inbound trigger >> by Mobile IPv6. >> Based on MIPL2 kerne

Re: [RFC] Mobile IPv6 introduction

From: Hugo Santos <[EMAIL PROTECTED]> Date: Wed, 2 Aug 2006 01:58:49 +0100 >Still regarding Subtrees, is there any interest in revitalizing that > code? I have a couple patches that i could submit. I'm not sure. If we implement a routing cache front end for the ipv6 FIB, which is very likel

Re: [RFC] Mobile IPv6 introduction

David, On Tue, Aug 01, 2006 at 05:35:35PM -0700, David Miller wrote: > This is partly why the multiple routing table code is being > added as the initial infrastrucutre, so that source based > things are possible. There have been other approaches for partial source-based stuff. For instance,

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

On Mon, Jul 31, 2006 at 09:30:50PM +1000, herbert wrote: > > > diff --git a/net/ipv4/netfilter/ip_nat_core.c > > b/net/ipv4/netfilter/ip_nat_core.c > > index 1741d55..731efbb 100644 > > --- a/net/ipv4/netfilter/ip_nat_core.c > > +++ b/net/ipv4/netfilter/ip_nat_core.c > > @@ -443,7 +443,9 @@ int ip

Re: [PATCH] NET: fix kernel panic from no dev->hard_header_len space

From: Krzysztof Halasa <[EMAIL PROTECTED]> Date: Wed, 02 Aug 2006 02:42:05 +0200 > Alexey Kuznetsov <[EMAIL PROTECTED]> writes: > > > Actually, it is historical hole in design, inherited from ancient > > times. Calling conventions of dev->hard_header() just did not allow > > to reallocate. BTW in

Re: [PATCH] NET: fix kernel panic from no dev->hard_header_len space

Alexey Kuznetsov <[EMAIL PROTECTED]> writes: > Actually, it is historical hole in design, inherited from ancient > times. Calling conventions of dev->hard_header() just did not allow > to reallocate. BTW in 2.6 it can, if it uses pskb_expand_head(). Does that mean that hard_header() and then hard

Re: [PATCH] NET: fix kernel panic from no dev->hard_header_len space

From: Krzysztof Halasa <[EMAIL PROTECTED]> Date: Wed, 02 Aug 2006 02:24:43 +0200 > Do you mean IP calls hard_header() which, in turn, does skb_push()? > > How about Ethernet - is it safe? There is hard_header() which blindly > adds 14 bytes. I think Alexey is saying that setting ->hard_header()

Re: [RFC] Mobile IPv6 introduction

From: Hugo Santos <[EMAIL PROTECTED]> Date: Sat, 29 Jul 2006 15:12:44 +0100 >- In general, lot's of places in the IPv6 stack don't take the source > address into consideration and generically only use destination as > key, i think this is a major setback that should be approached >

Re: [PATCH 0/20][IPV6/XFRM] MIPv6 CN (part B)

From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Sat, 29 Jul 2006 18:37:04 +0900 > Here is Part B patches, following this mail. > > Part B is also available as mip6cn-20060716-review branch at: > > git://git.skbuff.net:9419/gitroot/nakam/linux-2.6-mip6cn > > This tree includes part A, then it

Re: [PATCH] NET: fix kernel panic from no dev->hard_header_len space

Hi, Alexey Kuznetsov <[EMAIL PROTECTED]> writes: > As I already said there is nothing wrong with the first chunk. > Except that it hides the real problem. The problem is already very well hidden :-) I have seen just two reports of this problem since 1994, and I believe both of them were related

Re: [PATCH 22/23] [PATCH] [XFRM] POLICY: Support netlink socket interface for sub policy.

From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Sat, 29 Jul 2006 18:30:55 +0900 > diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h > index 901bb65..68d3443 100644 > --- a/include/linux/xfrm.h > +++ b/include/linux/xfrm.h > @@ -303,12 +303,14 @@ #define XFRM_POLICY_BLOCK 1 > _

Re: [PATCH 15/23] [PATCH] [XFRM] STATE: Allow non IPsec protocol.

From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Sat, 29 Jul 2006 18:30:40 +0900 > static inline int xfrm_id_proto_match(u8 proto, u8 userproto) > { > +#ifdef CONFIG_XFRM_ADVANCED > + return (!userproto || proto == userproto || > + (userproto == IPSEC_PROTO_ANY && (proto == IPPR

Re: [PATCH 14/23] [PATCH] [XFRM]: Restrict authentication algorithm only when inbound transformation protocol is IPsec.

From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Sat, 29 Jul 2006 18:30:38 +0900 > - (tmpl->aalgos & (1 + ((tmpl->aalgos & (1 + !(xfrm_id_proto_match(tmpl->id.proto, IPSEC_PROTO_ANY))) && This is another instance of a xfr

Re: [PATCH 10/23] [PATCH] [XFRM]: Trace which secpath state is reject factor.

From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Sat, 29 Jul 2006 18:30:29 +0900 > @@ -272,6 +272,9 @@ #define XFRM_TYPE_NON_FRAGMENT1 > void(*destructor)(struct xfrm_state *); > int (*input)(struct xfrm_state *, struct sk_buff > *skb); >

Re: [PATCH 13/23] [PATCH] [XFRM]: Expand XFRM_MAX_DEPTH for routing header and destination options header.

From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Sat, 29 Jul 2006 18:30:36 +0900 > +#ifdef CONFIG_XFRM_ADVANCED > +#define XFRM_MAX_DEPTH 6 > +#else > #define XFRM_MAX_DEPTH 4 > +#endif Since I suggest to eliminate XFRM_ADVANCED, we should do "6" always here if that

Re: [PATCH 7/23] [PATCH] [XFRM] STATE: Add a hook to find where to be inserted header in outbound.

From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Sat, 29 Jul 2006 18:30:23 +0900 > @@ -270,6 +270,7 @@ struct xfrm_type > void(*destructor)(struct xfrm_state *); > int (*input)(struct xfrm_state *, struct sk_buff > *skb); > int

Re: [PATCH 5/23] [PATCH] [XFRM] STATE: Add source address list.

From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Sat, 29 Jul 2006 18:30:12 +0900 > @@ -263,6 +263,7 @@ struct xfrm_usersa_id { > __u32 spi; > __u16 family; > __u8proto; > + xfrm_address_t

Re: [PATCH 6/23] [PATCH] [XFRM] STATE: Search by address using source address list.

From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Sat, 29 Jul 2006 18:30:18 +0900 > +#ifdef CONFIG_XFRM_ADVANCED > + struct xfrm_state *(*state_lookup_byaddr)(xfrm_address_t *daddr, > xfrm_address_t *saddr, u8 proto); > +#endif I think we should delete XFRM_ADVANCED config option, it i

Re: [take2 1/4] kevent: core files.

From: Zach Brown <[EMAIL PROTECTED]> Date: Tue, 01 Aug 2006 16:56:59 -0700 > Even if we only have one syscall with a cmd multiplexer (which I'm not > thrilled with), we should at least make these arguments explicit in the > system call. It's weird to hide them in a struct. We could also think >

Re: [take2 1/4] kevent: core files.

OK, here's some of my reactions to the core part. > +#define KEVENT_SOCKET0 > +#define KEVENT_INODE 1 > +#define KEVENT_TIMER 2 > +#define KEVENT_POLL 3 > +#define KEVENT_NAIO 4 > +#define KEVENT_AIO 5 I guess we can't really avoid some

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

On Tue, 1 Aug 2006, [EMAIL PROTECTED] wrote: Hi Scott Sorry to be coming in late, but I'm curious about why this work is being submitted as a separate driver, rather than as patches against the driver from Dustin McIntire that was added a few months ago. Is the intention to go forward wit

Re: [PATCH 2/23] [PATCH] [XFRM]: Introduce a helper to compare id protocol.

From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Sat, 29 Jul 2006 18:29:56 +0900 > Put the helper to header for future use. This change is fine. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.k

Re: [PATCH 1/23] [PATCH] [XFRM]: Add XFRM_MODE_xxx for future use.

From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Sat, 29 Jul 2006 18:29:45 +0900 > Transformation mode is used as either IPsec transport or tunnel. > It is required to add two more items, route-optimization and inbound trigger > by Mobile IPv6. > Based on MIPL2 kernel patch. This change looks fi

Re: [PATCH] sunlance: fix compilation on sparc-UP

FYI, drivers/scsi/esp.c was broken by same changes. drivers/scsi/esp.c: In function `esp_sun4_probe': drivers/scsi/esp.c:1149: error: `esp_dev' undeclared (first use in this function) drivers/scsi/esp.c:1149: error: (Each undeclared identifier is reported only once drivers/scsi/esp.c:1149: error

[PATCH] Fix more per-cpu typos

Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- arch/x86_64/kernel/smp.c |2 +- include/net/netdma.h |2 +- net/core/dev.c |4 ++-- net/ipv4/tcp.c |2 +- 4 files changed, 5 insertions(+), 5 deletions(-) --- a/arch/x86_64/kernel/smp.c +++ b/arch/x86_

Re: [RFC 1/3] secid reconciliation on inbound

On Tue, 1 Aug 2006, Venkat Yekkirala wrote: > +#define PACKET__COME_THRU 0x0008UL > +#define PACKET__GO_THRU 0x0010UL These names seem awkward, and do we really need a separate perm for each direction? - James -- James Morris <[EMAIL

Re: [RFC 2/3] secid reconciliation on inbound: add LSM hooks

On Tue, 1 Aug 2006, Venkat Yekkirala wrote: > - if (err) > - goto out; > + /* if (err) */ > + /* goto out; */ > > - err = selinux_xfrm_sock_rcv_skb(sksec->sid, skb, &ad); > -out: + /* err = selinux_xfrm_sock_rcv_skb(sksec->sid, skb, &ad); */ > +out:

[RFC 1/3] secid reconciliation on inbound

Currently a packet accumulates multiple security identifiers, each of a different class, as it enters the system. This patch set reconciles these identifiers into a single identifier while also allowing LSM (SELinux is addressed in this patch set) to impose flow control checks based on the identif

[RFC 3/3] secid reconciliation on inbound: core networking changes

Invoke the skb_policy_check LSM hook from within networking code. This is being done at the same time and as a part of checking xfrm policy. This is hopefully adequate (not anticipating IP protos that don't use xfrm). Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> --- xfrm.h | 50 +---

[RFC 2/3] secid reconciliation on inbound: add LSM hooks

Add skb_policy_check hook to LSM to enable reconciliation of the various security identifiers as well as enforce flow control on inbound (INPUT/FORWARD) traffic. Also defines reconciliation for SELinux. Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> --- dummy.c|7 ++ hooks.c| 3

Re: [PATCH] ipv4: don't call upper-layer disconnect function if not connected

From: Brian Haley <[EMAIL PROTECTED]> Date: Tue, 01 Aug 2006 15:48:54 -0400 > Calling connect() with AF_UNSPEC will disconnect a socket, but we don't > need to do any work if the socket isn't currently connected. > > Signed-off-by: Brian Haley <[EMAIL PROTECTED]> The socket could have been bind

Re: [PATCH] IPv6: only set err in rawv6_bind() when necessary

From: Brian Haley <[EMAIL PROTECTED]> Date: Tue, 01 Aug 2006 13:06:03 -0400 > The variable 'err' is set in rawv6_bind() before the address check fails > instead of after, moved inside if() statement. > > Signed-off-by: Brian Haley <[EMAIL PROTECTED]> This is a common C idiom in the kernel:

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

On Tue, Aug 01, 2006 at 08:34:05AM -0700, Phil Oester wrote: > On Tue, Aug 01, 2006 at 12:00:59AM -0700, David Miller wrote: > > What we have now is infinitely better than the past, > > wherein all TSO packets were dropped due to corrupt > > checksums as soon at the NAT module was loade

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

On Mon, Jul 31, 2006 at 08:36:58PM +0200, Patrick McHardy wrote: > > diff --git a/net/netfilter/nf_queue.c b/net/netfilter/nf_queue.c > index 662a869..df1f4e5 100644 > --- a/net/netfilter/nf_queue.c > +++ b/net/netfilter/nf_queue.c I presume we need similar patches for the old ipv4/ipv6 versions a

Re: Regarding offloading IPv6 addrconf and ndisc

From: Hugo Santos <[EMAIL PROTECTED]> Date: Tue, 1 Aug 2006 13:00:03 +0100 > Resiliency to failure is not something that depends on the > kernel. If the code in question is in the kernel, and it crashes, > how will you recover? Developer momentum means that the kernel is likely to get fixed wh

Re: Regarding offloading IPv6 addrconf and ndisc

From: Hugo Santos <[EMAIL PROTECTED]> Date: Tue, 1 Aug 2006 12:50:02 +0100 >I might have some cycles during the month to code up something in > this direction, at least for an initial review, i'll try to do so. Great. I prefer to talk about code anyways :) >Also, the reliability of a s

[PATCH 4/6] zd1211rw: Remove bogus assert

From: Daniel Drake <[EMAIL PROTECTED]> This function is never called in interrupt context, and it doesn't matter if it is called in IRQ context or not. Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> Signed-off-by: Ulrich Kunitz <[EMAIL PROTECTED]> --- drivers/net/wireless/zd1211rw/zd_usb.c |

[PATCH 6/6] zd1211rw: Packet filter fix for managed (STA) mode

I had problems with my AVM Fritz!Box access point. It appeared that the AP deauthorized me and the softmac didn't reconnect me. This patch handles the problem. Signed-off-by: Ulrich Kunitz <[EMAIL PROTECTED]> --- drivers/net/wireless/zd1211rw/zd_chip.c |4 ++-- drivers/net/wireless/zd1211rw/z

[PATCH 1/6] zd1211rw: Fixes radiotap header

There has been a problem in the radiotap header. Monitor mode works now with tcpdump 3.94 + libpcap 0.9.4. ethereal 0.99.0 + libpcap 0.9.4 is broken, because it doesn't find the right offset for the IEEE 802.11 header. Signed-off-by: Ulrich Kunitz <[EMAIL PROTECTED]> --- drivers/net/wireless/zd12

[PATCH 3/6] zd1211rw: Fix software encryption/decryption

From: Daniel Drake <[EMAIL PROTECTED]> Apparently the ZD1211 doesn't mind, but the ZD1211B absolutely must be told that encryption is happening in software. Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> Signed-off-by: Ulrich Kunitz <[EMAIL PROTECTED]> --- drivers/net/wireless/zd1211rw/zd_mac.c

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

[...] > /* Writes a packet to the TX_DATA_FIFO */ > static inline void > smsc911x_tx_writefifo(struct smsc911x_data *pdata, unsigned int *buf, > unsigned int wordcount) > { > while (wordcount--) { > smsc911x_reg_write(*buf++, pdata, TX_DATA_FIFO); > }

[PATCH] zd1211rw: six urgent upstream fixes

Here are six fixes for the zd1211rw driver. They fix - radiotap issues for the monitor mode - WEP encryption - an endianess problem in the rx path - reassociation after disassociation be the AP If possible these patches should be included in 2.6.18 -- Uli - To unsubscribe from this list: sen

[PATCH 5/6] zd1211rw: Fixed endianess issue with length info tag detection

Discovered a problem while accessing www.python.org on my PPC32. The problem was pretty consistent for all sticks. The reason was that while testing for the length info tag, I ignored the endianess of the host system. Please recognize that converting the constant to little endian, we create faster

[PATCH 2/6] zd1211rw: Pass more management frame types up to host

From: Daniel Drake <[EMAIL PROTECTED]> We'll be needing these at some point... Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> Signed-off-by: Ulrich Kunitz <[EMAIL PROTECTED]> --- drivers/net/wireless/zd1211rw/zd_chip.h |4 +++- drivers/net/wireless/zd1211rw/zd_mac.c |6 -- 2 files

Re: [PATCH] NET: fix kernel panic from no dev->hard_header_len space

Hello! > Do the semantics (I'm not talking about bugs) allow skb passed > to dev->hard_header() (if defined) No. dev->hard_header() should get enough of space, which is dev->hard_header_len. Actually, it is historical hole in design, inherited from ancient times. Calling conventions of dev->hard

Re: [PATCH] NET: fix kernel panic from no dev->hard_header_len space

Hello! > > Alexey, any suggestions on how to handle this kind of thing? Device, which adds something at head must check for space. Anyone, who adds something at head, must check. Otherwise, it will remain buggy forever. > What's wrong with my patch? As I already said there is nothing wrong wit

[PATCH] ipv4: don't call upper-layer disconnect function if not connected

Calling connect() with AF_UNSPEC will disconnect a socket, but we don't need to do any work if the socket isn't currently connected. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index c84a320..b294b92 100644 --- a/net/ipv4/af_inet.c +++ b/ne

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

Ben Greear <[EMAIL PROTECTED]> writes: > Basically, my point is that > if VLANs are true devices, they will just work with all of the > user-space protocols > and they will easily handle abstractions such as bridges, (multiple) > IP addresses, MAC addresses, > net-filter, and all the rest. I thi

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

Hi Scott > Sorry to be coming in late, but I'm curious about why this work is being > submitted as a separate driver, rather than as patches against the driver > from Dustin McIntire that was added a few months ago. Is the intention to > go forward with two different drivers for these chips?

Re: E1000: bug on error path in e1000_probe()

On Tue, 1 Aug 2006, Auke Kok wrote: Stephane Doyon wrote: The e1000_probe() function passes references to the netdev structure before it's actually registered. In the (admittedly obscure) case where the netdev registration fails, we are left with a dangling reference. Specifically, e1000_p

[PATCH 3/5] d80211: return correct value when loading of rate control module fails

From: Karol Lewandowski <[EMAIL PROTECTED]> When loading of rate_control module fails, ieee80211_register_hw returns value from previous check. This patch fixes that. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211.c |3 ++- 1 files changed, 2 insertions(+), 1 deletio

[PATCH 5/5] d80211: Switch d80211 drivers to IEEE80211_ style definitions

This patch makes the d80211 drivers work with the switch to IEEE80211_ style names in d80211.h. Based on the patch by Michael Wu <[EMAIL PROTECTED]>. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- drivers/net/wireless/d80211/adm8211/adm8211.c | 10 +- drivers/net/wireless/d8021

[PATCH 1/5] d80211: make sleeping in hw->config possible

This patch makes sleeping in the hw->config callback possible by removing the only atomic caller. The atomic caller was a timer and is replaced by a workqueue. This is based on a patch from Michael Buesch <[EMAIL PROTECTED]>. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee8021

[PATCH 2/5] d80211: return correct error codes for scan requests

Do not allow scanning when the network interface is down. Return 0 instead of -EBUSY when scanning is in progress on the same network interface. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211_ioctl.c |6 ++ net/d80211/ieee80211_sta.c |5 - 2 files change

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

On 06-08-01 15:58 Jiri Benc wrote: > > pointing non-migrated drivers (ipw2[12]00, zd1211rw) at the old > > code, > > Yes. Rather than moving, zd1211 should be ported to d80211 - this will > also allow using of more advanced features of the hw. I have currently no idea, when this will happen. Cur

[PATCH 0/5] d80211: pull request

Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git up to obtain following patches: Jiri Benc: d80211: make sleeping in hw->config possible d80211: return correct error codes for scan requests d80211: Switch d80211 drivers to IEEE80211_ style definitio

Re: [patch] RFC: matching interface groups

Hi Phil, On Tue, Aug 01, 2006 at 11:46:55AM -0700, Phil Oester told us: > Since in this scenario userspace is able to determine ppp vs pptp, > could you not also do something like have an inbound_ppp and inbound_pptp > chain, then jump to the appropriate chain depending on type? If you > need p

[PATCH] sky2: status interrupt handling improvement

More changes to prevent losing status and causing hangs. The hardware is smarter than I gave it credit for. Clearing the status IRQ causes the status state machine to toggle an IRQ if needed and post any more transmits. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sky2.c

Re: E1000: bug on error path in e1000_probe()

Stephane Doyon wrote: The e1000_probe() function passes references to the netdev structure before it's actually registered. In the (admittedly obscure) case where the netdev registration fails, we are left with a dangling reference. Specifically, e1000_probe() calls netif_carrier_off(n

Re: [patch] RFC: matching interface groups

On Tue, Aug 01, 2006 at 07:10:09PM +0200, Balazs Scheidler wrote: > Each interface can belong to a single "group" at a time, an interface > comes up without being a member in any of the groups. > > Userspace can assign interfaces to groups after being created, this > would typically be performed i

Re: [patch] RFC: matching interface groups

On Tue, 01 Aug 2006 19:10:09 +0200 Balazs Scheidler <[EMAIL PROTECTED]> wrote: > Hi, > > I would like to easily match a set of dynamically created interfaces > from my packet filter rules. The attached patch forms the basis of my > implementation and I would like to know whether something like th

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

On Tue, 1 Aug 2006, Steve Glendinning wrote: Attached is a driver patch for SMSC911x family of ethernet chips, generated against 2.6.18-rc1 sources. There's a similar driver in the tree; this one has been tested by SMSC on all flavors of the chip and claimed to be efficient. Updated after feed

[patch] RFC: matching interface groups

Hi, I would like to easily match a set of dynamically created interfaces from my packet filter rules. The attached patch forms the basis of my implementation and I would like to know whether something like this is mergeable to mainline. The use-case is as follows: * I have two different subsyste

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

On Tuesday 01 August 2006 19:11, John W. Linville wrote: > On Tue, Aug 01, 2006 at 04:25:05PM +0200, Ivo Van Doorn wrote: > > Hi, > > > > >> Do you have a plan when you will merge rt2x00 patches so I can apply > > >> Michael's renaming patch(es) without risk of conflicts? > > > > > >Working on it

Re: [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls

On Tuesday 01 August 2006 16:41, Andrew Morton wrote: > On Mon, 31 Jul 2006 19:04:33 +1000 > Herbert Xu <[EMAIL PROTECTED]> wrote: > > > 2) There is something broken in the x86_64 unwind code which is causing > > it to panic just about everytime somebody calls dump_stack(). > > > > Andi, this is

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

John W. Linville wrote: I'm just not sure that cleverness is worth the headache, especially since the most clever things usually only work by accident... Or, work by solid, modular design and small tweaks! Point taken. But stashing little hacks in the networking core for specific virtual d

Re: e1000 speed/duplex error

On 8/1/06, Auke Kok <[EMAIL PROTECTED]> wrote: Jeff Kirsher wrote: > On 8/1/06, a1 <[EMAIL PROTECTED]> wrote: >> Hi, Jeff. >> >> >> JK> OPTION 2: Turn auto-negotiate on the e1000 card and tell it to only >> JK> advertise 100 Full Duplex. This will allow negotiation between the >> JK> two lnk par

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

On Tue, Aug 01, 2006 at 04:25:05PM +0200, Ivo Van Doorn wrote: > Hi, > > >> Do you have a plan when you will merge rt2x00 patches so I can apply > >> Michael's renaming patch(es) without risk of conflicts? > > > >Working on it ~now. I hit a snag in that Ivo's patches seem to rely on > >his radio

[PATCH] IPv6: only set err in rawv6_bind() when necessary

The variable 'err' is set in rawv6_bind() before the address check fails instead of after, moved inside if() statement. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c index 8a30cd8..072b28b 100644 --- a/net/ipv6/raw.c +++ b/net/ipv6/raw.c @@ -240,10 +

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

John W. Linville wrote: On Tue, Aug 01, 2006 at 09:10:06AM -0700, Ben Greear wrote: Jamal Hadi Salim wrote: Agreed. I have some very strong opinions on this subject that i could share with you if you want. For example, IMO, I think it would be a lot reasonable to assume that a VLAN or VLANS

Re: e1000 speed/duplex error

I thought the common behavior is that if one side force any particular parameter, other side should "sense" that and go to that mode too. Nope. That is a common misconception and perhaps the source of many duplex mismatch problems today. Here is some boilerplate I bring-out from time to time

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

On Tue, Aug 01, 2006 at 09:17:15AM -0700, Ben Greear wrote: > John W. Linville wrote: > Well, if it makes you feel better, I can't see a good way to do > vlans-over-vlans cleanly, backwards compatibly, and functional with > bridging, etc. I would not plan to add such a feature to the kernel > unl

Re: [RFC 1/4] kevent: core files.

> I do not think if we do a ring buffer that events should be obtainable > via a syscall at all. Rather, I think this system call should be > purely "sleep until ring is not empty". Mmm, yeah, of course. That's much simpler. I'm looking forward to Evgeniy's next patch set. > The ring buffer s

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

On Tue, Aug 01, 2006 at 09:10:06AM -0700, Ben Greear wrote: > Jamal Hadi Salim wrote: > >Agreed. I have some very strong opinions on this subject that i could > >share with you if you want. For example, IMO, I think it would be a lot > >reasonable to assume that a VLAN or VLANS are attributes of a

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

On Tue, Aug 01, 2006 at 08:33:34AM -0400, Jamal Hadi Salim wrote: > On Tue, 2006-01-08 at 08:08 -0400, John W. Linville wrote: > > And, I think that a > > reconsideration of all three functions as a group could lead to > > better/cleaner functionality with easier support for extension (e.g. > > 80

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

John W. Linville wrote: On Mon, Jul 31, 2006 at 09:39:08PM -0400, Jamal Hadi Salim wrote: On Mon, 2006-31-07 at 08:30 -0400, John W. Linville wrote: Do we hold the view that our L2 code is on par with the rest of our code? Is there an appetite for a clean-up? Or is it just me? If you m

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

Jamal Hadi Salim wrote: On Tue, 2006-01-08 at 08:08 -0400, John W. Linville wrote: [..] There is no doubt that we need to be able to do all three (vlan, bridge, bond) at once. I'm just not convinced we need to support stacking them in every conceivable order. In theory there should be no

Re: [DSCAPE] rate_control needs some form of reference counting

On Tue, 1 Aug 2006 17:16:32 +0200, Karol Lewandowski wrote: > Without that ieee80211_register_hw was returning value from previous > check: I missed that. Thanks for spotting this. > This fixes that oops. Problem remains, though. I suppose that oops > would happen anyway if someone would do: >

Re: Runtime power management for network interfaces

On Mon, 31 Jul 2006 17:29:41 -0700 David Brownell <[EMAIL PROTECTED]> wrote: > On Monday 31 July 2006 9:17 am, Stephen Hemminger wrote: > > On Tue, 25 Jul 2006 11:59:52 -0400 (EDT) > > Alan Stern <[EMAIL PROTECTED]> wrote: > > > > > During a Power Management session at the Ottawa Linux Symposium,

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

On Tue, Aug 01, 2006 at 12:00:59AM -0700, David Miller wrote: > What we have now is infinitely better than the past, > wherein all TSO packets were dropped due to corrupt > checksums as soon at the NAT module was loaded. At what point did this problem begin? 2.6.18-rc or prior? Phil

  1   2   >