From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Sat, 29 Jul 2006 18:30:18 +0900
> +#ifdef CONFIG_XFRM_ADVANCED > + struct xfrm_state *(*state_lookup_byaddr)(xfrm_address_t *daddr, > xfrm_address_t *saddr, u8 proto); > +#endif I think we should delete XFRM_ADVANCED config option, it is only serving to make the code very ugly and full of ifdefs. > +#ifdef CONFIG_XFRM_ADVANCED > + int use_spi = xfrm_id_proto_match(x->id.proto, IPSEC_PROTO_ANY); > +#else > + int use_spi = 1; > +#endif Why this transformation? In fact, you added several others. xfrm_id_proto_match() with userproto argument IPSEC_PROTO_ANY always evaluates to one. If you intend to change the userproto argument in some future changeset, then add the xfrm_id_proto_match() call in that changeset. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
