Since network device can auto calculate and verify the checksum of a
packet, for example: some e1000 interface. Different device will set
different value of skb->ip_summed.
a) If device do nothing to checksum, skb->ip_summed would be set to
CHECKSUM_NONE.
b) If device can only calculate a che
From: Paul Moore <[EMAIL PROTECTED]>
Date: Sun, 16 Jul 2006 22:42:07 -0400
> Right now I use both the bitmap_walk() and bitmap_setbit() routines
> to deal with both CIPSO tags straight from the sk_buff as well as
> the internal bitmap representation. Padding out the internal
> bitmaps would requi
On Sunday 16 July 2006 9:12 pm, David Miller wrote:
> From: Paul Moore <[EMAIL PROTECTED]>
> Date: Sun, 16 Jul 2006 12:10:44 -0400
>
> > On Friday 14 July 2006 10:03 pm, James Morris wrote:
> > > On Fri, 14 Jul 2006, [EMAIL PROTECTED] wrote:
> > > > +/**
> > > > + * cipso_v4_bitmap_walk - Walk a bi
From: "chas williams - CONTRACTOR" <[EMAIL PROTECTED]>
Date: Sun, 16 Jul 2006 07:20:35 -0400
> why does the input side of the ip layer believe the cb contains valid
> data? it should zero the contents of the cb, or just fill in the cb
> correctly when the packet arrives at its doorstop.
Yes, tha
From: Guillaume Chazarain <[EMAIL PROTECTED]>
Date: Sun, 16 Jul 2006 23:56:31 +0200
> CONFIG_DEBUG_SLAB found the following bug:
> netem_enqueue() in sch_netem.c gets a pointer inside a slab object:
> struct netem_skb_cb *cb = (struct netem_skb_cb *)skb->cb;
> But then, the slab object may be free
From: Krzysztof Halasa <[EMAIL PROTECTED]>
Date: Sun, 16 Jul 2006 14:23:49 +0200
> WAN: Converted synclink drivers to use netif_carrier_*() instead
> of hdlc_set_carrier().
>
> Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]>
Also applied, thanks for fixing this up Krzysztof.
-
To unsubscribe
From: Krzysztof Halasa <[EMAIL PROTECTED]>
Date: Sun, 16 Jul 2006 14:19:07 +0200
> WAN: Cosmetic changes to N2 and C101 drivers
>
> Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]>
Applied, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
From: Krzysztof Halasa <[EMAIL PROTECTED]>
Date: Sun, 16 Jul 2006 14:17:20 +0200
> WAN: Fixed a problem with PPP/raw HDLC/X.25 protocols not doing
> netif_dormant_off() at startup.
>
> Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]>
Applied, thanks.
-
To unsubscribe from this list: send the
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Mon, 17 Jul 2006 08:03:50 +1000
> The thing is qdiscs using cb means that this method of clearing cb
> before netif_rx doesn't work anymore.
>
> In particular, even if loopback clears cb before calling netif_rx,
> some qdisc could come along between neti
From: Paul Moore <[EMAIL PROTECTED]>
Date: Sun, 16 Jul 2006 12:10:44 -0400
> On Friday 14 July 2006 10:03 pm, James Morris wrote:
> > On Fri, 14 Jul 2006, [EMAIL PROTECTED] wrote:
> > > +/**
> > > + * cipso_v4_bitmap_walk - Walk a bitmap looking for a bit
> > >
> > > + * cipso_v4_bitmap_setbit - S
On Sat, Jul 15, 2006 at 06:12:22PM -0700, David Miller wrote:
>
> But I'm beginning to think that the onus of this may in fact fall upon
> the devices, in fact. Loopback is one of the few devices where the
> control block might not be cleared out, due to uses in the output
> path. Devices predom
CONFIG_DEBUG_SLAB found the following bug:
netem_enqueue() in sch_netem.c gets a pointer inside a slab object:
struct netem_skb_cb *cb = (struct netem_skb_cb *)skb->cb;
But then, the slab object may be freed:
skb = skb_unshare(skb, GFP_ATOMIC)
cb is still pointing inside the freed skb, so here is
On Sunday 16 July 2006 12:33, Auke Kok wrote:
> [adding netdev to the cc]
>
>
> unfortunately I didn't.
>
> e1000 has a special e1000_pci_save_state/e1000_pci_restore_state set of
> routines that save and restore the configuration space. the fact that it
> works for suspend to memory to me suggests
Shawn Starr wrote:
Hardware
IBM ThinkPad T42
E1000 card info:
02:01.0 Ethernet controller: Intel Corporation 82540EP Gigabit Ethernet
Controller (Mobile) (rev 03)
Subsystem: IBM PRO/1000 MT Mobile Connection
Flags: bus master, 66MHz, medium devsel, latency 64, IRQ 9
M
On Friday 14 July 2006 10:03 pm, James Morris wrote:
> On Fri, 14 Jul 2006, [EMAIL PROTECTED] wrote:
> > +/**
> > + * cipso_v4_bitmap_walk - Walk a bitmap looking for a bit
> >
> > + * cipso_v4_bitmap_setbit - Sets a single bit in a bitmap
>
> Can you use lib/bitmap.c instead?
Looking again at inc
Adrian Bunk wrote:
This patch contains the following possible cleanups:
- make needlessly global functions static
- #if 0 unused functions
Please review which of these functions do make sense and which do
conflict with pending patches.
Thanks Adrian. I have put this in my tree and made an add
Hopefully this will help people like Adrian Bunk send patches where the
maintainers will see them :)
Signed-off-by: Daniel Drake <[EMAIL PROTECTED]>
diff --git a/MAINTAINERS b/MAINTAINERS
index e99028c..48a5c02 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3298,6 +3298,15 @@ W: http://www.
WAN: Converted synclink drivers to use netif_carrier_*() instead
of hdlc_set_carrier().
Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]>
diff --git a/drivers/char/pcmcia/synclink_cs.c
b/drivers/char/pcmcia/synclink_cs.c
index 0721345..bdd09d9 100644
--- a/drivers/char/pcmcia/synclink_cs.c
+++
WAN: Cosmetic changes to N2 and C101 drivers
Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]>
diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c
index 3796a59..2911be3 100644
--- a/drivers/net/wan/c101.c
+++ b/drivers/net/wan/c101.c
@@ -197,7 +197,6 @@ static int c101_open(struct net
WAN: Fixed a problem with PPP/raw HDLC/X.25 protocols not doing
netif_dormant_off() at startup.
Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]>
diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c
index b81263e..fbaab5b 100644
--- a/drivers/net/wan/hdlc_ppp.c
+++ b/drivers/net
David Miller <[EMAIL PROTECTED]> writes:
>> WARNING: "hdlc_set_carrier" [drivers/char/synclinkmp.ko] undefined!
>> WARNING: "hdlc_set_carrier" [drivers/char/synclink_gt.ko] undefined!
>> WARNING: "hdlc_set_carrier" [drivers/char/synclink.ko] undefined!
>> WARNING: "hdlc_set_carrier" [drivers/char/
In message <[EMAIL PROTECTED]>,David Miller writes:
>From: Herbert Xu <[EMAIL PROTECTED]>
>> At least this lets us get rid of a few other memsets :)
>>
>Applied, good spotting :-) I remember when we added those
>things.
>
>But I'm beginning to think that the onus of this may in fact fall upon
>th
Quoting Herbert Xu:
| > case SO_NO_CHECK:
| > - sk->sk_no_check = valbool;
| > + /* UDP-Lite (RFC 3828) mandates checksumming,
| > + * hence user must not enable this option. */
| > + if (
23 matches
Mail list logo
