On Sat, Jul 15, 2006 at 06:12:22PM -0700, David Miller wrote: > > But I'm beginning to think that the onus of this may in fact fall upon > the devices, in fact. Loopback is one of the few devices where the > control block might not be cleared out, due to uses in the output > path. Devices predominantly provide a zero'd out control block in the > skb on packet receive.
The thing is qdiscs using cb means that this method of clearing cb before netif_rx doesn't work anymore. In particular, even if loopback clears cb before calling netif_rx, some qdisc could come along between netif_rx and ip_rcv and put stuff in the cb. The same thing can happen to any NIC in fact, as long as we allow qdiscs to use the cb area without clearing it, ip_rcv needs to clear it itself. With a little bit of effort we should be able to get away with clearing just optlen. Whether this effort is worthwhile I don't know :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
