In message <[EMAIL PROTECTED]>,David Miller writes: >From: Herbert Xu <[EMAIL PROTECTED]> >> At least this lets us get rid of a few other memsets :) >> >Applied, good spotting :-) I remember when we added those >things. > >But I'm beginning to think that the onus of this may in fact fall upon >the devices, in fact. Loopback is one of the few devices where the >control block might not be cleared out, due to uses in the output >path. Devices predominantly provide a zero'd out control block in the >skb on packet receive.
the atm layer has the same problem. some atm device drivers use the skb cb field, so it needs to be zero'ed by the next upper layer (clip, lane) before being passed to the ip layer. its also possible that the atm layer should clone the skb before passing to the next layer which would also zeroize the cb. >Other opinions welcome... why does the input side of the ip layer believe the cb contains valid data? it should zero the contents of the cb, or just fill in the cb correctly when the packet arrives at its doorstop. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
