While hunting down oversized inlines
I stumbled on tcf_generic_walker().
It is defined in two separate files:
once as an inline in include/net/pkt_act.h
(really big one, ~750 bytes of code)
and once as a static function in net/sched/act_police.c
These two instances are not identical.
Second one h
From: Samuel Ortiz <[EMAIL PROTECTED]>
Date: Thu, 6 Apr 2006 02:21:37 +0300
> This patch enables support for the Sigmatel's STIR421x IrDA chip.
> Once patched with Sigmatel's firmware, this chip "almost" follows the
> USB-IrDA spec. Thus this patch is against irda-usb.[ch].
>
> The code has been
From: Samuel Ortiz <[EMAIL PROTECTED]>
Date: Thu, 6 Apr 2006 02:21:25 +0300
> This patch integrates the smcinit code into the smsc-ircc driver.
> Some laptops have their smsc-ircc chip not properly configured by the BIOS
> and needs some preconfiguration. Currently, this can be done from userspac
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 6 Apr 2006 09:12:58 +1000
> [INET]: Use port unreachable instead of proto for tunnels
>
> This patch changes GRE and SIT to generate port unreachable instead of
> protocol unreachable errors when we can't find a matching tunnel for a
> packet.
>
>
From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Tue, 4 Apr 2006 18:37:01 +0200
> This patch contains the following possible cleanups:
> - make the following needlessly global function static:
> - arp.c: arp_rcv()
This is ok.
> - remove the following unused EXPORT_SYMBO's:
> - devinet.c: devinet_
From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Tue, 4 Apr 2006 21:09:35 +0200
> This patch fixes a memory leak (buf wasn't freed) spotted by the
> Coverity checker.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Applied, thanks Adrian.
-
To unsubscribe from this list: send the line "unsubscrib
From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Tue, 4 Apr 2006 21:07:42 +0200
> This patch fixes an off-by-21-or-49 error ;-) spotted by the Coverity
> checker.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Applied, thanks Adrian.
-
To unsubscribe from this list: send the line "unsubscribe ne
This patch fixes the nic initialization. If the nic was in low power
mode, it brings it back to normal power. Also, it utilizes a new
hardware reset during the init.
I am resending based on feedback, I corrected the register size mapping
(again) and delay after posted write.
Signed-Off-By: Ayaz
Manfred Spraul wrote:
Ayaz Abdulla wrote:
Ayaz Abdulla wrote:
Manfred Spraul wrote:
Ayaz Abdulla wrote:
This patch adds support for configuration of various parameters. This
includes module parameters and ethtool commands.
+
+if (netif_running(dev)) {
+nv_start_rx(de
Sky2 driver will oops referencing bad memory if used on
a dual port card. The problem is accessing past end of
MIB counter space.
Applies for both 2.6.17 and 2.6.16 (with fuzz)
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- test-2.6.orig/drivers/net/sky2.c
+++ test-2.6/drivers/net/sk
On Wed, 5 Apr 2006, Jesse Brandeburg wrote:
> I'll also send a patch today to back-rev the xmit routine to the 5.6.10.1
> state.
I'm in a bit of a hurry, but I wanted to send these debug patches out.
Forgive me if my mailer decides to munge them.
I'd suggest trying the first one and then both
On 4/5/06, Herbert Xu <[EMAIL PROTECTED]> wrote:
> Michal Feix <[EMAIL PROTECTED]> wrote:
> >
> > All boxes running for two weeks now and spitting these assert messages
> > have about 1,5GB of slab size allocated, with skbuff_head_cache entry
> > being the largest entry. After rebooting, it is all
Hi David,
This patch enables support for the Sigmatel's STIR421x IrDA chip.
Once patched with Sigmatel's firmware, this chip "almost" follows the USB-IrDA
spec. Thus this patch is against irda-usb.[ch].
The code has been tested by Nick Fedchik on an STIR4210 chipset based dongle.
Signed-off-by:
Hi David,
This patch integrates the smcinit code into the smsc-ircc driver.
Some laptops have their smsc-ircc chip not properly configured by the BIOS and
needs some preconfiguration. Currently, this can be done from userspace with
smcinit, a utility that comes with the irda-utils package. It me
On Tue, Apr 04, 2006 at 01:52:17PM -0700, David S. Miller wrote:
> Applied, thanks Herbert. And yes I do agree about changing IP GRE
> tunnel ICMP generation to be in line with the rest of this stuff.
Great. Here is the patch to do that and also change SIT.
[INET]: Use port unreachable instead
From: Roland Dreier <[EMAIL PROTECTED]>
Date: Wed, 05 Apr 2006 14:52:24 -0700
> > + case 0x1030 ... 0x1034:
>
> Do we use the gcc "case range" extension in the kernel? (This is an
> honest question -- I don't think I've seen it used anywhere, and I'd
> be curious to know what the taste arbiter
On Thu, Apr 06, 2006 at 04:11:58AM +1000, Herbert Xu wrote:
> That's a very interesting observation. Can others please check if they
> have an abnormally large skbuff slab cache?
Mine seem to be reasonably sized:
e1000 with assertion failures (up 14 days, 2:51):
OBJS ACTIVE USE OBJ SIZE SLA
On Mon, 3 Apr 2006, Boris B. Zhmurov wrote:
>
> Hello, Phil Oester.
>
> On 04.04.2006 01:39 you said the following:
>
> > On Mon, Apr 03, 2006 at 04:01:23PM -0500, Mark Nipper wrote:
> >
> >>After three days and some hours, I finally saw another
> >>event:
> >
> >
> > Ack, same here.
Roland Dreier wrote:
> + case 0x1030 ... 0x1034:
Do we use the gcc "case range" extension in the kernel? (This is an
honest question -- I don't think I've seen it used anywhere, and I'd
be curious to know what the taste arbiters think of it)
I'm not a fan of it either but it is used already
On Wednesday 05 April 2006 15:52, Roland Dreier wrote:
> > + case 0x1030 ... 0x1034:
>
> Do we use the gcc "case range" extension in the kernel? (This is an
> honest question -- I don't think I've seen it used anywhere, and I'd
> be curious to know what the taste arbiters think of it)
There ar
On Wed, 5 Apr 2006, Roland Dreier wrote:
> > + case 0x1030 ... 0x1034:
>
> Do we use the gcc "case range" extension in the kernel? (This is an
> honest question -- I don't think I've seen it used anywhere, and I'd
> be curious to know what the taste arbiters think of it)
It's OK AFAIK.
grep fi
> +case 0x1030 ... 0x1034:
Do we use the gcc "case range" extension in the kernel? (This is an
honest question -- I don't think I've seen it used anywhere, and I'd
be curious to know what the taste arbiters think of it)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
t
Apparently the Intel PRO/100 device enables interrupts on reset.
Unless firmware explicitly disables PRO/100 interrupts, we can
get a flood of interrupts when a driver attaches to an unrelated
device that happens to share the PRO/100 IRQ.
This should resolve this "irq 11: nobody cared" bug report:
From: David Daney
Here is a new version of the patch I sent March 31. For background,
this is my description from the first patch:
> When an internet host joins a network where there is no DHCP server,
> it may auto-allocate an IP address by the method described in RFC
> 3927. There are several
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Mike Kershaw wrote:
>>Looks very interesting, but I had in mind exactly the opposite (if I
>>understand correctly): packets written to the virtual device would be
>>received by the kernel, instead of going out to the radio. The kernel
>>would think it
Ayaz Abdulla wrote:
Ayaz Abdulla wrote:
Manfred Spraul wrote:
Ayaz Abdulla wrote:
This patch adds support for configuration of various parameters. This
includes module parameters and ethtool commands.
+
+if (netif_running(dev)) {
+nv_start_rx(dev);
+nv_start_tx(
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Mike Kershaw wrote:
> Josh Wright and I have been working on a library to make a common
> injection layer across the drivers,
Looks very interesting, but I had in mind exactly the opposite (if I
understand correctly): packets written to the virtual de
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 06 Apr 2006 04:11:58 +1000
> Michal Feix <[EMAIL PROTECTED]> wrote:
> >
> > All boxes running for two weeks now and spitting these assert messages
> > have about 1,5GB of slab size allocated, with skbuff_head_cache entry
> > being the largest entr
Ayaz Abdulla wrote:
This patch fixes the issues with multiple irqs.
I am resending based on feedback. I decoupled the dma mask for
consistent memory and fixed leak with multiple irq in error path.
Thanks to Manfred for catching the spin lock problem.
Signed-Off-By: Ayaz Abdulla <[EMAIL PROT
Ayaz Abdulla wrote:
Manfred Spraul wrote:
Ayaz Abdulla wrote:
if (nv_alloc_rx(dev)) {
-spin_lock(&np->lock);
+spin_lock_irqsave(&np->lock, flags);
Tiny point:
there is not need for irqsave(): we are in timer context, that
guarantees:
- bottom half disabled
- inter
Hi Ayaz,
looks good, except:
Ayaz Abdulla wrote:
+
+ NvRegPowerState2 = 0x600,
You access a register at offset 0x600
/* Miscelaneous hardware related defines: */
-#define NV_PCI_REGSZ 0x270
+#define NV_PCI_REGSZ_VER1 0x270
+#define NV_PCI_REGSZ_VER2
Michal Feix <[EMAIL PROTECTED]> wrote:
>
> All boxes running for two weeks now and spitting these assert messages
> have about 1,5GB of slab size allocated, with skbuff_head_cache entry
> being the largest entry. After rebooting, it is all nice and small, but
> it is noticable, that this entry
Vlad Yasevich wrote:
On Wed, 2006-04-05 at 10:38 -0600, Mark Butler wrote:
The problem in this case is skb1 does not own the skb_shared_info
structure (and hence the frag_list) once it has been cloned.
skb_unshare is the function that should be used to get a modifiable copy.
So, wha
OK, here's a stronger attempt. I might have gone a little wild with the patch
description :). Two questions and a data point:
1) It occurs to me as I write this that I don't know how the trailer_len stuff
works if a fragments final data bits are page frags in the skb. Did I
screw this up
On Wed, Apr 05, 2006 at 06:33:18PM +0200, Marco Berizzi wrote:
> Hello everybody.
> I'm getting these errors (with packet/connectivity loss) on
> our firewall after I have plugged in a 3c905C nic. Linux is
> Slackware 10.2 with vanilla 2.6.16.1.
>
> Hints?
>
> PS: I have temporary resolved the pr
On Wed, 2006-04-05 at 10:32 -0700, Stephen Hemminger wrote:
> On Wed, 05 Apr 2006 10:31:14 -0700
> Sanjeev Jorapur <[EMAIL PROTECTED]> wrote:
>
> > On Wed, 2006-04-05 at 10:13 -0700, Stephen Hemminger wrote:
> > > On Wed, 05 Apr 2006 09:38:24 -0700
> > > "Bryan O'Sullivan" <[EMAIL PROTECTED]> wrot
On Wed, 2006-04-05 at 10:13 -0700, Stephen Hemminger wrote:
> On Wed, 05 Apr 2006 09:38:24 -0700
> "Bryan O'Sullivan" <[EMAIL PROTECTED]> wrote:
>
> > On Sat, 2006-04-01 at 05:14 -0800, Linsys Contractor Amit S. Kale wrote:
> >
> > > We would like this driver to be inluded in mainline kernel.
>
On Wed, 05 Apr 2006 10:31:14 -0700
Sanjeev Jorapur <[EMAIL PROTECTED]> wrote:
> On Wed, 2006-04-05 at 10:13 -0700, Stephen Hemminger wrote:
> > On Wed, 05 Apr 2006 09:38:24 -0700
> > "Bryan O'Sullivan" <[EMAIL PROTECTED]> wrote:
> >
> > > On Sat, 2006-04-01 at 05:14 -0800, Linsys Contractor Amit
On Wed, 2006-04-05 at 10:13 -0700, Stephen Hemminger wrote:
> Or for a new driver, just make it one big piece and put it at a
> website for download and include linke.
Funny, I'd have thought that was a guaranteed way to get it ignored.
http://vger.kernel.org/majordomo-info.html
On Wed, Apr 05, 2006 at 10:11:11AM -0700, Stephen Hemminger wrote:
> On Wed, 5 Apr 2006 18:36:10 +0200
> Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > This patch removes the unused EXPORT_SYMBOL(secure_ipv6_port_ephemeral).
> >
> > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
> >
> > --- linux-
On Wed, 5 Apr 2006 18:36:10 +0200
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> This patch removes the unused EXPORT_SYMBOL(secure_ipv6_port_ephemeral).
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
>
> --- linux-2.6.17-rc1-mm1-full/drivers/char/random.c.old 2006-04-05
> 17:00:04.
On Wed, 05 Apr 2006 09:38:24 -0700
"Bryan O'Sullivan" <[EMAIL PROTECTED]> wrote:
> On Sat, 2006-04-01 at 05:14 -0800, Linsys Contractor Amit S. Kale wrote:
>
> > We would like this driver to be inluded in mainline kernel.
> > Kindly review it and feel free to get back to me for any
> > feedback
On Wed, Apr 05, 2006 at 09:59:38AM -0500, Dave Kleikamp wrote:
> I'm getting a panic that I've traced back to this changeset:
> http://www.kernel.org/git/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e695633e21ffb6a443a8c2f8b3f095c7f1a48eb0
>
> xfrm4_rcv_encap dereferences x->enc
This patch contains the following cleanups:
- make the following needlessly global functions static:
- lock_adapter_irq()
- unlock_adapter_irq()
- #if 0 the following unused global functions:
- wanrouter_encapsulate()
- wanrouter_type_trans()
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
On Wed, 2006-04-05 at 10:38 -0600, Mark Butler wrote:
> Vlad Yasevich wrote:
>
> >Hi All
> >
> >I am trying to understand if it is a good idea to have cloned skbs
> >reside on a frag_list?
> >
> >I've ran into a situation with SCTP, where it is possible to create
> >infinite recursion loops by hav
On Wed, Apr 05, 2006 at 11:39:05AM -0400, Vlad Yasevich wrote:
> Hi All
>
> I am trying to understand if it is a good idea to have cloned skbs
> reside on a frag_list?
>
> I've ran into a situation with SCTP, where it is possible to create
> infinite recursion loops by having cloned skbs reside o
On Sat, 2006-04-01 at 05:49 -0800, Linsys Contractor Amit S. Kale wrote:
> +for (ctx = 0; ctx < MAX_RCV_CTX; ++ctx) {
Why did this patch suddenly start in the middle?
> + if (adapter->is_up != ADAPTER_UP_MAGIC) {
> + printk("NetXen adapter %d\n", opencount);
> +
On Sat, 2006-04-01 at 05:14 -0800, Linsys Contractor Amit S. Kale wrote:
> We would like this driver to be inluded in mainline kernel.
> Kindly review it and feel free to get back to me for any
> feedback/queries/comments.
Based on some light reading and my own recent experience, I'd estimate
This patch removes the unused EXPORT_SYMBOL(secure_ipv6_port_ephemeral).
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
--- linux-2.6.17-rc1-mm1-full/drivers/char/random.c.old 2006-04-05
17:00:04.0 +0200
+++ linux-2.6.17-rc1-mm1-full/drivers/char/random.c 2006-04-05
17:00:22.000
Vlad Yasevich wrote:
Hi All
I am trying to understand if it is a good idea to have cloned skbs
reside on a frag_list?
I've ran into a situation with SCTP, where it is possible to create
infinite recursion loops by having cloned skbs reside on a frag_list.
We end up in a situation where have tw
Hello everybody.
I'm getting these errors (with packet/connectivity loss) on
our firewall after I have plugged in a 3c905C nic. Linux is
Slackware 10.2 with vanilla 2.6.16.1.
Hints?
PS: I have temporary resolved the problem running 'ifconfig
eth2 down' and 'ifconfig eth2 up'
Apr 5 17:47:07 Tet
On Sat, 2006-04-01 at 05:20 -0800, Linsys Contractor Amit S. Kale wrote:
> +static inline void
> +netxen_nic_reg_write (netxen_adapter *adapter, u64 off, __uint32_t val)
> +{//Only for window 1
> +void *addr;
> +
> +read_lock(&adapter->adapter_lock);
> +
> +if (adapter->cur
On Sat, 2006-04-01 at 05:48 -0800, Linsys Contractor Amit S. Kale wrote:
> diff -Naru linux-2.6.16_orig/drivers/net/netxen/netxen_nic_init.c
> linux-2.6.16/drivers/net/netxen/netxen_nic_init.c
Why are you submitting the same file multiple times?
This is really pretty sloppy.
http://vger
On Sat, 2006-04-01 at 05:20 -0800, Linsys Contractor Amit S. Kale wrote:
> +U16 brdnum;
Where does U16 come from?
> +#define MAX_CMD_DESCRIPTORS 1024
Same comment as before WRT generic macro names. You're certain to break
the kernel build at some point with all these names.
From: Dale Farnsworth <[EMAIL PROTECTED]>
After resetting the hardware on a tx_timeout, call netif_wake_queue()
only if we have free tx descriptors.
Also, attempt to recover if mv643xx_eth_start_xmit() is called when
there are fewer free tx descriptors than expected.
The BUG_ON() call we are rep
On Sat, 2006-04-01 at 05:20 -0800, Linsys Contractor Amit S. Kale wrote:
> +#define NO_EPG_PROXY 1
> +
> +#define HOST_CPU_64_BIT 1
What?
> +#include
> +#ifdef NETIF_F_HW_VLAN_TX
> +#include
> +#endif
> +#ifndef MODULE
> +#include
> +#endif
?
> +#define BAR_00
> +#def
From: Brent Cook <[EMAIL PROTECTED]>
Fix the tx interrupt handler to free completed tx descriptors even
when NAPI is enabled. Otherwise, the tx queue would fill up resulting
in poor performance and "NETDEV WATCHDOG: : transmit timed out"
messages.
Signed-off-by: Brent Cook <[EMAIL PROTECTED]>
Si
On Sat, 2006-04-01 at 05:19 -0800, Linsys Contractor Amit S. Kale wrote:
> +#include
> +#include
> +#include
> +
> +#include
> +#include
> +
> +#define NetXen_CONF_X863
> +
> +#if defined(CONFIG_MODVERSIONS) && !defined(MODVERSIONS)
> +#define MODVERSIONS
> +#endif
> +
> +#if defi
On Sat, 2006-04-01 at 05:19 -0800, Linsys Contractor Amit S. Kale wrote:
> +/*
> + * netxen_niu_gbe_phy_read - read a register from the GbE PHY via
> + * mii management interface.
> + *
> + * Note: The MII management interface goes through port 0.
> + * Individual phys are addressed as foll
On Sat, 2006-04-01 at 05:18 -0800, Linsys Contractor Amit S. Kale wrote:
> +extern struct netxen_adapter_s *g_adapter;
> +extern spinlock_thal_lock;
In a header.
> diff -Naru linux-2.6.16_orig/drivers/net/netxen/xge_mdio.c
> linux-2.6.16/drivers/net/netxen/xge_mdio.c
This entire
On Sat, 2006-04-01 at 05:17 -0800, Linsys Contractor Amit S. Kale wrote:
> +unsigned long
> +decode_crb_addr (unsigned long addr)
> +{
Missing a nexgen_ prefix.
> +int
> +wait_rom_done (netxen_adapter *adapter)
Ditto.
> +int
> +rom_fast_read (netxen_adapter *adapter, int addr)
And again. I'm
On Sat, 2006-04-01 at 05:16 -0800, Linsys Contractor Amit S. Kale wrote:
> +extern char * netxen_nic_driver_string;
> +extern void netxen_update_stats(struct netxen_port *port);
> +extern void netxen_change_ringparam(struct netxen_adapter_s *adapter);
> +extern int rom_fast_read(struct netxen_adap
On Wednesday 05 April 2006 10:40, David Acker wrote:
> Ben Greear wrote:
> > The reason I suggested to not make the size #defines visible is that it
> > really doesn't help
> > much. If you are receiving in user space, a more useful number is:
> >
> > sizeof(vlan_eth_header) + MTU of interface
> >
On Sat, 2006-04-01 at 05:17 -0800, Linsys Contractor Amit S. Kale wrote:
> +extern struct netxen_adapter_s *g_adapter;
> +extern spinlock_thal_lock;
Should be in a header file.
> +void
> +netxen_nic_pci_change_crbwindow(netxen_adapter *adapter, uint32_t wndw)
Should use u32,
Never mind. Somehow I missed Herbert's patch for this in the netdev
archives.
--
David Kleikamp
IBM Linux Technology Center
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-i
Hi All
I am trying to understand if it is a good idea to have cloned skbs
reside on a frag_list?
I've ran into a situation with SCTP, where it is possible to create
infinite recursion loops by having cloned skbs reside on a frag_list.
We end up in a situation where have two clones skb1 and skb2 t
Ben Greear wrote:
The reason I suggested to not make the size #defines visible is that it
really doesn't help
much. If you are receiving in user space, a more useful number is:
sizeof(vlan_eth_header) + MTU of interface
Depending on the underlying NIC, you may still receive larger packets, so
I'm getting a panic that I've traced back to this changeset:
http://www.kernel.org/git/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e695633e21ffb6a443a8c2f8b3f095c7f1a48eb0
xfrm4_rcv_encap dereferences x->encap without testing it for null.
Signed-off-by: Dave Kleikamp <[EMAIL P
Hello developers.
For those of you who do not know if it is needed or not to switch
to/from netlink, I've created simple set of benchmarks which shows
performance of _blocking_ data transfer from kernelspace to userspace
in case of using unicast and broadcast.
There are several tests for different
David Acker wrote:
This is patch for include/linux/if_vlan.h . Its purpose is to allow a
user space program to use the vlan_ethhdr structure when directly
handling 802.1Q packets. This can be done by using a raw socket like:
int s = socket(PF_PACKET, SOCK_RAW, htons(ETH_P_ALL));
This socket sho
This is patch for include/linux/if_vlan.h . Its purpose is to allow a
user space program to use the vlan_ethhdr structure when directly
handling 802.1Q packets. This can be done by using a raw socket like:
int s = socket(PF_PACKET, SOCK_RAW, htons(ETH_P_ALL));
This socket should see VLAN packets
On Tue, 2006-04-04 at 17:40 -0600, Mark Butler wrote:
> Rick Jones wrote:
>
> > Again from RFC 791:
> >
> >>
> >> Every internet destination must be able to receive a datagram of 576
> >> octets either in one piece or in fragments to be reassembled.
> >
> >
> > Hence the minimum IPv4 MTU
David S. Miller wrote:
> From: Patrick McHardy <[EMAIL PROTECTED]>
> Date: Mon, 03 Apr 2006 15:43:13 +0200
>
>
>>Fix a regression from the netfilter/IPsec patches with bridging.
>>Bart, please review this patch, if everything is fine I think it
>>should also go in -stable.
>
>
> Applied, thanks
73 matches
Mail list logo
