On Sat, 2006-04-01 at 05:19 -0800, Linsys Contractor Amit S. Kale wrote:
> +/*
> + * netxen_niu_gbe_phy_read - read a register from the GbE PHY via
> + * mii management interface.
> + *
> + * Note: The MII management interface goes through port 0.
> + * Individual phys are addressed as follows:
> + * [15:8] phy id
> + * [7:0] register number
> + *
> + * Returns: 0 success
> + * -1 error
> + *
> + */
Please use kdoc formatting.
> +long netxen_niu_gbe_phy_read (long phy, long reg, netxen_crbword_t *readval)
> {
> + netxen_niu_gb_mii_mgmt_address_t address;
> + netxen_niu_gb_mii_mgmt_command_t command;
> + netxen_niu_gb_mii_mgmt_indicators_t status;
> + netxen_niu_gb_mii_mgmt_config_t mii_cfg;
Ugh. What's with all the horrible and insanely long typedefs?
> + long timeout=0;
> + long result = 0;
> + long restore = 0;
> + netxen_niu_gb_mac_config_0_t mac_cfg0;
> +
> + /* MII mgmt all goes through port 0 MAC interface, so it cannot be in
> reset */
> + NetXen_CRB_READ_CHECK(NetXen_NIU_GB_MAC_CONFIG_0(0), &mac_cfg0);
All the indentation in this file is wrong.
<b
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
