Re: [RFC] Some infrastructure for interrupt-less TX

2006-02-22 Thread Jörn Engel
On Wed, 22 February 2006 12:37:48 -0800, Caitlin Bestler wrote: > [EMAIL PROTECTED] wrote: > > Below patch wasn't even compile tested. I'm not involved > > with network drivers anymore, so my personal interest is > > fairly low. But since I firmly believe in the advantages and > > feasibility of

Re: [PATCH] Allow kfree_skb to be called with a NULL argument

2006-02-22 Thread Jörn Engel
On Thu, 23 February 2006 12:17:14 +1100, Herbert Xu wrote: > J?rn Engel <[EMAIL PROTECTED]> wrote: > > Fairly trivial. The extra conditional should get optimized away with > > current code. But it also allows to walk through network drivers and > > get rid of the permanent > >if (skb) > >

[GIT]: net-2.6.17 rebased

2006-02-22 Thread David S. Miller
To Linus's current tree. I've left the previous tree around as "bak-net-2.6.17.git" just in case something went wrong during the rebase. Thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.k

Re: [PATCH] Allow kfree_skb to be called with a NULL argument

2006-02-22 Thread Herbert Xu
J?rn Engel <[EMAIL PROTECTED]> wrote: > Fairly trivial. The extra conditional should get optimized away with > current code. But it also allows to walk through network drivers and > get rid of the permanent >if (skb) >kfree(skb); > conditionals. This is bad because it hid

Re: Problem with Ipsec transport mode over NAT

2006-02-22 Thread Patrick McHardy
Chinh Nguyen wrote: > I discovered that the "bug" is in the function tcp_v4_rcv for kernel > 2.6.16-rc1. > > After the ESP packet is decapped and decrypted in xfrm4_rcv_encap_finish, the > unencrypted packet is pushed back through ip_local_deliver. For a UDP packet, > it > goes (back) to functio

Re: [PATCH 0/6] sky2: fixes for 2.6.16

2006-02-22 Thread Francois Romieu
Stephen Hemminger <[EMAIL PROTECTED]> : > This set of patches covers the set of bug fixes that need > to go into 2.6.16 for the sky2 driver. #1..#6 Applied to branch 'for-jeff' at git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git I have replaced the empty summary message of #4 by '[PATC

Re: [PATCH 0/3] skge: patches for 2.6.16

2006-02-22 Thread Andrew Morton
Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > Bug fix patches to skge driver that need to go in 2.6.16. > Some of them are in -mm and some have already been sent (and ignored). Thanks. Jeff, will you handle these or do you want me to? - To unsubscribe from this list: send the line "unsubscribe

[PATCH] WE-20 for kernel 2.6.16

2006-02-22 Thread Jean Tourrilhes
Hi Jeff, This is version 20 of the Wireless Extensions. This is the completion of the RtNetlink work I started early 2004, it enables the full Wireless Extension API over RtNetlink. The patch has been fully tested with 2.6.16-rc2 and 2.6.16-rc3 and various wireless drivers,

Re: pktgen + napi == kaboom

2006-02-22 Thread Simon Kirby
On Wed, Feb 22, 2006 at 10:56:31AM -0800, Ben Greear wrote: > For VLANs, make sure that the 'multi-skb' is always zero. This is because > the VLAN code modifies the skb by re-assigning the skb->dev to the > underlying > device. > > I'm not sure if this is the problem you hit, but it could be...

RE: [RFC] Some infrastructure for interrupt-less TX

2006-02-22 Thread Caitlin Bestler
[EMAIL PROTECTED] wrote: > Below patch wasn't even compile tested. I'm not involved > with network drivers anymore, so my personal interest is > fairly low. But since I firmly believe in the advantages and > feasibility of interrupt-less TX, there should at least be an > ugly broken patch to flam

[PATCH 1/6] sky2: yukon-ec-u chipset initialization

2006-02-22 Thread Stephen Hemminger
Add more complete setup code for Yukon EC_U chipset. Based on matching code in 8.31 code in SysKonnect vendor driver. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-1.0.orig/drivers/net/sky2.c2006-02-20 09:42:42.0 -0800 +++ sky2-1.0/drivers/net/sky2.c 2006-02-20 12:12:

[PATCH 2/6] sky2: limit coalescing values to ring size

2006-02-22 Thread Stephen Hemminger
Don't allow coalescing values to be bigger than the transmit ring. Since if you set them that big, the interrupt never happens and driver livelocks. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-1.0.orig/drivers/net/sky2.c2006-02-20 09:48:32.0 -0800 +++ sky2-1.0/drive

[PATCH 3/6] sky2: poke coalescing timer to fix hang

2006-02-22 Thread Stephen Hemminger
Need to restart the interrupt coalescing timer after clearing the interrupt, to avoid races with interrupt timer and processing. Patch from Carl-Daniel Halfinger Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-02-21 09:14:34.0 -0800 +++

[PATCH 5/6] sky2: use device iomem to access PCI config

2006-02-22 Thread Stephen Hemminger
To avoid problems with PCI config access without ACPI (or busted ACPI tables), use the device's window into PCI config space. I know this probably will upset the purists, but I would rather have users than ACPI testers. It also generates less code. Signed-off-by: Stephen Hemminger <[EMAIL PROTECT

[no subject]

2006-02-22 Thread Stephen Hemminger
Need to force a transmit coalesce timer restart after processing transmit packets. Otherwise, can get transmit status after last update and chip doesn't send the next one. Can go with the chip defaults for coalescing timers, except for Tx timer which needs to be bigger. Signed-off-by: Stephen Hem

[PATCH 0/6] sky2: fixes for 2.6.16

2006-02-22 Thread Stephen Hemminger
This set of patches covers the set of bug fixes that need to go into 2.6.16 for the sky2 driver. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 6/6] sky2: close race on IRQ mask update.

2006-02-22 Thread Stephen Hemminger
Need to avoid race in updating IRQ mask. This can probably be replaced smarter use of the interrupt control registers (if/when chipset docs are available). Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-02-22 11:33:41.0 -0800 +++ sky2/d

[PATCH 2/3] skge: genesis phy initialzation

2006-02-22 Thread Stephen Hemminger
The SysKonnect Genesis based board would fail on initialization with phy_read errors caused by not waiting for last phy write. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- netdev-2.6.orig/drivers/net/skge.c 2006-02-22 09:50:03.0 -0800 +++ netdev-2.6/drivers/net/skge.c 2

[PATCH 3/3] skge: protect interrupt mask

2006-02-22 Thread Stephen Hemminger
There is a race between updating the irq mask and setting it which can be triggered on SMP with a bad cable. Similar patch from Ingo Molnar and Thomas Gleixner Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- netdev-2.6.orig/drivers/net/skge.c 2006-02-22 09:50:37.0 -0800 +++ n

[PATCH 1/3] skge: NAPI/irq race fix

2006-02-22 Thread Stephen Hemminger
Fix a race in the receive NAPI, irq handling. The interrupt clear and the start need to be separated. Otherwise there is a window between the last frame received and the NAPI done level handling. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- netdev-2.6.orig/drivers/net/skge.c 2006-0

[PATCH 0/3] skge: patches for 2.6.16

2006-02-22 Thread Stephen Hemminger
Bug fix patches to skge driver that need to go in 2.6.16. Some of them are in -mm and some have already been sent (and ignored). - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordo

Re: pktgen + napi == kaboom

2006-02-22 Thread Ben Greear
Robert Olsson wrote: Simon Kirby writes: > Just tried to do some benchmarks for outgoing packet rates with the > e1000 and tg3. When I tried some vlan tagging with pktgen, it blew > up immediately: Hello! No pktgen has no support vlan as-is .Guess there should be some config option to

Re: pktgen + napi == kaboom

2006-02-22 Thread Ben Greear
Simon Kirby wrote: 2.6.15.4: Just tried to do some benchmarks for outgoing packet rates with the e1000 and tg3. When I tried some vlan tagging with pktgen, it blew up immediately: For VLANs, make sure that the 'multi-skb' is always zero. This is because the VLAN code modifies the skb by re-a

Re: [PATCH] pktgen: fix races between control/worker threads

2006-02-22 Thread Robert Olsson
Jesse Brandeburg writes: > > I looked quickly at this on a couple different machines and wasn't > able to reproduce, so don't let me block the patch. I think its a > good patch FWIW OK! We ask Deve to apply it. Cheers. --ro - To unsubscribe from

Re: Buglet in iproute2?

2006-02-22 Thread Jean Tourrilhes
Joerg wrote : > Hello all, > reading the sources of iproute2-2.6.15-060110 I found something that > actually might be a buglet. In libnetlink.c, function rtnl_talk is the > following piece of code: > > 303:if (nladdr.nl_pid != peer || > 304:h->nlmsg_pid != rtnl->local

[PATCH] [IPV6]: Ensure to join all-routers multicast address.

2006-02-22 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. If net.ipv6.conf.default.forwarding is !0 when bringing up the interface, we failed to join all routers multicast address, while we join/leave if we enable/disable net.ipv6.conf.ethX.forwarding later. This is inconsistent because we assume that we join all routers multicast if and only if

Re: [PATCH] Allow kfree_skb to be called with a NULL argument

2006-02-22 Thread Michael Buesch
On Wednesday 22 February 2006 18:52, you wrote: > On Wed, 22 February 2006 18:44:33 +0100, Michael Buesch wrote: > > On Wednesday 22 February 2006 09:26, you wrote: > > > Fairly trivial. The extra conditional should get optimized away with > > > current code. But it also allows to walk through ne

Re: [PATCH] Allow kfree_skb to be called with a NULL argument

2006-02-22 Thread Jörn Engel
On Wed, 22 February 2006 18:44:33 +0100, Michael Buesch wrote: > On Wednesday 22 February 2006 09:26, you wrote: > > Fairly trivial. The extra conditional should get optimized away with > > current code. But it also allows to walk through network drivers and > > get rid of the permanent > > i

Re: [PATCH] Allow kfree_skb to be called with a NULL argument

2006-02-22 Thread Michael Buesch
On Wednesday 22 February 2006 09:26, you wrote: > Fairly trivial. The extra conditional should get optimized away with > current code. But it also allows to walk through network drivers and > get rid of the permanent > if (skb) > kfree(skb); > conditionals. I am all for this

Re: [PATCH] pktgen: fix races between control/worker threads

2006-02-22 Thread Jesse Brandeburg
On 2/17/06, Robert Olsson <[EMAIL PROTECTED]> wrote: > > Arthur Kepner writes: > > Tanks. These races should be cured now I've tested a some runs and > it works but I didn't see any problems before either. We'll hear from > Jesse if this cured his problems. I looked quickly at this on a couple

Re: [PATCH] tg3: netif_carrier_off runs too early; could still be queued when init fails

2006-02-22 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michael Chan wrote: > On Tue, 2006-02-21 at 17:41 -0500, Jeff Mahoney wrote: > >> dmesg after modprobe tg3: >> tg3.c:v3.49 (Feb 2, 2006) >> ACPI: PCI Interrupt :0a:02.0[A] -> GSI 24 (level, low) -> IRQ 201 >> Uhhuh. NMI received for unknown reason

Problem with Ipsec transport mode over NAT

2006-02-22 Thread Chinh Nguyen
I believe there is a bug with TCP traffic encrypted in Transport Mode over NAT (ie. UDP-encap ESP). I sent a message to the netfilter-devel list and someone suggested that I post to netdev. Here are my messages. Thanks. Original Message Subject: Understanding Netfilter and IPSe

Re: no carrier detection after resume from swsusp (8139too)

2006-02-22 Thread Robert Love
On Wed, 2006-02-22 at 16:12 +0100, Nikolaus Filus wrote: > I didn't look enough on this issue before. > > After resume, I get "invalid argument" from > /sys/class/net/eth1/carrier. Reloading the driver *OR* restarting > networkmanager solves the problem! Is it possible a process like nm blocks >

Re: no carrier detection after resume from swsusp (8139too)

2006-02-22 Thread Nikolaus Filus
Cc: networkamanger-list, as it seems now to be related to nm On Wednesday 22 February 2006 00:49, Francois Romieu wrote: > (owner of http://bugzilla.kernel.org/show_bug.cgi?id=5681 Cc:ed) > > Nikolaus Filus <[EMAIL PROTECTED]> : > [...] > > > I'm using linux 2.6.14.3 with swsusp2 2.2rc14 (not the

Re: From: Carlos Mart??n <[EMAIL PROTECTED]>

2006-02-22 Thread Carlos Martín
On Wednesday 22 February 2006 15:36, Christoph Hellwig wrote: > On Tue, Feb 21, 2006 at 10:03:58PM +0100, Carlos Mart?n wrote: > > > The important bit is that you need the pointers with the above module > > > spit, because you can't call usb- or pci-specific routines from > > > acx-common.ko > >

Re: From: Carlos Mart??n <[EMAIL PROTECTED]>

2006-02-22 Thread Christoph Hellwig
On Tue, Feb 21, 2006 at 10:03:58PM +0100, Carlos Mart?n wrote: > > The important bit is that you need the pointers with the above module > > spit, because you can't call usb- or pci-specific routines from > > acx-common.ko > > Yes, I realise that (unless you export them, but I don't think we wan

Re: [PATCH UPDATE netdev-2.6.git] bonding: suppress duplicate packets

2006-02-22 Thread Arnaldo Carvalho de Melo
On 2/21/06, Jay Vosburgh <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > >On Tue, 21 Feb 2006 16:36:44 -0800 > >Jay Vosburgh <[EMAIL PROTECTED]> wrote: > [...] > >> +if (dev->master->priv_flags & IFF_MASTER_8023AD && > >> +sk

fib_trie stats fix [PATCH]

2006-02-22 Thread Robert Olsson
fib_triestats has been buggy and caused oopses some platforms as openwrt. The patch below should cure those problems. Cheers. --ro Signed-off-by: Robert Olsson <[EMAIL PROTECTED]> --- linux-2.6.16-rc4/net/ipv4/fib_trie.c.061021 2006-02-21 22:22

fib_trie initialzation fix [PATCH]

2006-02-22 Thread Robert Olsson
Hello! In some kernel configs /proc functions seems to be accessed before the trie is initialized. The patch below checks for this. Cheers. --ro Signed-off-by: Robert Olsson <[EMAIL PROTECTED]> --- linux-2.6.16-rc4/net/ipv4/fib_trie.c.orig 2006-02

Re: XFRM_STATE_NOPMTUDISC, was : MTU/DF problem with 2.6

2006-02-22 Thread Herbert Xu
On Wed, Feb 22, 2006 at 10:39:03AM +0200, Ilia Sotnikov wrote: > On 2/21/06, Herbert Xu <[EMAIL PROTECTED]> wrote: > > Actually, here is a better patch for your problem. We should really > > be using the TOS when doing IPsec lookups: > > > > [IPSEC] Use TOS when doing tunnel lookups > > > > We sho

Re: no carrier detection after resume from swsusp (8139too)

2006-02-22 Thread Pierre Ossman
Francois Romieu wrote: > > http://bugzilla.kernel.org/show_bug.cgi?id=5681 suggests that > suspend/resume support is broken in 8139cp but I have some > code to test (see above). > Seems to solve the problem. Good work! :) Once this gets merged then Andrew should drop the hack that's in -mm. R

Buglet in iproute2?

2006-02-22 Thread jpo234
Hello all, reading the sources of iproute2-2.6.15-060110 I found something that actually might be a buglet. In libnetlink.c, function rtnl_talk is the following piece of code: 303:if (nladdr.nl_pid != peer || 304:h->nlmsg_pid != rtnl->local.nl_pid || 305:

Re: no carrier detection after resume from swsusp (8139too)

2006-02-22 Thread Nikolaus Filus
On Wednesday 22 February 2006 00:49, Francois Romieu wrote: > (owner of http://bugzilla.kernel.org/show_bug.cgi?id=5681 Cc:ed) > Nikolaus Filus <[EMAIL PROTECTED]> : > [...] > > > I'm using linux 2.6.14.3 with swsusp2 2.2rc14 (not the most new > > ones). Since I'm using NetworkManager, which switc

Re: Valid 802.11 channels

2006-02-22 Thread Mathieu Chouquet-Stringer
[EMAIL PROTECTED] (Ulrich Kunitz) writes: > BTW > > France10 - 13 Dunno about Spain but for France it's been 1-13 since 2003 with the following limits though: - inside: limited to 100mW - outside: 100mW for channels 1 to 9 and 10mW for 10 to 13 -- Mathieu Chouquet-Stringer "L

Re: XFRM_STATE_NOPMTUDISC, was : MTU/DF problem with 2.6

2006-02-22 Thread Ilia Sotnikov
On 2/21/06, Herbert Xu <[EMAIL PROTECTED]> wrote: > Actually, here is a better patch for your problem. We should really > be using the TOS when doing IPsec lookups: > > [IPSEC] Use TOS when doing tunnel lookups > > We should use the TOS because it's one of the routing keys. It also > means that w

[RFC] Some infrastructure for interrupt-less TX

2006-02-22 Thread Jörn Engel
Below patch wasn't even compile tested. I'm not involved with network drivers anymore, so my personal interest is fairly low. But since I firmly believe in the advantages and feasibility of interrupt-less TX, there should at least be an ugly broken patch to flame about. Go for it, tell me how st

Re: XFRM_STATE_NOPMTUDISC, was : MTU/DF problem with 2.6

2006-02-22 Thread Ilia Sotnikov
On 2/21/06, Beschorner Daniel <[EMAIL PROTECTED]> wrote: > Thanks to Herbert & Ilia (You mentioned your patch on the Openswan list, I > should have tried earlier)! > > Results after a quick test: Ilia's patch works for me, Herbert's doesn't. > Thanks, Daniel! I hope that the patch will be included

[PATCH] Allow kfree_skb to be called with a NULL argument

2006-02-22 Thread Jörn Engel
Fairly trivial. The extra conditional should get optimized away with current code. But it also allows to walk through network drivers and get rid of the permanent if (skb) kfree(skb); conditionals. Jörn -- Unless something dramatically changes, by 2015 we'll be largely