On Thu, 23 February 2006 12:17:14 +1100, Herbert Xu wrote: > J?rn Engel <[EMAIL PROTECTED]> wrote: > > Fairly trivial. The extra conditional should get optimized away with > > current code. But it also allows to walk through network drivers and > > get rid of the permanent > > if (skb) > > kfree(skb); > > conditionals. > > This is bad because it hides bugs. In places where skb should never be > NULL you've just made it silently ignore what should be a fatal error.
How is that argument special for kfree_skb? Both libc free and kfree ignore NULL arguments and do so for good reasons. Jörn -- "Translations are and will always be problematic. They inflict violence upon two languages." (translation from German) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
