On 2/21/06, Jay Vosburgh <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > >On Tue, 21 Feb 2006 16:36:44 -0800 > >Jay Vosburgh <[EMAIL PROTECTED]> wrote: > [...] > >> + if (dev->master->priv_flags & IFF_MASTER_8023AD && > >> + skb->protocol == __constant_htons(ETH_P_SLOW)) > > > >Don't use the __constant_htons() form except in initialized tables and > >switch statements. > > Why not? Isn't the __constant_xxx form for use with constants? > I don't see any usage guidelines in the obvious places (Documentation/, > google, etc).
Well, both __constant_xtox(constant) and xtox(constant) produces the exact same code last time I checked, so using xtox(constant) is shorter, more clear. - Arnaldo - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
