From: Dave Jones <[EMAIL PROTECTED]>
Date: Wed, 14 Dec 2005 00:37:08 -0500
> drivers/net/skge.ko needs unknown symbol netif_stopped
it's a typo, it should be netif_queue_stopped(). :-/
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED
On Mon, Dec 12, 2005 at 09:59:30PM -0800, Linux Kernel wrote:
> tree 987cfbd2134b82bea55c55fa17bd70d29df70458
> parent 0e670506668a43e1355b8f10c33d081a676bd521
> author Stephen Hemminger <[EMAIL PROTECTED]> Wed, 07 Dec 2005 07:01:49 -0800
> committer Jeff Garzik <[EMAIL PROTECTED]> Tue, 13 Dec
In article <[EMAIL PROTECTED]> (at Tue, 13 Dec 2005 20:57:42 -0800 (PST)),
"David S. Miller" <[EMAIL PROTECTED]> says:
> From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]>
> Date: Wed, 14 Dec 2005 13:03:55 +0900 (JST)
>
> > BTW, will you please capitalize labels in enums?
>
> Andi suggested using func
From: "Michael Chan" <[EMAIL PROTECTED]>
Date: Tue, 13 Dec 2005 15:15:35 -0800
> Yes. But add the following as well:
>
> --- a/drivers/net/tg3.c 2005-12-13 14:28:05.0 -0800
> +++ b/drivers/net/tg3.c 2005-12-13 14:27:31.0 -0800
> @@ -9909,9 +9909,11 @@ static int __devi
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]>
Date: Wed, 14 Dec 2005 13:03:55 +0900 (JST)
> BTW, will you please capitalize labels in enums?
Andi suggested using function pointer, which means no need
for the silly enumeration. So maybe the following, which
implements it that way, is the best.
dif
In article <[EMAIL PROTECTED]> (at Tue, 13 Dec 2005 18:20:08 -0800 (PST)),
"David S. Miller" <[EMAIL PROTECTED]> says:
> So what I've done is move these operations into base context using
> workqueues. Packet initiated events simply schedule a workqueue
> event, and the actual processing occurs
From: Andi Kleen <[EMAIL PROTECTED]>
Date: Wed, 14 Dec 2005 04:01:12 +0100
> > Comments?
>
> Wouldn't it be cleaner to pass function pointers instead
> of all these switches?
The arguments are different, but yeah we could do that.
-
To unsubscribe from this list: send the line "unsubscribe netd
> Comments?
Wouldn't it be cleaner to pass function pointers instead
of all these switches?
-Andi
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
As many of you have noticed I've been working on cleanups
and simplifications to net/ipv6/addrconf.c so that we can
move over to RCU locking for the inet6_dev management of
the IPV6 stack.
The following patch implements a major hurdle in implementing such
changes. Unlike ipv4, ipv6 can have devi
On Tue, 2005-12-13 at 16:10 -0800, David S. Miller wrote:
> Like this?
>
> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
> index be1f30a..eadc0c3 100644
> --- a/drivers/net/tg3.c
> +++ b/drivers/net/tg3.c
> @@ -4368,6 +4368,9 @@ static int tg3_chip_reset(struct tg3 *tp
>
> udelay(120
From: "Michael Chan" <[EMAIL PROTECTED]>
Date: Tue, 13 Dec 2005 14:19:40 -0800
> Yes, your patch looks cleaner but will require additional changes.
> Sometimes, we get the lock just before chip reset and we don't release
> it because the reset automatically releases it. We'll have to reset the
> l
On Tue, 2005-12-13 at 15:45 -0800, David S. Miller wrote:
> From: "Michael Chan" <[EMAIL PROTECTED]>
> Date: Tue, 13 Dec 2005 13:37:25 -0800
>
> > Fix nvram arbitration bugs. The nvram arbitration rules were not
> > strictly followed in a few places and this could lead to reading
> > corrupted val
From: "Michael Chan" <[EMAIL PROTECTED]>
Date: Tue, 13 Dec 2005 13:39:38 -0800
> Fix the following bugs in tg3_set_power_state():
>
> 1. Both WOL and ASF flags require switching to aux power.
>
> 2. Add a missing handshake with firmware to enable WOL.
>
> 3. Turn off the PHY if both WOL and ASF
From: "Michael Chan" <[EMAIL PROTECTED]>
Date: Tue, 13 Dec 2005 13:39:01 -0800
> Fix tg3_suspend() and tg3_resume() by clearing and setting the
> TG3_FLAG_INIT_COMPLETE flag when appropriate. tg3_set_power_state()
> looks at TG3_FLAG_INIT_COMPLETE on the peer device to determine
> when to appropri
From: "Michael Chan" <[EMAIL PROTECTED]>
Date: Tue, 13 Dec 2005 13:38:19 -0800
> If the dual-port 5704 is configured as a single-port device with
> only one PCI function, it would trigger a BUG() condition in
> tg3_find_5704_peer(). This fixes the problem by returning its
> own pdev if the peer ca
From: "Michael Chan" <[EMAIL PROTECTED]>
Date: Tue, 13 Dec 2005 13:37:25 -0800
> Fix nvram arbitration bugs. The nvram arbitration rules were not
> strictly followed in a few places and this could lead to reading
> corrupted values from the nvram.
>
> Signed-off-by: Michael Chan <[EMAIL PROTECTED
Fix the following bugs in tg3_set_power_state():
1. Both WOL and ASF flags require switching to aux power.
2. Add a missing handshake with firmware to enable WOL.
3. Turn off the PHY if both WOL and ASF are disabled.
4. Add nvram arbitration before halting the firmware.
5. Fix tg3_setup_copper
Fix nvram arbitration bugs. The nvram arbitration rules were not
strictly followed in a few places and this could lead to reading
corrupted values from the nvram.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 47bd4a3..dabc39b 100644
---
On Mon, Dec 12, 2005 at 07:25:20PM -0500, Jeff Garzik wrote:
> Was it updated per the comments you received on the first posting?
I think I addressed everything, yes.
--
"You grabbed my hand and we fell into it, like a daydream - or a fever."
signature.asc
Description: Digital signature
On 12/13/05, Benjamin LaHaise <[EMAIL PROTECTED]> wrote:
> Hello Christoph,
>
> On Tue, Dec 13, 2005 at 07:29:36PM +0100, Christoph Hellwig wrote:
> > Mid-term I plan to restructure the file_operations so that we don't need
> > to have all these duplicate aio and vectored versions. This patch is
>
Looks like jeff touched is_multicast_addr last.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
I'm (easily) confused.
Unless the specs have changed recently, the broadcast address of all 1's
is just a special type of multicast adddress, that "all stations shall be
able to recognize".
In looking at the code in etherdevice.h it looks like the test of
is_multicast_ether_addr() is broken, beca
Since BICTCP_SRTT is a fixed number (0.1 second), we can further
simplify the patch as follows.
First, remove
+#define BICTCP_SRTT ((HZ << 3)/10) /* BIC is now RTT independent */
Next, replace
+ return cubic_root((cube_factor * dist) >> (cube_scale + 3 - BICTCP_HZ));
with
+ return cubic_root(c
On Tue, 2005-13-12 at 10:32 -0800, Jesse Brandeburg wrote:
> To help allay your concerns, someone in our lab is going to test routing
> between two ports on some older server hardware (<1Ghz Pentium 3 class)
> today. I hope to have some results by tomorrow.
>
that would be great.
> In our be
On Tue, Dec 13, 2005 at 01:43:23PM -0500, Benjamin LaHaise wrote:
> Hello Christoph,
>
> On Tue, Dec 13, 2005 at 07:29:36PM +0100, Christoph Hellwig wrote:
> > Mid-term I plan to restructure the file_operations so that we don't need
> > to have all these duplicate aio and vectored versions. This
Hello Christoph,
On Tue, Dec 13, 2005 at 07:29:36PM +0100, Christoph Hellwig wrote:
> Mid-term I plan to restructure the file_operations so that we don't need
> to have all these duplicate aio and vectored versions. This patch is
> a small step in that direction but also a worthwile cleanup on it
Mid-term I plan to restructure the file_operations so that we don't need
to have all these duplicate aio and vectored versions. This patch is
a small step in that direction but also a worthwile cleanup on it's own:
(1) introduce a alloc_sock_iocb helper that encapsulates allocating a
proper s
On Tue, 13 Dec 2005, jamal wrote:
On Mon, 2005-12-12 at 20:38 +0100, Robert Olsson wrote:
> jamal writes:
> > Robert, what about just #1? Maybe thats the best compromise that would
> > work for all.
>
> I've tried that before with flow test and got contribution from #2
>
> 0 prefetch 756 kpps
On Tue, 13 Dec 2005 11:45, Stephen Hemminger wrote:
> On Mon, 12 Dec 2005 18:56:49 -0600
>
> Michael Ellerman <[EMAIL PROTECTED]> wrote:
> > Since a5fe736eaf9bae1b45317313de04b564441b94f2 (2.6.13-rc1 ish),
> > is_valid_ether_addr() has been broken, because its assumption that
> > FF:FF:FF:FF:FF:FF
On Tue, 13 Dec 2005 18:59:30 +0100
Christian Borntraeger <[EMAIL PROTECTED]> wrote:
> On Tuesday 13 December 2005 18:47, Stephen Hemminger wrote:
> > Is there any chance of removing usage of netif_rx_reschedule()?
> > qeth seems to be the only remaining user of this interface.
>
> Huh?
>
> I gue
On Tuesday 13 December 2005 18:47, Stephen Hemminger wrote:
> Is there any chance of removing usage of netif_rx_reschedule()?
> qeth seems to be the only remaining user of this interface.
Huh?
I guess you are talking about the ibmveth driver for the POWER boxes? qeth
(for zSeries and z9 boxes) c
Is there any chance of removing usage of netif_rx_reschedule()?
qeth seems to be the only remaining user of this interface.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info
On Mon, 12 Dec 2005 18:56:49 -0600
Michael Ellerman <[EMAIL PROTECTED]> wrote:
> Since a5fe736eaf9bae1b45317313de04b564441b94f2 (2.6.13-rc1 ish),
> is_valid_ether_addr() has been broken, because its assumption that
> FF:FF:FF:FF:FF:FF is a multicast address is wrong. Ouch.
>
> Signed-off-by: Mich
Please pull from 'upstream-fixes' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
to receive the following updates:
drivers/net/skge.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Jeff Garzik:
[netdrvr skge] fix build
diff --git a/drivers/net/sk
On Fri, 2005-09-12 at 15:11 -0800, David S. Miller wrote:
> From: jamal <[EMAIL PROTECTED]>
> Date: Fri, 09 Dec 2005 16:30:24 -0500
>
> > indeed sounds interesting until you start hitting clones ;->
> > so dont run a sniffer or do anything of the sort if you want to see
> > some good numbers - oth
On Sun, 2005-11-12 at 23:33 -0800, David S. Miller wrote:
> From: jamal <[EMAIL PROTECTED]>
> Date: Wed, 07 Dec 2005 19:03:17 -0500
>
> > What you in submitting the patch is probably a better approach to break
> > any stalemate. I think its time we need to have Dave and Jeff both
> > involved - we
On Tue, Dec 06, Stephen Hemminger wrote:
> Get rid of warning in case of race with ring full and lockless
> tx on the skge driver. It is possible to be in the transmit
> routine with no available slots and already stopped.
Where do I find that netif_stopped?
--
short story of a lazy sysadmin:
I'm not sure if this is the right list for such a questions..
But still.
Recently we tried to set up an IPSEC tunnel in a branch office
of a large company, using linux (currently 2.6.14). The endpoint
is running some Cisco PIX device. Everything's fine, using any
userspace tools available, excep
On Mon, 2005-12-12 at 22:04 +, Gert Ormel wrote:
> Hello,
>
> I'm sending you the output of dmsg of my sosn's HP nc6220 laptop
> running SuSE 10.0.
> It looks as if his laptop is having thermal management problems
> I don't like the ACPI warnings but they might be harmless, but as
> found
>
On Mon, 2005-12-12 at 20:38 +0100, Robert Olsson wrote:
> jamal writes:
> > Robert, what about just #1? Maybe thats the best compromise that would
> > work for all.
>
> I've tried that before with flow test and got contribution from #2
>
> 0 prefetch 756 kpps
> 1 prefetch 805 kpps (first)
>
Hello,
Please find attached the output of dmesg from an HP nc6220 laptop
With SuSE 10.0 installed. The 'thermal management' of this machine
Is unreliable and I was wondering whether this might be caused by
An ACPI or a kernel bug, or whether the OS is to blame.
My apologies if it turns out to b
-stable review patch. If anyone has any objections, please let us know.
--
From: Thomas Graf <[EMAIL PROTECTED]>
The receive path for fib_lookup netlink messages is lacking sanity
checks for header and payload and is thus vulnerable to malformed
netlink messages causing illegal m
42 matches
Mail list logo
