On Tue, 2005-12-13 at 15:45 -0800, David S. Miller wrote:
> From: "Michael Chan" <[EMAIL PROTECTED]>
> Date: Tue, 13 Dec 2005 13:37:25 -0800
>
> > Fix nvram arbitration bugs. The nvram arbitration rules were not
> > strictly followed in a few places and this could lead to reading
> > corrupted values from the nvram.
> >
> > Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
>
> Why not solve that last case by making tg3_nvram_{lock,unlock}()
> nest properly? Like this:
>
Yes, your patch looks cleaner but will require additional changes.
Sometimes, we get the lock just before chip reset and we don't release
it because the reset automatically releases it. We'll have to reset the
lock_cnt in that case.
Either way is fine because getting the lock a second time without first
releasing it is a no-op.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
