Re: sky2 prints many "hw tcp v4 csum failed"

2005-11-17 Thread Akinobu Mita
On Thu, Nov 17, 2005 at 07:26:22AM -0800, Stephen Hemminger wrote: > On Thu, 17 Nov 2005 20:14:48 +0900 > Akinobu Mita <[EMAIL PROTECTED]> wrote: > > > I'm using sky2 driver on 2.6.14-mm2. > > It works fine, but I got this message repeatedly. > > > > hw tcp v4 csum failed > > > > I can suppress

[2.6 patch] move some code to net/ipx/af_ipx.c

2005-11-17 Thread Adrian Bunk
On Mon, Nov 14, 2005 at 02:57:07AM +0100, Adrian Bunk wrote: > On Fri, Nov 11, 2005 at 02:35:51AM -0600, Matt Mackall wrote: > > trivial: drop unused 802.3 code if we compile without IPX > > > > (originally from http://wohnheim.fh-wedel.de/~joern/software/kernel/je/25/) > > > > Signed-off-by: Mat

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-17 Thread jamal
On Thu, 2005-17-11 at 22:03 -0500, jamal wrote: > > I will attempt some ascii art shortly. Actually if you agree with it > please include it in your patch so it is easier for people to make > changes in the future. > ok, ascii art is hard - instead in pseudo code (please double check with the R

Re: [Orinoco-devel] [2.6 patch] drivers/net/wireless/orinoco.h: "extern inline" -> "static inline"

2005-11-17 Thread Adrian Bunk
On Fri, Nov 18, 2005 at 02:52:36PM +1100, David Gibson wrote: > On Fri, Nov 18, 2005 at 04:33:29AM +0100, Adrian Bunk wrote: > > "extern inline" doesn't make much sense. > > Yes it does. "extern inline" tells gcc not to fall back to out of > line version if it can't inline the function. These fu

Re: [Orinoco-devel] [2.6 patch] drivers/net/wireless/orinoco.h: "extern inline" -> "static inline"

2005-11-17 Thread David Gibson
On Fri, Nov 18, 2005 at 04:33:29AM +0100, Adrian Bunk wrote: > "extern inline" doesn't make much sense. Yes it does. "extern inline" tells gcc not to fall back to out of line version if it can't inline the function. These functions *must* by inlined, or they'll break horribly on Sparc, at least.

[2.6 patch] drivers/net/bonding/bonding.h: "extern inline" -> "static inline"

2005-11-17 Thread Adrian Bunk
"extern inline" doesn't make much sense. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/bonding/bonding.h |8 1 file changed, 4 insertions(+), 4 deletions(-) --- linux-2.6.15-rc1-mm1-full/drivers/net/bonding/bonding.h.old 2005-11-18 02:36:37.0 +0100 +++ l

[2.6 patch] drivers/net/wireless/orinoco.h: "extern inline" -> "static inline"

2005-11-17 Thread Adrian Bunk
"extern inline" doesn't make much sense. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.15-rc1-mm1-full/drivers/net/wireless/orinoco.h.old 2005-11-18 02:38:43.0 +0100

[RFC: 2.6 patch] remove drivers/net/tulip/xircom_tulip_cb.c

2005-11-17 Thread Adrian Bunk
This patch removes the obsolete drivers/net/tulip/xircom_tulip_cb.c driver. Is there any reason why it should be kept? Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/tulip/Kconfig | 16 drivers/net/tulip/Makefile |1 drivers/net/tulip/xircom_tulip_c

[2.6 patch] drivers/net/gianfar.h: "extern inline" -> "static inline"

2005-11-17 Thread Adrian Bunk
"extern inline" doesn't make much sense. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/gianfar.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.15-rc1-mm1-full/drivers/net/gianfar.h.old 2005-11-18 02:38:02.0 +0100 +++ linux-2.6.15-rc1-mm1-

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-17 Thread jamal
On Thu, 2005-17-11 at 21:36 +0100, Stefan Rompf wrote: > Am Donnerstag 17 November 2005 04:29 schrieb jamal: > > > > > 1) There are read_only oper state IFF_XXX flags which are sent via > > > > netlink to user space. These are set by the kernel (and not by user > > > > space); they reflect the sta

Re: [PATCH 2/2] LSM-IPSec Network Hooks

2005-11-17 Thread Trent Jaeger
On Nov 17, 2005, at 8:42 PM, Chris Wright wrote: * Trent Jaeger ([EMAIL PROTECTED]) wrote: Patch with sock callback lock made unconditional. Previous send (earlier today, 11/17) was not the latest patch -- please disregard that patch. Little heavy on KERN_DEBUG printk's. Could you drop t

Re: [PATCH 2/2] LSM-IPSec Network Hooks

2005-11-17 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 18 Nov 2005 12:28:40 +1100 > On Thu, Nov 17, 2005 at 06:42:29PM -0500, Trent Jaeger wrote: > > Patch with sock callback lock made unconditional. Previous send > > (earlier today, 11/17) was not the latest patch -- please disregard > > that patch. >

Re: [PATCH 2/2] LSM-IPSec Network Hooks

2005-11-17 Thread Chris Wright
* Trent Jaeger ([EMAIL PROTECTED]) wrote: > Patch with sock callback lock made unconditional. Previous send > (earlier today, 11/17) was not the latest patch -- please disregard > that patch. Little heavy on KERN_DEBUG printk's. Could you drop them (or perhaps use pr_debug instead)? thanks, -c

Re: [PATCH 2/2] LSM-IPSec Network Hooks

2005-11-17 Thread Herbert Xu
On Thu, Nov 17, 2005 at 06:42:29PM -0500, Trent Jaeger wrote: > Patch with sock callback lock made unconditional. Previous send > (earlier today, 11/17) was not the latest patch -- please disregard > that patch. > > Signed-off-by: Trent Jaeger <[EMAIL PROTECTED]> Looks very good. Thank you Tre

Re: [DEBUG INFO]IPv6: sleeping function called from invalid context.

2005-11-17 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 18 Nov 2005 08:44:27 +0800), Yan Zheng <[EMAIL PROTECTED]> says: > I get follow message when switch to single user mode and the kernel version > is 2.6.15-rc1-git5. : > Nov 18 08:26:23 localhost kernel: Debug: sleeping function called from > invalid conte

[DEBUG INFO]IPv6: sleeping function called from invalid context.

2005-11-17 Thread Yan Zheng
I get follow message when switch to single user mode and the kernel version is 2.6.15-rc1-git5. Regards Nov 18 08:26:23 localhost kernel: Debug: sleeping function called from invalid context at mm/slab.c:2472 Nov 18 08:26:23 localhost kernel: in_atomic():1, irqs_disabled():0 Nov 18 08:26:23 lo

[PATCH 2/2] LSM-IPSec Network Hooks

2005-11-17 Thread Trent Jaeger
Patch with sock callback lock made unconditional. Previous send (earlier today, 11/17) was not the latest patch -- please disregard that patch. Regards, Trent. --- This patch series implements per packet access control via the extension of the Linux Security Modules

Re: [LLC]: Fix TX window scaling

2005-11-17 Thread David S. Miller
From: Olaf Hering <[EMAIL PROTECTED]> Date: Thu, 17 Nov 2005 10:06:36 +0100 > This change causes this: > > net/llc/llc_c_ac.c: In function `llc_conn_ac_inc_npta_value': > net/llc/llc_c_ac.c:998: warning: comparison is always true due to limited > range of data type > net/llc/llc_c_ac.c:999: warn

Re: [BRIDGE]: recompute features after adding new device

2005-11-17 Thread David S. Miller
From: Olaf Rempel <[EMAIL PROTECTED]> Date: Tue, 15 Nov 2005 23:15:31 +0100 > On Tue, 15 Nov 2005 22:53:19 +0100 > Olaf Rempel <[EMAIL PROTECTED]> wrote: > > gnaa, typo. > should be "br" not "br0" Your patch won't apply anyways because your email client changes tab characters into spaces. Pleas

Re: [PATCH 1/1] [NETFILTER] ip_conntrack: fix ftp/irc/tftp helpers on ports >= 32768

2005-11-17 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Tue, 15 Nov 2005 11:03:51 +0100 > [NETFILTER] ip_conntrack: fix ftp/irc/tftp helpers on ports >= 32768 > > Since we've converted the ftp/irc/tftp helpers to use the new > module_parm_array() some time ago, we ware accidentially using signed data > type

Re: [PATCH] TCP highspeed build error

2005-11-17 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 17 Nov 2005 13:01:01 -0800 > There is a compile error that crept in with the last patch of > TCP patches. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> There is no use of "pkts_acked" nor "data_acked" in that hstcp_cong_avoid() fu

[RFC] TCP CUBIC

2005-11-17 Thread Stephen Hemminger
I took your CUBIC patches from your BIC web page and ported them from 2.6.13 to the new stuff in 2.6.15. If anyone wants to look or test see: http://developer.osdl.org/shemminger/patches/2.6.15-cubic/ This adds yet another congestion variant, my graphs will run out of colors soon. - To u

Re: [PATCH] Fix oops in r8169 driver

2005-11-17 Thread Olaf Kirch
On Thu, Nov 17, 2005 at 08:31:07PM +0100, Francois Romieu wrote: > Olaf Kirch <[EMAIL PROTECTED]> : > [...] > > When rtl8169_init_board didn't find the PCI power state > > capability, it would bail out but return 0 (success). > > rtl8169_init_one would then oops trying to dereference > > t

Re: Fw: [BUG] kernel 2.6.14.2 breaks IPSEC

2005-11-17 Thread Herbert Xu
On Thu, Nov 17, 2005 at 09:39:58PM +0100, Charles-Edouard Ruault wrote: > > i just realized i had forgotten to flush my nat tables :( when i > reported it did not change. > I just tried again and i was able to pinpoint that nat is indeed the > problem. > I can have all my other netfilter rules an

[PATCH] TCP highspeed build error

2005-11-17 Thread Stephen Hemminger
There is a compile error that crept in with the last patch of TCP patches. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- tcp-2.6.orig/net/ipv4/tcp_highspeed.c +++ tcp-2.6/net/ipv4/tcp_highspeed.c @@ -111,7 +111,7 @@ static void hstcp_init(struct sock *sk) } static void hstcp_cong_

Re: Fw: [BUG] kernel 2.6.14.2 breaks IPSEC

2005-11-17 Thread Charles-Edouard Ruault
Herbert Xu wrote: Andrew Morton <[EMAIL PROTECTED]> wrote: So far, i've looked into net/ipv4/esp4.c and i can confirm that the correct spi has been selected and inserted into the packet in function esp_output esph->spi = x->id.spi; ( line 97 ). It looks as if the corruption happens later do

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-17 Thread Stefan Rompf
Am Donnerstag 17 November 2005 04:29 schrieb jamal: > > > 1) There are read_only oper state IFF_XXX flags which are sent via > > > netlink to user space. These are set by the kernel (and not by user > > > space); they reflect the state of "link". We can avoid a myriad of new IFF_*-flags if we all

[PATCH] smc91x: fix one source of spurious interrupts

2005-11-17 Thread Nicolas Pitre
Not only SMC_ACK_INT(IM_TX_EMPTY_INT) in in smc_hardware_send_pkt) appears to be unnecessary (tested with an SMC91C94 and SMC91C111), but it seems to trigger spurious interrupts on some machines as well. Removed. While at it, let's log any remaining spurious interrupts if any (and clean usag

Re: [PATCH] Fix oops in r8169 driver

2005-11-17 Thread Francois Romieu
Olaf Kirch <[EMAIL PROTECTED]> : [...] > When rtl8169_init_board didn't find the PCI power state > capability, it would bail out but return 0 (success). > rtl8169_init_one would then oops trying to dereference > the dev pointer which is NULL. And the device is still unusable because rtl81

Re: sky2 prints many "hw tcp v4 csum failed"

2005-11-17 Thread Stephen Hemminger
On Thu, 17 Nov 2005 18:30:07 +0100 Karsten Keil <[EMAIL PROTECTED]> wrote: > On Thu, Nov 17, 2005 at 07:26:22AM -0800, Stephen Hemminger wrote: > > On Thu, 17 Nov 2005 20:14:48 +0900 > > Akinobu Mita <[EMAIL PROTECTED]> wrote: > > > > > I'm using sky2 driver on 2.6.14-mm2. > > > It works fine, bu

Re: TCP burst mitigation in Linux

2005-11-17 Thread Stephen Hemminger
On Thu, 17 Nov 2005 11:41:55 -0500 (EST) Janardhan Iyengar <[EMAIL PROTECTED]> wrote: > > [I am not subscribed to this list, so please Cc me on all responses.] > > Hello all, > > I have a few questions I'd like answers to: > > * Is burst mitigation for TCP is implemented in Linux? By burst >

Re: sky2 prints many "hw tcp v4 csum failed"

2005-11-17 Thread Karsten Keil
On Thu, Nov 17, 2005 at 07:26:22AM -0800, Stephen Hemminger wrote: > On Thu, 17 Nov 2005 20:14:48 +0900 > Akinobu Mita <[EMAIL PROTECTED]> wrote: > > > I'm using sky2 driver on 2.6.14-mm2. > > It works fine, but I got this message repeatedly. > > > > hw tcp v4 csum failed > > > > I can suppress

[PATCH] fix spelling errors in netdev Kconfigs

2005-11-17 Thread Jon Mason
I ran aspell on the Kconfigs in drivers/net/ and found the following spelling errors. Signed-off-by: Jon Mason <[EMAIL PROTECTED]> diff -r 971dbac4c501 drivers/net/Kconfig --- a/drivers/net/Kconfig Wed Nov 16 16:25:28 2005 +++ b/drivers/net/Kconfig Thu Nov 17 08:24:31 2005 @@ -55,7 +5

[PATCH] Fix oops in r8169 driver

2005-11-17 Thread Olaf Kirch
Subject: Fix oops in r8169 driver When rtl8169_init_board didn't find the PCI power state capability, it would bail out but return 0 (success). rtl8169_init_one would then oops trying to dereference the dev pointer which is NULL. Signed-off-by: Olaf Kirch <[EMAIL PROTECTED]> Index: 2

TCP burst mitigation in Linux

2005-11-17 Thread Janardhan Iyengar
[I am not subscribed to this list, so please Cc me on all responses.] Hello all, I have a few questions I'd like answers to: * Is burst mitigation for TCP is implemented in Linux? By burst mitigation, I mean a mechanism to avoid sudden bursts of packets that may (under several plausible circ

Re: 2.6.15-rc1: NET_CLS_U32 not working?

2005-11-17 Thread Christian
Christian schrieb: Adrian Bunk schrieb: I'm assuming you are trying to insert the new module in your old kernel? yes, rebuilding the whole kernel (after just enabling NET_CLS_U32 as a module) makes the warnings go away. This is one of the unfortunate but hardly avoidable cases where adding

Re: sky2 prints many "hw tcp v4 csum failed"

2005-11-17 Thread Stephen Hemminger
On Thu, 17 Nov 2005 20:14:48 +0900 Akinobu Mita <[EMAIL PROTECTED]> wrote: > I'm using sky2 driver on 2.6.14-mm2. > It works fine, but I got this message repeatedly. > > hw tcp v4 csum failed > > I can suppress these messages by > # ethtool -K eth0 tx off rx off > > And, These messages cannot b

Re: [PATCH] [RFT] ip_tables NUMA optimization

2005-11-17 Thread Eric Dumazet
Harald Welte a écrit : I've hand-merged Eric Dumazet's original ip_tables numa optimization patch to current git head. Also, I've ported it to ip6_tables and arp_tables. Since this is 2.6.16 stuff, I don't want to have it applied at this time, but merely request testers (esp. for the non-ipv4 p

[PATCH] [RFT] ip_tables NUMA optimization

2005-11-17 Thread Harald Welte
I've hand-merged Eric Dumazet's original ip_tables numa optimization patch to current git head. Also, I've ported it to ip6_tables and arp_tables. Since this is 2.6.16 stuff, I don't want to have it applied at this time, but merely request testers (esp. for the non-ipv4 part). Thanks, -- - Har

[PATCH 2/2] LSM-IPSec Network Hooks

2005-11-17 Thread Trent Jaeger
Made unconditional the locking of sk_callback_lock when extracting the security structure. PATCH 1/2 unchanged. Regards, Trent. -- This patch series implements per packet access control via the extension of the Linux Security Modules (LSM) interface by hooks in t

sky2 prints many "hw tcp v4 csum failed"

2005-11-17 Thread Akinobu Mita
I'm using sky2 driver on 2.6.14-mm2. It works fine, but I got this message repeatedly. hw tcp v4 csum failed I can suppress these messages by # ethtool -K eth0 tx off rx off And, These messages cannot be seen with sk98lin v8.16.2.3 (on 2.6.14-mm2 with a little changes to build it) Motherboard:

Re: [LLC]: Fix TX window scaling

2005-11-17 Thread Olaf Hering
On Tue, Nov 15, Linux Kernel Mailing List wrote: > tree 574e979829d3363c16c8c6d1fe624b206d8ce4f9 > parent cb422c464bdaeeb3b9ad4539010e357bf1bd1745 > author Jochen Friedrich <[EMAIL PROTECTED]> Tue, 15 Nov 2005 13:57:15 -0800 > committer David S. Miller <[EMAIL PROTECTED]> Tue, 15 Nov 2005 13:57:1