Harald Welte a écrit :
I've hand-merged Eric Dumazet's original ip_tables numa optimization
patch to current git head. Also, I've ported it to ip6_tables and
arp_tables.
Since this is 2.6.16 stuff, I don't want to have it applied at this
time, but merely request testers (esp. for the non-ipv4 part).
Thanks,
Hi Harald
Thank you for doing this, since I'm currently too busy with my day job to
update the patch myself.
However I did read your patch and caught one vfree() call wrongly replaced by
a kfree() call in arp_tables.c
@@ -911,6 +930,47 @@ static int get_entries(const struct arpt
return ret;
}
+static void free_table_info(struct arpt_table_info *info)
+{
+ int cpu;
+ for_each_cpu(cpu) {
+ if (info->size <= PAGE_SIZE)
+ kfree(info->entries[cpu]);
+ else
+ kfree(info->entries[cpu]); !!!!
+ }
+ kfree(info);
It should probably use vfree() like :
> + for_each_cpu(cpu) {
> + if (info->size <= PAGE_SIZE)
> + kfree(info->entries[cpu]);
> + else
> + vfree(info->entries[cpu]);
> + }
See you
Eric Dumazet
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
