question on new skbuff time-stamp code.

2005-11-13 Thread Ben Greear
I don't see how this code (from 2.6.14, skbuff.h) can be correct. Shouldn't we be doing some subtraction against the base time value somewhere? Or maybe just the comment is incorrect? /** * skb_get_timestamp - get timestamp from a skb * @skb: skb to get stamp from * @stamp:

Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-13 Thread jamal
On Sun, 2005-13-11 at 23:38 +0100, Krzysztof Halasa wrote: > jamal <[EMAIL PROTECTED]> writes: [Skipping all L3 issues ..] > > My suggestion to move forward is: > > i) Lets just stick to existing states in the RFC and no innovation of > > any sort. > > This is backwards: > Why is it backwards?

Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-13 Thread jamal
On Mon, 2005-14-11 at 00:43 +0100, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2005-11-13 10:09 > > Issue-1) > > We have agreed to implement based on 2863. > > Stefan has gone one step further and suggested extra states for L3 > > status. The idea for the extra states being to resolve in this

cassini driver and IPv6

2005-11-13 Thread David Monro
Hi, I have a board pulled from a sun box which uses the cassini driver (its the one with 2 cassini chips and a symbios 896 scsi chip behind an intel pci bridge, with copper connections, I think its sun part X4422A). I am using the driver from kernel.org 2.6.14.2. Kernel messages on startup: cass

Re: [PATCH 6/15] misc: Trim non-IPX builds

2005-11-13 Thread Adrian Bunk
On Fri, Nov 11, 2005 at 02:35:51AM -0600, Matt Mackall wrote: > trivial: drop unused 802.3 code if we compile without IPX > > (originally from http://wohnheim.fh-wedel.de/~joern/software/kernel/je/25/) > > Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> > > Index: tiny/net/802/Makefile > ===

Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-13 Thread Krzysztof Halasa
Thomas Graf <[EMAIL PROTECTED]> writes: > What has been proposed so far is a stupid hack around something broken > in userspace. Not sure. Ignoring routes going though failed interfaces doesn't seem like a hack at all. > What are you going to do when you need to overwrite a route while the > int

Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-13 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2005-11-13 10:09 > Issue-1) > We have agreed to implement based on 2863. > Stefan has gone one step further and suggested extra states for L3 > status. The idea for the extra states being to resolve in this fix old > standing issue (since 2.2 days) of higher metric rout

Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-13 Thread Krzysztof Halasa
jamal <[EMAIL PROTECTED]> writes: > a) one that depends on the L3* states that goes around and marks every > route as "inactive". What "inactive" means is still unclear; it could > just be to add a blackhole route. Stefan and Krzysztof main proponents. Blackhole is different, packets get simply

[PATCH 8/10] [NETFILTER] fix type of sysctl variables in nf_conntrack_ipv6

2005-11-13 Thread Harald Welte
[NETFILTER] fix type of sysctl variables in nf_conntrack_ipv6 These variables should be unsigned. This fixes sysctl handler for nf_ct_frag6_{low,high}_thresh. Signed-off-by: Yasuyuki Kozakai <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> --- commit 55022977d3917fb573ad60cad

[PATCH 7/10] [NETFILTER]: cleanup IPv6 Netfilter Kconfig

2005-11-13 Thread Harald Welte
[NETFILTER]: cleanup IPv6 Netfilter Kconfig This removes linux 2.4 configs in comments as TODO lists. And this also move the entry of nf_conntrack to top like IPv4 Netfilter Kconfig. Based on original patch by Krzysztof Piotr Oledzki <[EMAIL PROTECTED]>. Signed-off-by: Yasuyuki Kozakai <[EMAIL P

[PATCH 5/10] [NETFILTER] nfnetlink: unconditionally require CAP_NET_ADMIN

2005-11-13 Thread Harald Welte
[NETFILTER] nfnetlink: unconditionally require CAP_NET_ADMIN This patch unconditionally requires CAP_NET_ADMIN for all nfnetlink mesages. It also removes the per-message cap_required field, since all existing subsystems use CAP_NET_ADMIN for all their messages anyway. Patrick McHardy owes me a b

[PATCH 3/10] [NETFILTER] ctnetlink: More thorough size checking of attributes

2005-11-13 Thread Harald Welte
[NETFILTER] ctnetlink: More thorough size checking of attributes Add missing size checks. Thanks Patrick McHardy for the hint. Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> --- commit 78496d0ef63df77e59096a9cbdfa264e9ddc75d9 tree 7c0590c7545

[PATCH 2/10] [NETFILTER] nfnetlink: skip size check if size not specified (== 0)

2005-11-13 Thread Harald Welte
[NETFILTER] nfnetlink: skip size check if size not specified (== 0) Skip sizecheck if the size of the attribute wasn't specified, ie. zero. Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> --- commit 2c6f159b30802fc23360dc80810cc47128c54a95 tre

[PATCH 6/10] [NETFILTER]: link 'netfilter' before ipv4

2005-11-13 Thread Harald Welte
[NETFILTER]: link 'netfilter' before ipv4 Staticaly linked nf_conntrack_ipv4 requires nf_conntrack. but currently nf_conntrack is linked after it. This changes the order of ipv4 and netfilter to fix this. Signed-off-by: Krzysztof Oledzki <[EMAIL PROTECTED]> Signed-off-by: Yasuyuki Kozakai <[EMAIL

[PATCH 1/10] [NETFILTER] ctnetlink: use size_t to make gcc-4.x happy

2005-11-13 Thread Harald Welte
[NETFILTER] ctnetlink: use size_t to make gcc-4.x happy Make gcc-4.x happy. Use size_t instead of int. Thanks to Patrick McHardy for the hint. Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]> Signed-off-by: Harald Welte <[EMAIL PROTECTED]> --- commit 2e09968d59b232b96bc95c091e70ccfabf07ea30

[PATCH 4/10] [NETFILTER] nf_conntrack: Add missing code to TCP conntrack module

2005-11-13 Thread Harald Welte
[NETFILTER] nf_conntrack: Add missing code to TCP conntrack module Looks like the nf_conntrack TCP code was slightly mismerged: it does not contain an else branch present in the IPv4 version. Let's add that code and make the testsuite happy. Signed-off-by: KOVACS Krisztian <[EMAIL PROTECTED]> Sig

[PATCH 10/10] [NETFILTER] fix leak of fragment queue at unloading nf_conntrack_ipv6

2005-11-13 Thread Harald Welte
[NETFILTER] fix leak of fragment queue at unloading nf_conntrack_ipv6 This patch makes nf_conntrack_ipv6 free all IPv6 fragment queues at module unloading time. Also introduce a BUG_ON if we ever again have leaks in the memory accounting. Signed-off-by: Yasuyuki Kozakai <[EMAIL PROTECTED]> Signe

[PATCH 9/10] [NETFILTER] nf_conntrack: fix possibility of infinite loop while evicting nf_ct_frag6_queue

2005-11-13 Thread Harald Welte
[NETFILTER] nf_conntrack: fix possibility of infinite loop while evicting nf_ct_frag6_queue This synchronizes nf_ct_reasm with ipv6 reassembly, and fixes a possibility of an infinite loop if CPUs evict and create nf_ct_frag6_queue in parallel. Signed-off-by: Yasuyuki Kozakai <[EMAIL PROTECTED]>

Pull request for upstream-jgarzik branch of netdev-jwl

2005-11-13 Thread John W. Linville
A collection of minor changes, mostly bug fixes. This also includes Adrian's hostap.c rename to hostap_main.c (acked by Jouni). I went ahead and pulled-in my e1000 changes and my fec_8xx Kconfig change. I don't think they are controversial. (I copied the e1000 guys on those patches, and they di

Pull request for bonding-sysfs branch of netdev-jwl

2005-11-13 Thread John W. Linville
Jeff, These are the sysfs changes for the bonding driver. I put them in a separate branch for a couple of reasons. For one, I had to massage a few of the patches, and some of them had fuzz. So, it would be good for Mitch and/or Jay to double-check the merge. Also, I thought this might be a lit

[TCP|BUG] Missing packet or sequence number failure?

2005-11-13 Thread Ludo Stellingwerff
Hi all, Problem description: Remote access through ssh results in a locked-up tcp-session. Version: 2.6.14.2 + imq-patches + routes-patches(Julian's) Kernel config attached. When connecting to a linux 2.6.14.2 server through ssh, the session starts okay, but after a while the session gets stuck.

Re: [PATCH] Remove drivers/net/gt64240eth.h

2005-11-13 Thread Ralf Baechle
On Sat, Nov 12, 2005 at 05:49:04PM -0500, Chuck Meade wrote: > It is included and used in drivers/net/gt64240eth.c in the linux-mips > git tree. I'm not sure what git tree you are intending to remove this > file from, but it is used/needed in the linux-mips world, and the > gt64240 is for MIPS sy

Re: [2.6 patch] rename hostap.c to hostap_main.c

2005-11-13 Thread Sam Ravnborg
> > AFAIK you can't build a module hostap.o consisting of multiple objects > with the source files of one of them named hostap.c (Sam Cc'ed for this). Correct. Sam - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majo

Re: [RFT] pcnet32: support for boards with multiple phys

2005-11-13 Thread John W. Linville
On Sun, Nov 13, 2005 at 02:26:58PM +0100, Thomas Bogendoerfer wrote: > On Sat, Nov 12, 2005 at 10:15:23PM -0500, John W. Linville wrote: > > Is it necessary to maintain special cases for the single-PHY > > configurations? What would be the effect of folding the single-PHY > > situation into the m

Re: [2.6 patch] rename hostap.c to hostap_main.c

2005-11-13 Thread Jouni Malinen
On Sun, Nov 13, 2005 at 05:27:45PM +0100, Adrian Bunk wrote: > There's no other change. > > If you agree, Jeff might be able to do the > > mv drivers/net/wireless/hostap/hostap.c \ > drivers/net/wireless/hostap/hostap_main.c > > plus applying the patch below. OK, I'm okay with that chang

[2.6 patch] rename hostap.c to hostap_main.c

2005-11-13 Thread Adrian Bunk
On Sat, Nov 05, 2005 at 08:15:43PM -0800, Jouni Malinen wrote: > On Sun, Nov 06, 2005 at 01:53:43AM +0100, Adrian Bunk wrote: > > I wanted to remove the #include "hostap_ioctl.c" from hostap.c and build > > hostap_ioctl.c separately, but this doesn't work since hostap.c has the > > same name as t

Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-13 Thread jamal
On Sun, 2005-13-11 at 16:47 +0100, Stefan Rompf wrote: > Am Sonntag 13 November 2005 16:09 schrieb jamal: > > > I think the discussions have been valuable despite the time they took. > > This is just to bring us back to not go on a tangent and hopefully close > > this sooner. > > thanks for takin

Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-13 Thread Stefan Rompf
Am Sonntag 13 November 2005 16:09 schrieb jamal: > I think the discussions have been valuable despite the time they took. > This is just to bring us back to not go on a tangent and hopefully close > this sooner. thanks for taking the time to moderate this. > We have agreed to implement based on

Re: Consensus? WAS(RFC 2863)

2005-11-13 Thread jamal
Stefan, I am not gonna comment on this email although it is tempting. Can you refer to my latest email and see if we can reach some closure? cheers, jamal On Sun, 2005-13-11 at 16:01 +0100, Stefan Rompf wrote: > Am Sonntag 13 November 2005 15:13 schrieb jamal: > > > > Obviously, no. I mean rout

Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-13 Thread jamal
I think the discussions have been valuable despite the time they took. This is just to bring us back to not go on a tangent and hopefully close this sooner. There are two main outstanding issues as i see it: Issue-1) We have agreed to implement based on 2863. Stefan has gone one step further a

Re: Consensus? WAS(RFC 2863)

2005-11-13 Thread Stefan Rompf
Am Sonntag 13 November 2005 15:13 schrieb jamal: > > Obviously, no. I mean route entry "inactive" flag (not existing yet) > > which has exactly nothing to do with its destination. > > I dont know what that would buy you that a blackhole route could not > give you: Packets will be dropped at the ip

Re: [RFT] pcnet32: support for boards with multiple phys

2005-11-13 Thread Thomas Bogendoerfer
On Sat, Nov 12, 2005 at 10:15:23PM -0500, John W. Linville wrote: > On Tue, Nov 08, 2005 at 11:43:54AM -0800, Don Fry wrote: > > This patch contains code from Thomas Bogendoerfer which I have modified > > somewhat. It works fine for me in my testing, but I would like > > additional exposure to thi

Re: Consensus? WAS(RFC 2863)

2005-11-13 Thread jamal
On Sun, 2005-13-11 at 00:04 +0100, Krzysztof Halasa wrote: > Jamal Hadi Salim <[EMAIL PROTECTED]> writes: > > > Issue 1: > > 1) There are routes that are added by the kernel. These are labelled as > > being added by the kernel. > > 2) Others maybe added by a dynamic routing daemon and these would

[PATCH 1/2] atmel: CodingStyle cleanup

2005-11-13 Thread Alexey Dobriyan
From: Carlo Perassi <[EMAIL PROTECTED]> Reading this driver I noticed some trailing whitespaces and tabs so I removed them with some 80th column fitting and a few more similar things. Signed-off-by: Carlo Perassi <[EMAIL PROTECTED]> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- drivers