Re: RFR: 8356632: Fix remaining {@link/@linkplain} tags with refer to private/protected types in java.base [v3]

2025-05-23 Thread Nizar Benalla
> Please review this patch to fix some `javadoc` bugs in `java.base`. > Certain `@link` tags used to refer to private fields instead of public APIs. > > A couple of `@see` tags in the [serialization > page](https://download.java.net/java/early_access/jdk25/docs/api/serialized-form.html#java.lang.

Re: RFR: 8356632: Fix remaining {@link/@linkplain} tags with refer to private/protected types in java.base [v3]

2025-05-23 Thread Weijun Wang
On Fri, 23 May 2025 14:59:07 GMT, Nizar Benalla wrote: >> Please review this patch to fix some `javadoc` bugs in `java.base`. >> Certain `@link` tags used to refer to private fields instead of public APIs. >> >> A couple of `@see` tags in the [serialization >> page](https://download.java.net/ja

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v4]

2025-05-23 Thread Mark Sheppard
On Fri, 23 May 2025 09:57:02 GMT, Daniel Fuchs wrote: > > If I have read the original code correctly there is a flaw in it, that is > > the startExchange is never called. > > @msheppar what do you mean by that? It's called in > [ExchangeImpl.java](https://github.com/openjdk/jdk/blob/68ee06f0c9

RFR: 8357639: DigestEchoClient fails intermittently due to: java.io.IOException: Data received while in pool

2025-05-23 Thread Daniel Fuchs
The java/net/httpclient/DigestEchoClient.java fails intemittently with IOException: HTTP/1.1 header parser received no bytes. Analysis shows that this is caused by the CleanupTrigger which receives data after the reused connection has been taken out of the HTTP/1.1 clear pool (Caused by: java.i

Re: RFR: 8356632: Fix remaining {@link/@linkplain} tags with refer to private/protected types in java.base [v2]

2025-05-23 Thread Weijun Wang
On Thu, 22 May 2025 15:18:43 GMT, Nizar Benalla wrote: >> Please review this patch to fix some `javadoc` bugs in `java.base`. >> Certain `@link` tags used to refer to private fields instead of public APIs. >> >> A couple of `@see` tags in the [serialization >> page](https://download.java.net/ja

RE: Suggestion needed to port the fix to JDK17 and JDK11S

2025-05-23 Thread Shruthi .
Hi Alan, I was able to backport the preClose re-order changes to JDK17 and I executed the Race.java testcase 500 times, and it passed consistently without any failures. I also tested Race.java without the patch and it fails in the first iteration it self. We are running the tests under java/net

Re: RFR: 8357539: TimeSource.now() is not monotonic [v3]

2025-05-23 Thread Jaikiran Pai
On Fri, 23 May 2025 06:11:47 GMT, Daniel Jeliński wrote: >> We observed a case where the instants returned by `TimeSource.now()` were >> returned in non-monotonic order. The reason was that sometimes we were using >> a delay calculated with one `localSource` as an input to a different >> (upda

Re: RFR: 8357539: TimeSource.now() is not monotonic [v3]

2025-05-23 Thread Daniel Fuchs
On Fri, 23 May 2025 06:14:37 GMT, Daniel Jeliński wrote: >> We observed a case where the instants returned by `TimeSource.now()` were >> returned in non-monotonic order. The reason was that sometimes we were using >> a delay calculated with one `localSource` as an input to a different >> (upda

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v4]

2025-05-23 Thread Mark Sheppard
On Thu, 22 May 2025 12:27:46 GMT, Mikhail Yankelevich wrote: >> HttpServer::stop will terminate the server immidiately after all exhcnages >> are complete. >> If the exchanges take longer then the specified delay it will terminate >> straight after the delay, the same as the previous behaviour

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v4]

2025-05-23 Thread Mikhail Yankelevich
On Fri, 23 May 2025 08:50:11 GMT, Mark Sheppard wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Suggestions from cr >> >> Co-authored-by: Daniel Fuchs <67001856+df...@users.noreply.github.com> > > src/j

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v4]

2025-05-23 Thread Mark Sheppard
On Thu, 22 May 2025 12:27:46 GMT, Mikhail Yankelevich wrote: >> HttpServer::stop will terminate the server immidiately after all exhcnages >> are complete. >> If the exchanges take longer then the specified delay it will terminate >> straight after the delay, the same as the previous behaviour

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v4]

2025-05-23 Thread Mark Sheppard
On Thu, 22 May 2025 12:27:46 GMT, Mikhail Yankelevich wrote: >> HttpServer::stop will terminate the server immidiately after all exhcnages >> are complete. >> If the exchanges take longer then the specified delay it will terminate >> straight after the delay, the same as the previous behaviour

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v4]

2025-05-23 Thread Mark Sheppard
On Fri, 23 May 2025 08:54:42 GMT, Mikhail Yankelevich wrote: >> src/jdk.httpserver/share/classes/sun/net/httpserver/ServerImpl.java line 227: >> >>> 225: } >>> 226: >>> 227: public final boolean isFinishing() { >> >> encapsulating the server state in a CountDownLatch is obfuscated sem

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v4]

2025-05-23 Thread Daniel Fuchs
On Fri, 23 May 2025 09:00:39 GMT, Mark Sheppard wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Suggestions from cr >> >> Co-authored-by: Daniel Fuchs <67001856+df...@users.noreply.github.com> > > src/j

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v4]

2025-05-23 Thread Daniel Fuchs
On Fri, 23 May 2025 09:07:51 GMT, Mark Sheppard wrote: >> Yes, but this is an existing function and it is used in other classes. I >> didn't change the functionality > > the internal state representation of the server could do with a rethink and > overhaul, and representing part of that state i

Re: RFR: 8304065: HttpServer.stop should terminate immediately if no exchanges are in progress [v4]

2025-05-23 Thread Daniel Fuchs
On Fri, 23 May 2025 08:48:32 GMT, Mark Sheppard wrote: > If I have read the original code correctly there is a flaw in it, that is the > startExchange is never called. @msheppar what do you mean by that? It's called in [ExchangeImpl.java](https://github.com/openjdk/jdk/blob/68ee06f0c9ec420cb1a

Integrated: 8357539: TimeSource.now() is not monotonic

2025-05-23 Thread Daniel Jeliński
On Thu, 22 May 2025 09:53:26 GMT, Daniel Jeliński wrote: > We observed a case where the instants returned by `TimeSource.now()` were > returned in non-monotonic order. The reason was that sometimes we were using > a delay calculated with one `localSource` as an input to a different (updated >

Re: RFR: 8357539: TimeSource.now() is not monotonic [v3]

2025-05-23 Thread Daniel Jeliński
On Fri, 23 May 2025 06:14:37 GMT, Daniel Jeliński wrote: >> We observed a case where the instants returned by `TimeSource.now()` were >> returned in non-monotonic order. The reason was that sometimes we were using >> a delay calculated with one `localSource` as an input to a different >> (upda

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v26]

2025-05-23 Thread Bradford Wetmore
> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE > respectively. > > CSR is underway. > > Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK > API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net > jck:api/javax_security jck:ap