On Fri, 23 May 2025 08:50:11 GMT, Mark Sheppard <mshep...@openjdk.org> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Suggestions from cr
>>
>> Co-authored-by: Daniel Fuchs <67001856+df...@users.noreply.github.com>
>
> src/jdk.httpserver/share/classes/sun/net/httpserver/ServerImpl.java line 227:
>
>> 225: }
>> 226:
>> 227: public final boolean isFinishing() {
>
> encapsulating the server state in a CountDoenLatch is obfuscated semantics
Yes, but this is an existing function and it is used in other classes. I didn't
change the functionality
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25333#discussion_r2104143995
