On Thu, 15 May 2025 12:51:16 GMT, Artur Barashev wrote:
>> Sure.
>
> Also, the parentheses are not needed around `context != null`
If there's one things to know about me, it's my liberal use of parens. I want
my code to match my intent.
I plan to update the "missing" parens.
-
P
On Thu, 15 May 2025 01:59:50 GMT, Bradford Wetmore wrote:
>> test/jdk/javax/net/ssl/ExtendedSSLSession/ExportKeyingMaterialTests.java
>> line 62:
>>
>>> 60: * produced.
>>> 61: */
>>> 62: public class ExportKeyingMaterialTests extends SSLContextTemplate {
>>
>> What's the reason we don't use
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote:
> This change tries to add timeout to individual testcases so that I am able to
> run them with a timeout factor of 1 in the future (JDK-8260555).
>
> The first commit changes the timeout factor to 0.7, so that I can run tests
> and test the
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote:
> This change tries to add timeout to individual testcases so that I am able to
> run them with a timeout factor of 1 in the future (JDK-8260555).
>
> The first commit changes the timeout factor to 0.7, so that I can run tests
> and test the
On Tue, 13 May 2025 13:53:05 GMT, Daniel Fuchs wrote:
>> Includes request method, request URI, response status code, and HTTP/2
>> stream ID while logging response headers in the HTTP Client.
>>
>> ### Demonstration
>>
>> Snippets from running JTreg against
>> `test/jdk/java/net/httpclient/He
> Includes request method, request URI, response status code, and HTTP/2 stream
> ID while logging response headers in the HTTP Client.
>
> ### Demonstration
>
> Snippets from running JTreg against
> `test/jdk/java/net/httpclient/HeadTest.java`:
>
> **Before:**
>
> INFO: HEADERS: REQUEST HEAD
On Thu, 15 May 2025 11:26:09 GMT, Volkan Yazici wrote:
>> Includes request method, request URI, response status code, and HTTP/2
>> stream ID while logging response headers in the HTTP Client.
>>
>> ### Demonstration
>>
>> Snippets from running JTreg against
>> `test/jdk/java/net/httpclient/H
On Wed, 14 May 2025 10:44:55 GMT, Daniel Fuchs wrote:
>> Volkan Yazici has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Match header logging in `Http1Request` with others
>> - Shorten code
>> - Improve header logging in more places
On Wed, 14 May 2025 09:31:07 GMT, Volkan Yazici wrote:
>> Includes request method, request URI, response status code, and HTTP/2
>> stream ID while logging response headers in the HTTP Client.
>>
>> ### Demonstration
>>
>> Snippets from running JTreg against
>> `test/jdk/java/net/httpclient/H
On Thu, 15 May 2025 11:29:33 GMT, Volkan Yazici wrote:
>> Includes request method, request URI, response status code, and HTTP/2
>> stream ID while logging response headers in the HTTP Client.
>>
>> ### Demonstration
>>
>> Snippets from running JTreg against
>> `test/jdk/java/net/httpclient/H
On Thu, 15 May 2025 05:14:02 GMT, Patrick Strawderman wrote:
> Avoid allocating a substring to parse the response code in
> HttpURLConnection#getResponseCode, but instead use the Integer.parseInt
> overload that accepts String indices.
Thanks for this fix. The proposed changes LGTM. Did you ru
On Thu, 15 May 2025 00:27:31 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1727:
>>
>>> 1725:
>>> 1726: // context length must fit in 2 unsigned bytes.
>>> 1727: if ((context != null) && context.length >= 65536) {
>
> 8351843: change
> test/jdk/com/sun/net/httpserver/simpleserver/RootDirPermissionsTest.java to a
> manual test
serhiysachkov has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. Th
On Thu, 15 May 2025 11:29:33 GMT, Volkan Yazici wrote:
>> Includes request method, request URI, response status code, and HTTP/2
>> stream ID while logging response headers in the HTTP Client.
>>
>> ### Demonstration
>>
>> Snippets from running JTreg against
>> `test/jdk/java/net/httpclient/H
On Thu, 15 May 2025 11:29:33 GMT, Volkan Yazici wrote:
>> Includes request method, request URI, response status code, and HTTP/2
>> stream ID while logging response headers in the HTTP Client.
>>
>> ### Demonstration
>>
>> Snippets from running JTreg against
>> `test/jdk/java/net/httpclient/H
On Thu, 15 May 2025 11:29:33 GMT, Volkan Yazici wrote:
>> Includes request method, request URI, response status code, and HTTP/2
>> stream ID while logging response headers in the HTTP Client.
>>
>> ### Demonstration
>>
>> Snippets from running JTreg against
>> `test/jdk/java/net/httpclient/H
On Thu, 15 May 2025 13:47:23 GMT, serhiysachkov wrote:
>> change
>> test/jdk/com/sun/net/httpserver/simpleserver/RootDirPermissionsTest.java to
>> a manual test
>
> serhiysachkov has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes t
On Tue, 13 May 2025 08:15:34 GMT, Volkan Yazici wrote:
> Includes request method, request URI, response status code, and HTTP/2 stream
> ID while logging response headers in the HTTP Client.
>
> ### Demonstration
>
> Snippets from running JTreg against
> `test/jdk/java/net/httpclient/HeadTest
On Thu, 15 May 2025 20:42:39 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Merged with changes for JDK-8353578
>
> src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java line 169:
> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE
> respectively.
>
> CSR is underway.
>
> Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK
> API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net
> jck:api/javax_security jck:ap
On Thu, 15 May 2025 04:26:30 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1682:
>>
>>> 1680: // ...now the final expand.
>>> 1681: return (deriveKey ?
>>> 1682:
>>> hkdf.
On Wed, 14 May 2025 04:03:44 GMT, Bradford Wetmore wrote:
>> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE
>> respectively.
>>
>> CSR is underway.
>>
>> Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK
>> API (jck:api/java_security jck:
On Wed, 14 May 2025 04:03:44 GMT, Bradford Wetmore wrote:
>> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE
>> respectively.
>>
>> CSR is underway.
>>
>> Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK
>> API (jck:api/java_security jck:
On Tue, 13 May 2025 15:08:08 GMT, kieran-farrell wrote:
>> Spec currently suggests that only IPv6 addresses can return null for
>> InterfaceAddress.getBroadcast(). Clarifying spec to state that certain IPv4
>> address such as the loopback address do not support broadcasting and can
>> therefor
On Tue, 13 May 2025 14:01:10 GMT, Artur Barashev wrote:
> > It is nice to refactor the common code for algorithm constraints checking
> > into a new class, `X509KeyManagerConstraints.java`, used by both
> > `SunX509KeyManagerImpl` and `X509KeyManagerImpl`. However, it looks like a
> > new syst
25 matches
Mail list logo
