On Thu, 15 May 2025 11:26:09 GMT, Volkan Yazici <vyaz...@openjdk.org> wrote:
>> Includes request method, request URI, response status code, and HTTP/2 >> stream ID while logging response headers in the HTTP Client. >> >> ### Demonstration >> >> Snippets from running JTreg against >> `test/jdk/java/net/httpclient/HeadTest.java`: >> >> **Before:** >> >> INFO: HEADERS: REQUEST HEADERS: >> HEAD /transfer/ HTTP/1.1 >> Content-Length: 0 >> Host: 127.0.0.1:43647 >> ... >> INFO: HEADERS: RESPONSE HEADERS: >> connection: Upgrade >> upgrade: h2c >> ... >> INFO: HEADERS: RESPONSE HEADERS: >> :status: 304 >> content-length: 300 >> ... >> INFO: HEADERS: HEADERS FRAME (streamid=1): >> :authority: 127.0.0.1:50611 >> :method: GET >> :path: / >> >> >> **After:** >> >> INFO: HEADERS: REQUEST HEADERS: >> HEAD /transfer/ HTTP/1.1 >> Content-Length: 0 >> Host: 127.0.0.1:43647 >> ... >> INFO: HEADERS: RESPONSE HEADERS: >> GET http://127.0.0.1:48497/ 101 >> connection: Upgrade >> upgrade: h2c >> ... >> INFO: HEADERS: RESPONSE HEADERS (streamid=1): >> GET http://127.0.0.1:48497/ 304 >> :status: 304 >> content-length: 300 >> ... >> INFO: HEADERS: HEADERS FRAME (streamid=1): >> GET https://127.0.0.1:50611/ >> :authority: 127.0.0.1:50611 >> :method: GET >> :path: / > > Volkan Yazici has updated the pull request incrementally with two additional > commits since the last revision: > > - Avoid localization > - Apply suggestions from code review > > Co-authored-by: Daniel Fuchs <67001856+df...@users.noreply.github.com> src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 665: > 663: > 664: if (Log.headers()) { > 665: StringBuilder sb = new StringBuilder("RESPONSE HEADERS > (streamid=%d):\n".formatted(streamid)); Suggestion: StringBuilder sb = new StringBuilder("RESPONSE HEADERS (streamid=%s):\n".formatted(streamid)); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25201#discussion_r2090945160
