On Wed, 14 May 2025 10:44:55 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Volkan Yazici has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Match header logging in `Http1Request` with others
>> - Shorten code
>> - Improve header logging in more places
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http1Request.java line
> 93:
>
>> 91: int protocolFieldPrefixIndex = line.lastIndexOf(' ');
>> 92: assert protocolFieldPrefixIndex > 0;
>> 93: sb.append(" ").append(line, 0,
>> protocolFieldPrefixIndex).append('\n');
>
> I'd rather print the whole line here - including HTTP/1.1.
> Nice to have it indented differently though.
Implemented in 7b958db6f4.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25201#discussion_r2090943446
