Re: RFR: 8278353: Provide Duke as default favicon in Simple Web Server

2024-05-07 Thread Daniel Fuchs
On Tue, 30 Apr 2024 11:23:01 GMT, Christian Stein wrote: > Please pre-review this draft pull request adding a default for response for > the `/favicon.ico` path to the Simple Web Server introduced by [JEP > 408](https://openjdk.org/jeps/408). The image in this PR is a copy of > https://inside.

Re: RFR: 8278353: Provide Duke as default favicon in Simple Web Server

2024-05-07 Thread Christian Stein
On Tue, 7 May 2024 07:45:35 GMT, Daniel Jeliński wrote: >> Using Java's birthday `"Mon, 23 May 1995 11:11:11 GMT"` for the time being. > > [java.version.date](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/System.html#java.version.date) > could be a reasonable alternative

Re: RFR: 8278353: Provide Duke as default favicon in Simple Web Server

2024-05-07 Thread Daniel Jeliński
On Tue, 7 May 2024 06:17:22 GMT, Christian Stein wrote: >> src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/FileServerHandler.java >> line 269: >> >>> 267: var bytes = stream.readAllBytes(); >>> 268: respHdrs.set("Content-Type", "image/x-icon"); >>> 269:

Re: RFR: 8278353: Provide Duke as default favicon in Simple Web Server

2024-05-06 Thread Christian Stein
On Mon, 6 May 2024 14:55:31 GMT, Christian Stein wrote: >> Please pre-review this draft pull request adding a default for response for >> the `/favicon.ico` path to the Simple Web Server introduced by [JEP >> 408](https://openjdk.org/jeps/408). The image in this PR is a copy of >> https://insi

Re: RFR: 8278353: Provide Duke as default favicon in Simple Web Server

2024-05-06 Thread Christian Stein
On Tue, 30 Apr 2024 11:23:01 GMT, Christian Stein wrote: > Please pre-review this draft pull request adding a default for response for > the `/favicon.ico` path to the Simple Web Server introduced by [JEP > 408](https://openjdk.org/jeps/408). The image in this PR is a copy of > https://inside.