On Tue, 30 Apr 2024 11:23:01 GMT, Christian Stein <cst...@openjdk.org> wrote:
> Please pre-review this draft pull request adding a default for response for > the `/favicon.ico` path to the Simple Web Server introduced by [JEP > 408](https://openjdk.org/jeps/408). The image in this PR is a copy of > https://inside.java/images/favicon.ico > > Before this change, an initial request from a browser yields the following > output on the server console: > > Binding to loopback by default. For all interfaces use "-b 0.0.0.0" or "-b > ::". > Serving PATH and subdirectories on 127.0.0.1 port 8000 > URL http://127.0.0.1:8000/ > 127.0.0.1 - - [30/Apr/2024:13:11:39 +0200] "GET / HTTP/1.1" 200 - > 127.0.0.1 - - [30/Apr/2024:13:11:40 +0200] "GET /favicon.ico HTTP/1.1" 404 - > > > After applying this change set, the two last line read: > > 127.0.0.1 - - [30/Apr/2024:13:12:08 +0200] "GET / HTTP/1.1" 200 - > 127.0.0.1 - - [30/Apr/2024:13:12:08 +0200] "GET /favicon.ico HTTP/1.1" 200 - src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/FileServerHandler.java line 269: > 267: var bytes = stream.readAllBytes(); > 268: respHdrs.set("Content-Type", "image/x-icon"); > 269: // TODO respHdrs.set("Last-Modified", getLastModified(...)); Is there a canonical way to retrieve a stable timestamp for the built-in `favicon.ico` here? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19020#discussion_r1591136695
