Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v2]

2024-08-13 Thread Jaikiran Pai
On Tue, 13 Aug 2024 15:08:24 GMT, Jaikiran Pai wrote: >> This is a fresh version of the PR that I had opened here >> https://github.com/openjdk/jdk/pull/20442. A `git merge` command ended up >> causing unexpected issues with that old PR. >> >> The commits in this PR are the ones which were alr

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v2]

2024-08-13 Thread Daniel Fuchs
On Tue, 13 Aug 2024 15:08:24 GMT, Jaikiran Pai wrote: >> This is a fresh version of the PR that I had opened here >> https://github.com/openjdk/jdk/pull/20442. A `git merge` command ended up >> causing unexpected issues with that old PR. >> >> The commits in this PR are the ones which were alr

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v2]

2024-08-13 Thread Jaikiran Pai
> This is a fresh version of the PR that I had opened here > https://github.com/openjdk/jdk/pull/20442. A `git merge` command ended up > causing unexpected issues with that old PR. > > The commits in this PR are the ones which were already reviewed and a new one > which was done to implement Da

RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient

2024-08-13 Thread Jaikiran Pai
This is a fresh version of the PR that I had opened here https://github.com/openjdk/jdk/pull/20442. A `git merge` command ended up causing unexpected issues with that old PR. The commits in this PR are the ones which were already reviewed and a new one which was done to implement Daniel's sugge

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v6]

2024-08-13 Thread Jaikiran Pai
On Tue, 13 Aug 2024 13:19:44 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which fixes the issue noted in >> https://bugs.openjdk.org/browse/JDK-8335181? >> >> As noted in that issue, the current implementation in the >> `java.net.http.HttpClient` doesn't correctly handl

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v5]

2024-08-13 Thread Jaikiran Pai
On Mon, 12 Aug 2024 14:33:29 GMT, Daniel Fuchs wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> simplify request approver test construct - no need to expect request path > > src/java.net.http/share/classes/jdk/inter

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v6]

2024-08-13 Thread Jaikiran Pai
> Can I please get a review of this change which fixes the issue noted in > https://bugs.openjdk.org/browse/JDK-8335181? > > As noted in that issue, the current implementation in the > `java.net.http.HttpClient` doesn't correctly handle an incoming GOAWAY frame. > The HTTP3 RFC https://www.rfc-

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v5]

2024-08-12 Thread Daniel Fuchs
On Mon, 12 Aug 2024 07:12:07 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which fixes the issue noted in >> https://bugs.openjdk.org/browse/JDK-8335181? >> >> As noted in that issue, the current implementation in the >> `java.net.http.HttpClient` doesn't correctly handl

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v5]

2024-08-12 Thread Daniel Fuchs
On Mon, 12 Aug 2024 07:12:07 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which fixes the issue noted in >> https://bugs.openjdk.org/browse/JDK-8335181? >> >> As noted in that issue, the current implementation in the >> `java.net.http.HttpClient` doesn't correctly handl

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v5]

2024-08-12 Thread Jaikiran Pai
> Can I please get a review of this change which fixes the issue noted in > https://bugs.openjdk.org/browse/JDK-8335181? > > As noted in that issue, the current implementation in the > `java.net.http.HttpClient` doesn't correctly handle an incoming GOAWAY frame. > The HTTP3 RFC https://www.rfc-

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v4]

2024-08-06 Thread Jaikiran Pai
> Can I please get a review of this change which fixes the issue noted in > https://bugs.openjdk.org/browse/JDK-8335181? > > As noted in that issue, the current implementation in the > `java.net.http.HttpClient` doesn't correctly handle an incoming GOAWAY frame. > The HTTP3 RFC https://www.rfc-

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v3]

2024-08-06 Thread Jaikiran Pai
On Tue, 6 Aug 2024 09:10:13 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which fixes the issue noted in >> https://bugs.openjdk.org/browse/JDK-8335181? >> >> As noted in that issue, the current implementation in the >> `java.net.http.HttpClient` doesn't correctly handle

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v3]

2024-08-06 Thread Jaikiran Pai
> Can I please get a review of this change which fixes the issue noted in > https://bugs.openjdk.org/browse/JDK-8335181? > > As noted in that issue, the current implementation in the > `java.net.http.HttpClient` doesn't correctly handle an incoming GOAWAY frame. > The HTTP3 RFC https://www.rfc-

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v2]

2024-08-02 Thread Jaikiran Pai
On Fri, 2 Aug 2024 11:24:07 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which fixes the issue noted in >> https://bugs.openjdk.org/browse/JDK-8335181? >> >> As noted in that issue, the current implementation in the >> `java.net.http.HttpClient` doesn't correctly handle

Re: RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient [v2]

2024-08-02 Thread Jaikiran Pai
> Can I please get a review of this change which fixes the issue noted in > https://bugs.openjdk.org/browse/JDK-8335181? > > As noted in that issue, the current implementation in the > `java.net.http.HttpClient` doesn't correctly handle an incoming GOAWAY frame. > The HTTP3 RFC https://www.rfc-

RFR: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient

2024-08-02 Thread Jaikiran Pai
Can I please get a review of this change which fixes the issue noted in https://bugs.openjdk.org/browse/JDK-8335181? As noted in that issue, the current implementation in the `java.net.http.HttpClient` doesn't correctly handle an incoming GOAWAY frame. The HTTP3 RFC https://www.rfc-editor.org/r