On Mon, 12 Aug 2024 14:33:29 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> simplify request approver test construct - no need to expect request path
>
> src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 653:
>
>> 651: if (debug.on()) {
>> 652: debug.log("request unprocessed by peer
>> (REFUSED_STREAM) " + this.request);
>> 653: }
>
> Hmm.... Should we just call:
>
>
> closeAsUnprocessed():
> return;
>
>
> here?
I've now updated this PR to follow this suggestion. The `finally` block which
does `connection.decrementStreamsCount(streamid);` is needed (otherwise the
`HttpClient` close() doesn't complete), so I haven't changed that part.
With the latest state of this PR, a test-repeat 50 of java/net/httpclient tests
continues to pass without any failures.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20442#discussion_r1715275039
