Hi,
A question about this issue. Can you explain why the server/proxy is
sending a response body to a HEAD request?
My reading of the RFCs suggests this is not allowed.
Thanks,
Michael
On 12/07/2021 11:54, Alex Kasko wrote:
On Mon, 12 Jul 2021 10:34:54 GMT, Alex Kasko wrote:
When HEAD r
On Thu, 12 Aug 2021 13:44:23 GMT, Julia Boes wrote:
> This is a doc-only fix that improves the wording of the API doc of
> `getRequestHeaders()`. The other changes are trivial cleanup.
Marked as reviewed by michaelm (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5100
Vote: yes
On 25/08/2021 10:09, Daniel Fuchs wrote:
I hereby nominate Patrick Concannon to Membership in the Networking
Group.
Patrick is a Committer in the JDK project, and has been actively
participating in the evolution and maintenance of the networking
libraries for several years.
Patrick
Thanks. I have filed https://bugs.openjdk.java.net/browse/JDK-8273059 to
track this.
- Michael.
On 19/08/2021 19:50, Andrey Turbanov wrote:
Hello.
During investigation of results of IDEA inspections I found a
redundant call to Math.min in a method
jdk.internal.net.http.Http2ClientImpl#getConn
Hi,
Could I get the following trivial change reviewed please?
It removes a redundant call to Math.min(Integer.MAX_VALUE, )
Thanks,
Michael.
-
Commit messages:
- Removed redundant Math.min() call
Changes: https://git.openjdk.java.net/jdk/pull/5277/files
Webrev: https://webrevs
> Hi,
>
> Could I get the following trivial change reviewed please?
> It removes a redundant call to Math.min(Integer.MAX_VALUE, )
>
> Thanks,
> Michael.
Michael McMahon has updated the pull request incrementally with one additional
commit since the last revision:
> Hi,
>
> Could I get the following trivial change reviewed please?
> It removes a redundant call to Math.min(Integer.MAX_VALUE, )
>
> Thanks,
> Michael.
Michael McMahon has updated the pull request incrementally with one additional
commit since the last revision:
m
On Fri, 27 Aug 2021 12:01:25 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following trivial change reviewed please?
> It removes a redundant call to Math.min(Integer.MAX_VALUE, )
>
> Thanks,
> Michael.
This pull request has now been integrated.
Chang
On Tue, 14 Sep 2021 16:51:40 GMT, Daniel Fuchs wrote:
>> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpHandlers.java
>> line 129:
>>
>>> 127: * response body bytes are a {@code UTF-8} encoded byte
>>> sequence of
>>> 128: * {@code body}. The response {@linkplain
>>> Ht
On Wed, 15 Sep 2021 08:42:40 GMT, Julia Boes wrote:
>> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsServer.java
>> line 152:
>>
>>> 150: return server;
>>> 151: }
>>> 152:
>>
>> Too bad we couldn't simplify the setting up a basic certificate for https.
>
> That wou
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Wed, 22 Sep 2021 21:05:34 GMT, Mahendra Chhipa
wrote:
>> Dependencies of TestHttpServre, HttpTransaction, HttpCallback are removed
>> from following tests:
>> open/test/jdk/sun/net/www/protocol/http/ResponseCacheStream.java
>> open/test/jdk/sun/net/www/protocol/http/SetChunkedStreamingMode.j
On Wed, 29 Sep 2021 13:45:43 GMT, Mahendra Chhipa
wrote:
>> test/jdk/sun/net/www/protocol/http/B6296310.java line 103:
>>
>>> 101: try(PrintWriter pw = new
>>> PrintWriter(trans.getResponseBody())) {
>>> 102: pw.print("");
>>> 103: }
>>
>> Not sure what the purpo
On Thu, 30 Sep 2021 09:05:41 GMT, Daniel Fuchs wrote:
>> I think it would be simpler to replace lines 101-103 just with
>> `trans.close()`
>
> Strictly speaking to preserve the current behavior - that would be
> `trans.getResponseBody().close();` isn't it?
HttpExchange.close() calls the close
On Thu, 30 Sep 2021 09:38:17 GMT, Mahendra Chhipa
wrote:
>> Dependencies of TestHttpServre, HttpTransaction, HttpCallback are removed
>> from following tests:
>> open/test/jdk/sun/net/www/protocol/http/ResponseCacheStream.java
>> open/test/jdk/sun/net/www/protocol/http/SetChunkedStreamingMode.j
On Wed, 25 Aug 2021 14:21:59 GMT, Alex Kasko wrote:
>> When HEAD request is used with a proxy (or a server) that requires NTLM,
>> authentication fails when server returns large (8kb+) body along with
>> NTLMSSP_CHALLENGE response.
>>
>> Proposed fix is to check for ongoing NTLM auth in `reset
I think we should at least clarify the behavior of
HttpRequest.Builder.timeout() ie. that it is specifically related to the
response headers, and maybe consider adding a timeout variant that sets
the timeout for the entire response, including the body.
- Michael.
On 06/10/2021 10:42, Daniel F
On Fri, 15 Oct 2021 14:47:18 GMT, Evan Whelan wrote:
>> Hi,
>>
>> Please review my fix for JDK-8274779 which changes how HttpClient and
>> HttpsClient checks for equality when comparing request methods.
>>
>> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")`
>> rather
On Tue, 12 Oct 2021 10:40:15 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Tue, 12 Oct 2021 10:40:15 GMT, Julia Boes wrote:
>> This change implements a simple web server that can be run on the
>> command-line with `java -m jdk.httpserver`.
>>
>> This is facilitated by adding an entry point for the `jdk.httpserver`
>> module, an implementation class whose main meth
On Tue, 19 Oct 2021 13:48:24 GMT, Evan Whelan wrote:
>> Hi,
>>
>> Please review my fix for JDK-8274779 which changes how HttpClient and
>> HttpsClient checks for equality when comparing request methods.
>>
>> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")`
>> rather
On Fri, 15 Oct 2021 15:11:06 GMT, Michael McMahon wrote:
> Just wondering what actually happens if you encounter this bug? I guess that
> the post will fail somehow because it has been given a closed connection. If
> so, would it be possible to write the test to simulate that behavior
On Tue, 26 Oct 2021 12:46:31 GMT, Julia Boes wrote:
> This change ensures that the realm string passed to the BasicAuthenticator
> constructor is a quoted-string, as per RFC7230 [1]. A Utils class is added to
> jdk.httpserver/sun.net.httpserver that holds the new isQuotedString() method
> and
On Tue, 26 Oct 2021 16:24:48 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API classes
On Tue, 26 Oct 2021 13:31:35 GMT, Daniel Fuchs wrote:
>> This change ensures that the realm string passed to the BasicAuthenticator
>> constructor is a quoted-string, as per RFC7230 [1]. A Utils class is added
>> to jdk.httpserver/sun.net.httpserver that holds the new isQuotedString()
>> metho
On Fri, 29 Oct 2021 10:12:25 GMT, Daniel Fuchs wrote:
>> I still think it is too much of a corner case to impose on the API doc so
>> much. How about changing the @throws to
>>
>>
>> * @throws IllegalArgumentException if realm is an empty string or is
>> not correctly
>> *
On Fri, 29 Oct 2021 10:28:39 GMT, Michael McMahon wrote:
>> OK - but then I'd still say: `The value of the {@code realm} parameter will
>> be embedded in a quoted string.`
>> Otherwise the caller might think they need to provide a quoted string such
>> as: "
On Fri, 29 Oct 2021 16:17:46 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API classes
On Mon, 1 Nov 2021 13:12:51 GMT, Julia Boes wrote:
>> This change ensures that the realm string passed to the BasicAuthenticator
>> constructor is a quoted-string, as per RFC7230 [1]. A Utils class is added
>> to jdk.httpserver/sun.net.httpserver that holds the new isQuotedString()
>> method a
On Wed, 17 Nov 2021 14:07:09 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find enclosed a patch that solves an unexpected interaction between
>> server-set cookies and user-set cookies in the `java.net.HttpClient`.
>>
>> In JDK 12 we fixed
>> [JDK-8213189](https://bugs.openjdk.java.net/browse
On Fri, 19 Nov 2021 10:12:15 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find enclosed a patch that solves an unexpected interaction between
>> server-set cookies and user-set cookies in the `java.net.HttpClient`.
>>
>> In JDK 12 we fixed
>> [JDK-8213189](https://bugs.openjdk.java.net/browse
On Wed, 24 Nov 2021 17:29:40 GMT, Julia Boes wrote:
>> This change introduces jwebserver, a dedicated JDK tool for the Simple Web
>> Server.
>>
>> A description is provided in a follow-up comment.
>
> Julia Boes has updated the pull request incrementally with one additional
> commit since the
Yes, I agree with this. It's a niche use case which should be made clear
in the docs.
The new method should have a default implementation.
I think I prefer also to use a SocketAddress in case there is some
future need to also
specify the local port. The InetSocketAddress constructors allow a
On Tue, 7 Dec 2021 10:24:31 GMT, Julia Boes wrote:
> This change sets a maximum request time for the `jwebserver` (and `java -m
> jdk.httpserver`), unless it has already been set.
>
> While here, I removed a comment from the implementation classes, a left-over
> from the pre-module era that i
This updates the testkeys keystore file used by SimpleSSLContext in the test
tree, in order to add subject alt names for the literal IP addresses
"127.0.0.1" and "::1". This should allow the self signed certificate in the
keystore to be accepted even when the local OS doesn't have a localhost to
On Tue, 7 Dec 2021 15:03:31 GMT, Daniel Fuchs wrote:
>> test/jdk/com/sun/net/httpserver/SANTest.java line 77:
>>
>>> 75: int port1 = s1.getAddress().getPort();
>>> 76: int port2 = s2.getAddress().getPort();
>>> 77: test ("127.0.0.1", root+"/test1", port2, "sma
On Mon, 6 Dec 2021 21:27:48 GMT, Michael McMahon wrote:
> This updates the testkeys keystore file used by SimpleSSLContext in the test
> tree, in order to add subject alt names for the literal IP addresses
> "127.0.0.1" and "::1". This should allow the s
Hi,
This change adds Channel Binding Token (CBT) support to HTTPS
(java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
authentication scheme. When enabled, the implementation preemptively includes a
CBT with authentication requests over Kerberos. The feature is enabled
On Thu, 13 Jan 2022 18:18:24 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively includes
On Thu, 13 Jan 2022 15:39:28 GMT, Julia Boes wrote:
>> This new test confirms that the jwebserver does not wait indefinitely for a
>> request to arrive, but instead closes the connection when the maximum
>> request time is reached. To facilitate this, Exchange::run is amended to
>> process can
On Fri, 14 Jan 2022 14:52:13 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively includes
On Mon, 17 Jan 2022 13:49:35 GMT, Daniel Fuchs wrote:
>> I vote for "jdk.https.tls.cbt"
>
>> It's actually a purely system property rather than a Net property at the
>> moment (same as the other spnego ones). Maybe, I should convert them all to
>> net properties, so they can be documented/set i
On Mon, 17 Jan 2022 13:44:06 GMT, Daniel Fuchs wrote:
>> Shall we log a message if the value is not one of the 3 forms?
>
> Usually malformed values are just ignored - and the property takes its
> default value. But yes - s.n.w.h.HttpClient has a logger so it wouldn't be
> much effort to log it
On Sat, 15 Jan 2022 14:02:15 GMT, Michael Osipov wrote:
>> I suggest moving the `TlsChannelBinding` class into
>> `java.base/sun.security.util` since it's not only used by LDAP anymore. It's
>> even not restricted to GSS-API. According to
>> https://www.rfc-editor.org/rfc/rfc5056, "Although in
On Wed, 19 Jan 2022 15:36:16 GMT, Michael McMahon wrote:
>>> It's actually a purely system property rather than a Net property at the
>>> moment (same as the other spnego ones). Maybe, I should convert them all to
>>> net properties, so they can be documented
On Fri, 14 Jan 2022 15:06:12 GMT, Daniel Fuchs wrote:
> Have you been able to test this on a specific setup? Would be good to hear
> from @msheppar too.
I have tested it with the server setup by Prajwal. Security SQE are looking
into configuring a server with a similar setup which can be teste
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McMahon
On Wed, 19 Jan 2022 22:25:43 GMT, Weijun Wang wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changes after first review round
>
> src/java.naming/share/classes/com/sun/jndi/ld
On Thu, 20 Jan 2022 11:04:18 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed sasl module dependency and added SaslException cause
>
> src/java.base/share/
On Thu, 20 Jan 2022 11:14:40 GMT, Michael Osipov wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed sasl module dependency and added SaslException cause
>
> src/java.naming/s
On Thu, 20 Jan 2022 11:16:16 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed sasl module dependency and added SaslException cause
>
> src/java.base/s
On Fri, 21 Jan 2022 13:38:08 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/sun/net/www/http/HttpClient.java line 189:
>>
>>> 187: } else {
>>> 188: logError("Unexpected value for \"jdk.https.negotiate.cbt\"
>>
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McMahon has u
On Fri, 21 Jan 2022 13:39:06 GMT, Michael Osipov wrote:
>> Actually, it turns out I should be throwing `NamingException` here. That is
>> what was being thrown by `TlsChannelBinding.parseType` before and an
>> existing test was expecting that. NamingException only takes a String
>> message. So
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McM
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McMahon has update
On Fri, 21 Jan 2022 19:48:02 GMT, Weijun Wang wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added root cause to NamingException
>
> src/java.base/share/classes/java/net/doc-file
On Fri, 21 Jan 2022 19:53:55 GMT, Daniel Jeliński wrote:
>> Fix RFC compliance.
>> Tier1 and tier2 passed.
>
> Daniel Jeliński has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update copyright year
src/java.base/share/classes/sun/net/www/pr
On Mon, 24 Jan 2022 14:38:02 GMT, Michael McMahon wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright year
>
> src/java.base/share/classes/sun/net/www/protocol/http/
On Mon, 24 Jan 2022 15:23:44 GMT, Weijun Wang wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Mon, 24 Jan 2022 18:07:36 GMT, Daniel Jeliński wrote:
>> Fix RFC compliance.
>> Tier1 and tier2 passed.
>
> Daniel Jeliński has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update accept header to */*
LGTM
-
Marked as revie
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McMahon has u
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Mich
On Tue, 25 Jan 2022 11:34:57 GMT, Michael Osipov wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> final review update (pre CSR)
>
> src/java.base/share/classes/sun/net/www
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael Mc
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McMahon has
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McMahon has updated
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McMahon has update
On Thu, 27 Jan 2022 16:47:52 GMT, Daniel Fuchs wrote:
>> It's `java.net.SocketException: Unexpected end of file from server`. Does
>> not include any CBT words so don't know if it's worth parsing.
>
> Thanks. Then it would be better to catch only `SocketException` here rather
> than `Exception`
On Fri, 28 Jan 2022 14:28:43 GMT, Alan Bateman wrote:
>> with IP "0.0.0.0"
>>
>> - it either does nothing and ping fails, or, in some virtual environments
>> is treated as the default route address.
>> - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted
>> as a vaild psu
On Fri, 28 Jan 2022 14:46:32 GMT, Michael Felt wrote:
>> If it defeats the purpose, then it needs to be skipped.
>>
>> * When I was trying to understand the test, it seemed to be that it
>> _assumed_ that "0.0.0.0" was 'converted' to 127.0.0.1.
>> * If there is an international standard (ISO, P
;, "b.c" and all hosts under the domain "d.com" and all of its
> sub-domains.
>
> A test will be added separately to the implementation.
>
> Bug report: https://bugs.openjdk.java.net/browse/JDK-8279842
>
> Thanks,
> Michael
Michael McMahon has
On Thu, 13 Jan 2022 12:10:11 GMT, Michael McMahon wrote:
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptivel
On Fri, 28 Jan 2022 09:45:02 GMT, Daniel Fuchs wrote:
> Please find enclosed a simple test fix for:
> 8280868: LineBodyHandlerTest.java creates and discards too many clients
>
> The LineBodyHandlerTest.java creates and discards many clients (64).
> The test has been observed failing intermittent
On Thu, 3 Feb 2022 09:24:46 GMT, Julia Boes wrote:
> This change updates the tests in question to handle the case where sym link
> creation is not supported, as observed on Windows 11 where additional
> privileges are required to create sym links.
>
> Testing: tier 1-3 across platforms, plus t
Hi,
Could I get the following patch reviewed please? (A CSR is also required which
I will submit when the docs are agreed)
It adds a pair of new system properties to make the keep alive timer in
java.net.HttpURLConnection configurable.
The proposed property names are:
"http.keepAlive.time.serv
On Fri, 4 Feb 2022 14:11:49 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Could I get the following patch reviewed please? (A CSR is also required
>> which I will submit when the docs are agreed)
>>
>> It adds a pair of new system properties to make the keep alive timer in
>> java.net.HttpURLConnecti
posed property names are:
>
> "http.keepAlive.time.server" and "http.keepAlive.time.proxy"
>
> Thanks,
> Michael
Michael McMahon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
b
posed property names are:
>
> "http.keepAlive.time.server" and "http.keepAlive.time.proxy"
>
> Thanks,
> Michael
Michael McMahon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
b
On Mon, 14 Feb 2022 13:38:06 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
posed property names are:
>
> "http.keepAlive.time.server" and "http.keepAlive.time.proxy"
>
> Thanks,
> Michael
Michael McMahon has updated the pull request incrementally with one additional
commit since the last revision:
Fixed test case problem and update f
posed property names are:
>
> "http.keepAlive.time.server" and "http.keepAlive.time.proxy"
>
> Thanks,
> Michael
Michael McMahon has updated the pull request incrementally with one additional
commit since the last revision:
tighten up spec wording and move props besid
posed property names are:
>
> "http.keepAlive.time.server" and "http.keepAlive.time.proxy"
>
> Thanks,
> Michael
Michael McMahon has updated the pull request incrementally with one additional
commit since the last revision:
remove extraneous .swp file
-
C
On Fri, 4 Feb 2022 13:11:02 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following patch reviewed please? (A CSR is also required
> which I will submit when the docs are agreed)
>
> It adds a pair of new system properties to make the keep alive timer in
> java.
On Wed, 16 Feb 2022 21:27:40 GMT, Daniel Fuchs wrote:
> Please find here a changeset to ProblemList
> sun/net/www/protocol/https/HttpsURLConnection/B6216082.java until JDK-8282017
> is fixed
LGTM
-
Marked as reviewed by michaelm (Reviewer).
PR: https://git.openjdk.java.net/jdk/p
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new
Hi,
Could I get the following change reviewed please, which is to disable the MD5
message digest algorithm by default in the HTTP Digest authentication
mechanism? The algorithm can be opted into by setting a new system property
"http.auth.digest.enabledDigestAlgs" to include the value MD5. The
On Thu, 3 Mar 2022 16:13:37 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8282617?
>
> The `HttpClient` class uses a `inCache` (internal) field to keep track of
> whether a connection is
On Fri, 4 Mar 2022 11:25:38 GMT, Daniel Fuchs wrote:
> Should we instead have a property to disable algorithms, whose default value
> would contain "MD5" by default?
I considered that and implemented it that way at the start, but what you would
end up with then is users running their code with
On Fri, 4 Mar 2022 12:12:25 GMT, Daniel Fuchs wrote:
> > I considered that and implemented it that way at the start, but what you
> > would end up with then is users running their code with something like:
> > -DdisabledAlgNames=""
> > I find that style leads to a much less explicit "opting in"
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new
On Fri, 4 Mar 2022 13:13:47 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Could I get the following change reviewed please, which is to disable the
>> MD5 message digest algorithm by default in the HTTP Digest authentication
>> mechanism? The algorithm can be opted into by setting a new system propert
On Fri, 4 Mar 2022 14:11:00 GMT, Jaikiran Pai wrote:
>> Hi,
>>
>> Could I get the following change reviewed please, which is to disable the
>> MD5 message digest algorithm by default in the HTTP Digest authentication
>> mechanism? The algorithm can be opted into by setting a new system propert
On Fri, 4 Mar 2022 14:39:50 GMT, Jaikiran Pai wrote:
>> Hi,
>>
>> Could I get the following change reviewed please, which is to disable the
>> MD5 message digest algorithm by default in the HTTP Digest authentication
>> mechanism? The algorithm can be opted into by setting a new system propert
echanisms so the update
won’t change the behavior? (If there is no negotiation?)
Gruss
Bernd
--
http://bernd.eckenfels.net
Von: net-dev im Auftrag von Michael
McMahon
Gesendet: Friday, March 4, 2022 1:33:06 PM
An:net-dev@openjdk.java.net
Betreff: Re: RFR: 8281561:
On Fri, 4 Mar 2022 14:59:48 GMT, Weijun Wang wrote:
>> Hi,
>>
>> Could I get the following change reviewed please, which is to disable the
>> MD5 message digest algorithm by default in the HTTP Digest authentication
>> mechanism? The algorithm can be opted into by setting a new system property
On Fri, 4 Mar 2022 16:26:52 GMT, Weijun Wang wrote:
>> Hi,
>>
>> Could I get the following change reviewed please, which is to disable the
>> MD5 message digest algorithm by default in the HTTP Digest authentication
>> mechanism? The algorithm can be opted into by setting a new system property
601 - 700 of 1041 matches
Mail list logo
