On Fri, 4 Mar 2022 13:13:47 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system property >> "http.auth.digest.reEnabledAlgs" to include the value MD5. The change also >> updates the Digest authentication implementation to use some of the more >> secure features defined in RFC7616, such as username hashing and additional >> digest algorithms like SHA256 and SHA512-256. >> >> - Michael > > src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java > line 71: > >> 69: // This will probably be expanded to include SHA-1 eventually >> 70: private static final Set<String> defDisabledAlgs = >> 71: Set.of("MD5"); > > What I'm suggesting is that the content of this set could be seeded with the > value of a Security Property, defined in java.security - rather than have the > default value hardcoded here. Yes, I think that should work ------------- PR: https://git.openjdk.java.net/jdk/pull/7688