On Mon, 14 Feb 2022 13:38:06 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits since the last revision: >> >> - Merge branch 'master' into keepalive >> - update after Daniel's first review >> - Merge branch 'master' into keepalive >> - added docs >> - reverted change to LIFETIME constant. Were not necessary >> - updates >> - Merge branch 'master' into keepalive >> - Merge branch 'master' into keepalive >> - Merge branch 'master' into keepalive >> - Merge branch 'master' into keepalive >> - ... and 2 more: >> https://git.openjdk.java.net/jdk/compare/2fc8366a...b0b7673c > > test/jdk/sun/net/www/http/KeepAliveCache/KeepAliveProperty.java line 111: > >> 109: out.print(BODY); >> 110: out.flush(); >> 111: pass = true; > > should that be: pass = ! expectClose? Good catch. That was masking another problem in the test where it wasn't detecting the socket close properly. > test/jdk/sun/net/www/http/KeepAliveCache/KeepAliveProperty.java line 125: > >> 123: >> 124: static String fetch(URL url) throws Exception { >> 125: InputStream in = url.openConnection(NO_PROXY).getInputStream(); > > could use try-with-resource here Ok ------------- PR: https://git.openjdk.java.net/jdk/pull/7349
