t;> prefer the hosts file (which it should do on Linux and OSX). And so
>>> the platform specific lookupIfLocalhost() can be put after the
>>> getaddrinfo() (again).
>>>
>>> I actually think the bug "exists" on all platforms. If getaddrinfo()
>>&
ack when the JDK
>> ServerSocket is running through accept request (from our client socket).
>> I don't think it's an issue for this case.
>>
>> line 611 :
>> http://hg.openjdk.java.net/jdk8/tl/jdk/file/tip/src/windows/native/java/net/TwoStacksPlainSocketImpl.c
&g
>> https://bugs.openjdk.java.net/browse/JDK-8010371
>>
>> Webrev
>> http://cr.openjdk.java.net/~bpb/8010371
>>
>>
> So is getaddrinfo returning EAGAIN or is it failing with EAI_SYSTEM and
> errno set to EAGAIN? I also wonder if the EAGAIN means the underlying
> syscall ha
t;> javadoc?
>
> I don't think it is necessary for this to be documented. It is more
> informational.
>
> -Chris.
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
level until we get result
or timeout, but it requires much more work and probably out of scope of
this CR.
-Dmitry
On 2013-10-03 13:11, Chris Hegarty wrote:
> On 10/02/2013 11:18 PM, Dmitry Samersoff wrote:
>> Chris,
>>
>> I'm not sure immediate native retry ma
> -Chris.
>
> On 10/03/2013 10:44 AM, Dmitry Samersoff wrote:
>> Chris,
>>
>> On my opinion, it's better to just return meaningful exception to
>> customer and let them deal with network issue (as current webrev does).
>>
>> Typical network failure
Changeset: 5d6dc0cba08f
Author:dsamersoff
Date: 2013-10-03 16:54 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d6dc0cba08f
8009213: sun/management/jdp/JdpTest.sh fails with exit code 1
Summary: There's no guarantee that the java process has executed far enough to
be found
y makes sense to
> leave it in there. Actually, can you tell me why you'd rather not
> include ipv6 loopbacks at all?
>
> New webrev at:
>
> http://cr.openjdk.java.net/~robm/7180557/webrev.04/
>
> -Rob
>
> On 21/09/13 12:20, Dmitry Samersoff wrote:
>>
Rob,
Existing code uses if (JVM_GetHostName(myhostname, NI_MAXHOST)) so I
withdraw my last comments. Please, don't change it!!!
-Dmitry
On 2013-10-07 20:30, Rob McKenna wrote:
> Thanks Dmitry! I'll correct that nipick pre-push.
>
> -Rob
>
> On 07/10/13 16:4
ror is only returned by WSAGetLastError?
>
> However I think we have a problem with using gai_strerror here as the
> MSDN documentation says that it is not thread safe. This means we may
> have to look for a WSA equivalent or maybe drop the Windows part of the
> fix (using a mutex
is that winsock_errors dates from early
>> versions of Windows whether there wasn't a means to translate Windows
>> Sockets errors. We should look at eliminating it (not for JDK 8 of
>> course, it's too late) so that all errors are handle translated
>> consistently.
ava.net/~bpb/8010371/webrev.4-amendment/
>>>>
>>> I've restored the bug fields and I assume you'll create a new bug for the
>>> follow-up. Sorry this was missed in the original review (probably because
>>> it went through so many iterations).
>
Changeset: 88436832cfd0
Author:dsamersoff
Date: 2013-10-19 00:05 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88436832cfd0
8004213: JDP packet needs pid, broadcast interval and rmi server hostname fields
Summary: Add some extra fileds to jdp packet
Reviewed-by: allwin, sla,
Changeset: 392acefef659
Author:dsamersoff
Date: 2013-10-19 20:59 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/392acefef659
8024071: In ManagementAgent.start it should be possible to set the jdp.name
parameter.
Summary: Pass one more property from Agent to JdpController
Rev
t it is disabled by default. It is now finally
> being removed.
>
> This bug tracks changing the native in src/share/native/java/net and
> src/solaris/native/java/net so that the system calls are used directly rather
> than going through the JVM_* functions.
>
> http://cr.openj
23/02/14 08:55, Chris Hegarty wrote:
>>>>> On 22 Feb 2014, at 17:23, Dmitry Samersoff
>>>>> wrote:
>>>>>
>>>>>> Chris,
>>>>>>
>>>>>> Didn't look to windows part. Unix part looks good for
if the given address is not 4 byte aligned.
>
> http://cr.openjdk.java.net/~chegar/8034181/webev.00/webrev/
>
> -Chris
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8034181
>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to c
cal ipv6 address. As such, it can happen that during the test the
> interface is disabled, and the test will fail with the report Socket
> receive timeout.
>
> This fix removes the Teredo interface from the testing scenario, so that
> a more stable interface
> will be used.
>
h 32 bytes of data:
> Reply from 127.0.53.53: bytes=32 time<1ms TTL=128
> Reply from 127.0.53.53: bytes=32 time<1ms TTL=128
> Reply from 127.0.53.53: bytes=32 time<1ms TTL=128
> Reply from 127.0.53.53: bytes=32 time<1ms TTL=128
>
> this highlights a DNS configuration issue
> {"192.168.1.2", "192.168.1.2"},
> -{"hello.foo.bar", null},
> +{"invalidhost.invalid", null},
> {"1024.1.2.3", null},
> {"128.14.66000", null }
>
>
> regards
&
ia = NET_SockaddrToInetAddress(env, (struct sockaddr *)&sa, &port);
> isa = (*env)->NewObject(env, isa_class, isa_ctorID, ia, port);
> (*env)->SetObjectArrayElement(env, isaa, 0, isa);
>
> -Chris.
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
s Hegarty wrote:
> On 18 Dec 2014, at 12:22, Dmitry Samersoff
> wrote:
>
>> Chris,
>>
>> In a windows world it's rather common to rely on socket inheritance
>> e.g. set socket to stdin(stdout) of child process and do CreateProcess.
>
> OK, but there ca
TTd0Z1IyR1JmbDZPSVk/resolvconf-reinit/ResolvingHost.java
>
> [2]:
> https://e61b615da46327c9050d624b0a3783ba21c6b125.googledrive.com/host/0B5Kp-cB1sXJrfnZ4NHZ0S1V3UTJZcDFra3RwUFZjQXY5WVZzUkwtTTd0Z1IyR1JmbDZPSVk/resolvconf-reinit/
>
--
Dmitry Samersoff
Oracle Java development team, Saint P
ke sure
> nothing broke.
>
>
>
> Thanks in advance
>
> Christoph
>
>
>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
workInterface.c
>>>
>>> As a follow up to JDK-8156521, and when comparing against the
>>> version of this file in jdk8u-dev a few minor issues were noticed.
>>>
>>> There is a free of a memory structure that was missed somehow
>>> in the 9 versi
Chris,
Looks good for me. Only minor nits (no need to re-review).
1040 missed space before {
1158 please, add comment and {} around continue.
1938 I'm not sure that check for IFF_POINTOPOINT is necessary (but
don't mid to leave it). Do you know the case when both flags are set?
-Dmitry
On 20
rates an RST? Also, is there any way to detect a FIN
> in the JVM and react on it?
>
>
>
> Thanks in advance and best regards
>
> Christoph
>
>
>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
.openjdk.java.net/browse/JDK-8075484
>>>>
>>>> webrev:
>>>> http://cr.openjdk.java.net/~vtewari/8075484/webrev0.0/index.html
>>>> <http://cr.openjdk.java.net/%7Evtewari/8075484/webrev0.0/index.html>
>>>>
>>>> This is
onsistent with the existing code.
>
> Thanks,
>
> Vyom
>
>
> On Friday 02 September 2016 01:38 AM, Dmitry Samersoff wrote:
>> Vyom,
>>
>> Did you consider to use select() to calculate timeout instead of
>> gettimeofday ?
>>
>> gettimeo
>>>>>>>>JNU_ThrowOutOfMemoryError(env, "NET_Timeout
>>>>>>>> native heap allocation failed");
>>>>>>>>} else {
>>>>>>>> JNU_ThrowByNameWithMessageAnd
following patch. It generally coverts codes from
> shell to plain java.
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8169115
>
> Webrev:
>
> http://cr.openjdk.java.net/~xiaofeya/8169115/webrev.00/
>
> Thanks,
>
> Felix
>
--
Dmitry Sa
/~xiaofeya/8169115/webrev.02/
>
> Thanks,
> Felix
> On 2016/12/6 19:16, Dmitry Samersoff wrote:
>> Felix,
>>
>> 1. I'm not sure that javaweb.sfbay.sun.com is the best domain name for
>> this test. Could we use different one (e.g. icann.org)
>>
>> 2.
Changeset: 887e525597f8
Author:dsamersoff
Date: 2010-06-23 17:25 +0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/887e525597f8
6931566: NetworkInterface is not working when interface name is more than 15
characters long
Summary: Separate Linux and Solaris code, use lifreq unde
Chris,
Please review my changes.
see:
http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.03/
-Dmitry
--
Dmitry Samersoff
J2SE Sustaining team, SPB04
* Give Rabbit time and he'll always get the answer ...
was missed
during code review as there was a lot of refactoring to clean up the
code. The solution is to simply set the scope id as was the case in the
original code.
Webrev:
http://cr.openjdk.java.net/~chegar/6967937/webrev.00/webrev/
Thanks,
-Chris.
--
Dmitry Samersoff
J2SE Sustaining team
Alan,
Thank you for the comments.
Fixed.
http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.04/
-Dmitry
On 2010-07-12 12:00, Alan Bateman wrote:
Dmitry Samersoff wrote:
Chris,
Please review my changes.
see:
http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.03/
-Dmitry
The fix
On 2010-07-12 22:30, Alan Bateman wrote:
Dmitry Samersoff wrote:
Alan,
Thank you for the comments.
Fixed.
http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.04/
-Dmitry
The copyright date on the new test says 2008 :-)
Copy-paste from a neighbor ;)
Fixed?
http://cr.openjdk.java.net
Changeset: 25050030a320
Author:dsamersoff
Date: 2010-07-13 15:32 +0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/25050030a320
6964714: NetworkInterface getInetAddresses enumerates IPv6 addresses if
java.net.preferIPvStack property set
Summary: User can disable ipv6 explicitly
java.net.preferIPv4Stack=true.
*/
-Chris.
--
Dmitry Samersoff
J2SE Sustaining team, SPB04
* Give Rabbit time and he'll always get the answer ...
hegar/6972374/webrev.00/webrev/
Thanks,
-Chris.
--
Dmitry Samersoff
J2SE Sustaining team, SPB04
* Give Rabbit time and he'll always get the answer ...
help this issue. I have built using
> latest openjdk 8 repo on Windows 64 and Linux 32/64. Since it's a macro
> change in path "src/solaris", I only did jtreg tests for Linux 32 and 64
> build. The jtreg tests I ran are restricted to package "java/net".
> Please let me know if you need me to do more tests or on more platforms
> (such as Solaris).
>
> Best regards,
> Frank
>
--
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...
be clear, Frank's changes are simply
> changing the definitions so that platforms like AIX will use the same
> implementation as Solaris, Mac, etc. There will be no behavior changes
> from this. You're just asking general questions, right?
>
> On 16/08/2012 12:25, Dmitry Samer
Changeset: 2598dad9
Author:dsamersoff
Date: 2012-09-11 19:58 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2598dad9
7194597: Typeo in com.sun.management.VMOption.toString()
Summary: VMOption.toString() returns "...(read-only)" if writable
"...(read-write)" otherwise
actly what we want.
>>
>> -Chris.
>>
>>> Anyway, the main advice I think is to keep things locally consistent
>>> where possible. Also major refactoring or formatting in a bug fix is a
>>> royal pain for reviewers.
>>>
>>> -Alan
>
> --
> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
> Oracle Java Platform Group | Core Libraries Team
> 35 Network Drive
> Burlington, MA 01803
> jim.g...@oracle.com
>
--
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...
de
> (http://cr.openjdk.java.net/~chegar/7193520/webrev.00/) eliminate distracting
> dead wood, and it makes it run (slightly) faster, because the run time checks
> are eliminated.
>
>
> Thanks!
> and
> RSVP
> John Zavgren
> john.zavg...@oracle.com
>
>
>
>
--
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...
run time logic isn't actually needed anymore because openJDK
>> doesn't support Linux kernel 2.2.X, and consequently one cannot run openJDK
>> on these older OSes. The run time checks are never used.
>>
>> The proposed changes to the code
>> (http://cr.o
not equivalent to a Huggy Bear sofa so garish as to require one to
> wear peril sensitive sunglasses.
Personally, I also don't think that the coding style is important. It's
important to have the style common one over all code - which one doesn't
really matter.
-Dmitry
--
Dmi
ations". That option
> seems complicated and dangerous.
>
> Thanks!
> John Zavgren
> john.zavg...@oracle.com
>
--
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...
Changeset: 0c1c4b185451
Author:dsamersoff
Date: 2012-09-29 15:44 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c1c4b185451
7186723: TEST_BUG: Race condition in
sun/management/jmxremote/startstop/JMXStartStopTest.sh
Summary: Make test self-terminating and independent to cyg
the list. I'm not suggesting we don't continue to
> include it, rather just removing the guarantee that it is always
> present. The motivation for bringing this up is modules and compact
> profiles where it might be desirable to not include the ftp protocol
> handler for fo
Changeset: b2d8a99a049e
Author:dsamersoff
Date: 2012-10-17 18:34 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b2d8a99a049e
6809322: javax.management.timer.Timer does not fire all notifications
Summary: Some notifications get dropped due to ConcurrentModificationException
t
gt; structure. This change eliminates
> a false positive from our static code analyzer: parfait. This modification
> doesn't change any of the externally-visible behavior in the procedure.
>
> I look forward to your comments and suggestions.
>
> Thanks!
> John Zavgren
>
age is in the following location:
>
> http://cr.openjdk.java.net/~chegar/8000203/webrev.01/
>
> Thanks!
> John Zavgren
> john.zavg...@oracle.com
>
--
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...
The webrev image is in the following location:
>>>
>>> http://cr.openjdk.java.net/~chegar/8000203/webrev.01/
>>>
>>> Thanks!
>>> John Zavgren
>>> john.zavg...@oracle.com
>
--
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...
h.
>
> http://cr.openjdk.java.net/~chegar/8002297/webrev.00/webrev/
>
> -Chris
--
Dmitry Samersoff
Java development team, SPB04
* There will come soft rains ...
On 2012-11-06 15:41, Chris Hegarty wrote:
> On 11/06/2012 11:30 AM, Dmitry Samersoff wrote:
>> Chris,
>>
>> If you need definitely refusing port the best option is use port 0
>> reserved by IANA for this purpose.
>
> Do you have a link specifying this? I don&#x
8, Chris Hegarty wrote:
>>>>> Trivial test issue where the test will fail if run on a machine
>>>>> that has
>>>>> a process listening on port 8080 ( test expects this port to refuse
>>>>> the
>>>>> connection ). The s
rmation in the original UTF-16 encoding.
> END QUOTE
>
> The link below may be helpful to the second param of
> WideCharToMultiByte.
> http://blogs.msdn.com/b/oldnewthing/archive/2012/05/04/10300670.aspx
>
> You comments are appreciated.
> Best regards,
> Frank
>
--
Dmitry Samersoff
Saint Petersburg, Russia, http://devnull.samersoff.net
* There will come soft rains ...
9:16:28 PM GMT -05:00 US/Canada Eastern
> Subject: Re: getportbyname in Java?
>
> I don't think so...
>
> Thanks,
> - Kurchi
>
> On 13.11.2012 16:40, Weijun Wang wrote:
>> Is there a Java API I can translate "http" to 80?
>>
>> Thanks
>> Max
>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
right file name but the wrong content. 'sorry about that.)
>
> http://cr.openjdk.java.net/~mullan/webrevs/8003991/webrev.00/
>
> Thanks!
> John Zavgren
>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
inSocketImpl.getIn/OutputStream where isClosedOrPending()
> grabs the fdLock to check if the socket is closed, or not, and the
> construction of the in/output stream, where another thread may
> asynchronously close the socket.
>
> http://cr.openjdk.java.net/~chegar/8003833/webrev.00/
>>
>> -Alan
>
> just checked the new build on Linux and it's fine.
> There are a couple of other fixes that will follow this one
> related to this problem. But, I'd like to go ahead and push this one first
> if possible
>
> - Michael
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
?
>>
>> Best regards,
>> Frank
>>
>> On 11/14/2012 12:12 AM, Chris Hegarty wrote:
>>> On 11/11/2012 07:03 PM, Dmitry Samersoff wrote:
>>>> Frank,
>>>>
>>>> Changes look good for me.
>>>
>>> I admit that I a
t;. What
> about that?
>
> Best regards,
> Frank
>
> On 12/10/2012 3:43 PM, Dmitry Samersoff wrote:
>> Frank,
>>
>> Looks good for me.
>>
>> May be "Can't get WIDE string" should be changed to something more
>> verbose.
>>
web servers and proxies.
>
> Thanks
> Michael
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
20.7u-dev/webrev.1/
I see a comment // MMM 7200720 ??
at ll: 202 of NTLMAuthentication.java
- Does it make sense to change it to something more verbose?
Otherwise looks good for me.
> http://cr.openjdk.java.net/~michaelm/8003948.7u-dev/webrev.1/
Looks good for me.
-Dmitry
--
Dmitry
an simply be removed.
>
> http://cr.openjdk.java.net/~chegar/8004675/webrev.00/webrev/
>
> -Chris.
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
The Server in this
> case doesn't ever receive the destination address or host name. It is
> simply replying to the initial/opening SOCKS handshake.
>
> The updated host name is still brittle ( if a .t TLD is ever registered!
> ). I don't have a better alternative.
>
> -Ch
On 2012-12-12 22:29, Chris Hegarty wrote:
> On 12/12/2012 18:15, Dmitry Samersoff wrote:
>> Chris,
>>
>> According to rfc2606 TLD .invalid is reserved for cases like this one,
>
> Yes, I came across this, but there is nothing to stop an internal DNS
> server f
to define buffer lengths. Were one to supply a
> negative value as an argument, it would be cast into an unsigned "Martian"
> value and there'd be (hopefully) a system call error.
>
> Thanks!
> John Zavgren
>
> http://cr.openjdk.java.net/~mullan/webrevs/jz
declared as integers, but they must be "unsigned"
>> integers because they are used to define buffer lengths. Were one to supply
>> a negative value as an argument, it would be cast into an unsigned "Martian"
>> value and there'd be (hopefully) a system cal
t stem from the fact that the variables
>>> that the native code passes to various system calls were not declared
>>> correctly. They were declared as integers, but they must be "unsigned"
>>> integers because they are used to define buffer lengths. Were one to su
Changeset: b600d490dc57
Author:dsamersoff
Date: 2012-12-20 16:02 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b600d490dc57
6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject
Summary: call readObject in all cases
Reviewed-by: emcmanus
Contributed-by:
Changeset: e43f90d5af11
Author:dsamersoff
Date: 2012-12-20 16:56 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e43f90d5af11
6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure
Summary: the catch block in the fetchNotifs() method is extended to expe
Changeset: 3f014bc09297
Author:dsamersoff
Date: 2012-12-20 17:24 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f014bc09297
7009998: JMX synchronization during connection restart is faulty
Summary: add a return statement after the re-connecting has finished and the
state is
t;>> serviceability-dev list as that is where this code is maintained.
>>>>
>>>> On 19/12/2012 15:36, John Zavgren wrote:
>>>>> Greetings:
>>>>> Please consider the following change to the two files:
>>>>> src/share/transport/s
Changeset: c1a55ee9618e
Author:dsamersoff
Date: 2012-12-20 20:12 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1a55ee9618e
8005309: Missed tests for 6783290,6937053,7009998
Summary: Missed tests for 6783290,6937053,7009998
Reviewed-by: sjiang, emcmanus
Contributed-by: jaros
On 12/19/2012 03:42 PM, Alan Bateman wrote:
>>>>>
>>>>> John - this is the debugger socket transport so cc'ing the
>>>>> serviceability-dev list as that is where this code is maintained.
>>>>>
>>>>> On 19/12/2012 15:36, John Zavgren wrote:
>>>>>> Greetings:
>>>>>> Please consider the following change to the two files:
>>>>>> src/share/transport/socket/sysSocket.h
>>>>>> src/solaris/transport/socket/socket_md.c
>>>>>> that eliminate compiler warnings that stem from the fact that the
>>>>>> variables that the native code passes to various system calls were not
>>>>>> declared correctly. They were declared as integers, but they must be
>>>>>> "unsigned" integers because they are used to define buffer lengths.
>>>>>> Were one to supply a negative value as an argument, it would be cast
>>>>>> into an unsigned "Martian" value and there'd be (hopefully) a system
>>>>>> call error.
>>>>>>
>>>>>> Thanks!
>>>>>> John Zavgren
>>>>>>
>>>>>> http://cr.openjdk.java.net/~mullan/webrevs/jzavgren/8005120/
>>>>>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
ket/socketTransport.c:371:33:
>>>>> warning: pointer targets in passing argument 3 of 'dbgsysAccept'
>>>>> differ
>>>>> in signedness [-Wpointer-sign]
>>>>> ../../../../src/share/transport/socket/sysSocket.h:41:5: note:
>>&
s
> issue is concerned changes will only be make to the Linux version of
> closefd.
>
> Webrev
> ---
>
> http://cr.openjdk.java.net/~chegar/8006395/webrev.00/webrev/
>
> -Chris.
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
Changeset: 962d6612cace
Author:dsamersoff
Date: 2013-02-03 21:39 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/962d6612cace
8002048: Protocol to discovery of manageable Java processes on a network
Summary: Introduce a protocol to discover manageble Java instances across a
n
Changeset: 0e7d5dd84fdf
Author:dsamersoff
Date: 2013-02-06 16:53 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e7d5dd84fdf
8007277: JDK-8002048 testcase fails to compile
Summary: sun.* classes is not included to ct.sym file and symbol file have to
be ignored
Reviewed-by: a
Changeset: 1df991184045
Author:dsamersoff
Date: 2013-02-11 18:44 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1df991184045
8007536: Incorrect copyright header in JDP files
Summary: Copyright header in JDP files missed the "classpath exception" rule.
Reviewed-by: mikael
! s
Changeset: f7fb173ac833
Author:dsamersoff
Date: 2013-02-12 16:02 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f7fb173ac833
8007786: JDK-8002048 testcase doesn't work on Solaris
Summary: test built in into Solaris shell doesn't have -e operator
Reviewed-by: sla, sspitsyn
!
Changeset: 8181be9a3538
Author:dsamersoff
Date: 2013-02-13 21:06 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8181be9a3538
8008095: TEST_BUG: JDK-8002048 one more testcase failure on Solaris
Summary: fixed couple of more Solaris shell incompatibilities
Reviewed-by: chegar
John,
closesocket call should be here.
-Dmitry
On 2013-03-04 20:12, John Zavgren wrote:
> Greetings:
>
> I posted a webrev image for a modification that eliminates a file descriptor
> leak.
>
> http://cr.openjdk.java.net/~jzavgren/8008804/webrev.01/
>
> Thanks
e here.
>
> -Dmitry
>
> On 2013-03-04 20:12, John Zavgren wrote:
>> Greetings:
>>
>> I posted a webrev image for a modification that eliminates a file descriptor
>> leak.
>>
>> http://cr.openjdk.java.net/~jzavgren/8008804/webrev.01/
>>
>&g
:18, Rob McKenna wrote:
> Hi folks,
>
> This is a slight alteration of the fix contributed by Stuart Douglas.
> This fix deals with a SocketException caused by getSoTimeout() on a
> closed connection.
>
> http://cr.openjdk.java.net/~robm/8009650/webrev.01/
>
>
rote:
> Hi Dmitry,
>
> I'm not 100% sure what you mean by duplication, the exceptions and their
> messages are distinct. I think it would be best to keep it that way.
>
> -Rob
>
> On 07/03/13 22:00, Dmitry Samersoff wrote:
>> Rob,
>>
>> Is it po
gt;> Ah, I see what you mean. Can do.
>>
>> -Rob
>>
>> On 07/03/13 23:13, Dmitry Samersoff wrote:
>>> Rob,
>>>
>>> Sorry for not being clean enough. We have repeated pattern:
>>>
>>> if (logger.isLoggable(PlatformLogger.FINEST)) {
>
jdk.java.net/~chegar/8012244/webrev.00/webrev/
>
> -Chris.
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
> without checking it's returned value.
>
> http://cr.openjdk.java.net/~jzavgren/8012108/webrev.01/
>
> Thanks!
> John Zavgren
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
ADAPTER_ADDRESSES *) realloc (adapterInfo, len);
>>
>> -Dmitry
>>
>> On 2013-04-19 00:56, John Zavgren wrote:
>>> Greetings:
>>>
>>> I fixed a case in the windows native code where calloc() was being used
>>> without checking it's retu
20, 2013, at 3:16 AM, Dmitry Samersoff
> wrote:
>
>> John,
>>
>> 102, 145 else is redundant.
>>
>> 438 - we will crash here if start is null
>
>
> Maybe it is good to have an additional check for start != null, but from what
>
errors
> occur, we make the assignment:
> *netaddrPP = start at line 429 and return immediately (without
> considering start->next).
>
> If you see any errors in my thinking, please let me know.
> Thanks!
> John
>
>
> On 04/20/2013 07:40 AM, Dmitry Samersoff wrote:
>&
v.03/
> <http://cr.openjdk.java.net/%7Ejzavgren/8012108/webrev.03/>
>
> Thanks!
> John
>
> On 04/20/2013 10:36 AM, Kurchi Subhra Hazra wrote:
>> On Apr 20, 2013, at 4:40 AM, Dmitry Samersoff
>> wrote:
>>
>>> Kurchi,
>>>
>>> if *neta
ly
>>>>> submitted.
>>>>>
>>>>> This is for JEP 184: HTTP URL Permissions
>>>>>
>>>>> The idea here is to define a higher level http permission class
>>>>> which "knows about" URLs, HTTP request methods and headers.
>>>>> So, it is no longer necessary to grant blanket permission for any kind
>>>>> of TCP connection to a host/port. Instead a HttpURLPermission
>>>>> restricts
>>>>> access to only the Http protocol itself. Restrictions can also be
>>>>> imposed
>>>>> based on URL paths, specific request methods and request headers.
>>>>>
>>>>> The API change can be seen at the URL below:
>>>>>
>>>>> http://cr.openjdk.java.net/~michaelm/8010464/api/
>>>>>
>>>>> In addition to defining a new permission class, HttpURLConnection
>>>>> is modified to make use of it and the documentation change
>>>>> describing this
>>>>> can be seen at the link below:
>>>>>
>>>>> http://cr.openjdk.java.net/~michaelm/8010464/api/blender.html
>>>>>
>>>>> All comments welcome.
>>>>>
>>>>> Thanks
>>>>>
>>>>> Michael.
>>>
>>
>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer
2013-05-01 15:04, Michael McMahon wrote:
> On 01/05/13 11:09, Dmitry Samersoff wrote:
>> Michael,
>>
>>> "GET,POST:Header1,Header2"
>> Colon is a delimiter between http header and it's value.
>>
>> With this syntax we might have problems in a future
character.
>
> Michael
>
> On 01/05/13 12:11, Dmitry Samersoff wrote:
>> Michael,
>>
>> I'm just asking about replacing : (colon) to another character to be
>> able to write something like:
>>
>> permission
>> java.net.HttpURLPermissio
o you to make a decision.
-Dmitry
>
> - Michael
>
> On 01/05/13 12:38, Dmitry Samersoff wrote:
>> Michael,
>>
>> Sorry for not being clean enough.
>>
>> On my opinion an ability to check header value as well as a header name
>> is quite useful future for
1 - 100 of 118 matches
Mail list logo
