Chris,

Looks good for me.

-Dmitry


On 2010-07-28 12:25, Chris Hegarty wrote:
Dmitry, Alan,

The Solaris version of getFlags sets an Exception if the ioctl fails.
When used in addif getFlags will fail when access to the virtual
interface's parent is forbidden, i.e. in a zone. addif is called when
iterating over interfaces in enumIPvXInterfaces, if an exception occurs
it simply cleans up and returns, propagating the exception.

getFalgs should not set an exception. All other calls to it check the
return value and set an exception if appropriate.

Webrev:
http://cr.openjdk.java.net/~chegar/6972374/webrev.00/webrev/

Thanks,
-Chris.


--
Dmitry Samersoff
J2SE Sustaining team, SPB04
* Give Rabbit time and he'll always get the answer ...

Reply via email to