Alan,
Thank you for the comments.
Fixed.
http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.04/
-Dmitry
On 2010-07-12 12:00, Alan Bateman wrote:
Dmitry Samersoff wrote:
Chris,
Please review my changes.
see:
http://cr.openjdk.java.net/~dsamersoff/6964714/webrev.03/
-Dmitry
The fix to NetworkInterface.c looks good to me.
I notice you've got the Sun copyright header in the test so that should
be fixed. Also I agree with Chris's comment that the test can simply
check if the Enumeration contains an element that is an instance of
Inet6Address. Minor nit is that you seem to be intending by 8 instead of
4 spaces. Given that the test is in the NetworkInterface directory then
an alternative name might be IPv4Only.java (keep the name short?).
-Alan.
--
Dmitry Samersoff
J2SE Sustaining team, SPB04
* Give Rabbit time and he'll always get the answer ...