Add IDN support to existing net APIs

2014-02-18 Thread Jonathan Lu
or re-compilation. What's your opinion on this ? any comment is welcome. Thank you - Jonathan Lu --- [1] http://en.wikipedia.org/wiki/Internationalized_domain_name [2] http://download.java.net/jdk8/docs/api/java/net/IDN.html [3] http://www.unicode.org/reports/tr36/ [

Re: Add IDN support to existing net APIs

2014-03-24 Thread Jonathan Lu
l.x.mcma...@oracle.com> wrote: > On 20/02/14 03:15, Jonathan Lu wrote: > > > Hi Michael, > > Thanks a lot for your comments. > > On Wed, Feb 19, 2014 at 6:28 PM, Michael McMahon < > michael.x.mcma...@oracle.com> wrote: > >> I think it's a good

RFR 8043954: Fix behavior difference of connect() for AIX

2014-06-03 Thread Jonathan Lu
Hello, Could I have following patch reviewed for bug 8034954 ? http://cr.openjdk.java.net/~luchsh/JDK-8043954/ The patch is to fix a behavior difference of connect() API for AIX platform, according to the documentation, http://www-01.ibm.com/support/knowledgecenter/ssw_aix_71/com.ibm.aix.commtrf

Re: RFR 8043954: Fix behavior difference of connect() for AIX

2014-06-03 Thread Jonathan Lu
urrent implementation (just curious)? > The change is now an improvement. > > Thank you and best regards, > Volker > > > On Tue, Jun 3, 2014 at 11:51 AM, Jonathan Lu > wrote: > > Hello, > > > > Could I have following patch reviewed for bug 8034954 ? > &g

Re: RFR 8043954: Fix behavior difference of connect() for AIX

2014-06-05 Thread Jonathan Lu
Hi Alan, On Wed, Jun 4, 2014 at 9:16 PM, Alan Bateman wrote: > On 04/06/2014 07:31, Jonathan Lu wrote: > >> Hi Volker, >> >> Thanks for your comment! an updated webrev was made at >> http://cr.openjdk.java.net/~luchsh/JDK-8043954.2/ >> >> Would it make

Re: RFR 8043954: Fix behavior difference of connect() for AIX

2014-06-06 Thread Jonathan Lu
Hi Alan, On Fri, Jun 6, 2014 at 1:53 AM, Alan Bateman wrote: > On 05/06/2014 11:37, Jonathan Lu wrote: > > > If getsockopt(SO_ERROR) failed, I did not find any explicit docs about > the behavior. > but as I tested with some C code snippet, the value of sockopt_arg would &

Re: RFR 8043954: Fix behavior difference of connect() for AIX

2014-06-06 Thread Jonathan Lu
ression tests without specific issues. > > So thumbs up from me! > > Regards, > Volker > > > On Fri, Jun 6, 2014 at 12:03 PM, Jonathan Lu > wrote: > > Hi Alan, > > > > On Fri, Jun 6, 2014 at 1:53 AM, Alan Bateman > > wrote: > > > >>

Crash problem in net.dll

2011-08-29 Thread Jonathan Lu
= netaddrP; Best regards! Jonathan Lu

Re: Crash problem in net.dll

2011-08-29 Thread Jonathan Lu
netaddrP); +if (count == -1) { return NULL; } } And from my point of view, such scenario may also appear in other parts, maybe a more thorough check is needed for all modules. Regards! - Jonathan Lu On 08/29/2011 04:40 PM, Michael McMahon wrote: Jonathan, I think the chan

Re: Crash problem in net.dll

2011-09-07 Thread Jonathan Lu
/webrev.1/ Thanks, Michael. On 29/08/11 15:33, Michael McMahon wrote: Jonathan, Bug id 7084560 has been created to track this. That fix looks fine to me. Thanks, Michael. On 29/08/11 10:20, Jonathan Lu wrote: Hi Michael, Thanks for reminding, I checked the source under src/windows folder and

Re: Crash problem in net.dll

2011-09-07 Thread Jonathan Lu
Aha, got it, thanks! Jonathan. On 09/07/2011 04:19 PM, Michael McMahon wrote: Jonathan, The tests were fine amd the fix was pushed last week. Michael. On 07/09/11 09:14, Jonathan Lu wrote: Hi Michael, Any news about the testing results of this patch? Thanks Jonathan On 08/29/2011 11:02

java.net.NetworkInterface.getNetworkInterfaces does not work properly on AIX with IPv6

2011-10-17 Thread Jonathan Lu
Hi net-devs, I've got a problem on AIX operating system when IPv6 is enabled,which can be easily reproduced by attached test case NetworkInterfaceTest.java. On AIX paltform, the /proc file system behaves differently from Linux, so we cannot just read required lines from /proc/net/if_inet6 but t

Re: java.net.NetworkInterface.getNetworkInterfaces does not work properly on AIX with IPv6

2011-10-19 Thread Jonathan Lu
On 10/19/2011 06:03 PM, Steve Poole wrote: On Mon, 2011-10-17 at 15:14 +0800, Jonathan Lu wrote: Hi net-devs, I've got a problem on AIX operating system when IPv6 is enabled,which can be easily reproduced by attached test case NetworkInterfaceTest.java. On AIX paltform, the /proc file s

Re: java.net.NetworkInterface.getNetworkInterfaces does not work properly on AIX with IPv6

2011-10-19 Thread Jonathan Lu
On 10/20/2011 01:24 PM, Jonathan Lu wrote: On 10/19/2011 06:03 PM, Steve Poole wrote: On Mon, 2011-10-17 at 15:14 +0800, Jonathan Lu wrote: Hi net-devs, I've got a problem on AIX operating system when IPv6 is enabled,which can be easily reproduced by attached test

Re: java.net.NetworkInterface.getNetworkInterfaces does not work properly on AIX with IPv6

2011-10-20 Thread Jonathan Lu
On 10/20/2011 02:35 PM, Steve Poole wrote: On Thu, 2011-10-20 at 13:24 +0800, Jonathan Lu wrote: On 10/19/2011 06:03 PM, Steve Poole wrote: On Mon, 2011-10-17 at 15:14 +0800, Jonathan Lu wrote: Hi net-devs, I've got a problem on AIX operating system when IPv6 is enabled,which can be e

Re: java.net.NetworkInterface.getNetworkInterfaces does not work properly on AIX with IPv6

2011-10-21 Thread Jonathan Lu
On 10/20/2011 09:16 PM, Neil Richards wrote: On Thu, 2011-10-20 at 17:12 +0800, Jonathan Lu wrote: On 10/20/2011 02:35 PM, Steve Poole wrote: Thanks Steve, I've updated the test case and patch, see the attachments. I've added IBM portions copyright comment to both headers. - Jonathan

Re: Question about getaddrinfo in Inet4AddressImpl.c

2011-10-25 Thread Jonathan Lu
Hello Chris, On 10/25/2011 05:41 PM, Chris Hegarty wrote: On 10/25/11 08:31 AM, Charles Lee wrote: Hi guys, I am reading some native code in the jdk repos. I find that in Inet4AddressImpl.c (folder solaris), gethostbyname is used. Meanwhile in the Inet6AddressImpl.c. getaddrinfo is used. My q

Re: A little modification to error message

2012-07-05 Thread Jonathan Lu
Hi Sean, Patch committed Changeset: 15a6b0bceb1e Author:zhouyx Date: 2012-07-06 10:36 +0800 URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/15a6b0bceb1e 7181353: Update error message to distinguish native OOM and java OOM in net Reviewed-by: chegar ! src/solaris/native/java/net/Inet4Ad

Re: Suggestion of combining some macros of processing solaris, macosx with other UNIX

2012-08-17 Thread Jonathan Lu
On 08/17/2012 04:14 PM, Chris Hegarty wrote: On 16/08/12 10:21, Frank Ding wrote: Hi Chris and Alan, Thank you for taking time to help this issue. I have built using latest openjdk 8 repo on Windows 64 and Linux 32/64. Since it's a macro change in path "src/solaris", I only did jtreg t

Re: Request for code review 6512101: Incorrect encoding in NetworkInterface.getDisplayName()

2012-12-10 Thread Jonathan Lu
Hi Frank, Patch pushed @ http://hg.openjdk.java.net/jdk8/tl/jdk/rev/883feced1cdd Best regards! - Jonathan On 12/11/2012 09:49 AM, Frank Ding wrote: Hi All, Thank you all. I will have Jonathan help to commit. Best regards, Frank On 12/10/2012 6:12 PM, Chris Hegarty wrote: On 10/12/2012 08