Hi Sean,
Patch committed
Changeset: 15a6b0bceb1e
Author: zhouyx
Date: 2012-07-06 10:36 +0800
URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/15a6b0bceb1e
7181353: Update error message to distinguish native OOM and java OOM in net
Reviewed-by: chegar
! src/solaris/native/java/net/Inet4AddressImpl.c
! src/solaris/native/java/net/Inet6AddressImpl.c
! src/solaris/native/java/net/NetworkInterface.c
! src/solaris/native/java/net/PlainDatagramSocketImpl.c
! src/windows/native/java/net/DualStackPlainDatagramSocketImpl.c
! src/windows/native/java/net/Inet6AddressImpl.c
! src/windows/native/java/net/NetworkInterface.c
! src/windows/native/java/net/TwoStacksPlainDatagramSocketImpl.c
Please verify
Regards
Jonathan
On 07/03/2012 02:10 PM, Sean Chou wrote:
A bug is reported.
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7181353 .
On Mon, Jul 2, 2012 at 3:57 PM, Chris Hegarty
<chris.hega...@oracle.com <mailto:chris.hega...@oracle.com>> wrote:
Thanks Sean, looks fine to me.
-Chris
Sean Chou <zho...@linux.vnet.ibm.com
<mailto:zho...@linux.vnet.ibm.com>> wrote:
>Hello,
>
> Any one would like to take a look again ?
>
>---------- Forwarded message ----------
>From: Sean Chou <zho...@linux.vnet.ibm.com
<mailto:zho...@linux.vnet.ibm.com>>
>Date: Tue, Jun 26, 2012 at 1:03 PM
>Subject: Re: A little modification to error message
>To: Chris Hegarty <chris.hega...@oracle.com
<mailto:chris.hega...@oracle.com>>
>Cc: net-dev@openjdk.java.net <mailto:net-dev@openjdk.java.net>
>
>
>Hi Chris,
>
> They are not all native OOMs, I made a new one which includes
all of
>them. Please take a look.
>
>webrev: http://cr.openjdk.java.net/~zhouyx/OJDK-528/webrev.01/
<http://cr.openjdk.java.net/%7Ezhouyx/OJDK-528/webrev.01/>
>
>
>On Thu, Jun 21, 2012 at 5:23 PM, Chris Hegarty
<chris.hega...@oracle.com <mailto:chris.hega...@oracle.com>>
> wrote:
>
>> Sean,
>>
>> The updated error messages look fine to me.
>>
>> Are these all the possibly native OOM throw sites in the
networking area,
>> or just some you came across?
>>
>> -Chris.
>>
>>
>> On 21/06/2012 06:41, Sean Chou wrote:
>>
>>> Hi all,
>>>
>>> We did some modification in these error messages because
of some
>>> user feedback “It is confusing to realize if the OOM is from
java heap
>>> or native heap”. So these error messages are modified from "heap
>>> allocation failed" to "Native heap allocation failed". And in some
>>> places a little more to help locate to functions like "send
buffer heap
>>> allocation failed".
>>> Would any one like to take a look?
>>>
>>> webrev:
http://cr.openjdk.java.net/~**zhouyx/OJDK-528/webrev.00/
<http://cr.openjdk.java.net/%7E**zhouyx/OJDK-528/webrev.00/><http://cr.openjdk.java.net/~zhouyx/OJDK-528/webrev.00/
<http://cr.openjdk.java.net/%7Ezhouyx/OJDK-528/webrev.00/>>
>>> .
>>>
>>> --
>>> Best Regards,
>>> Sean Chou
>>>
>>>
>
>
>--
>Best Regards,
>Sean Chou
>
>
>
>
>--
>Best Regards,
>Sean Chou
--
Best Regards,
Sean Chou
