Hi Alan, On Wed, Jun 4, 2014 at 9:16 PM, Alan Bateman <alan.bate...@oracle.com> wrote:
> On 04/06/2014 07:31, Jonathan Lu wrote: > >> Hi Volker, >> >> Thanks for your comment! an updated webrev was made at >> http://cr.openjdk.java.net/~luchsh/JDK-8043954.2/ >> >> Would it make sense to set errno to sockopt_arg for the case that > getsockopt(SO_ERROR) returns an error? Otherwise it looks okay to me. > If getsockopt(SO_ERROR) failed, I did not find any explicit docs about the behavior. but as I tested with some C code snippet, the value of sockopt_arg would not be changed if getsockopt(SO_ERROR) failed. So I prefer to keep the current approach, does it make sense to you ? > > -Alan. > Many thanks Jonathan
