Re: getCanonicalHostName on Windows

2008-03-04 Thread Christopher Hegarty
Hi Max, The Java methods that you are using are correct. As it is specified "best effort" is used to determine the FQDN. getByName will try to do forward lookup of k1.n3.local to retrieve its address, which I assumes will succeed. Then this address is used to do a reverse lookup to determine

hg: jdk7/jsn/jdk: 6667108: typo in javadoc for java.net.Socket.getRemoteSocketAddress()

2008-03-07 Thread christopher . hegarty
Changeset: a100f699c155 Author:chegar Date: 2008-03-07 09:57 + URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/a100f699c155 6667108: typo in javadoc for java.net.Socket.getRemoteSocketAddress() Summary: Simple typo in method specification. Reviewed-by: jccollet ! src/share/cla

hg: jdk7/jsn/jdk: 6615656: Removed unimplemented java.net methods

2008-03-07 Thread christopher . hegarty
Changeset: 328415dfe347 Author:chegar Date: 2008-03-07 11:30 + URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/328415dfe347 6615656: Removed unimplemented java.net methods Reviewed-by: jccollet ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/share/classes/java/

hg: jdk7/jsn/jdk: 6591358: documentation error in URLConnection.setRequestProperty("accept", ...)

2008-03-07 Thread christopher . hegarty
Changeset: 10d5be3e1fa8 Author:chegar Date: 2008-03-07 11:51 + URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/10d5be3e1fa8 6591358: documentation error in URLConnection.setRequestProperty("accept", ...) Summary: Simple doc change, "accept" -> "Accept" Reviewed-by: jccollet !

hg: jdk7/jsn/jdk: 6628576: InterfaceAddress.equals() NPE when broadcast field == null

2008-03-07 Thread christopher . hegarty
Changeset: 50a8b5ca8f39 Author:chegar Date: 2008-03-07 13:00 + URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/50a8b5ca8f39 6628576: InterfaceAddress.equals() NPE when broadcast field == null Summary: Update logic in equals to correctly handle nulls. Reviewed-by: michaelm ! sr

hg: jdk7/jsn/jdk: 6659779: HttpURLConnections logger should log tunnel requests

2008-04-15 Thread christopher . hegarty
Changeset: 459d23a95dfb Author:chegar Date: 2008-04-15 14:22 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/459d23a95dfb 6659779: HttpURLConnections logger should log tunnel requests Summary: Invoke Logger for CONNECT request/responses. Reviewed-by: jccollet ! src/share/cla

hg: jdk7/jsn/jdk: 6687282: URLConnection for HTTPS connection through Proxy w/ Digest Authentication gives 400 Bad Request

2008-04-16 Thread christopher . hegarty
Changeset: a954a6f3be6f Author:chegar Date: 2008-04-16 14:17 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/a954a6f3be6f 6687282: URLConnection for HTTPS connection through Proxy w/ Digest Authentication gives 400 Bad Request Summary: Change http/digest implementation to us

hg: jdk7/jsn/jdk: 6687919: REGRESSION : Classloader can handle any resource which is not included in classpath

2008-05-02 Thread christopher . hegarty
Changeset: d95a6a4ea502 Author:chegar Date: 2008-05-02 21:33 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/d95a6a4ea502 6687919: REGRESSION : Classloader can handle any resource which is not included in classpath Reviewed-by: jccollet, alanb ! src/share/classes/sun/misc/U

hg: jdk7/jsn/jdk: 6670408: testcase panics 1.5.0_12&_14 JVM when java.net.PlainSocketImpl trying to throw an exception

2008-05-15 Thread christopher . hegarty
Changeset: ca48d7cc3579 Author:chegar Date: 2008-05-15 10:26 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/ca48d7cc3579 6670408: testcase panics 1.5.0_12&_14 JVM when java.net.PlainSocketImpl trying to throw an exception Summary: Replace select with poll Reviewed-by: alanb

hg: jdk7/jsn/jdk: 6729881: Compiler warning in networking native code

2008-07-28 Thread christopher . hegarty
Changeset: b7fce4bac617 Author:chegar Date: 2008-07-28 13:02 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/b7fce4bac617 6729881: Compiler warning in networking native code Summary: Cleanup compiler warnings Reviewed-by: alanb, jccollet, michaelm ! src/solaris/native/java/n

hg: jdk7/jsn/jdk: 6730740: Fix for 6729881 has apparently broken several 64 bit tests: "Bad address"

2008-07-29 Thread christopher . hegarty
Changeset: 441f88d39988 Author:chegar Date: 2008-07-29 09:53 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/441f88d39988 6730740: Fix for 6729881 has apparently broken several 64 bit tests: "Bad address" Reviewed-by: alanb, jccollet ! src/solaris/native/java/net/linux_clo

hg: jdk7/jsn/jdk: 6734171: java.net.NetworkInterface reports XCheck:jni warnings

2008-08-06 Thread christopher . hegarty
Changeset: 97d08b2b4539 Author:chegar Date: 2008-08-06 07:14 -0700 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/97d08b2b4539 6734171: java.net.NetworkInterface reports XCheck:jni warnings Summary: Removed leading "L" or trailing ";" from FindClass classname param Reviewed-by: al

hg: jdk7/jsn/jdk: 6746836: java.net exception classes don't specify serialVersionUID

2008-09-19 Thread christopher . hegarty
Changeset: c54ce70a3668 Author:chegar Date: 2008-09-19 15:14 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/c54ce70a3668 6746836: java.net exception classes don't specify serialVersionUID Reviewed-by: alanb, jccollet ! make/sun/net/spi/Makefile ! make/sun/net/spi/nameservic

hg: jdk7/jsn/jdk: 6621697: Problem with file test/sun/net/www/http/ChunkedInputStream/test.txt

2008-09-24 Thread christopher . hegarty
Changeset: de7864ec310c Author:chegar Date: 2008-09-24 17:10 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/de7864ec310c 6621697: Problem with file test/sun/net/www/http/ChunkedInputStream/test.txt Reviewed-by: michaelm ! test/sun/net/www/http/ChunkedInputStream/ChunkedEnco

hg: jdk7/jsn/jdk: 6752807: java.net test ADatagramSocket.sh is broken

2008-09-26 Thread christopher . hegarty
Changeset: 8b0be0bc4b14 Author:chegar Date: 2008-09-26 11:24 +0100 URL: http://hg.openjdk.java.net/jdk7/jsn/jdk/rev/8b0be0bc4b14 6752807: java.net test ADatagramSocket.sh is broken Summary: update bootclasspath set by test to simply prepend TESTCLASSES Reviewed-by: michaelm ! test/

hg: jdk7/tl/jdk: 6756771: com.sun.net.httpserver.HttpServer should handle POSTs larger than 2Gig

2008-10-28 Thread christopher . hegarty
Changeset: 98ac3d398ed6 Author:chegar Date: 2008-10-28 16:14 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/98ac3d398ed6 6756771: com.sun.net.httpserver.HttpServer should handle POSTs larger than 2Gig Summary: update implementation to use long instead of int Reviewed-by: mich

hg: jdk7/tl/jdk: 2 new changesets

2008-11-13 Thread christopher . hegarty
Changeset: a85ef87f9eaa Author:chegar Date: 2008-11-12 16:38 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a85ef87f9eaa 6755625: Add HttpURLConnection.setFixedLengthStreamingMode(long) Reviewed-by: jccollet ! src/share/classes/com/sun/net/ssl/internal/www/protocol/https/Ht

hg: jdk7/tl/jdk: 6720866: Slow performance using HttpURLConnection for upload

2008-11-26 Thread christopher . hegarty
Changeset: a0709a172b6d Author:chegar Date: 2008-11-26 15:37 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a0709a172b6d 6720866: Slow performance using HttpURLConnection for upload Reviewed-by: michaelm ! src/share/classes/sun/net/www/http/ChunkedOutputStream.java

hg: jdk7/tl/jdk: 6755782: It is not clear how DatagramSocket deals with broadcast enabling/disabling

2009-01-14 Thread christopher . hegarty
Changeset: 8c1c6e11204b Author:chegar Date: 2009-01-14 17:17 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8c1c6e11204b 6755782: It is not clear how DatagramSocket deals with broadcast enabling/disabling Reviewed-by: jccollet ! src/share/classes/java/net/DatagramSocket.jav

hg: jdk7/tl/jdk: 6799040: Portability issues in src/solaris/native/java/net/Inet4AddressImpl.c

2009-02-11 Thread christopher . hegarty
Changeset: 043dfafc41a5 Author:chegar Date: 2009-02-11 13:16 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/043dfafc41a5 6799040: Portability issues in src/solaris/native/java/net/Inet4AddressImpl.c Reviewed-by: alanb Contributed-by: chris...@zoulas.com ! src/solaris/native/

hg: jdk7/tl/jdk: 6800805: java.net.NetworkInterface.getNetworkInterfaces() does not list IPv6 network interfaces correctly

2009-02-16 Thread christopher . hegarty
Changeset: f8a9a7aff362 Author:chegar Date: 2009-02-16 17:19 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f8a9a7aff362 6800805: java.net.NetworkInterface.getNetworkInterfaces() does not list IPv6 network interfaces correctly Reviewed-by: jccollet ! src/solaris/native/java

hg: jdk7/tl/jdk: 6806649: synchronization bottleneck when constructing Thread subclasses

2009-02-23 Thread christopher . hegarty
Changeset: 0f4497002345 Author:chegar Date: 2009-02-23 10:36 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f4497002345 6806649: synchronization bottleneck when constructing Thread subclasses Summary: Replace subclass audits synchronization with ConcurrentHashMap with weakl

hg: jdk7/tl/jdk: 6775145: ClassLoaderUtil.releaseLoader calls System.out.println ("classLoader = " + classLoader)

2009-03-04 Thread christopher . hegarty
Changeset: 94d02968a504 Author:chegar Date: 2009-03-04 13:28 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/94d02968a504 6775145: ClassLoaderUtil.releaseLoader calls System.out.println ("classLoader = " + classLoader) Summary: Remove System.out debugging statements Reviewed-

hg: jdk7/tl/jdk: 6737323: Typo in javadoc for SocketPermission

2009-03-04 Thread christopher . hegarty
Changeset: 03001e92d155 Author:chegar Date: 2009-03-04 13:36 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/03001e92d155 6737323: Typo in javadoc for SocketPermission Summary: Remove redundant line form class description Reviewed-by: jccollet ! src/share/classes/java/net/Soc

hg: jdk7/tl/jdk: 6807602: Increase MAX_BUFFER_LEN and MAX_HEAP_BUFFER_LEN on 64-bit Solaris and Linux

2009-05-29 Thread christopher . hegarty
Changeset: 928e0f1043e6 Author:chegar Date: 2009-05-29 15:51 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/928e0f1043e6 6807602: Increase MAX_BUFFER_LEN and MAX_HEAP_BUFFER_LEN on 64-bit Solaris and Linux Reviewed-by: alanb ! src/solaris/native/java/net/net_util_md.h

hg: jdk7/tl/jdk: 6855335: Several changes in the SCTP implementation.

2009-06-29 Thread christopher . hegarty
Changeset: a44009aba19f Author:chegar Date: 2009-06-29 14:53 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a44009aba19f 6855335: Several changes in the SCTP implementation. Reviewed-by: michaelm ! make/com/sun/nio/sctp/mapfile-vers ! src/solaris/classes/sun/nio/ch/SctpChann

hg: jdk7/tl/jdk: 6863110: Newly connected/accepted SctpChannel should fire OP_READ if registered with a Selector

2009-07-23 Thread christopher . hegarty
Changeset: 645c1d0b9db9 Author:chegar Date: 2009-07-23 14:06 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/645c1d0b9db9 6863110: Newly connected/accepted SctpChannel should fire OP_READ if registered with a Selector Reviewed-by: jccollet ! src/solaris/classes/sun/nio/ch/Sc

hg: jdk7/tl/jdk: 2 new changesets

2009-08-07 Thread christopher . hegarty
Changeset: 0d99696fec64 Author:chegar Date: 2009-08-07 10:50 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0d99696fec64 6826780: URLClassPath should use HashMap instead of HashMap Summary: Replace URL with a String representation. Reviewed-by: michaelm, jccollet ! make/sun/

hg: jdk7/tl/jdk: 3 new changesets

2009-09-18 Thread christopher . hegarty
Changeset: c9cbd2a09fd4 Author:chegar Date: 2009-09-18 16:24 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c9cbd2a09fd4 6882609: Move default InMemoryCookieStore to java.net Summary: remove static dependency on sun.net.www.protocol.http Reviewed-by: alanb, jccollet ! make/s

hg: jdk7/tl/jdk: 2 new changesets

2009-09-22 Thread christopher . hegarty
Changeset: 023063a403ed Author:chegar Date: 2009-09-22 14:42 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/023063a403ed 6882654: Remove dependency on java.util.concurrent from KeepAlive implementaion Reviewed-by: michaelm ! src/share/classes/sun/net/www/http/KeepAliveCache.

hg: jdk7/tl/jdk: 6887364: SetOutgoingIf.java fails if run on multihomed machine without PIv6 on all interfaces

2009-10-07 Thread christopher . hegarty
Changeset: f864c15f6779 Author:chegar Date: 2009-10-07 17:23 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f864c15f6779 6887364: SetOutgoingIf.java fails if run on multihomed machine without PIv6 on all interfaces Reviewed-by: alanb ! test/java/net/MulticastSocket/SetOutgo

hg: jdk7/tl/jdk: 3 new changesets

2009-10-21 Thread christopher . hegarty
Changeset: 44fa9caa1727 Author:chegar Date: 2009-10-21 15:41 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/44fa9caa1727 6893238: Move NTLM and SPNEGO implementations into separate packages Reviewed-by: michaelm, alanb ! make/java/net/Makefile ! make/sun/net/FILES_java.gmk !

hg: jdk7/tl/jdk: 6894169: Move HttpLogFormatter into a separate package

2009-10-22 Thread christopher . hegarty
Changeset: 93f8d9494e05 Author:chegar Date: 2009-10-22 15:44 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/93f8d9494e05 6894169: Move HttpLogFormatter into a separate package Reviewed-by: alanb ! make/sun/net/FILES_java.gmk - src/share/classes/sun/net/www/protocol/http/Http

hg: jdk7/tl/jdk: 2 new changesets

2009-12-10 Thread christopher . hegarty
Changeset: ae944611249f Author:chegar Date: 2009-12-10 15:52 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ae944611249f 6909089: Memory leak occurs by lack of free for read buffer in SocketInputStream#read() Reviewed-by: alanb, jccollet ! src/windows/native/java/net/Socket

hg: jdk7/tl/jdk: 6915313: Reorganize implementation to make it more feasible to port to JDK6

2010-01-11 Thread christopher . hegarty
Changeset: fc5578368a0c Author:chegar Date: 2010-01-11 16:04 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fc5578368a0c 6915313: Reorganize implementation to make it more feasible to port to JDK6 Summary: This makes the SCTP implementation easier to run with Suns JDK6. Revie

hg: jdk7/tl/jdk: 6916922: (sctp) SO_RCVBUF & SO_SNDBUF returns twice the value set

2010-01-15 Thread christopher . hegarty
Changeset: b019cdae32dd Author:chegar Date: 2010-01-15 16:31 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b019cdae32dd 6916922: (sctp) SO_RCVBUF & SO_SNDBUF returns twice the value set Reviewed-by: alanb ! src/solaris/native/sun/nio/ch/SctpNet.c ! test/com/sun/nio/sctp/Sct

hg: jdk7/tl/jdk: 6916890: (sctp) SctpChannel.send may cause IAE if given a heap buffer with an offset

2010-01-18 Thread christopher . hegarty
Changeset: 680d7d312a30 Author:chegar Date: 2010-01-18 14:01 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/680d7d312a30 6916890: (sctp) SctpChannel.send may cause IAE if given a heap buffer with an offset Reviewed-by: alanb ! src/solaris/classes/sun/nio/ch/SctpChannelImpl.

hg: jdk7/tl/jdk: 6917317: (sctp) Remove dependency on handleSocketError

2010-01-18 Thread christopher . hegarty
Changeset: e0870a19b09e Author:chegar Date: 2010-01-18 14:56 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e0870a19b09e 6917317: (sctp) Remove dependency on handleSocketError Reviewed-by: alanb ! src/solaris/native/sun/nio/ch/SctpNet.c ! test/com/sun/nio/sctp/SctpChannel/Co

hg: jdk7/tl/jdk: 6707289: InterfaceAddress.getNetworkPrefixLength() does not conform to Javadoc

2010-01-25 Thread christopher . hegarty
Changeset: e67bf9abc6a5 Author:chegar Date: 2010-01-25 15:41 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e67bf9abc6a5 6707289: InterfaceAddress.getNetworkPrefixLength() does not conform to Javadoc Reviewed-by: michaelm ! src/windows/native/java/net/NetworkInterface_winXP.

hg: jdk7/tl/jdk: 6905552: libnet/nio portability issues

2010-01-27 Thread christopher . hegarty
Changeset: 8df0ffac7f4d Author:chegar Date: 2010-01-27 16:11 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8df0ffac7f4d 6905552: libnet/nio portability issues Reviewed-by: alanb ! src/share/native/java/net/net_util.c ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/so

hg: jdk7/tl/jdk: 6693244: Java Web Start app fails on 6u10 beta w/ AssertionError in AuthenticationInfo.requestCompleted

2010-02-10 Thread christopher . hegarty
Changeset: ec438f2b6886 Author:chegar Date: 2010-02-10 13:23 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ec438f2b6886 6693244: Java Web Start app fails on 6u10 beta w/ AssertionError in AuthenticationInfo.requestCompleted Reviewed-by: michaelm ! src/share/classes/sun/net

hg: jdk7/tl/jdk: 6912868: "java.net.useSystemProxies" behavior fails to check "use_same_proxy" in GNOME

2010-02-22 Thread christopher . hegarty
Changeset: e83d9c0d5e95 Author:chegar Date: 2010-02-22 15:27 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e83d9c0d5e95 6912868: "java.net.useSystemProxies" behavior fails to check "use_same_proxy" in GNOME Reviewed-by: alanb, chegar Contributed-by: damjan@gmail.com !

hg: jdk7/tl/jdk: 6365587: Proxy-Connection header sent through tunnel

2010-02-23 Thread christopher . hegarty
Changeset: c96d6cb31723 Author:chegar Date: 2010-02-23 17:08 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c96d6cb31723 6365587: Proxy-Connection header sent through tunnel Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java

hg: jdk7/tl/jdk: 6933618: java/net/MulticastSocket/NoLoopbackPackets.java fails when rerun

2010-03-10 Thread christopher . hegarty
Changeset: 47958f76babc Author:chegar Date: 2010-03-10 14:44 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/47958f76babc 6933618: java/net/MulticastSocket/NoLoopbackPackets.java fails when rerun Reviewed-by: alanb ! test/java/net/MulticastSocket/NoLoopbackPackets.java

hg: jdk7/tl/jdk: 6934054: java/net/Socket/FDClose.java return error in samevm

2010-03-11 Thread christopher . hegarty
Changeset: 07e1c5a90c6a Author:chegar Date: 2010-03-11 16:17 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/07e1c5a90c6a 6934054: java/net/Socket/FDClose.java return error in samevm Summary: test is no longer useful Reviewed-by: alanb ! test/ProblemList.txt - test/java/net/S

hg: jdk7/tl/jdk: 6933629: java/net/HttpURLConnection/HttpResponseCode.java fails if run in samevm mode

2010-03-11 Thread christopher . hegarty
Changeset: c342735a3e58 Author:chegar Date: 2010-03-11 17:37 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c342735a3e58 6933629: java/net/HttpURLConnection/HttpResponseCode.java fails if run in samevm mode Reviewed-by: alanb ! test/ProblemList.txt ! test/java/net/CookieHan

hg: jdk7/tl/jdk: 6223635: Code hangs at connect call even when Timeout is specified when using a socks proxy

2010-03-11 Thread christopher . hegarty
Changeset: c6f8c58ed51a Author:chegar Date: 2010-03-11 17:50 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c6f8c58ed51a 6223635: Code hangs at connect call even when Timeout is specified when using a socks proxy Reviewed-by: michaelm, chegar Contributed-by: damjan@gmail

hg: jdk7/tl/jdk: 6934923: test/java/net/ipv6tests/TcpTest.java hangs on Solaris 10

2010-03-16 Thread christopher . hegarty
Changeset: f88f6f8ddd21 Author:chegar Date: 2010-03-16 10:05 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f88f6f8ddd21 6934923: test/java/net/ipv6tests/TcpTest.java hangs on Solaris 10 Reviewed-by: alanb ! test/java/net/ipv6tests/TcpTest.java ! test/java/net/ipv6tests/Test

hg: jdk7/tl/jdk: 6935199: java/net regression tests failing with Assertions

2010-03-16 Thread christopher . hegarty
Changeset: 895a1211b2e1 Author:chegar Date: 2010-03-16 14:31 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/895a1211b2e1 6935199: java/net regression tests failing with Assertions Reviewed-by: michaelm ! test/ProblemList.txt ! test/java/net/CookieHandler/TestHttpCookie.java

hg: jdk7/tl/jdk: 6935233: java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java fails with modules build

2010-03-19 Thread christopher . hegarty
Changeset: 3bb93c410f41 Author:chegar Date: 2010-03-19 13:07 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3bb93c410f41 6935233: java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java fails with modules build Reviewed-by: alanb ! test/ProblemList.txt ! test/java/net/Serv

hg: jdk7/tl/jdk: 6632169: HttpClient and HttpsClient should not try to reverse lookup IP address of a proxy server

2010-03-22 Thread christopher . hegarty
Changeset: c40572afb29e Author:chegar Date: 2010-03-22 11:55 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c40572afb29e 6632169: HttpClient and HttpsClient should not try to reverse lookup IP address of a proxy server Reviewed-by: michaelm ! src/share/classes/sun/net/www/p

hg: jdk7/tl/jdk: 6614957: HttpsURLConnection not using the set SSLSocketFactory for creating all its Sockets; ...

2010-03-23 Thread christopher . hegarty
Changeset: 8a9ebdc27045 Author:chegar Date: 2010-03-23 13:54 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8a9ebdc27045 6614957: HttpsURLConnection not using the set SSLSocketFactory for creating all its Sockets 6771432: createSocket() - smpatch fails using 1.6.0_10 because

hg: jdk7/tl/jdk: 6937703: java/net regression test issues with samevm

2010-03-25 Thread christopher . hegarty
Changeset: 6109b166bf68 Author:chegar Date: 2010-03-25 09:38 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6109b166bf68 6937703: java/net regression test issues with samevm Reviewed-by: alanb ! test/ProblemList.txt ! test/java/net/ProxySelector/B6737819.java ! test/java/net

hg: jdk7/tl/jdk: 6648001: Cancelling HTTP authentication causes subsequent deadlocks

2010-04-06 Thread christopher . hegarty
Changeset: 69002275e0e2 Author:chegar Date: 2010-04-06 13:47 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/69002275e0e2 6648001: Cancelling HTTP authentication causes subsequent deadlocks Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/AuthenticationInfo

hg: jdk7/tl/jdk: 6921111: NullPointerException in PlainDatagramSocketImpl.socketSetOption

2010-04-06 Thread christopher . hegarty
Changeset: 495ba30cf02f Author:chegar Date: 2010-04-06 15:44 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/495ba30cf02f 692: NullPointerException in PlainDatagramSocketImpl.socketSetOption Reviewed-by: alanb ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/

Re: [Fwd: PlainSocketImpl.socketGetOption1() ?]

2007-10-10 Thread Christopher Hegarty - Sun Microsystems
Hi Roman, This method was added as part of the changes for 4868820: "IPv6 support for Windows XP and 2003 server", back in 1.5. But I cannot see anywhere that it is called, or as you said even implemented, even when it was originally added. I suspect that it was left over from some redesign w

6659779 code review

2008-04-15 Thread Christopher Hegarty - Sun Microsystem
Hi Michael, Jessie, Can I please get a code review for CR 6659779. This trivially adds logger invocations to log tunnel requests, ie. HTTP CONNECT. -Chris. --- old/src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Tue Apr 15 13:59:44 2008 +++ new/src/share/classes/sun/ne

Re: [Fwd: [PATCH]: Portability fixes]

2009-02-02 Thread Christopher Hegarty - Sun Microsystems
Martin Buchholz wrote: On Mon, Feb 2, 2009 at 05:42, Christopher Hegarty - Sun Microsystems Ireland wrote: +static int isAsciiSpace(char c) { + return (((c) == '\t') || ((c) == '\r') || ((c) == '\b') || + ((c) == '\n') || ((c) == ' &

Re: Updated URLEncodedQueryString

2007-08-02 Thread Christopher Hegarty - Sun Microsystems Ireland
Some initial (picky) comments: 1) "Thread Safety Instances of UrlEncodedQueryString are not not synchronized." Typo: "not not". I would expand this a little. Maybe taking wording similar to java.util.HashMap: "Note that this implementation is not synchronized. If multiple

Re: [Fwd: PlainSocketImpl.socketGetOption1() ?]

2007-10-12 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Roman, The bug I filed against this issue is 6615656. It has not reached our external bug interface yet, but should do so in the next few days. When it does it will be reachable at: http://bugs.sun.com/view_bug.do?bug_id=6615656 On another note, thanks you for the contribution. I have no

[Fwd: Strange problem w/ RMI HTTP to CGI socket factory]

2007-10-12 Thread Christopher Hegarty - Sun Microsystems Ireland
Forwarding this mail to the core libs mailing list as they are most probably in a better position to answer it as they own the sun.rmi package. -Chris. Original Message Subject: Strange problem w/ RMI HTTP to CGI socket factory Date: Thu, 11 Oct 2007 15:57:48 -0400 From: Sarel

Re: [Fwd: PlainSocketImpl.socketGetOption1() ?]

2007-10-12 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Roman, I have reviewed your proposed changes and they look fine. I agree that both java.net.NetworkInterface.getSubnet0 and java.net.NetworkInterface.getBroadcast0 are unimplemented and should also be removed. We should be able to remove these NetworkInterface methods under CR 6615656 als

Re: [Fwd: PlainSocketImpl.socketGetOption1() ?]

2007-10-12 Thread Christopher Hegarty - Sun Microsystems Ireland
Yes, I see that you are already signed up. I will proceed to review your fix and will be in contact shortly. Regards, -Chris.

Re: getCanonicalHostName on Windows

2008-03-05 Thread Christopher Hegarty - Sun Microsystems Ireland
hris. Max (Weijun) Wang wrote: On Mar 4, 2008, at 10:35 PM, Christopher Hegarty wrote: Hi Max, The Java methods that you are using are correct. As it is specified "best effort" is used to determine the FQDN. getByName will try to do forward lookup of k1.n3.local to retrieve its addr

Re: Proposed fix for 6660405.

2008-03-05 Thread Christopher Hegarty - Sun Microsystems Ireland
The change looks good. I approve this change. -Chris Jean-Christophe Collet wrote: Here is my proposed fix for CR 6660405. The issue is that after a redirect, and if there is a cache hit (i.e. the URL is found in the cache) HttpURLConnection will return the wrong InputStream. Details are in t

Re: Proposed fix for 6651717

2008-03-05 Thread Christopher Hegarty - Sun Microsystems Ireland
Yes, this change is fine. -Chris. Jean-Christophe Collet wrote: This is a straightforward fix in mailtoURLConnection to remove a left over debug statement in the connect() method. Also took the opportunity to remove unneeded imports and add appropriate @Override tags. No regression test as th

CR 6667108 code review

2008-03-07 Thread Christopher Hegarty - Sun Microsystems Ireland
CR 6667108: "typo in javadoc for java.net.Socket.getRemoteSocketAddress()" Trivial cleanup of a typo in getRemoteSocketAddress specification. diff -r fa6948bdc4b0 src/share/classes/java/net/Socket.java --- a/src/share/classes/java/net/Socket.javaThu Mar 06 10:35:28 2008 -0800 +++ b/src/sha

Re: JSN gate notifications.

2008-03-07 Thread Christopher Hegarty - Sun Microsystems Ireland
Thanks Brad, this is great. -Chris. Brad Wetmore wrote: Hi net-dev'ers, This is Brad Wetmore, your friendly neighborhood JSN gatekeeper. For some reason, pushes to the various JSN gates were initially configured to send notifications only to the security group's aliases. That problem has

CR 6591358 code review

2008-03-07 Thread Christopher Hegarty - Sun Microsystems Ireland
Another trivial documentation change. CR 6591358: "documentation error in URLConnection.setRequestProperty("accept", ...)" -Chris. --- old/src/share/classes/java/net/URLConnection.java Fri Mar 7 11:19:24 2008 +++ new/src/share/classes/java/net/URLConnection.java Fri Mar 7 11:19:24 2008 @@

Re: Code review for 6644726: Cookie management issues

2008-04-16 Thread Christopher Hegarty - Sun Microsystems Ireland
This change looks good. -Chris. Jean-Christophe Collet wrote: Here are my proposed changes to fix 6644726 It does fix all 7 issues listed in the CR (see http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6644726 for details) and adds a proper regression test. The short list is: - support f

6687282 code review

2008-04-16 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi, I need to get a code review for, CR 6687282 : "URLConnection for HTTPS connection through Proxy w/ Digest Authentication gives 400 Bad Request". Digest authentication uses the request-URI as part of its algorithm when generating the response hash. The request-URI is usually the abs_path

Re: Code review needed for 6558853

2008-04-18 Thread Christopher Hegarty - Sun Microsystems Ireland
This change looks good. -Chris. Jean-Christophe Collet wrote: I need a code review for the simple fix to 6558853. It's a simple case of a flag not set in the native code when creating a Inet6Address. Patch attached below. Thanks

Re: Symbol ``['' and a java.net.URI.create method

2008-04-29 Thread Christopher Hegarty - Sun Microsystems Ireland
Since this is a question about java.net.URI I am moving this question to the OpenJDK Net Dev alias. I will try to answer it there. -Chris. Michal Vyskocil wrote: Hi all, I'm working on adopting of jpackage project to openSUSE and got a problem with build of maven. The jpackage's folks have

Re: Symbol ``['' and a java.net.URI.create method

2008-04-29 Thread Christopher Hegarty - Sun Microsystems Ireland
rgument. You can look at the java.net.URI class description to give you a better understanding of how this encoding works. -Chris. Christopher Hegarty - Sun Microsystems Ireland wrote: Since this is a question about java.net.URI I am moving this question to the OpenJDK Net Dev alias. I will t

Re: Symbol ``['' and a java.net.URI.create method

2008-05-10 Thread Christopher Hegarty - Sun Microsystems Ireland
Thanks for the update Michal. It is nice to know that even though this was not our bug we were able to help diagnose the problem. -Chris. Michal Vyskocil wrote: On Tuesday 29 April 2008 18:21:43 Christopher Hegarty - Sun Microsystems Ireland wrote: The square bracket characters ('[

Re: Embedded HTTP server

2008-06-18 Thread Christopher Hegarty - Sun Microsystems Ireland
I think that this thread should be moved to the net-dev alias. I know that Michael is certainly a member of net-dev and is currently the owner of the HTTP server. -Chris. David M. Lloyd wrote: On 05/27/2008 02:15 PM, Alan Bateman wrote: Juha Lindfors wrote: On Tue, May 27, 2008 at 7:03 P

SCTP for Java

2008-08-19 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi, I just sent a mail to the nio-discuss [1] mailing list requesting feedback on a proposed Java API for SCTP. If you are interested in this topic please read this mail which provides a some details and a link to the API. Feedback is really welcome. -Chris. [1] http://mail.openjdk.java.ne

Re: SCTP for Java

2008-08-26 Thread Christopher Hegarty - Sun Microsystems Ireland
On 08/26/08 14:41, David M. Lloyd wrote: On 08/20/2008 04:37 AM, Alan Bateman wrote: Florian Weimer wrote: : I've been wondering for a while if it is possible (with reasonable additional effort) to add new socket and socket address classes without patching the JDK sources. No, it's not. :-)

Re: ChunkedInputStream/test.txt

2008-09-25 Thread Christopher Hegarty - Sun Microsystems Ireland
Joseph D. Darcy wrote: Yes, I've already asked Chris to fix this in OpenJDK 6 too. I pushed these changes into the OpenJDK 6 workspace, so it will be in the next build/push. -Chris. Regards, -Joe

Project Proposal: SCTP

2008-10-21 Thread Christopher Hegarty - Sun Microsystems Ireland
In accordance with the OpenJDK guidelines for projects [1], I hereby propose an OpenJDK Project "SCTP". This Project will be used for the development of an API for Stream Control Transport Protocol (SCTP) and corresponding OpenJDK prototype. I propose this project be sponsored by the Networki

Re: CFV: Project sponsorship: SCTP

2008-10-21 Thread Christopher Hegarty - Sun Microsystems Ireland
Only Members of the Networking Group are eligible to vote on this decision. The current Members are: Alan Bateman Christopher Hegarty Michael McMahon Jean-Christophe Collet Thanks, Michael [1] http://mail.openjdk.java.net/pipermail/net-dev/2008-October/000427.html

Re: [Fwd: [PATCH]: Portability fixes]

2009-01-30 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Alan, Yes, I will assign 6799040 to myself and work with Christos to finalize the networking changes. Thanks, -Chris. Alan Bateman wrote: Christos mailed core-libs-dev yesterday with a few portability issues.Anyone have cycles to look at the Inet4AddressImpl.c changes? I've created 67990

Re: [Fwd: [PATCH]: Portability fixes]

2009-02-02 Thread Christopher Hegarty - Sun Microsystems Ireland
** * Macros and constants */ -Chris. [1] http://hg.openjdk.java.net/jdk7/tl/jdk/annotate/f9cf49b7b248/src/solaris/native/java/net/Inet6AddressImpl.c On 01/30/09 10:36, Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Alan, Yes, I will assign 6799040 t

Re: [Fwd: [PATCH]: Portability fixes]

2009-02-09 Thread Christopher Hegarty - Sun Microsystems Ireland
the final changes: http://cr.openjdk.java.net/~chegar/6799040 Thanks, -Chris. On 02/02/09 22:13, Christopher Hegarty - Sun Microsystems wrote: Martin Buchholz wrote: On Mon, Feb 2, 2009 at 05:42, Christopher Hegarty - Sun Microsystems Ireland wrote: +static int isAsciiSpace(char c) { + return

CR 6800805 - code review

2009-02-13 Thread Christopher Hegarty - Sun Microsystems Ireland
I need to get a code review for 6800805: java.net.NetworkInterface.getNetworkInterfaces() does not list IPv6 network interfaces correctly. http://cr.openjdk.java.net/~chegar/6800805/webrev.00/ There is a change in behaviour between JDK5 and JDK6 in how virtual interfaces addresses are repor

Request for Review: 6775145

2009-03-04 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Michael, Jessie, Please take a few moments to review this trivial change: http://cr.openjdk.java.net/~chegar/6775145/webrev.00/webrev/ http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6775145 6775145: ClassLoaderUtil.releaseLoader calls System.out.println ("classLoader

Request for Review: 6737323

2009-03-04 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Michael, Jessie, Please take a few moments to review this trivial change: 6737323: Typo in javadoc for SocketPermission http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6737323 http://cr.openjdk.java.net/~chegar/6737323/webrev.00/webrev/ Very trivial changes - remove redundant lin

Re: Code review request: Undefined requesting URL in "java.net.Authenticator.getPasswordAuthentication()"

2009-04-14 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Max, I only looked at the networking part of the changes. They look fine, I just have a few questions/comments: 1) sun.net.www.protocol.http.HttpURLConnection Can you use the same HttpCallerInfo instance for proxy authentication at line 1108? This instance has been created using the s

Re: Code review request: Undefined requesting URL in "java.net.Authenticator.getPasswordAuthentication()"

2009-04-16 Thread Christopher Hegarty - Sun Microsystems Ireland
s Mx On Apr 14, 2009, at 8:55 PM, Max (Weijun) Wang wrote: On Apr 14, 2009, at 5:59 PM, Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Max, I only looked at the networking part of the changes. They look fine, I just have a few questions/comments: 1) sun.net.www.protocol.http.Ht

Re: Code review request: Undefined requesting URL in "java.net.Authenticator.getPasswordAuthentication()"

2009-04-17 Thread Christopher Hegarty - Sun Microsystems Ireland
right before the service principal name is created. I also add a test, putting two Kerberos KDC, one HTTP server, one proxy server in a single regression test is fun! Thanks Mx On Apr 14, 2009, at 8:55 PM, Max (Weijun) Wang wrote: On Apr 14, 2009, at 5:59 PM, Christopher Hegarty - Sun Microsys

Request for Review 6837982

2009-05-06 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Jessie, Michael, Alan, I would like to try and get this simple change into b59 through the build integration slot, and therefore make M3. The change is simply to the docs Makefile so that the SCTP API docs are generated. CR 6837982: SCTP API docs not being generated. Webrev: http://cr

Re: Request for Review 6837982

2009-05-07 Thread Christopher Hegarty - Sun Microsystems Ireland
, jgss and smartcardio javadoc files do not contain Copyrights Thanks Max On May 6, 2009, at 11:28 PM, Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Jessie, Michael, Alan, I would like to try and get this simple change into b59 through the build integration slot, and therefore ma

Re: Request for Review 6837982

2009-05-07 Thread Christopher Hegarty - Sun Microsystems Ireland
I filed the follow bug for this: 6838450: Sun specific APIs should have consistent copyright footer -Chris. On 05/07/09 12:10, Alan Bateman wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: Great, thanks Max, I've added the footer and updated the webrev

Request for Review 6807602

2009-05-21 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Jessie, Michael, Alan, 6807602: Increase MAX_BUFFER_LEN and MAX_HEAP_BUFFER_LEN on 64-bit Solaris and Linux Webrev: http://cr.openjdk.java.net/~chegar/6807602/webrev.00/webrev/ This is a forward port of a change that went into 6u14. It does exactly what it says on the tin! Thanks, -Ch

Request for Review 6855335

2009-06-29 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Michael, Jessie, I need a code review for some SCTP changes that were found during testing. CR 6855335: Several changes in the SCTP implementation. Webrev: http://cr.openjdk.java.net/~chegar/6855335/webrev.00/webrev/ 1) SctpMultiChannel.branch returns null. branch was not implemented

Re: Request for Review 6855335

2009-06-29 Thread Christopher Hegarty - Sun Microsystems Ireland
On 29/06/2009 11:32, Michael McMahon wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Michael, Jessie, I need a code review for some SCTP changes that were found during testing. CR 6855335: Several changes in the SCTP implementation. Webrev: http://cr.openjdk.java.net

Request for Review 6863110

2009-07-22 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi, Newly connected and accepted SctpChannels eagerly receive the COMM_UP notification so that an Association can be created with the appropriate in/out streams. This of course removes the notification from the native stack and caches it at the java level so that it can be received later by t

Re: Test failure when running with -esa

2009-08-28 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Martin, Thanks for reporting this. We actually already know about it, but somehow haven't gotten around to fixing it in JDK7 yet. I'll put it on the list for M6. 6693244: Java Web Start app fails on 6u10 beta w/ AssertionError in AuthenticationInfo.requestCompleted Thanks, -Chris. On 2

Re: Code review needed for 6737819

2009-09-15 Thread Christopher Hegarty - Sun Microsystems Ireland
Looks good. -Chris. On 15/09/2009 15:36, Jean-Christophe Collet wrote: Here are the changes for 6737819. This allows for the previously hard-coded, always in, values for http.nonProxyHosts and ftp.nonProxyHosts to be overridden when necessary. I.E. before it was never possible to reach localho

Request for Review 6882594

2009-09-16 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Jessie, Michael, Alan, 6882594: Remove static dependency on NTLM authentication Webrev: http://cr.openjdk.java.net/~chegar/6882594/webrev.0 The HTTP client implementation (sun.net.www.protocol.http.HttpURLConnection) loads the NTLM Authentication classes even if no authentication is used

  1   2   >