Re: Caching behaviour of InetAddress

2008-02-18 Thread Alan Bateman
Andreas Plesner Jacobsen wrote: : Thanks for the background info. Incidentally, that brings us to a third inconsistent operating mode of getByName(), so we're up to three different behaviours: 1. When running under a security manager, we cache forever 2. When not running under a security mana

Re: 4212324: Packets sent to broadcast address not received on servers bound to specific addr

2008-02-23 Thread Alan Bateman
Damjan Jovanovic wrote: Hi Is this the right place to discuss/post patches for Java 1.7? If not, what is? Sun's websites are so confusing... Yes, this is right place. Has there been any work on the bug I referred to in the subject? If not, read on. Michael McMahon is probably the best p

hg: jdk7/tl/jdk: 2 new changesets

2008-03-11 Thread alan . bateman
Changeset: 278e769f9123 Author:alanb Date: 2008-03-11 14:42 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/278e769f9123 6448457: (ch) Channels.newOutputStream().write() does not write all data Reviewed-by: iris, sherman ! src/share/classes/java/nio/channels/Channels.java + t

Re: 100% CPU on SocketChannelImpl.connect()

2008-04-15 Thread Alan Bateman
Guy Korland wrote: Hi, It seems like the following code causes an endless loop in some cases. for (;;) { InetAddress ia = isa.getAddress(); if (ia.isAnyLocalAddress()) ia = InetAddress.getLocalHost(); n = Net.connect(fd, ia, isa.getPort(),trafficClass); if ((n == IOStatus.INTE

Re: 100% CPU on SocketChannelImpl.connect()

2008-04-15 Thread Alan Bateman
Guy Korland wrote: I haven't seen this code cause problems before. Do you have an example that demonstrates this? I don't have a specific example, we saw it when using we Jini with an Exporter that we developed based on NIO. If so, which operating system? We saw it on windows XP

Re: 100% CPU on SocketChannelImpl.connect()

2008-04-15 Thread Alan Bateman
Guy Korland wrote: We saw it happens on JDK5.0_u14 and JDK6.0_u5 also it happens on Linux and Windows. As you can see form the attached jpg the application only call connect() 20 times but it takes around 6 minutes. Guy This may not be an OpenJDK issue in which case it may be better to seek

Re: Symbol ``['' and a java.net.URI.create method

2008-04-29 Thread Alan Bateman
Yep, it sounds like it might be doing "URI.create(file)" rather than "new File(file).toURI()". -Alan. Christopher Hegarty - Sun Microsystems Ireland wrote: The square bracket characters ('[' and ']') are reserved characters in a URI. If they are to be used then they need to percent encoded.

Re: network tests

2008-05-23 Thread Alan Bateman
Joe Darcy wrote: Greetings. Recently Mark Wielaard started an effort to run the regression tests on OpenJDK builds and publish the results (http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-May/001921.html). Certain tests in the nio and networking area assume Sun-internal hosts li

Re: A proposal for a FTP client API

2008-05-23 Thread Alan Bateman
Jean-Christophe Collet wrote: Hello, I have posted an entry in my blog about the current status of the FTP client API. It contains a quick description of the project as well as a link to the current draft of the API. So if you're interested in that topic go take a look at http://blogs.sun.com

Re: network tests

2008-05-24 Thread Alan Bateman
Joe Darcy wrote: : Could the classic networking tests be refactored a bit to be centralized like the nio tests? Would it be natural for classic networking and nio to get their host information from the same place? There was a time when the networking tests had dependencies on quite a few web

Re: Embedded HTTP server

2008-06-18 Thread Alan Bateman
David M. Lloyd wrote: Is Michael presently in charge of this piece of software from Sun's perspective? Is he subscribed to this list? I've cc'ed the networking group as that is where he HTTP server is maintained. Micahel is a member of that group. It may be worth re-sending your original prop

Re: SCTP for Java

2008-08-20 Thread Alan Bateman
Florian Weimer wrote: : I've been wondering for a while if it is possible (with reasonable additional effort) to add new socket and socket address classes without patching the JDK sources. Otherwise, you won't get any interoperability with existing code, you need to deal with the fine points of

Re: SCTP for Java

2008-08-26 Thread Alan Bateman
Florian Weimer wrote: [Extensible socket types] : Do you think it would be possible to do this out-of-tree? I think I could port my client code to SocketChannel. (If I require a customized JDK, it will raise a few eyebrows.) It should be feasible but it would likely be a platform/provi

Re: SCTP for Java

2008-08-26 Thread Alan Bateman
David M. Lloyd wrote: : I just mean, what would be the benefit of using SocketAddress rather than using a String or Path directly? You can avoid the difficulties of extending SocketAddress by simply not using it. If the protocol or socket address is specified by String then the implementation

Re: SCTP for Java

2008-08-26 Thread Alan Bateman
David M. Lloyd wrote: : No, the concern is just that the SocketAddress hierarchy is just kind of broken (the indicators are the fact that it's an empty abstract class, and that anywhere it's used, it's immediately casted to a more specific type). You could change this, but it still seems to m

Re: hg: jdk7/jsn/jdk: 6717876: Make java.net.NetworkInterface.getIndex() public

2008-08-28 Thread Alan Bateman
Mark Wielaard wrote: : This seems to introduce a new public API in the java.net package. I was wondering how that works for someone that wants to introduce such things in openjdk. There is still some infrastructure and process that isn't externalized yet. The change approval process for API add

Re: hg: jdk7/jsn/jdk: 6717876: Make java.net.NetworkInterface.getIndex() public

2008-08-28 Thread Alan Bateman
Andrew John Hughes wrote: : More generally, it's not clear where the decision was made to make this part of the (as yet non-existent) JDK7 platform JSR. Will there be more insight into this process from outside Sun in the near future? The change approval process for API additions and change

Re: hg: jdk7/jsn/jdk: 6717876: Make java.net.NetworkInterface.getIndex() public

2008-08-28 Thread Alan Bateman
Mark Wielaard wrote: : Thanks. On irc I was pointed to "CCC" review board which currently is "under construction": http://openjdk.java.net/guide/reviewBodies.html and not planned to be made public till 2008/Q2. Would it be possible to publish a summary whenever such a CCC has occurred to the anno

[Fwd: Re: ChunkedInputStream/test.txt]

2008-09-23 Thread Alan Bateman
Forwarding to networking group as the test does indeed look like it should be re-worked. 6621697 is tracking the issue with sccs keywords in the data. Mark Wielaard wrote: Hi Kelly, On Wed, 2008-09-17 at 09:29 -0700, Kelly O'Hair wrote: This binary file has a %[A-Z]% byte pattern in it

Re: CFV: Project sponsorship: SCTP

2008-10-21 Thread Alan Bateman
Michael McMahon wrote: Greetings, voting members of the Networking Group! Question: Should the Networking Group sponsor the "SCTP" Project[1]? Please cast your vote by replying, publicly, to this message Vote: yes

hg: jdk7/tl/jdk: 2 new changesets

2008-11-11 Thread alan . bateman
Changeset: 275fa248e808 Author:alanb Date: 2008-11-11 08:59 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/275fa248e808 6763122: ZipFile ctor does not throw exception when file is not a zip file Reviewed-by: bristor ! src/share/native/java/util/zip/zip_util.c ! test/java/uti

hg: jdk7/tl/jdk: 6593946: (bf) X-Buffer.compact() does not discard mark as specified

2008-11-25 Thread alan . bateman
Changeset: b7c47f49a53d Author:alanb Date: 2008-11-25 19:26 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b7c47f49a53d 6593946: (bf) X-Buffer.compact() does not discard mark as specified Summary: InvalidMarkException now correctly thrown. Thanks to [EMAIL PROTECTED] for the

Re: MulticastSocket(group, port) problems with bind() with IPv6 enabled

2008-12-05 Thread Alan Bateman
Pekka Savola wrote: Hi, I've looked through the Sun bug database and AFAICS this is not listed. I've also looked through the latest source code to see if this is addressed [1], but apparently not. I'm trying to find a way to get this addressed. When you create a MulticastSocket(new InetSo

hg: jdk7/tl/jdk: 6787009: (attach) Stub injection potentially unsafe on windows-x64

2008-12-23 Thread alan . bateman
Changeset: 3d09cc6c4ea9 Author:alanb Date: 2008-12-22 19:28 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3d09cc6c4ea9 6787009: (attach) Stub injection potentially unsafe on windows-x64 Reviewed-by: mchung ! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c

[Fwd: [PATCH]: Portability fixes]

2009-01-29 Thread Alan Bateman
Christos mailed core-libs-dev yesterday with a few portability issues.Anyone have cycles to look at the Inet4AddressImpl.c changes? I've created 6799040 to track it. Martin has already pushed a changeset to jdk7/tl/jdk for the UNIXProcess_md.c issue. --- Begin Message --- Hello, Here are some s

Re: [Fwd: [PATCH]: Portability fixes]

2009-02-02 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Alan, Christos, I've looked at the changes that Christos suggested and also how Martin fixed UNIXProcess_md. Here is what I believe the final change should look like. Comments: 1) "3. last is possibly uninitialized." We have already

hg: jdk7/tl/jdk: 6781363: New I/O: Update socket-channel API to jsr203/nio2-b99; ...

2009-02-16 Thread alan . bateman
Changeset: f06f30b29f36 Author:alanb Date: 2009-02-15 12:25 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f06f30b29f36 6781363: New I/O: Update socket-channel API to jsr203/nio2-b99 4313887: New I/O: Improved filesystem interface 4607272: New I/O: Support asynchronous I/O Re

hg: jdk7/tl/jdk: 3 new changesets

2009-02-24 Thread alan . bateman
Changeset: 910f9cceb0f8 Author:alanb Date: 2009-02-24 09:11 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/910f9cceb0f8 6808647: (file) Paths.get("C:").newDirectoryStream() iterates over Path elements with additional slash [win] 6808648: (file) Files.walkFileTree should obta

Re: Request for Review: 6775145

2009-03-04 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Michael, Jessie, Please take a few moments to review this trivial change: http://cr.openjdk.java.net/~chegar/6775145/webrev.00/webrev/ http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6775145 6775145: ClassLoaderUtil.releaseLo

Re: Review request for 6817246

2009-03-18 Thread Alan Bateman
Mandy Chung wrote: 6817246: Redundant call to set InetAddressCachePolicy to FOREVER if not set during initialization Webrev at: http://cr.openjdk.java.net/~mchung/6817246/webrev.00/ System.setSecurityManager0 calls InetAddressCachePolicy.setIfNotSet(InetAddressCachePolicy.FOREVER) to set

hg: jdk7/tl/jdk: 4 new changesets

2009-03-24 Thread alan . bateman
Changeset: bccdcd761796 Author:alanb Date: 2009-03-24 14:03 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bccdcd761796 6819886: System.getProperty("os.name") reports Vista on Windows 7 Reviewed-by: sherman ! src/windows/native/java/lang/java_props_md.c Changeset: 4c3f75299

hg: jdk7/tl/jdk: 3 new changesets

2009-03-30 Thread alan . bateman
Changeset: 7264cacbddaa Author:alanb Date: 2009-03-27 15:24 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7264cacbddaa 6693490: (se) select throws "File exists" IOException under load (lnx) Reviewed-by: sherman ! src/share/classes/sun/nio/ch/SelChImpl.java ! src/solaris/cla

Review request for 4890703

2009-04-03 Thread Alan Bateman
Michael - can you review this? It's the updates to support SDP on Solaris. The webrev is here: http://cr.openjdk.java.net/~alanb/4890703/webrev.00/ Thanks, Alan.

hg: jdk7/tl/jdk: 7 new changesets

2009-04-06 Thread alan . bateman
Changeset: 267d1f8aa82a Author:alanb Date: 2009-04-02 11:13 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/267d1f8aa82a 6824135: (ch) test/java/nio/channels/AsyncCloseAndInterrupt.java fails (lnx) Reviewed-by: sherman ! src/share/classes/sun/nio/ch/FileChannelImpl.java ! tes

hg: jdk7/tl/jdk: 3 new changesets

2009-04-17 Thread alan . bateman
Changeset: 0b3660c68262 Author:alanb Date: 2009-04-15 14:53 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b3660c68262 6795561: (bf) CharBuffer.subSequence() uses wrong capacity value for new buffer Reviewed-by: sherman, iris ! src/share/classes/java/nio/ByteBufferAs-X-Buff

hg: jdk7/tl/jdk: 6830721: (fc) test/java/nio/channels/AsynchronousFileChannel/Basic.java intermittent failure

2009-04-20 Thread alan . bateman
Changeset: ccd08d4b19cf Author:alanb Date: 2009-04-20 09:30 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ccd08d4b19cf 6830721: (fc) test/java/nio/channels/AsynchronousFileChannel/Basic.java intermittent failure Reviewed-by: sherman ! test/java/nio/channels/AsynchronousFil

hg: jdk7/tl/jdk: 6831461: (sample) Copy -r fails with IllegalArgumentexception: 'maxDepth' is negative

2009-04-20 Thread alan . bateman
Changeset: e281812be4ce Author:alanb Date: 2009-04-20 13:27 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e281812be4ce 6831461: (sample) Copy -r fails with IllegalArgumentexception: 'maxDepth' is negative Reviewed-by: chegar ! src/share/sample/nio/file/Copy.java

hg: jdk7/tl/jdk: 6832557: TEST_BUG: java/lang/Class/getEnclosingConstructor/EnclosingConstructorTests.java fails to compile

2009-04-23 Thread alan . bateman
Changeset: 057e4afcf978 Author:alanb Date: 2009-04-23 19:44 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/057e4afcf978 6832557: TEST_BUG: java/lang/Class/getEnclosingConstructor/EnclosingConstructorTests.java fails to compile Reviewed-by: darcy, mcimadamore ! test/java/la

hg: jdk7/tl/jdk: 6834246: (ch) AsynchronousSocketChannel#write completes with wrong number of bytes written under load (win)

2009-05-04 Thread alan . bateman
Changeset: e1a713f0361f Author:alanb Date: 2009-05-04 19:25 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e1a713f0361f 6834246: (ch) AsynchronousSocketChannel#write completes with wrong number of bytes written under load (win) Reviewed-by: sherman ! src/windows/classes/sun

Re: Request for Review 6837982

2009-05-06 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Jessie, Michael, Alan, I would like to try and get this simple change into b59 through the build integration slot, and therefore make M3. The change is simply to the docs Makefile so that the SCTP API docs are generated. CR 6837982:

Re: Request for Review 6837982

2009-05-07 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Great, thanks Max, I've added the footer and updated the webrev http://cr.openjdk.java.net/~chegar/6837982/webrev.01/webrev -Chris. It seems like we don't have consistently here in that the javadoc for some of the other supported com.sun

Re: FW: setTrafficClass on server socket; IP_TOS replacement on Windows

2009-05-15 Thread Alan Bateman
Esmond Pitt FACS wrote: Alan [I'm not subscribed to net-dev so I'm not sure if this will get there ;-)] I assume it will need the moderator (Michael?) to approve. 1. I've just come across a situation where a user needs to call setTrafficClass on a server socket, so that a certain TOS value

Re: Request for Review 6807602

2009-05-21 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Jessie, Michael, Alan, 6807602: Increase MAX_BUFFER_LEN and MAX_HEAP_BUFFER_LEN on 64-bit Solaris and Linux Webrev: http://cr.openjdk.java.net/~chegar/6807602/webrev.00/webrev/ This is a forward port of a change that went into 6u14.

Re: Setting public TestEnv defaults for net/nio tests needing hosts

2009-06-04 Thread Alan Bateman
Mark Wielaard wrote: : The jdk6 and jdk7 environments are still somewhat dissimilar, but thanks to Andrew Hughes the patches have been ported to make sure they also work on jdk7 out of the box by default using just public hosts without the need to change anything in your test environment locally.

hg: jdk7/tl/jdk: 2 new changesets

2009-06-28 Thread alan . bateman
Changeset: 5208d0c90d73 Author:alanb Date: 2009-06-27 21:46 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5208d0c90d73 6838333: New I/O: Update file system API to jsr203/nio2-b101 6844313: New I/O: File timestamps should be represented by a FileTime rather than a long+TimeU

hg: jdk7/tl/jdk: 2 new changesets

2009-06-30 Thread alan . bateman
Changeset: b22f9e823be7 Author:alanb Date: 2009-06-30 11:11 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b22f9e823be7 6843003: Windows Server 2008 R2 system recognition Reviewed-by: ohair, sherman ! src/windows/native/java/lang/java_props_md.c Changeset: d57c10cf07c5 Auth

hg: jdk7/tl/jdk: 3 new changesets

2009-07-27 Thread alan . bateman
Changeset: 3eb4506815b6 Author:alanb Date: 2009-07-27 18:44 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3eb4506815b6 6863864: (fs) Path.createSymbolicLink doesn't set directory flag when creating sym link to directory (win) Reviewed-by: sherman ! src/windows/classes/sun/

hg: jdk7/tl/jdk: 3 new changesets

2009-07-31 Thread alan . bateman
Changeset: e2d9696aa701 Author:alanb Date: 2009-07-31 08:44 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e2d9696aa701 6867101: Path.checkAccess fails with sharing violation on special files such as pagefile.sys Reviewed-by: sherman ! src/windows/classes/sun/nio/fs/Windows

hg: jdk7/tl/jdk: 3 new changesets

2009-08-11 Thread alan . bateman
Changeset: 5b5df0632ecf Author:alanb Date: 2009-08-11 12:37 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5b5df0632ecf 4516760: (so) Intermittent SocketException: Transport endpoint is not connected (lnx) Reviewed-by: sherman ! src/solaris/native/sun/nio/ch/Net.c ! test/ja

hg: jdk7/tl/jdk: 3 new changesets

2009-08-20 Thread alan . bateman
Changeset: dfece53c600f Author:alanb Date: 2009-08-20 08:39 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dfece53c600f 6595866: File does work with symbolic links (win,vista) Reviewed-by: sherman ! src/windows/native/java/io/WinNTFileSystem_md.c + test/java/io/File/SymLinks

hg: jdk7/tl/jdk: 3 new changesets

2009-08-23 Thread alan . bateman
Changeset: 99a55f6f1cef Author:alanb Date: 2009-08-22 17:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/99a55f6f1cef 6874521: Remove @note tags Reviewed-by: andrew, darcy ! src/share/classes/java/nio/channels/Channels.java ! src/share/classes/java/nio/channels/FileChannel

hg: jdk7/tl/jdk: 4 new changesets

2009-09-05 Thread alan . bateman
Changeset: 3f87b755b1c8 Author:alanb Date: 2009-09-04 18:15 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3f87b755b1c8 6873621: (file) FileStore.supportsFileAttributeView(Class type) returns wrong result Reviewed-by: andrew ! src/share/sample/nio/file/Xdd.java ! src/solari

hg: jdk7/tl/jdk: 2 new changesets

2009-09-14 Thread alan . bateman
Changeset: 060c4c7082ef Author:alanb Date: 2009-09-14 15:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/060c4c7082ef 6529758: JVMTI Waiters demo crashes. Double free. Reviewed-by: ohair, tbell ! src/share/demo/jvmti/waiters/Agent.cpp ! src/share/demo/jvmti/waiters/Agent.h

Re: Request for Review 6882609

2009-09-16 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: 6882609: Move default InMemoryCookieStore to java.net Webrev: http://cr.openjdk.java.net/~chegar/6882609/webrev.0/webrev/ The default cookie store implementation (InMemoryCookieStore) currently resides in sun.net.www.protocol.http. There

Re: Request for Review 6882594

2009-09-17 Thread Alan Bateman
Christopher Hegarty -Sun Microsystems Ireland wrote: Max (Weijun) Wang wrote: HttpURLConnection.java: I think "if (authScheme.equals(BASIC))" can be written as "authScheme == BASIC", and possibly you can use switch/case in several places Thanks Max, these changes certainly make the code

Re: Request for Review 6882594

2009-09-18 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: On 17/09/2009 21:18, Alan Bateman wrote: Christopher Hegarty -Sun Microsystems Ireland wrote: Max (Weijun) Wang wrote: HttpURLConnection.java: I think "if (authScheme.equals(BASIC))" can be written as "authScheme

Re: Request for Review 6882384

2009-09-22 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: 6882384: Update http protocol handler to use PlatformLogger Webrev: http://cr.openjdk.java.net/~chegar/6882384/webrev.0/webrev/ Change http logging to use the PlatformLogger. We can simply remove the reflective calls to the logging API f

Re: Updated patch for JTReg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-24 Thread Alan Bateman
Pavel Tisnovsky wrote: Hi, updated patch for regression test java/net/MulticastSocket/SetOutgoingIf.java is exposed at http://cr.openjdk.java.net/~ptisnovs/JTReg_SetOutgoinfIf_isUp/ This patch ensures, that this test uses only network devices supporting multicast and also that the device is

hg: jdk7/tl/jdk: 2 new changesets

2009-10-05 Thread alan . bateman
Changeset: 97f17e6d0560 Author:alanb Date: 2009-10-04 15:42 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/97f17e6d0560 6884800: (file) Path.newInputStream does not usefully implement available() Reviewed-by: martin, chegar ! src/share/classes/sun/nio/ch/ChannelInputStream.j

Re: Request for Review 6887364 [SetOutgoingIf]

2009-10-06 Thread Alan Bateman
Christopher Hegarty -Sun Microsystems Ireland wrote: Hi Pavel, Michael, 6887364: SetOutgoingIf.java fails if run on multihomed machine without PIv6 on all interfaces [more details below] Webrev: http://cr.openjdk.java.net/~chegar/6887364/webrev/ I just realized why this test was failing on

hg: jdk7/tl/jdk: 3 new changesets

2009-10-11 Thread alan . bateman
Changeset: b84f40617f90 Author:alanb Date: 2009-10-09 09:59 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b84f40617f90 6889552: Sun provider should not require LDAP CertStore to be present Reviewed-by: vinnie, mullan ! src/share/classes/sun/security/provider/SunEntries.java

hg: jdk7/tl/jdk: 3 new changesets

2009-10-15 Thread alan . bateman
Changeset: f6833a276c1d Author:alanb Date: 2009-10-15 11:54 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f6833a276c1d 6883983: JarVerifier dependency on sun.security.pkcs should be removed Reviewed-by: sherman, wetmore ! src/share/classes/java/util/jar/JarVerifier.java Ch

hg: jdk7/tl/jdk: 4 new changesets

2009-10-19 Thread alan . bateman
Changeset: d9f41daf8bcc Author:alanb Date: 2009-10-19 19:58 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d9f41daf8bcc 6892710: (file) test/java/nio/file/Path/CheckPermissions.java fails in samevm mode Reviewed-by: ohair ! test/java/nio/file/Files/ContentType.java ! test/j

Re: Request for Review: 6893238

2009-10-21 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: CR 6893238: Move NTLM and SPNEGO implementations into separate packages Webrev: http://cr.openjdk.java.net/~chegar/6893238/webrev.0/webrev/ Following 688259, NTLM and SPNEGO authentication implementations are now runtime dependencies. The

Re: Request for Review: 6893238

2009-10-21 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: : Yes, this would certainly be cleaner. I've updated the webrev. Please take a look. http://cr.openjdk.java.net/~chegar/6893238/webrev.1/webrev/ Note: The lack of the initial cause of the IOException in firstToken should not be a proble

Re: Request for Review: 6894169

2009-10-22 Thread Alan Bateman
Christopher Hegarty -Sun Microsystems Ireland wrote: CR 6894169: Move HttpLogFormatter into a separate package Webrev: http://cr.openjdk.java.net/~chegar/6894169/webrev.0/webrev/ Moving HttpLogFormatter out of sun.net.www.protocol.http and into sun.net.www.protocol.http.logging will simplify

Need reviewer for 6894633: NetHooks hould not require provider to be present (sol)

2009-10-23 Thread Alan Bateman
I need a reviewer for a small fix to sun.net.NetHooks. On Solaris, the code incorrectly assumes that the sdp provider is always present. The loadProvider method should return null if not present. The diffs are attached. Thanks, Alan. --- a/src/solaris/classes/sun/net/NetHooks.java +++ b/sr

hg: jdk7/tl/jdk: 6894633: NetHooks should not require provider to be present (sol)

2009-10-24 Thread alan . bateman
Changeset: 2a0ed9d89fb0 Author:alanb Date: 2009-10-24 20:36 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2a0ed9d89fb0 6894633: NetHooks should not require provider to be present (sol) Reviewed-by: chegar, jccollet ! src/solaris/classes/sun/net/NetHooks.java

hg: jdk7/tl/jdk: 6888179: Separate out dependency on CORBA

2009-10-27 Thread alan . bateman
Changeset: 244a6868b440 Author:alanb Date: 2009-10-27 08:55 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/244a6868b440 6888179: Separate out dependency on CORBA Reviewed-by: dfuchs + src/share/classes/com/sun/jmx/remote/internal/IIOPHelper.java + src/share/classes/com/sun/j

hg: jdk7/tl/jdk: 6880672: Replace quicksort in java.util.Arrays with dual-pivot implementation

2009-10-29 Thread alan . bateman
Changeset: b05abb410c52 Author:alanb Date: 2009-10-29 11:18 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b05abb410c52 6880672: Replace quicksort in java.util.Arrays with dual-pivot implementation Reviewed-by: jjb Contributed-by: vladimir.yaroslavs...@sun.com, joshua.bl...@g

hg: jdk7/tl/jdk: 6896573: Arrays.sort(long[]) fails with StackOverflowError

2009-10-30 Thread alan . bateman
Changeset: 84ae559f7129 Author:alanb Date: 2009-10-30 15:06 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/84ae559f7129 6896573: Arrays.sort(long[]) fails with StackOverflowError Reviewed-by: jjb Contributed-by: vladimir.yaroslavs...@sun.com ! src/share/classes/java/util/Dua

hg: jdk7/tl/jdk: 6896829: test/sun/util/logging/PlatformLoggerTest.java needs @compile tag to be compiled by jtreg

2009-10-30 Thread alan . bateman
Changeset: fe9db22a220f Author:alanb Date: 2009-10-30 21:31 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fe9db22a220f 6896829: test/sun/util/logging/PlatformLoggerTest.java needs @compile tag to be compiled by jtreg Reviewed-by: mchung, tbell ! test/sun/util/logging/Platf

hg: jdk7/tl/jdk: 2 new changesets

2009-11-10 Thread alan . bateman
Changeset: ee7a380d350e Author:alanb Date: 2009-11-10 10:51 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ee7a380d350e 6898234: (dc) Multicast tests fail on OpenSolaris with vboxnet0 adapter Reviewed-by: chegar ! test/ProblemList.txt ! test/java/nio/channels/DatagramChannel

hg: jdk7/tl/jdk: 6899694: Dual-pivot quicksort improvements

2009-11-11 Thread alan . bateman
Changeset: 18c2b761548a Author:alanb Date: 2009-11-11 14:38 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/18c2b761548a 6899694: Dual-pivot quicksort improvements Reviewed-by: jjb Contributed-by: vladimir.yaroslavs...@sun.com, joshua.bl...@google.com ! src/share/classes/java

hg: jdk7/tl/jdk: 2 new changesets

2009-11-12 Thread alan . bateman
Changeset: b901762bba4b Author:alanb Date: 2009-11-11 16:22 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b901762bba4b 6900234: Several NIO tests should be removed from test/ProblemList.txt Reviewed-by: chegar ! test/ProblemList.txt ! test/java/nio/channels/AsynchronousChan

hg: jdk7/tl/jdk: 6901318: Yet more Dual-pivot quicksort improvements

2009-11-17 Thread alan . bateman
Changeset: 9afe87deb51b Author:alanb Date: 2009-11-17 09:44 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9afe87deb51b 6901318: Yet more Dual-pivot quicksort improvements Reviewed-by: jjb Contributed-by: vladimir.yaroslavs...@sun.com ! src/share/classes/java/util/DualPivotQ

hg: jdk7/tl/jdk: 6888171: JMX Monitor API should not require JavaBeans to be present

2009-11-23 Thread alan . bateman
Changeset: 1ced99075109 Author:alanb Date: 2009-11-23 19:26 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1ced99075109 6888171: JMX Monitor API should not require JavaBeans to be present Reviewed-by: emcmanus ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java ! s

hg: jdk7/tl/jdk: 3 new changesets

2009-12-07 Thread alan . bateman
Changeset: c68f6b6b47fd Author:alanb Date: 2009-12-07 12:24 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c68f6b6b47fd 6903753: (se) Selector should implement Closeable Reviewed-by: chegar, forax ! src/share/classes/java/nio/channels/Selector.java Changeset: 587fa61c0f07 A

hg: jdk7/tl/jdk: 6905046: More Dual-pivot quicksort improvements

2009-12-08 Thread alan . bateman
Changeset: 146c8921267f Author:jjb Date: 2009-12-08 12:40 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/146c8921267f 6905046: More Dual-pivot quicksort improvements Summary: More improvements from the DPQ team Reviewed-by: alanb ! src/share/classes/java/util/DualPivotQuicks

Re: Request for Review: 6909089

2009-12-10 Thread Alan Bateman
Christopher Hegarty -Sun Microsystems Ireland wrote: CR 6909089: Memory leak occurs by lack of free for read buffer in SocketInputStream#read() Webrev: http://cr.openjdk.java.net/~chegar/6909089/webrev.0/webrev/ Bug description says it all. -Chris. Looks okay to me - I assume you've che

hg: jdk7/tl/jdk: 2 new changesets

2010-01-10 Thread alan . bateman
Changeset: 755dd6bdccca Author:alanb Date: 2010-01-09 19:32 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/755dd6bdccca 6907760: (file) OVERFLOW event should cause pending events to be purged Reviewed-by: chegar ! src/share/classes/sun/nio/fs/AbstractWatchKey.java + test/jav

Re: Request for Review: 6915313

2010-01-10 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi, We have received several requests about porting the SCTP API to JDK6. This bug aims to amend the current implementation to minimize the amount of changes required to port it to JDK6. 1) Remove JDK7 API dependences from the implementat

Re: Request for Review: 6916922

2010-01-15 Thread Alan Bateman
Christopher Hegarty -Sun Microsystems Ireland wrote: see discussion on sctp-dev: http://mail.openjdk.java.net/pipermail/sctp-dev/2010-January/000151.html Essentially, on Linux SO_SNDBUF/SO_RCVBUF aren't symmetric. This stems from additional socket structures in the send and receive buffers.

hg: jdk7/tl/jdk: 6917021: (file) copyTo/moveTo can overrwrite existing file when target associated with custom provider

2010-01-18 Thread alan . bateman
Changeset: 42894ae6671c Author:alanb Date: 2010-01-18 15:21 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/42894ae6671c 6917021: (file) copyTo/moveTo can overrwrite existing file when target associated with custom provider Reviewed-by: chegar ! src/share/classes/sun/nio/fs/

Re: Request for Review: 6905552

2010-01-27 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Alan, Michael, Since we don't typically build on non-IPv6 systems, over a number of years the net/nio code has not maintained clean non-IPv6 code. This patch addresses that by excluding IPv6 specific code where AF_INET6 is not defined.

Re: Request for Review: 6905552

2010-01-27 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: : What we found is that on Solaris if an interface has only IPv6 addresses assigned to it, then you need to use a socket created with AF_INET6 when querying the ioclt. By default, we always try to with an AF_INET socket first and on Solaris

Re: Request Review: 6912868

2010-02-19 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi All, This patch corrects Java's usage of Gnome's proxy setting, in particular the previously ignored "use_same_proxy" setting as described on http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6912868 and https://bugzilla.redhat.com/sh

hg: jdk7/tl/jdk: 4 new changesets

2010-02-24 Thread alan . bateman
Changeset: 38fbb2353a6a Author:alanb Date: 2010-02-23 17:56 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/38fbb2353a6a 6925977: (file) test/java/nio/file/Path/CheckPermissions.java fails if test.src on read-only file system Reviewed-by: chegar ! test/java/nio/file/Path/Che

hg: jdk7/tl/jdk: 6929532: (file) WatchService should avoid queuing new modify events when lots of files are changing

2010-02-27 Thread alan . bateman
Changeset: 77beb60b39c6 Author:alanb Date: 2010-02-27 18:18 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/77beb60b39c6 6929532: (file) WatchService should avoid queuing new modify events when lots of files are changing Reviewed-by: alanb Contributed-by: sebastian.sickelm...

hg: jdk7/tl/jdk: 6929259: Remove double spaces from Dual-pivot quicksort

2010-02-27 Thread alan . bateman
Changeset: b77e94f5a601 Author:alanb Date: 2010-02-27 19:15 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b77e94f5a601 6929259: Remove double spaces from Dual-pivot quicksort Reviewed-by: alanb Contributed-by: vladimir.yaroslavs...@sun.com ! src/share/classes/java/util/Dual

hg: jdk7/tl/jdk: 2 new changesets

2010-02-28 Thread alan . bateman
Changeset: 529d2da0aee2 Author:alanb Date: 2010-02-27 19:26 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/529d2da0aee2 6815768: File.getxxxSpace() methods fail for very large file systems under 32bit Java Reviewed-by: ohair ! src/solaris/native/java/io/UnixFileSystem_md.c

hg: jdk7/tl/jdk: 6931216: TEST_BUG: test/java/nio/file/WatchService/LotsOfEvents.java failed with NPE

2010-03-03 Thread alan . bateman
Changeset: cddb43b12d28 Author:alanb Date: 2010-03-03 16:09 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cddb43b12d28 6931216: TEST_BUG: test/java/nio/file/WatchService/LotsOfEvents.java failed with NPE Reviewed-by: chegar ! test/java/nio/file/WatchService/LotsOfEvents.ja

Re: Code Review 6933618: java/net/MulticastSocket/NoLoopbackPackets.java fails when rerun

2010-03-10 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Alan, Michael, Trivial change. 6933618: java/net/MulticastSocket/NoLoopbackPackets.java fails when rerun If java/net/MulticastSocket/NoLoopbackPackets.java is run in a batch which contains all the MulticastSocket tests then it will fail

Re: Code Review 6933629: java/net/HttpURLConnection/HttpResponseCode.java fails if run in samevm mode

2010-03-10 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Alan, Michael, Summary: Make test run in othervm. java/net/HttpURLConnection/HttpResponseCode.java fails if run in samevm mode with a NullPointer Exception cause by CookieHandlerTest$MyCookieHandler.put(CookieHandlerTest.java:131) The

Re: Code Review 6934054: java/net/Socket/FDClose.java return error in samevm

2010-03-11 Thread Alan Bateman
Christopher Hegarty -Sun Microsystems Ireland wrote: Hi Alan, Michael, Another small test change! This test requires interruptible I/O to verify that the accept implementation does not impact on fd0. UseVMInterruptibleIO needs to be explicitly enabled since it is now disabled by default, see

Re: Code Review 6934054: java/net/Socket/FDClose.java return error in samevm

2010-03-11 Thread Alan Bateman
Christopher Hegarty -Sun Microsystems Ireland wrote: Alan Bateman wrote: . I'm tempted to suggest that the best thing is to just hg rm the test as it's not very useful. If you want to keep it then the changes looks OK This had crossed my mind. If you agree then I think I

Re: Code Review 6934923: test/java/net/ipv6tests/TcpTest.java hangs on Solaris 10

2010-03-15 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Alan, Michael, The test has a connected TCP socket and performs individual writes of only 2 bytes on one end. It does not read off the data on the other end. After 8 writes, on the 9th, the write blocks. Clearly the send buffer has not

Re: Code Review 6935233: java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java fails with modules build

2010-03-18 Thread Alan Bateman
Christopher Hegarty -Sun Microsystems Ireland wrote: Alan, Michael, java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java fails with modules build because number of open file descriptors exceeds 20. Instead of a hardcoded number, the test should check the number of file descriptors does no

Re: Code Review 6935233: java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java fails with modules build

2010-03-18 Thread Alan Bateman
Christopher Hegarty -Sun Microsystems Ireland wrote: Alan Bateman wrote: It still seems very fragile and doesn't take into account that the number of file descriptors might legitimately increase. How about changing the test to use ulimit on Solaris/Linux to set the hard limit

Re: Please review new regression test for java.net.* API

2010-03-18 Thread Alan Bateman
Pavel Tisnovsky wrote: Hi, please review new regression test for java.net.* API. This test check if the cacerts keytool database is configured properly and SSL is really working. The test should not fail if SSL is working (in other case it simply throws IOException). Webrev si available at h

<    5   6   7   8   9   10   11   12   13   14   >