Christopher Hegarty -Sun Microsystems Ireland wrote:
Hi Alan, Michael,
Another small test change!
This test requires interruptible I/O to verify that the accept
implementation does not impact on fd0. UseVMInterruptibleIO needs to
be explicitly enabled since it is now disabled by default, see
6554406. Without interruptible I/O the thread executing the accept
gets blocked and the test harness cannot perform the necessary cleanup
required by samevm.
Note: This test is only applicable to Solaris, since it is the only
platform to support interruptible I/O, but should still pass on all
platforms.
Webrev:
http://cr.openjdk.java.net/~chegar/6934054/webrev.00/webrev/
Thanks,
-Chris.
I'm tempted to suggest that the best thing is to just hg rm the test as
it's not very useful. If you want to keep it then the changes looks OK
to me. One suggestion is to have AReader implement Closeable and have
the close implement just do sock.close().
-Alan.
