Christopher Hegarty - Sun Microsystems Ireland wrote:
Hi Alan, Christos,
I've looked at the changes that Christos suggested and also how Martin
fixed UNIXProcess_md. Here is what I believe the final change should
look like.
Comments:
1) "3. last is possibly uninitialized."
We have already fixed this in a previous changeset, see [1]
2) I made similar changes to Inet6AddressImpl as well as for Inet4
Thanks for taking this one. The jint -> socklen_t change looks good to me.
I'm not so sure about keeping the workaround for that old Solaris
hostname parsing bug (4160367). I just checked Solaris 10 and
OpenSolaris and I can't duplicate it (eg: ping "<space>" prints unknown
host as expected). On older releases (I checked 8 and 9) then it
duplicates readily (ping "<space>" prints "<space> is alive"). It might
be worth checking into this as it may be that the workaround code can be
removed, or at least only compiled on Solaris where it is needed.
-Alan.
