> Updated following remaining tests to remove depenedies of TestHttpServer,
> HttpTransaction, HttpCallback
> open/test/jdk/java/net/ProxySelector/LoopbackAddresses.java
> open/test/jdk/java/net/ProxySelector/ProxyTest.java
> open/test/jdk/java/net/URL/PerConnectionProxy.java
> open/test/jdk/java/
On Wed, 2 Mar 2022 12:35:47 GMT, Daniel Fuchs wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed extra whitespace
>
> test/jdk/java/net/URLConnection/B5052093.java line 113:
>
>> 111: exchange.
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
Hi,
Could I get the following change reviewed please, which is to disable the MD5
message digest algorithm by default in the HTTP Digest authentication
mechanism? The algorithm can be opted into by setting a new system property
"http.auth.digest.enabledDigestAlgs" to include the value MD5. The
On Wed, 2 Mar 2022 12:42:11 GMT, Daniel Fuchs wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed extra whitespace
>
> test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java line 206:
>
>> 204:
On Fri, 4 Mar 2022 11:10:40 GMT, Mahendra Chhipa wrote:
>> test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java line 206:
>>
>>> 204: // override the Content-length header to be greater
>>> than the actual response body
>>> 205: trans.getResponseHeaders().set("
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
On Thu, 3 Mar 2022 16:13:37 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8282617?
>
> The `HttpClient` class uses a `inCache` (internal) field to keep track of
> whether a connection is
On Fri, 4 Mar 2022 11:25:38 GMT, Daniel Fuchs wrote:
> Should we instead have a property to disable algorithms, whose default value
> would contain "MD5" by default?
I considered that and implemented it that way at the start, but what you would
end up with then is users running their code with
On Fri, 4 Mar 2022 12:03:44 GMT, Michael McMahon wrote:
> I considered that and implemented it that way at the start, but what you
> would end up with then is users running their code with something like:
> -DdisabledAlgNames=""
>
> I find that style leads to a much less explicit "opting in" t
On Fri, 4 Mar 2022 12:12:25 GMT, Daniel Fuchs wrote:
> > I considered that and implemented it that way at the start, but what you
> > would end up with then is users running their code with something like:
> > -DdisabledAlgNames=""
> > I find that style leads to a much less explicit "opting in"
> Updated following remaining tests to remove depenedies of TestHttpServer,
> HttpTransaction, HttpCallback
> open/test/jdk/java/net/ProxySelector/LoopbackAddresses.java
> open/test/jdk/java/net/ProxySelector/ProxyTest.java
> open/test/jdk/java/net/URL/PerConnectionProxy.java
> open/test/jdk/java/
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
On Fri, 4 Mar 2022 11:21:47 GMT, Daniel Fuchs wrote:
>> In case of HttpExchange.setResponseHeader(). If responseLength is -1, then
>> content-length value is overridden to 0, if already set explicitly. Same is
>> the case when responseLength is > 0. Only in the case when responseLength ==
>> 0
On Fri, 4 Mar 2022 12:29:28 GMT, Michael McMahon wrote:
> > So, maybe, we could have a 2nd net property with the default disabled
> > algorithms and in net.properties we identify MD5 only for now. Users could
> > add to that list if they want or even specify it on the command line. I
> > think
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
On Fri, 4 Mar 2022 13:13:47 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Could I get the following change reviewed please, which is to disable the
>> MD5 message digest algorithm by default in the HTTP Digest authentication
>> mechanism? The algorithm can be opted into by setting a new system propert
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
Hello,
While I like the idea of the user having to explicitely specify the rexenabled
legacy algorithms (as opposed to removing the defaultsdisabled) it is not the
style the other algorithm policies in JCE work - so it might be confusing.
But, more critically I would separate the enabling/imple
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
On Fri, 4 Mar 2022 13:50:37 GMT, Jaikiran Pai wrote:
>> Hi,
>>
>> Could I get the following change reviewed please, which is to disable the
>> MD5 message digest algorithm by default in the HTTP Digest authentication
>> mechanism? The algorithm can be opted into by setting a new system propert
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
On Fri, 4 Mar 2022 14:11:00 GMT, Jaikiran Pai wrote:
>> Hi,
>>
>> Could I get the following change reviewed please, which is to disable the
>> MD5 message digest algorithm by default in the HTTP Digest authentication
>> mechanism? The algorithm can be opted into by setting a new system propert
**Problem**
When a Continuation Frame is received by the httpclient using HTTP/2 after a
Push Promise frame (can happen if the amount of headers to be sent in a single
Push Promise frame exceeds the maximum frame size, so a Continuation frame is
required), the following exception occurs:
java.
On Fri, 4 Mar 2022 14:06:14 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/doc-files/net-properties.html line 227:
>>
>>> 225: name.
>>> 226:
>>> 227:{@systemProperty http.auth.digest.reEnabledAlgs}
>>> (default: )
>>
>> Hello Michael, from
On Fri, 4 Mar 2022 14:39:50 GMT, Jaikiran Pai wrote:
>> Hi,
>>
>> Could I get the following change reviewed please, which is to disable the
>> MD5 message digest algorithm by default in the HTTP Digest authentication
>> mechanism? The algorithm can be opted into by setting a new system propert
Bernd,
If I understand you correctly, there is no negotiation at this level.
Once Digest is selected, it's up to the server to choose the algorithm
and then the client can either accept it or else reject it and the whole
request fails then.
It's true that with this change, if the server prop
On Fri, 4 Mar 2022 14:42:40 GMT, Conor Cleary wrote:
> **Problem**
> When a Continuation Frame is received by the httpclient using HTTP/2 after a
> Push Promise frame (can happen if the amount of headers to be sent in a
> single Push Promise frame exceeds the maximum frame size, so a Continuati
On Thu, 17 Feb 2022 18:57:02 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
Hi
I have reviewed the code for removing double semicolons at the end of lines
all the best
matteo
-
Commit messages:
- Removed double semicolon at the end of lines
Changes: https://git.openjdk.java.net/jdk/pull/7268/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=726
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Hi
I have pushed this PR about 1 month ago. Only 3 days ago OCA was accepted.
Now: what is the next step?
This is a cleanup PR
On Fri, 25 Feb 2022 15:40:09 GMT, Matteo Baccan wrote:
>> Hi
>>
>> I have reviewed the code for removing double semicolons at the end of lines
>>
>> all the best
>> matteo
>
> Hi
>
> I have pushed this PR about 1 month ago. Only 3 days ago OCA was accepted.
> Now: what is the next step?
>
> T
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
The changes look OK. The copyright year probably should be updated as part of
this PR
-
Marked as reviewed by la
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Hi Lance
I can make a second commit updating the copyright year
Tell me if this is necessary
ciao
matteo
-
PR:
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
We usually request that these be be broken up by area to attract the
appropriate reviewers and avoid eye-strain. The client mo
On Fri, 4 Mar 2022 17:17:12 GMT, Roger Riggs wrote:
>> Hi
>>
>> I have reviewed the code for removing double semicolons at the end of lines
>>
>> all the best
>> matteo
>
> We usually request that these be be broken up by area to attract the
> appropriate reviewers and avoid eye-strain. The c
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Marked as reviewed by prr (Reviewer).
Looks like there's only one client source code file touched
Most of the client changes a
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7268
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Nice tidy of the code.
Is there anything that can be done to prevent re-introduction of this trivial
problem? Perhaps a new S
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
LGTM also.
Similar suggestion for updating copyrights.
-
Marked as reviewed by wetmore (Reviewer).
PR: https:/
Thanks for the clarification Michael,
I was actually wrongly assuming that the client has to propose the method. If
the server can do that, then it is relative risk free to support additional
algorithms on the client side (and ignore a challenge if it requests disabled
algorithm (this would inc
Please review this small API enhancement to add the usual constructors taking a
cause to SocketException and then update uses of initiCause on creating
SocketException to instead pass the cause via the constructor.
Please also review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282688
---
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7268
On Thu, 3 Mar 2022 12:36:33 GMT, zzambers wrote:
>> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was
>> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() /
>> Socket.shutdownOutput() and InputStream.close() / OutputStream.close()
>> performed hal
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
I eyeballed the diff file and all seems okay.
Thanks,
David
-
Marked as reviewed by dholmes (Reviewer).
PR: http
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Nice, good work matteo
Should I change the JBS issue title to match the PR title, or is it preferred
for the PR title to chang
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
This PR changes a comment in javax/swing/RepaintManager.java. This commented
out code should be removed altogether in another P
50 matches
Mail list logo
