On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon <[email protected]> wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
> "http.auth.digest.reEnabledAlgs" to include the value MD5. The change also
> updates the Digest authentication implementation to use some of the more
> secure features defined in RFC7616, such as username hashing and additional
> digest algorithms like SHA256 and SHA512-256.
>
> - Michael
src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java
line 443:
> 441: } catch (IOException e) {
> 442: // should not happen since the algorithm has already been
> 443: // validated
Hello Michael, was this comment meant for something else? The comment feels a
bit odd since it says "has already been validated" which isn't the case since
the `validateAlgorithm` itself has failed here.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7688
