Integrated: 8253473: Javadoc clean up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator

2020-10-30 Thread Patrick Concannon
On Thu, 22 Oct 2020 14:33:11 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my doc-only fix for JDK-8253473: 'Javadoc clean > up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator ' ? > > This fix is set of formatting changes intended to clean up the javado

RFR: 8255584: `HttpPrincipal::getName` returns incorrect name

2020-10-30 Thread Patrick Concannon
Hi, Could someone please review my fix for JDK-8255584: '`HttpPrincipal::getName` returns incorrect name' ? The specification for `HttpPrincipal::getName` reports that it should return the name of the HttpPrincipal in the format "realm:username". However, it currently returns the username only.

Re: RFR: 8255584: `HttpPrincipal::getName` returns incorrect name

2020-10-30 Thread Daniel Fuchs
On Fri, 30 Oct 2020 14:41:18 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my fix for JDK-8255584: '`HttpPrincipal::getName` > returns incorrect name' ? > The specification for `HttpPrincipal::getName` reports that it should return > the name of the HttpPrincipal in the

Re: RFR: 8255584: `HttpPrincipal::getName` returns incorrect name [v2]

2020-10-30 Thread Patrick Concannon
> Hi, > > Could someone please review my fix for JDK-8255584: '`HttpPrincipal::getName` > returns incorrect name' ? > The specification for `HttpPrincipal::getName` reports that it should return > the name of the HttpPrincipal in the format "realm:username". However, it > currently returns the

Re: RFR: 8255584: `HttpPrincipal::getName` returns incorrect name [v2]

2020-10-30 Thread Patrick Concannon
On Fri, 30 Oct 2020 15:28:16 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8255584: fixed ordering of realm and username in name > > test/jdk/com/sun/net/httpserver/HttpPrincipalTest.java l

Re: RFR: 8255584: `HttpPrincipal::getName` returns incorrect name [v2]

2020-10-30 Thread Daniel Fuchs
On Fri, 30 Oct 2020 15:57:11 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my fix for JDK-8255584: >> '`HttpPrincipal::getName` returns incorrect name' ? >> The specification for `HttpPrincipal::getName` reports that it should return >> the name of the HttpPrincipal i