> Hi, > > Could someone please review my fix for JDK-8255584: '`HttpPrincipal::getName` > returns incorrect name' ? > The specification for `HttpPrincipal::getName` reports that it should return > the name of the HttpPrincipal in the format "realm:username". However, it > currently returns the username only. > > This fix updates the method to return the name in the correct format as > specified by the javadoc. > > Kind regards, > Patrick
Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision: 8255584: fixed ordering of realm and username in name ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/958/files - new: https://git.openjdk.java.net/jdk/pull/958/files/fa0f7173..2ad0c8d8 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=958&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=958&range=00-01 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/958.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/958/head:pull/958 PR: https://git.openjdk.java.net/jdk/pull/958